pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add warnings if feature flags are read before initialization. (#21201)

This commit is contained in:
Cody Leff 2022-08-25 15:53:18 -07:00 committed by GitHub
parent 17ad0d80de
commit 5811262cf2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts
View File

@ -84,5 +84,13 @@ declare global {
}
export function isFeatureEnabled(feature: FeatureFlag) {
return window && window.featureFlags && !!window.featureFlags[feature];
try {
return !!window.featureFlags[feature];
} catch (error) {
// eslint-disable-next-line no-console
console.error(`Failed to query feature flag ${feature} (see error below)`);
// eslint-disable-next-line no-console
console.error(error);
return false;
}
}

10
superset-frontend/src/featureFlags.ts
View File

@ -28,5 +28,13 @@ export function initFeatureFlags(featureFlags: FeatureFlagMap) {
}
export function isFeatureEnabled(feature: FeatureFlag) {
return window && window.featureFlags && !!window.featureFlags[feature];
try {
return !!window.featureFlags[feature];
} catch (error) {
// eslint-disable-next-line no-console
console.error(`Failed to query feature flag ${feature} (see error below)`);
// eslint-disable-next-line no-console
console.error(error);
return false;
}
}