Commit Graph

12144 Commits

Author SHA1 Message Date
Shubham Sinha b354f2265a
fix(dev-server run): Check for environment tag not being undefined (#21232)
* fixed local dev-server run

* removed console log

* removed console log
2022-08-30 14:51:32 +08:00
Stephen Liu 0c43190e04
fix(database-list): hidden upload file button if no permission (#21216) 2022-08-30 10:34:28 +08:00
Beto Dealmeida 8772e2cdb3
fix: improve get_db_engine_spec_for_backend (#21171)
* fix: improve get_db_engine_spec_for_backend

* Fix tests

* Fix docs

* fix lint

* fix fallback

* Fix engine validation

* Fix test
2022-08-29 11:42:42 -07:00
Geido 710a8ce5c0
chore: Minor Applitools enhancements (#21239)
* Enhance logging

* Update conf
2022-08-29 19:38:13 +03:00
Geido 1d3a805a61
chore: Drill to detail Modal tests (#21148)
* Add DrillDetailModal test

* Add DrillDetailPane tests

* Add TableControls test

* Lint

* Enhance SliceHeaderControls tests

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-08-29 14:22:15 +03:00
Michael S. Molina 77f54585de
chore: Keeps context menu in viewport (#21212) 2022-08-29 08:14:22 -03:00
Geido f017f98b88
chore: E2E tests for the Drill to detail modal (#21187)
* Add example ECharts Dashboard

* [WIP] E2E test

* Add echarts interactions

* Lint

* DRY
2022-08-29 11:25:27 +03:00
Đặng Minh Dũng ccb293a083
fix(Trino): create `PrestoBaseEngineSpec` base class to share common code between Trino and Presto (#21066)
* chore: create `PrestoBaseEngineSpec` class that share common functions between Presto and Trino

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* feat(Trino): support CertificateAuthentication

* chore(Presto): move `get_function_names` to `PrestoBaseEngineSpec`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores(Presto): remove `is_readonly_query`

* feat(Trino): implement `extra_table_metadata`

* feat(Trino): specify `User-Agent`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* fix: pylint

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores(Presto): move `PrestoBaseEngineSpec` to `presto.py`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* fix(Presto): typing annotations

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
2022-08-29 10:21:28 +03:00
Eric Briscoe 5f76ac9001
fix: Fixes error caused by step id placed in wrong location (#21226)
* Update chromatic PR action to have access to Job outputs

Adjusting to follow docs at: https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs

* Fixes error where step ID was incorrect location
2022-08-28 14:44:54 -07:00
Shubham Sinha d408393ba9
fixed guest role permissions (#21208) 2022-08-28 09:08:41 +02:00
Hugh A. Miles II c61a507e14
fix: add back custom sql filtering with Query as source (#21190) 2022-08-26 19:12:21 -07:00
Eric Briscoe e2ab966910
Update chromatic PR action to have access to Job outputs (#21224)
Adjusting to follow docs at: https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs
2022-08-26 16:21:22 -07:00
Eric Briscoe 092460a1f1
Removes if statement causing comment not to run (#21222) 2022-08-26 15:42:26 -07:00
Hugh A. Miles II 653c9f0e7f
fix: Update exception for DatasourceNotFound from `DatasourceDao.get_datasource()` (#21217)
* update exception

* add 404
2022-08-26 15:11:47 -07:00
Reese 25cc7897b1
feat: Environment tag (#20295)
* Added environment tag and relevant tests

* Reorganize imports

* Prevent errors when config value not set

* Default production tag to be hidden

* Change tag to Label component

* Fix import order

* Allow tag to be colored with theme

* Use theme for tag border radius

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Fix styling

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-08-26 16:08:24 -06:00
Reese 16032ed3e2
feat: Virtual dataset duplication (#20309)
* Inital duplicate functionality

* Fix formatting

* Create dedicated duplicate API

* Make use of new API

* Make use of new api permissions

* Add integration tests for duplicating datasets

* Add licenses

* Fix linting errors

* Change confirm button to 'Duplicate'

* Fix HTTP status code and response

* Add missing import

* Use user id instead of user object

* Remove stray debug print

* Fix sqlite tests

* Specify type of extra

* Add frontend tests

* Add match statement to test
2022-08-26 16:07:56 -06:00
Eric Briscoe f09c4327f8
Splitting into two separate chromatic jobs to reduce conditional logic causing run issues (#21219) 2022-08-26 14:56:19 -07:00
JUST.in DO IT 4e23d62d4f
fix(sqllab): missing zero values while copy-to-clipboard (#21153) 2022-08-26 14:28:48 -07:00
Michael S. Molina d41f44fcdf
fix: World Map right-click value (#21209) 2022-08-26 15:08:24 -03:00
Cody Leff 0726840fb7
fix(explore): Prevent unnecessary series limit subquery (#21154)
* Prevent series limit when no series limit columns specified.

* Add timeseries check for legacy charts.

* Apply fix to helpers.py.

* Skip Cypress color consistency tests.
2022-08-26 11:16:13 -06:00
Michael S. Molina 68fa4d2665
feat: Adds drill to detail context menu to Table (#21168)
* feat: Adds drill to detail context menu to Table

* Improves context menu positioning

* Fixes Pivot Table typying
2022-08-26 13:35:26 -03:00
yuzutas0 982210ad83
Fix formatting in README.md (#21205) 2022-08-26 12:21:43 -04:00
Michael S. Molina 859b6d2d20
feat: Adds drill to detail context menu to Pivot Table (#21198)
* feat: Adds drill to detail context menu to Pivot Table

* Adds useCallback
2022-08-26 08:23:26 -03:00
Michael S. Molina 1143e17742
fix: Typing of labelMap (#21181)
* fix: Typing of labelMap

* Adjusts val types
2022-08-26 08:22:57 -03:00
Cody Leff 5811262cf2
Add warnings if feature flags are read before initialization. (#21201) 2022-08-25 16:53:18 -06:00
Kamil Gabryjelski 17ad0d80de
chore: Add new e2e tests for Explore (#21184)
* chore(explore): Add cypress test for creating chart from dataset list

* Add cypress test for creating chart from sqllab query

* Fix the test for editing dataset in exploer

* Fix lint

* Fix tests
2022-08-25 18:50:31 +02:00
EugeneTorap 994e1f6bdc
chore: bump clickhouse-sqlalchemy 0.2.2 (#21195) 2022-08-25 15:35:20 +02:00
Paulo Eduardo da Silva 93557e3a1a
removing unnecessary margin for 50% fields (#21167) 2022-08-25 11:48:31 +08:00
Paulo Eduardo da Silva 74e40c2de1
removing bottom margin on CronPicker (#21140) 2022-08-25 11:44:16 +08:00
Anthony Gainor da3401a698
fix(database-modal): Show a different placeholder text in Snowflake connection form (#21172)
* Add new Database Modal

When adding a new database and selecting Snowflake, the database and account fields had the same placeholder. This PR adds a placeholder prop so values can be sent dynamically by field

* Call translation function for string literals

Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
2022-08-24 15:37:47 -06:00
smileydev d568999592
fix(database): make to display validation error msg when all cases (#20095)
* fix(database): make to display validation error msg when all cases

* fix(db): make to update the alert error condition

* fix(db): make to add error detail display

* fix(db): make to update error alert display by superset error style guide.

* fix(db): make to style modal header title with h4

* fix(db): make to place see more on bottom instead of top

* fix(db): make to fix shortly

* fix(db): make to fix lint issue

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-08-24 11:29:22 -06:00
Lily Kuang 604e30b3f0
fix: Filter throwing an error on Embedded Dashboard (#21157)
* fix: Filter throwing an error on Embedded Dashboard

* use short_id if storage not available

* avoid infinite loop
2022-08-24 09:38:20 -07:00
JUST.in DO IT 53de94c047
Revert "fix(sqllab): avoid unexpected re-rendering on DatabaseSelector (#21141)" (#21174) 2022-08-23 22:26:05 -07:00
Bogdan ed6212a1f9
Reimplement permissions fetching to do it in a single transaction (#21156)
Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2022-08-23 18:45:39 -07:00
Hugh A. Miles II cda7d70565
feat: print comment for chromatic storybook link (#21170)
* Update chromatic.yml

* Update chromatic.yml

* Update chromatic.yml

* Update chromatic.yml

* Update chromatic.yml

* Update chromatic.yml

* working

* plz work

* plzzzzz

* one more time

* one one more time

* this works

* lit

* last one
2022-08-23 19:31:05 -04:00
Eric Briscoe 6a0b7e5598
feat: Add Chromatic publishing to superset-frontend storybook (#21095)
* Work in progress to add Chromatic publishing to superset-fronted storybook

Adds new Github action to publish storybook builds to chromatic
Adjusts configuration to support MDX story format
Updates Alert stories to take advantage of MDX format for example in storybook that will publish to Chromatic
Fixes issue in ListViewCard stories that make the story build fail

* Adjust Chromatic Github action

* Adjust action so Gtihub Secret is read into env

Github secrets are not accessible in conditional blocks so this change moves the access of the github secret into an env variable which is accessible in conditional logic

* Removes unneccesary projectToken from package json

* Using a temp key to debug no access to value from github secret

* Refining skipping if no changes to superset-frontend

* Remove typos from Action component story, consolidate on folder check in Chromatic action

* Fix error in Chromatic action event

* Testing action with pul_request_target

* adjustments to Chromatic action triggers

* lint fix

* Testing if pull_request_target is disabled

* More adjustments to Chromatic action

* UI Change to trigger action

* Change to story text to test action

* update package-lock after merge conflicts from master

* Changes to test chromatic action

* Finalize Chromatic actions, fix lint errors

* Backs out addition of @storybook/addon-docs which is included in addon-essentials

* Lint error in package.json
2022-08-23 16:16:28 -04:00
JUST.in DO IT f77b910e2c
perf(sqllab): Rendering perf improvement using immutable state (#20877)
* perf(sqllab): Rendering perf improvement using immutable state

- keep queryEditors immutable during active state
- add unsavedQueryEditor to store all active changes
- refactor each component to subscribe the related unsaved editor state only

* revert ISaveableDatasource type cast

* missing trigger prop

* a default of an empty object and optional operator
2022-08-23 12:17:19 -03:00
Michael S. Molina 4ca4a5c7cb
feat: Adds drill to detail context menu to World Map (#21150) 2022-08-23 10:24:55 -03:00
dependabot[bot] 51e567ffef
chore(deps): bump async from 2.6.3 to 2.6.4 in /superset-frontend (#21062)
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](https://github.com/caolan/async/compare/v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-22 21:02:51 -06:00
Lyndsi Kay Williams 6094274f0b
feat: Create dataset blank state (#21058)
* beginning of routing

* elizabeth review

* changed folder layout

* Dataset layout setup

* Fix DatasetLayout test

* Fixed height issue

* Fix link to sqllab

* Fix DatasetPanel test

* Remove arbitrary right panel

* Add empty state SVGs

* Restructure/rename some Dataset files

* Fixed styling issue

* Fix background color

* Fix header border

* Fix empty DatasetPanel styles

* Adjust description rendering in DatasetPanel to fix tests

* Add spaces back to blank dataset description to fix tests

* Fix blank dataset description styles

Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
2022-08-22 18:45:03 -05:00
Cody Leff 52648ecd7f
feat(dashboard): Add Drill to Detail modal w/ chart menu + right-click support (#20728)
* Add drill-to-detail modal.

* Include additional filters from dashboard context in request.

* Set page cache size to be approximately equal to memory usage of Samples pane.

* Update getDatasourceSamples signature.

* One-line import/export.

* Fix incorrect argument order in getDatasourceSamples invocation.

* Fix height of modal.

* Disable option in chart menu unless feature flag is set.

* Open modal on right-click.

* Fix double requests on modal open, controls disappearing on filter update.

* Show formattedVal in clearable filter tag.

* Set force=false for all requests.

* Rearrange/refactor DrillDetailPane.

* Reset page index on reload.

* Fix endless re-requests on request failure.

* Fix modal layout issues.
2022-08-22 15:57:18 -07:00
Yao Zhou ca98fd8468
docs: Format the same size of picture for better part of "Supported Databases" document (#21037)
* Fix bug: some word not translate in js.
delete the 'null,' in messages.json,
so that word can be translate in js.

* docs:No code change. Reformat the database logs with size 400*160,modify the aprt of "Supported dabase" in README
2022-08-22 15:29:53 -04:00
Michael S. Molina 0bf4e56dc3
fix: Drill to detail on values with comma (#21151) 2022-08-22 13:52:39 -03:00
Antonio Rivero Martinez bdcc0a9bcf
fix(charts): Hide Values greater than Max Y Axis Bound on Mixed Time Series with Bar series (#21015)
* Mixed TimeSeries:

- When Bar chart is used as serie type, we need to hide values that are greater than the max Y Axis Bound.

* Mixed Time Series:

- Simplify logic for getOverMaxHiddenFormatter

* Mixed Time Series:

- Add tests for new getOverMaxHiddenFormatter util func
2022-08-22 08:55:09 -06:00
Rajakavitha Kodhandapani d44202f03c
docs: added timescaledb (#21128) 2022-08-22 22:16:46 +08:00
stevetracvc d79b0bfc74
fix(native filters): groupby filter issue (#21084) 2022-08-22 22:15:33 +08:00
Yongjie Zhao 11bf7b9125
feat: generate label map on the backend (#21124) 2022-08-22 21:00:02 +08:00
Geido 756ed0e36a
feat: Add label and tooltip for the color schemes control (#21040)
* Add tooltip

* Remove title

* Add license

* Enhance E2E tests

* Update tests

* Lint and test fixes

* Enhance layout
2022-08-22 10:44:15 +03:00
JUST.in DO IT a1389d3a9f
fix(sqllab): avoid unexpected re-rendering on DatabaseSelector (#21141) 2022-08-22 15:43:42 +08:00
Yongjie Zhao fea68ef23c
fix: resample method shouldn't be freeform (#21135) 2022-08-22 15:42:46 +08:00