Commit Graph

6882 Commits

Author SHA1 Message Date
Bruno Motta
abfd3734cf
test: tests for component FaveStar (#13320)
* test for FaveStar

* removing comment
2021-02-25 15:47:28 -08:00
Evan Rusackas
33bec57619
chore: migrating some LESS (#13296) 2021-02-25 15:44:58 -08:00
David Aaron Suddjian
e11d0cbf44
refactor: Introduce api resource hooks, fetch owners for chart errors (#13218)
* refactor: introduce api resource hooks, fix error owners

* comment

* vestigial comment

* not a function

* clarification

* vestigial comment

* filter the api for a leaner response

* reorganize code, add resource hook catalog

* better names

* implement state management in redux

* Revert "implement state management in redux"

This reverts commit d64d50a99f.

* add tests for hooks
2021-02-25 14:41:35 -08:00
Michael S. Molina
72721845e1
test: Adds tests to URLShortLinkButton component (#13319) 2021-02-25 10:59:36 -08:00
Bruno Motta
8395b3d6c8
test: Tests for DeleteModal component (#13286)
* tests for DeleteModal component

* fix: test attribute

* removing config from DeleteModal.test.tsx

* re-run tests

* Update superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* Update superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* Update superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* Update superset-frontend/src/components/DeleteModal/DeleteModal.test.tsx

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-02-25 10:56:07 -08:00
AAfghahi
776685736c
sql Lab buttons (#13174) 2021-02-25 09:51:48 -08:00
Jesse Yang
d39bc14a0b
test: optimize codecov config (#13329)
* test: optimize codecov config to let GitHub checks always pass

* Run tests on workflow changes, too
2021-02-25 05:22:34 -08:00
Yongjie Zhao
94d0bb9e7f
fix: date picker support date unit with singular and plural (#13330)
* fix: date picker support date unit with singular and plural

* fix grammar
2021-02-25 17:38:23 +08:00
Rob DiCiuccio
970e473d10
Use redis:latest in docker-compose workflow (#13323) 2021-02-25 00:36:19 -08:00
Geido
8ab45c90cc
refactor: New Icon system with Enhanced Antd Custom Icon (#12229)
* Enhance custom icon

* Minor fix

* Move DashboardList icon trash icon to enhanced

* Enhance trash icon on lists

* Enhance actions icons card view

* Add storybook entry for custom icons

* Test delete button

* Remove commented line

* Fix linting issue

* Enhance Antd icons

* Enhance existing icons up to BoltSmallRunIcon

* Remove unused import

* Import/Exports all icons from index

* Export all existing icons

* Implement more enhanced icons

* Add data-id on edit buttons

* Fix lint issue

* Inherit color

* Apply original color to actions

* Fix linting issue

* Fix typo

* Change ModeHoriz to MoreHoriz
2021-02-24 19:36:40 -08:00
Daniel Vaz Gaspar
0b114fcbc5
feat(reports): send notification on error with grace (#13135)
* fix: add config to disable dataset ownership on the old api

* fix CI docker build

* fix logic

* add deprecation comment on the config

* feat: send alerts reports errors to recipients

* update

* feat(reports): send notification on error with grace

* merge and revert config

* fix lint and MySQL test

* fix mysql tests
2021-02-24 13:31:31 -08:00
Rob DiCiuccio
27f7d1157f
build: Ephemeral environments for PRs via slash command (#13189)
* First pass at ephemeral env, new Docker ci target

* Add service checks, get public IP

* Separate issue_comment and workflow_run jobs

* Refactor workflows

* Adjust comment author association

* Checkout code

* Fix image name, manage service desired task count

* Use merge commit sha

* Fix IP output, add failure comment

* Refactor comment parsing & env spinup

* Check container image publish status

* Parse AWS account ID from registry URL

* Use PR number rather than variable merge commit SHA for image tag

* Fix docker push conditional

* Push multiple tags to ECR

* Fix comment author check

* Refactor comment body check

* Provision service with active task to get correct IP

* /testenv up

* Add @mentions to PR comments, env var cleanup
2021-02-24 10:50:52 -08:00
Amit Miran
29d6420ecc
fix: exception when saving dash (#13300)
* fix: project None value

* fix: pre-commit
2021-02-24 12:08:28 +02:00
Ville Brofeldt
0a00153375
feat(chart-data): add rowcount, timegrain and column result types (#13271)
* feat(chart-data): add rowcount, timegrain and column result types

* break out actions from query_context

* rename module
2021-02-24 07:43:47 +02:00
Mayur
6954114f84
feat: add Echarts Graph chart (#13111)
* update preset file

* migration added

* bug fix

* lint

* Update superset/migrations/versions/1412ec1e5a7b_legacy_force_directed_to_echart.py

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* version bump

* bummp dependency

* add package.lock

* merge migrations

* add integration test

* lint

* remove unnecessary params from test

* check key existance in migrations

* test to typescript

* Update graph.test.ts

* fix migration downstream head

* Upgrade to lockfileversion 2

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-02-23 16:47:20 -08:00
Bruno Motta
8ef52babfe
fix(test): change data-test-id to data-test in FlashProvider (#13304) 2021-02-23 13:20:09 -08:00
Đặng Minh Dũng
e8114be99a
docs: Connecting to Trino Databases (#13171)
* feat: add trino logo

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores: update image links in README.md

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* docs: add Trino Connecting to Databases doc

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
2021-02-23 14:32:21 -05:00
Pablo Rodriguez Bertorello
3fbd44ecce
chore: update instructions for Pinot in connecting to databases (#12238)
* Update index.mdx

Pinot connection fix

* Update index.mdx
2021-02-23 14:08:53 -05:00
Michael S. Molina
9a05d6afe5
Migrates Collapse component from Bootstrap to AntD (#12920) 2021-02-23 10:24:08 -08:00
Jesse Yang
e4a0233181
test: use data-test for testIdAttribute (#13292) 2021-02-23 11:43:35 -06:00
ʈᵃᵢ
75677f42bc
fix(listview): preserve bulk selections when view mode is changed (#13284) 2021-02-23 11:17:31 -06:00
Bruno Motta
6297ad7c8b
test: Switching FlashProvider to function component & creating tests (#13220) 2021-02-23 10:46:12 -06:00
bolkedebruin
99a0c8a8a1
refactor: Move raise_for_dashboard_access to security manager (#13235)
raise_for_dashboard_access is part of dashboard and cannot
be overridden by a security manager.
2021-02-23 10:52:34 +00:00
Daniel Vaz Gaspar
6e3121268e
fix(alerts): Handle None on results (#13289) 2021-02-23 09:50:55 +00:00
Daniel Vaz Gaspar
9e2455aab7
refactor(api): csrf token on the new REST API (#13212)
* refactor(api): csrf token on the new REST API

* improve OpenAPI spec description

* fix test

* remove public role like has default for all tests

* fix test
2021-02-23 09:50:22 +00:00
Rob Spielman
e37c2bf8fd
fixing chart keys in MultiLineViz (#12937) 2021-02-23 10:40:23 +02:00
Evan Rusackas
8db5d43969
fix: style tweaks for inconsistent button spacing (#13254)
* fix: button margin glitches

* removing unncessary fragment

* removing grid gap

* Revert "removing unncessary fragment"

This reverts commit 659e27348f.
2021-02-22 22:49:59 -08:00
Karol Kostrzewa
a5a31e0e60
fix schedules tests (#12870)
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-22 22:21:19 -08:00
Jesse Yang
af3a46048d
fix(home): missing key and invalid dates in Recents cards (#13291) 2021-02-22 20:30:52 -08:00
Jesse Yang
c02079278e
fix: migration script message formatting issue (#13262) 2021-02-22 18:37:43 -08:00
Karol Kostrzewa
974f4476e5
fix reports/commands_tests (#12864)
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-22 14:53:14 -08:00
Moriah Kreeger
fc180ab2a6
fix: add alert report timeout limits (#12926)
* prevent working timeout and grace period from being set to negative numbers

* add extra validation

* lint

* fix black

* fix isort

* add js tests

* fix lint + more python schema validation

* add report schema test for timeout limits

* add extra test for null grace period
2021-02-22 11:12:10 -08:00
Michael S. Molina
741219e84d
test: add Tests and Storybook for AsyncAceEditor (#13241) 2021-02-22 11:06:23 -08:00
ʈᵃᵢ
a646914493
fix(menu): links that result in 404s (#13283) 2021-02-22 12:15:12 -06:00
Lily Kuang
1e2ea36e70
disable redirect when bulk select enabled (#13245) 2021-02-22 09:27:18 -08:00
Victor Malai
b5379bc8c5
fix(viz): calendar heatmap granularity (#13233)
* fix: add time granularity to heatmap query

* fix: add time granularity to heatmap query

* Add aggregation for druid

* Fix lint

* Fix lint

Co-authored-by: Victor Malai <victormalai@Victors-MacBook-Pro.local>
2021-02-22 16:17:36 +02:00
rijojoseph07
efeb5a93e6
feat(presto): add support for user impersonation (#13214)
* changes to support presto impersionation with ldap

* renamed method to match 30 char limit

* import spell check

* added presto impersonation test

* refactored impersionation code to generalize for extension

* moving config_args mutation to the update_connect_args_for_impersonation

* moving config_args mutation to the update_connect_args_for_impersonation

* nits

* refactored update_impersonation_config method name to match lint rule

* reduced comment line length

* black reformats

Co-authored-by: rijojoseph01 <rijo.joseph@myntra.com>
2021-02-22 15:01:33 +02:00
simcha90
9b5e66b728
refactor(native-filters): Refactor filters config modal module (#13268)
* refactor(native-filters): Refactor filters config modal module

* fix: fix import

* lint: fix import
2021-02-22 09:23:38 +02:00
Victor Malai
e8d50356a2
Add sort by for dist bar chart (#13049) 2021-02-22 08:36:57 +02:00
Ville Brofeldt
87d6ad28ad
chore(viz): bump superset-ui 0.17.10 (#13258) 2021-02-22 08:24:31 +02:00
Ville Brofeldt
15567dd627
ci: always execute tests on non-PRs (#13260) 2021-02-22 08:23:34 +02:00
Victor Malai
73ce2f1ea7
feat: Add sort by metric for charts with multiple metrics (#13057)
* feat: Add sort by metric for pivot-table

* feat(legacy-plugin-chart-parallel-coordinates): subject Add sort by metric

* feat(legacy-plugin-chart-rose-chart): subject Add sort by metric

* feat(legacy-plugin-chart-partition): subject Add sort by metric

* feat(legacy-plugin-chart-paired-t-test): subject Add sort by metric

* feat(legacy-plugin-chart-treemap): subject Add sort by metric

* feat(legacy-plugin-chart-nvd3-area): subject Add sort by metric

* Fix lint

* feat(plugin-chart-horizon): Add sort by & Add no default sorting if checkbox is not selected
2021-02-21 21:59:45 -08:00
Michael S. Molina
42ab57850d
Migrate Bootstrap Alert to AntD (#12101) (#12122) 2021-02-21 20:50:18 -08:00
Michael S. Molina
7ee8d114d2
fix: SqlEditor_spec tests (#13186) 2021-02-21 20:49:51 -08:00
Lily Kuang
d8bd8ec896
fix(alert/report): alert modal loading dropdown options (#13222)
* alert modal loading

* add ui test
2021-02-22 01:59:33 +00:00
pavlozt
4bc2daf4c1
fix: TimeTable average with nulls calculations (#13122) 2021-02-20 19:46:00 +02:00
Kamil Gabryjelski
c1aacde304
fix(explore): Fix downloading as image charts which use Mapbox (#13181)
* Fix downloading as image charts which use Mapbox

* Remove unused prop

* Bump deckgl version
2021-02-20 19:45:03 +02:00
Kamil Gabryjelski
19a60435b0
chore: bump node.js to v14 (#13215)
* Bump node version to v15.8.0

* Update node version in Dockerfile and docker-compose.yml

* Set node version to LTS - v14.15.5

* Bump node version in .nvmrc
2021-02-20 19:42:51 +02:00
Xiang Fu
786c12d52d
fix: Fixing pinot query generation for date format conversion from python datetime format to java simple date format (#13163)
* Fixing pinot query generation for date format conversion from python datetime format to java simple date format

* Address comments

* fix test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-02-20 08:26:34 +02:00
Thinking Chen
eea5fe3b60
fix: add the untranslated text content of Chart page, Sql Editor page and some dashboard label in messages.pot (#13123) 2021-02-19 17:54:22 -08:00