* fix (dataset editor) add read-only mode for Source tab
* add feature flag, add unit tests
* rebase and fix comment
* add message for padlock
* move padlock to the bottom of tab
* Changed height of slices in dashboard into 100%-padding, so there is no scroll appearing anymore
* Added scroll to the block on dashboard, when filters are too high
* Applied lint
* Refactor tooltip in ColumnElement
* Refactor tooltip for Button
* Remove redundant import
* Refactor tooltip in SqlEditor
* Increase line height in tooltip so that the text is centered
* Refactor tooltip in Link
* Refactor tooltip in AdhocMetricEditPopoverTitle
* Refactor tooltip from ControlHeader
* Refactor tooltip in DateFilterControl
* Refactor tooltip in VizTypeControl
* fixup! Refactor tooltip in AdhocMetricEditPopoverTitle
* Refactor tooltip in QueryAndSaveBtns
* fixup! Refactor tooltip in DateFilterControl
* Refactor tooltip in CopyToClipboard, fix cursor pointer
* Refactor tooltip in TooltipWrapper
* Refactor tooltip in Field/DatasourceEditor
* Remove redundant import
* Fix typing for placement prop
* Decrease margin in ColumnElement divider
* Change default export to named
* Move SqlLab Tooltip styles to Emotion
* Fix tests
* Refactor DisplayQueryButton into functional component and use react-table
* Refactor EstimateQueryCostButton to functional component
* Use react-table instead of reactable-arc
* Remove reactable-arc dependency
* Add margin for copy button
* Make search case insensitive
* Remove MenuItem from CopyToClipboard
* Refactor DateFilterControl
* fixup! Remove MenuItem from CopyToClipboard
* Remove console log
* Refactor LanguagePicker
* Refactor HeaderActionsDropdown
* Remove dir with Menu component
* Add imports to common/components/index
* Fix after rebase
* toggleSchedule
* cleaning up run query button
* removing unnecessary (subtle!) style overrides
* bulk action classname to button style prop
* nixing btn-primary
* nixing cancelQuery class
* togglesave
* nixing autocomplete class
* linting
* nixing button classes of 'ok' and 'reset'
* unoing diagnostic test
* begrudgingly adding an m-r-3 class... for now
* this is not a class to worry about
* test fixes for limit control
* updating TODO notes, calling it a day for now.
* gah... copy paste error.
* use conditional operator for lookup
* editing dashboard title should update after save
* uncomment test
* fix json metadata save
* json metadata color scheme should overwrite state
* test's functionality is no longer applicable
* add lastModifiedTime to DashboardInfo
* Refactor TableLoader to use react-bootstrap
* Remove unnecessary css classes
* Fix import
* Fix styling for no data
* Refactor TableLoader into functional component
* Convert TableLoader to typescript
* style(sqllab): make database errors more clear and render as monospace
In SQL Lab, when a database error message is returned, generally because
of a user error in the SQL, it's identified as an "Unexpected Error" and
some of the text formatting of the error message (\n, spaces, tabs, ...)
are lost as they are rendered in html.
This PR identifies the error as a "Database Error", and renders like
more like a <pre>, using a monospace font.
* fix the build
* addressing comments
* addressed comments
* lint + removing cruft
* addressing comments
Recently a change related to emotion styling not properly working through
react-bootstrap's popover broke the SpatialControl.
This PR makes SpatialControl use antd's equivalent, and addresses the
issue as a result: emotion's styling context is preserved through
this superior popover.
* Remove usages of reactable in AlteredSliceTag
* Fix tests
* Move mocked data to fixtures file
* Use optional chaining
* Remove default value, change a unit test logic
* Code review fixes
* error -> error-solid
* warning -> warning-solid
* all the new icons mixed in!
* card-view -> card_view
* circle-check-solid -> circle_check_solid
* corrected circle-check to new name and correct (stroke) icon
* sort-asc/desc -> sort_asc/desc
* databases -> database
* compass -> nav_explore
* pencil -> edit-alt
* more pencil migrations
* easy list view rename
* star -> favorite (changed in Figma)
* removing deprecated icon
* renaming icon to mach figma
* More -> More Horiz
* forgot to change this when ranming the file
* updating some icon names in use
* adding hella icons
* fixing errant viewboxes
* removing dropdown-arrow in favor of triangle-down
* adding key to storybook map.
* fixing icon component reference
* tweaks to fave star styling to support revised icon
* fixing a bad icon inclusion
* missed a license
* touchup to virtual dataset... will tweak later.
* e2e fix
* linting
Fixed a couple of criticle errors and left the warnings as is (mostly
from react-hooks/exhaustive-deps).
Let's fix the warnings in future PRs as sometimes unexhaustive deps
are intentional.
* use svg for checkbox component
* add vertical align to svg
* use emotion styling
* update import to superset core
Co-authored-by: Elizabeth Thompson <elizabeth@preset.io>
* labels with onClick don't need .pointer. No labels need `m-r-5`
* making Timer a proper Label
* a little linting
* addresing (helpful, thanks) comment
* getting rid of weird focus/active outline ring
* Buttons... buttons _everywhere_
* linting
* Nixing views/CRUD/dataset/Button component
* fixing 2 typing errors
* fixing more TS errors
* prefer src path for include
* one more real button, one less CSS class
* one more "button" to "Button"
* Published Status is now a proper clickable Label
* nixing the CRUD button again
* touching up stories, with SupersetButton story
* SIP-34 button colors
* adding polished package to mix colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* more abstraction from bsStyle/bsSize props
* exchanging styles for a prop
* linting
* restoring feature flag to stock
* using src alias
* last <button> replacement
* this classname would never be applied
* more linting action
* fixing unsupported bsSize 'medium', and cta typing error
* more cta action
* unnecessary styles
* errant bsSize prop
* cleanup
* tweaks to make new New button work
* Linting
* fixing a couple tests
* fixing theme based test failure
* margin tweak for NEW button
* another fixed test
* another fixed test
* fixing two more tests
* fixing last broken tests.
* always be linting
* Adding tertiary/dashed buttons
* cleaning up QueryAndSave buttons
* fixing "link" button styles
* fixing/updating link button styles
* cta buttons on Modal component
* linting.
* exporting button story knobs, making ALL knobs safe for export.
* capitalizing a file... no big whoop
* Basic button tests
* renaming button - temporarily
* renaming file to fix capitalization issue
* passing theme through to a difficult popover.
* fixin' a newly busted unit test
* lint fixin'
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* touching up stories, with SupersetButton story
* SIP-34 button colors
* updating button colors to match Superset theme
* abstracting away from bootstrap-specific props (might pivot libraries soon!)
* linting
* restoring feature flag to stock
* cleanup
* Linting
* renaming button - temporarily
* renaming file to fix capitalization issue
* oops, shouldn't have changed this prop!
* adding a dive() to themedShallow, and fixing a cypress/jest test
* addressing lint stuff
* nixing new modal button
* Fixing another popover/button issue that should break cypress
* lint ✨
* passing classNames through to new button (should fix some tests)
* cleaning unused classes, making cypress tests use data attrs
* fixin' the test
* fixing another class-based test with data-test attr
* no longer passing theme as prop to buttons in popovers... themeprovider is better
* outline/border tweaks!
* style: shinier menus
* fixing mouseover glitch
* unused import
* rm emotion-reset
* restoring default config values
* lint fixes ✨
* a bit more pizzaz to the underlines (max's idea), fading active background
* simplifying navtitle -> label
* RBNavDropdown -> ReactBootstrapNavDropdown
* nixing whitespace
* replacing !importants with better selector specificity
* moving Menu LESS into Emotion
* no more border!
* fixing border issue
* language picker, account dropdown now use new dropdown component
* nixing whitespace in comment
* nixing duplicate styling
* removing borders on FAB navbar
* explicit font coloring
* linting
* moving two console errors to logger errors
* nixing unused map index
* nixing unused param
* linting
* changing an alert to a toast
* fixing tests
* lint fix
* one letter change, just to see if iti gets CI to pass this test.
* Niftier paddings
* upgrading storybook, fixing glob pattern
* moving a couple storybook dependencies to dev dependencies
* fixing annoying lint issue about dev dependencies needing to be dependencies
* adds essential addons, fixes backgrounds
* newline tweaks
* comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff
* a *python* linter doesn't like this whitespace?!
* putting the linespace back
* ugh, found the space causing CI issues... I think
* allow tests in jest confg
* sample stories for Label component
* passing tests
* stories to tsx!
* excluding knobs exports from published stories
* ts fix
* ts fix
* Label test to TS
* explicitly ignoring test files in webpack bundling
* linting stuff
* adding comment about test file exclusions
* colors corrected, hover/cursory only change if there's an onClick
* adding info label, breaking gallery out to its own story
* linting
* fixing bad class name
* now with fading!
* now supporting additional (non-bootstrap) label styles
* adding new secondary/primary labels to gallery
* fixing map key react warning
* using the new secondary label in the ChartList view
* linting
* fixing TS issue
* fix: removing unsupported modal sizes
* linting!
* NOT specifying bsSize seems to have the same effect as (unsupported) "medium"
* supporting 'large' and 'small' over 'lg' and 'sm'
* fixing last-of-type specificity
* Simplifying/consolidating styles
* fixing filterbox in explore
* linting
* adding some px to font sizes
* fixing in-dash overflow
* removing px for one special fontsize case
* simplifying, addressing comments
* widen the autocomplete menu for table names
* display the full table name in a tooltip
* license
* Update superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* src importing
* move autocomplete width css to main.less
* use html title attribute instead of tooltip
Co-authored-by: Evan Rusackas <evan@preset.io>
* chore: TypeScript <Label />
* rebase
* chore: TypeScript <Label />
* rebase
* A bunch o' test fixes. One more to go!
* helper for mountying Emotional components with Enzyme
* asf license
* fixed last test, some linting
* improve the storybook
* Adressing comments
Co-authored-by: Evan Rusackas <evan@preset.io>
* fix(log): log crashes if expired or not authenticated
* fix lint and rison
* add tests
* more tests
* perm fix
* fix test not found
* JS lint
* fix Jest test
* migrated LanguagePicker.jsx to tsx
* Migrated Menu.jsx to tsx
* migrated MenuObject.jsx to tsx
* migrated NewMenu.jsx to tsx
* Migrated UserMenu.jsx to tsx
* removed unnecessary export from UserMenu
* added language definition in LanguagePicker
* removed unnecessary exports from Menu.tsx
* used typeof guard for childs
* changed LanguageProps to Languages
* removed unnecessary type casting
* fixed linting errors
* style: SIP-34 labels
Aligning with SIP-34 designs for labels/pills. Going uppercase fixes the
padding issues we had before, and the rounder pills look better.
Cleaning up some CSS in the process
* lint
* chore: wiring ControlLabel to a new FormLabel
Creating new simple <FormLabel /> component and wiring all <label>
and react-bootstrap.ControlLabel towards it.
FormLabel becomes a pivotal point that can be altered to point to AntD
when we're ready.
* lint
* ViewportControl
* addressing comments
* Storybook added!
* starting to configure junk....
* Storybook works!!!
* Now with theme!
* apache boilerplate
* more apache comments
* lots o' knobs for the Button.... taking stock of the codebase
* more classes, but killing the knob for now.
* nixing unused module
* linting
* fresh package-lock
* now with tooltip!
* adding path and zlip because the linter told me to
* upgrading storybook packages from devdeps
* linting
* removing cruft
* killing an annoying (and old?) lint issue
* lint fix, take 2.
* removing zlib/path
* package lock reset from master
* re-adding new packages for this here PR
* nixing console log, simplifying
* nixing comment TODOs (done enough!)
* basic docs.
* out with the old, in with the new
* vertically centering logo once and for all
* lint: black instead of IDE formating
* touch config.py
* Styles -> StyledHeader
* nixing vestigial SVG
* removing trademark
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
* feat: add database dropdown to dashboard import
Currently, when importing a database from a JSON file, the process
looks at the database name from the source (the info is in the file)
and matches the datasources to that name. If no database by that name
exists, it simply fails.
With this PR, we add a database dropdown that allows the user to specify
which databases the datasources should target as the get upserted.
I want to stress that the code in this area is not in a great shape,
and that the challenge of serializing/deser the nested objects is
challenging, but that there should be a much better way to do this.
One of the improvement (out of scope for this PR) that would allow to
simplify those import/export would be to use UUIDs for
importable/exportable objects.
Another identified issue is the indirections between
`utils/import_expor_{model}.py` on top of `{Model}.import_object`. Not
addressing that here.
Next topic is the MVC stuff. Decided to stick with it for now as this is
more of a [obious missing feat:] than a rewrite.
* isort \!? 0%^$%Y$&?%$^?%0^?
* fix tests
* pre-committing to py3.6
* address dpgaspar's comments
* revert isort
* fix: reordering DOM output, simplifying styles, Emotionalizing
* simplification
* converting RefreshChartOverlay to TS
* Loading -> TS, stripping unused size prop
* simplification...
* just letting "position" prop act as a class name. Simpler!
* consolidating styles, changing a className prop to a position prop.
* nixing (unused) classname prop
* replacing inline loading img with the proper Loading component
* BY THERE.
* position prop is optional!
* bumping style package (now with typography styles!)
* ThemeProvider ALL the things!
* package lock
* linting
* no need to parseInt here anymore, the values are numeric now.
* feat: upgrade react-select v1.3.0 to v3.1.0
Upgrade `react-select`, replace `react-virtualized-select` with a custom
solution implemented with `react-window`.
Future plans include deprecate `react-virtualized` used in other places, too.
Migrate all react-select related components to `src/Components/Select`.
* Fix new list view
* Fix tests
* Address PR comments
* Fix a flacky Cypress test
* Adjust styles for Select in CRUD ListView
* Fix loadOptions for owners select in chart PropertiesModal
TODO: add typing support for AsyncSelect props.
* Address PR comments; allow isMulti in SelectControl, too
* Clean up NaN in table filter values
* Fix flacky test
* Expose additional APP_ICON_WIDTH python config variable to ui via app bootstrap for use in Menu
* Update base.py to inclue APP_ICON_WIDTH via bracket notation instead of .get and adjust Menu proptypes to be required.
Co-authored-by: Natalie Ruhe <nruhe@nruhe.attlocal.net>
Co-authored-by: Natalie Ruhe <natalie@preset.io>
* improve history for query params
* fix: push browser history on pagination in react listviews
* fix spec
Co-authored-by: Tai Dupree <tdupreetan@gmail.com>
* [datasets] new, react listview
* add hidden columns to support filtering by columns not rendered
* throw exception if config is incorrect
* fix database filter
* update endpoints to point to datasets; fix translation strings
* move Link into src/components
* add add new record button to datasets listview
