Commit Graph

7205 Commits

Author SHA1 Message Date
Lily Kuang
7980b767c0
feat: Implement Celery SoftTimeLimit handling (#13740)
* log soft time limit error

* lint

* update test
2021-04-12 13:18:17 -07:00
Sam Faber-Manning
911462a148
feat: only send alert error emails to owners of the alert (#13862)
* only send alert error emails to owners of the alert

* reformat long lines

* fix send to owners and add tests

* fix pylint errors

* fix formatting
2021-04-12 08:51:32 -07:00
Sam Faber-Manning
778bb8e540
feat: add descriptions to report emails (#13827)
* add description to report email

* add report description to slack notification

* fix issues caught by linter

* fix long line

* remove extra line

* handle missing descriptions

* run python black

* properly run python black
2021-04-12 08:50:44 -07:00
Kamil Gabryjelski
bf22487e23
Make chart exclude itself from cross filtering (#14046) 2021-04-12 14:08:07 +03:00
simcha90
d6bd160250
fix: fix bug when remove chart not removing it's related cross filter data (#14081) 2021-04-12 10:54:31 +03:00
simcha90
468638c5b8
feat(native-filters): Add default first value to select filter (#13726)
* feat: native filters first default value

* fix: fix CR notes

* feat: add support for `Place` type

* refactor: sync with master

* feat: add first value to Select filters

* refactor: fix CR notes

* refactor: updates usage of `ownFilters` to `ownState`

* Revert "refactor: updates usage of `ownFilters` to `ownState`"

This reverts commit 58b91998

* fix: revert mocks

* fix: fix CR notes

* chore: update package json

* chore: update package json

* chore: update package json

* test: fix tests

* fix: fix BE empty metrics

* lint: fix lint

* fix: fix BE empty metrics

* refactor: fix Cr notes
2021-04-12 09:22:33 +03:00
Ben Reinhart
1c6173c7ee
feat: Make async query JWT cookie domain configurable (#14007) 2021-04-11 20:33:33 -07:00
Hugh A. Miles II
de49f0d2de
fix: add exception to catch session not having JWT (#14036) 2021-04-11 16:47:06 -04:00
Tom Vendetta
287bc12e45
Use consistent chart value (#14031) 2021-04-11 09:30:26 +03:00
Hugh A. Miles II
a4fd6b8f33
fix: Use superset generic db to catch external_metadata queries (#13974) 2021-04-10 10:15:03 -04:00
Jesse Yang
fe08b698f5
docs: update outdated country map tools instructions (#14027)
also add actionable error for country map vis
2021-04-09 15:15:17 -07:00
Bruno Motta
66201e7c55
test: FilterSets-utils (#14028)
* Tests for "nativeFilters/FilterBar/FilterSets/utils"

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix: Lint error

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:07:37 -07:00
Bruno Motta
95ed8735f1
chore: well component to card component(Updating PR #12200) (#14033)
* replace Well componenet with Card component

* Fix lint errors

* Fix lint

* Addressing comments

* Addressing comments

* Fix lint errors

* Exporting Card from index.tsx and adding storybook variants

* Fix some refactoring

* Fix errors

* solving conflicts and lint errors

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/Card.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/common/components/common.stories.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 15:06:44 -07:00
Ville Brofeldt
bfa6140b15
fix(viz): bump superset-ui 0.17.30 (#14045)
* fix(viz): bump superset-ui 0.17.30

* fix test

* bump react-table to match the version in superset-ui
2021-04-09 20:49:38 +03:00
Bruno Motta
ff08d423a9
Tests for ControlItems (#13975) 2021-04-09 09:54:35 -07:00
Bruno Motta
1920811cf2
test: Tabs (#13941)
* Test for Tabs component

* Fix: "creteProps" to "createProps"

* Update superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:54:16 -07:00
Bruno Motta
011af825a9
test: Tab (#13937)
* Tests for Tab component

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:53:54 -07:00
Erik Ritter
3d357c661c
feat: handle chart/data API errors (#14040) 2021-04-09 09:39:02 -07:00
Bruno Motta
ec3f8d07f4
test: SliceHeader (#13888)
* tests for SliceHeader

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:14:16 -07:00
Bruno Motta
36f101e500
test: ShareMenuItems (#13860)
* Tests for ShareMenuItems

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-09 09:13:05 -07:00
Bruno Motta
c0017b3262
Tests for ColumnSelect (#13991) 2021-04-09 09:02:39 -07:00
Hugh A. Miles II
fd201fe834
Update CONTRIBUTING.md (#14025) 2021-04-09 11:57:53 -04:00
Bruno FERNANDO
9e03b6d122
feat(helm): add pod and deployment annotations to template (#14030) 2021-04-09 08:09:59 -07:00
Caleb Collins-Parks
2c96c5b341
Fix broken port-forward instructions (#14039)
The pod listens on port 8088, not port 80. Also if you port-forward from the service then you don't have to bother getting the pod name.
2021-04-09 13:17:22 +03:00
John Bodley
a3b41e2bac
fix: Issue 13956 (#13980)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-04-09 15:21:58 +12:00
Elizabeth Thompson
667eb83e33
use dynamic time_grains for schema (#14009) 2021-04-08 13:53:38 -07:00
Beto Dealmeida
c60a93db9c
feat: add extract_errors to Postgres (#13997)
* feat: add extract_errors to Postgres

* Add unit tests

* Fix lint

* Fix unit tests
2021-04-08 13:24:54 -07:00
Michael S. Molina
784d29b57c
chore: Moves Fade component into TableElement (#13458) 2021-04-08 12:56:21 -07:00
AAfghahi
b5e5b3aa62
feat: create backend routes and API for importing saved queries (#13893)
* initial commit

* revisions

* started tests

* added unit tests

* revisions

* tests passing

* fixed api test

* Update superset/queries/saved_queries/commands/importers/v1/utils.py

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

* Revert "Update superset/queries/saved_queries/commands/importers/v1/utils.py"

This reverts commit 18580aad1e.

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
2021-04-08 14:20:11 -04:00
Rob DiCiuccio
806fb73d25
feat(SIP-39): Websocket sidecar app (#11498)
* WIP node.js websocket app

* Load testing

* Multi-stream publish with blocking reads

* Use JWT for auth and channel ID

* Update ws jwt cookie name

* Typescript

* Frontend WebSocket transport support

* ws server ping/pong and GC logic

* ws server unit tests

* GC interval config, debug logging

* Cleanup JWT cookie logic

* Refactor asyncEvents.ts to support non-Redux use cases

* Update tests for refactored asyncEvents

* Add eslint, write READMEs, reorg files

* CI workflow

* Moar Apache license headers

* pylint found something

* adjust GH actions workflow

* Improve documentation & comments

* Prettier

* Add configurable logging via Winston

* Add SSL support for Redis connections

* Fix incompatible logger statements

* Apply suggestions from code review

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* rename streamPrefix config

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-04-08 11:12:03 -07:00
Rob DiCiuccio
6a81a7961c
feat: Support feature flag overrides in ephemeral test envs (#14008)
* Add support for feature flag overrides in ephemeral env cmd

* update docs to reference correct config

* Update ephemeral env docs
2021-04-08 11:05:59 -07:00
Jack Fragassi
5dd971eaf5
fix: execution log crashes for logs with no uuid (#13998)
* Fix execution log when no execution id

* Use single quotes

* Pretty
2021-04-08 06:50:23 -07:00
Lyndsi Kay Williams
7697bc297c
feat: FE: Export for Queries II (#13981)
* package.lock upgrade

* Copied changes from old PR

* Cleaned up ternaries

* Added export check for VERSIONED_EXPORT feature flag
2021-04-08 09:22:15 -04:00
Daniel Vaz Gaspar
89817d4cee
fix(alerts/reports): working timeout with celery kill and logic fix (#13911)
* fix: working timeout with celery kill and logic fix

* add config flags

* fix typo

* fix python lint

* log query time for alerts

* add tests

* fix lint
2021-04-08 11:23:31 +01:00
Ville Brofeldt
b427a80a4f
fix(sqla): apply sqla type on calculated columns (#14014) 2021-04-08 10:59:26 +03:00
Michael S. Molina
b5c95c537c
test: Adds tests to the CssEditor component (#13933) 2021-04-07 14:40:24 -07:00
Geido
6c06866583
test: Tests and Storybook entry for the IndeterminateCheckbox Component (#13502)
* Add tests for IndeterminateCheckbox

* Add storybook entry

* Fix linting issue

* Remove mocked icon

* Add jest.fn to mockedProps
2021-04-07 13:34:19 -07:00
Bruno Motta
dcb9f7cff1
test: DataTablesPane (#13736)
* Tests for DataTablesPane

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Using factory for props

* replacing "data-test"

* removing "act" from tests and fix error

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-07 11:35:27 -07:00
Bruno Motta
284402c583
test: AdhocMetricEditPopover (#13787)
* tests for AdhocMetricEditPopover

* replace "factoryProps" for "createProps"

* removing unnecessary if

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-04-07 10:34:29 -07:00
Geido
cc075f23ef
test: Tests and Storybook entry for the TableView Component (#13501)
* Refactor TableView tests

* Add more tests

* Add storybook entry

* Remove unnecessary control
2021-04-07 10:33:55 -07:00
Yongjie Zhao
f06d53455c
fix: annotation modal dateRangePicker saved invalid value (#13969) 2021-04-07 22:02:29 +08:00
Yongjie Zhao
e3efaba775
test: prevent flaky frontend unit test case (#13984)
* test: prevent flaky unit test case

* Update superset-frontend/spec/javascripts/datasource/ChangeDatasourceModal_spec.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-04-07 20:08:04 +08:00
Yongjie Zhao
56dc74e09f
fix: Pie chart not displayed in viz (#13987) 2021-04-07 17:08:24 +08:00
Beto Dealmeida
a82d72fef6
feat: initial work to make v1 API compatible with SIP-40 and SIP-41 (#13960)
* WIP

* Use errorhandler

* Add response schema

* Fix status on HTTPException

* s/found/encountered/g

* Fix test

* Fix lint

* Fix lint and test
2021-04-06 22:06:32 -07:00
Bruno Motta
1638e6e932
test: exploreUtils (#13719)
* Tests for exploreUtils

* removing eslint-disable

* applying factory

* Removing skip tests and code comments.

* Improving test name

* remove comments

* Improving "shouldUseLegacyApi" tests

* fixing typo
2021-04-06 21:35:34 -07:00
Michael S. Molina
4602ead10c
test: Adds tests to the filter scope components (#13887) 2021-04-06 21:31:35 -07:00
Beto Dealmeida
3b11654c5a
fix: import dataset/dashboard empty keys (#13979) 2021-04-06 20:55:15 -07:00
Bruno Motta
ab0f5e3087
test: PropertiesModal (Dashboard) (#13931)
* Tests for PropertiesModal (Dashboard)

* fix: fetchMock
2021-04-06 14:00:35 -07:00
Phillip Kelley-Dotson
34991f5fab
fix(explore): strip semicolons in virtual table SQL (#13801)
* add method to strip semicolon

* address comments

* test the test

* Update tests/sqla_models_tests.py

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* Update tests/sqla_models_tests.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* fix test

* add suggestion

* fix trailing space

* remove logger

* fix unit test

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-04-06 13:40:34 -07:00
Geido
c0888dc16d
Add tests for FilterBar CascadeFilterControl (#13950) 2021-04-06 11:15:17 -07:00