mirror of https://github.com/apache/superset.git
fix: import dataset/dashboard empty keys (#13979)
This commit is contained in:
parent
ab0f5e3087
commit
3b11654c5a
|
@ -115,7 +115,7 @@ def import_dashboard(
|
|||
# TODO (betodealmeida): move this logic to import_from_dict
|
||||
config = config.copy()
|
||||
for key, new_name in JSON_KEYS.items():
|
||||
if config.get(key):
|
||||
if config.get(key) is not None:
|
||||
value = config.pop(key)
|
||||
try:
|
||||
config[new_name] = json.dumps(value)
|
||||
|
|
|
@ -92,7 +92,7 @@ def import_dataset(
|
|||
# TODO (betodealmeida): move this logic to import_from_dict
|
||||
config = config.copy()
|
||||
for key in JSON_KEYS:
|
||||
if config.get(key):
|
||||
if config.get(key) is not None:
|
||||
try:
|
||||
config[key] = json.dumps(config[key])
|
||||
except TypeError:
|
||||
|
|
|
@ -312,7 +312,7 @@ class TestImportDatasetsCommand(SupersetTestCase):
|
|||
assert dataset.schema == ""
|
||||
assert dataset.sql == ""
|
||||
assert dataset.params is None
|
||||
assert dataset.template_params is None
|
||||
assert dataset.template_params == "{}"
|
||||
assert dataset.filter_select_enabled
|
||||
assert dataset.fetch_values_predicate is None
|
||||
assert dataset.extra is None
|
||||
|
|
|
@ -368,7 +368,7 @@ dataset_config: Dict[str, Any] = {
|
|||
"schema": "",
|
||||
"sql": "",
|
||||
"params": None,
|
||||
"template_params": None,
|
||||
"template_params": {},
|
||||
"filter_select_enabled": True,
|
||||
"fetch_values_predicate": None,
|
||||
"extra": None,
|
||||
|
|
Loading…
Reference in New Issue