Commit Graph

268 Commits

Author SHA1 Message Date
Jesse Yang
4342c33d0e
build: enable typescript for cypress (#10170) 2020-06-29 10:53:33 -07:00
Jesse Yang
9bdfa055ac
feat(viz): add query mode switch to table chart (#10113)
1, Replace table chart rendering from jquery.DataTables to react-table: apache-superset/superset-ui#623
2. Rearrange the control panel, replace GROUP BY and NOT GROUP BY with a "Query Mode" switch: apache-superset/superset-ui#609
2020-06-28 21:37:04 -07:00
ʈᵃᵢ
3414f35792
refactor: better naming for config flags (#10180) 2020-06-26 17:36:50 -07:00
Erik Ritter
8bdc6b1771
fix: row count container alignment (#10179) 2020-06-26 16:07:29 -07:00
Maxime Beauchemin
f888656e6d
style: bring new SIP-34 palettes in controls (#10121) 2020-06-26 13:27:51 -07:00
Jason Davis
9de9e1c19d
feat: Added configuration to SQL Lab results "Explore" button (#10164)
* added configuration to virtual table explore button

* added description to mixin

* fixed unit tests

Co-authored-by: Jason Davis <@dropbox.com>
2020-06-26 09:54:55 -07:00
oashton
d8314eeb0d
Add maximize and minimize feature to charts (#9210)
* Add maximize and minimize feature to charts

* Fixed lint issues

* Update superset-frontend/src/dashboard/components/SliceHeaderControls.jsx

Add translation function

Co-Authored-By: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Remove resizeEvent property, change condition to use the nextProps

* Minor changes, improve source code

* Fixed lint issues

* Remove unnecessary resizeEvent props

* Move inline style to css class style

* Minor fixes, improvements css

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2020-06-26 09:12:53 -07:00
Jesse Yang
ece4f6d0b5
build: upgrade Cypress and re-enable visualization tests (#10158) 2020-06-25 15:24:23 -07:00
Maxime Beauchemin
1781ebbaa4
fix: [search query view] edit link is broken (#10128)
* fix: [search query view] edit link is broken

* eslint + mypy

* rever app.py changes

* addressing comments

* use api/v1/query

* fix test
2020-06-25 12:20:10 -07:00
Jesse Yang
ecb44a4243
refactor: import emotion-theming methods from @superset-ui/style (#10157)
This makes the code cleaner and fixes missing theme variables when `npm link @superset-ui/style`.
2020-06-24 19:23:51 -07:00
Evan Rusackas
36ea42f092
fix: Loading overlay bugfix and cleanup (#10105)
* fix: reordering DOM output, simplifying styles, Emotionalizing

* simplification

* converting RefreshChartOverlay to TS

* Loading -> TS, stripping unused size prop

* simplification...

* just letting "position" prop act as a class name. Simpler!

* consolidating styles, changing a className prop to a position prop.

* nixing (unused) classname prop

* replacing inline loading img with the proper Loading component

* BY THERE.

* position prop is optional!
2020-06-24 14:21:45 -07:00
Bogdan
3db76c6fdc
Implement create view as functionality (#9794)
Implement create view as button in sqllab

Make CVAS configurable

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-06-24 09:50:41 -07:00
Ville Brofeldt
38667b72b1
fix: refine shouldUseLegacyApi and add tests (#10148)
* fix: refine shouldUseLegacyApi and add tests

* address review comments
2020-06-24 19:38:36 +03:00
Jesse Yang
4e71491d86
fix: FilterBox JS when no results (#10143) 2020-06-24 08:09:14 -07:00
Bogdan
763b38591c
Fix CTAS explore flow (#10147)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-06-23 22:36:05 -07:00
ʈᵃᵢ
be936c2eb8
style: listviews closer to SIP-34 (#10094) 2020-06-23 14:17:28 -07:00
Lily Kuang
4d1d40989c
feat: dataset add modal (#10104) 2020-06-23 10:15:35 -07:00
Jesse Yang
ed4f6e93ac
chore: bump superset-ui to v0.14.1 (#10112) 2020-06-22 11:14:23 -07:00
Grace Guo
a80453d945
fix: dashboard filter scope bug (#10114)
* fix: dashboard filter scope bug

* add extra comments per review
2020-06-22 10:18:04 -07:00
Grace Guo
221f38099b
[logging] add selected tab name into perf logging (#10080) 2020-06-22 10:14:29 -07:00
Erik Ritter
cb1705fdae
chore: type src/addSlice (#10127) 2020-06-22 08:14:27 -07:00
Erik Ritter
231c2b395d
chore: fix add datasource help string (#10129) 2020-06-22 07:51:50 -07:00
Maxime Beauchemin
cf0f1d568d
style: replace broken glyphs with font-awesome (#10123)
Glyphicons stopped working recently, not sure why, but let's get rid of
them and double down on font-awesome that we use a lot more in the
codebase. There's only a few instances of glyphicons and they all are
broken ATM.

Also a few other minor style tweaks
2020-06-21 21:38:08 -07:00
Grace Guo
69100536de
fix: dashboard should not add extra_filters onto chart annotation (#10115) 2020-06-20 18:08:45 -07:00
Will Barrett
961b55cfba
fix: Visualization settings were lost when editing a datasource from Explore (#10092) 2020-06-19 12:55:49 -07:00
Erik Ritter
2e76fbb7e5
chore: type FilterableTable (#10073) 2020-06-18 21:57:11 -07:00
Maxime Beauchemin
a6390afb89
style: push bootstrap theme towards SIP-34 styles (#10056)
* feat: cartel theme

* piling

* more tweaks

* Make things look better

* lint

* fix tests

* paint it black

* tweaks
2020-06-18 15:01:58 -07:00
Phillip Kelley-Dotson
02fee35314
chore(metricoption): remove metricoption and columntypelable dependency (#10077)
* remove columntypeLabel and metricoptions from superset

* fix lint

* remove old test

* update pakage

* add suggestions

* fix merge conflict
2020-06-17 19:55:17 -07:00
Will Barrett
817b7aaf29
style: Change logo color to new branding (#10090)
* Change logo color to new branding

* Add back Apache licenses

* Fix SVG format

* Fix one more license

* Bigger pngs
2020-06-17 19:47:02 -07:00
ʈᵃᵢ
c914af0bc4
fix: adds pagination/infinite scroll to owners select in DashboardList and ChartList (#10035) 2020-06-17 16:27:21 -07:00
Erik Ritter
987cb6e1fe
chore: type src/dashboard/util/charts (#10068) 2020-06-17 12:34:04 -07:00
Jesse Yang
5d4d50a609
fix(sqllab): table refresh API endpoint (#10076) 2020-06-17 12:24:10 -07:00
ʈᵃᵢ
8c012f7941
feat: add more columns and icons to dataset listview (#10043) 2020-06-16 17:30:10 -07:00
Evan Rusackas
00e6d7d706
chore: bumping superset-ui theme version (#10059) 2020-06-16 16:33:14 -07:00
Ville Brofeldt
d3a9ce5afc
fix: chart export fails when buildQuery not present (#10062) 2020-06-16 09:25:10 -07:00
Maxime Beauchemin
280ade826c
fix: dashboard export raises schema issues (#10060)
* fix: dashboard export raises schema issues

* Fix isort
2020-06-15 21:43:05 -07:00
Lily Kuang
98ab95e4c0
feat: owners profile icon on dataset list view (#10041) 2020-06-15 09:52:09 -07:00
Ville Brofeldt
ee77707532
feat: add deafult buildQuery for V1 chart data requests (#10048) 2020-06-12 07:49:13 -07:00
Grace Guo
0724eddb7c
other: [logging] add dashboard is_published into perf logging (#10042) 2020-06-11 18:57:52 -07:00
Natalie Ruhe
d1588c7658
Fix chart annotation source type showing perpetual loading when re-selecting the same value. (#10036)
Remove accidental console.log used during testing.

Co-authored-by: Natalie Ruhe <natalie@preset.io>
2020-06-10 16:17:56 -07:00
Lily Kuang
5339d31ed1
feat: implement secondary navigation for datasets (#9982) 2020-06-10 11:55:51 -07:00
Ville Brofeldt
56397d75cc
fix: raise error in sqllab when using reserved column name (#9859) 2020-06-10 16:32:43 +03:00
Ville Brofeldt
a8db78b069
chore: bump superset-ui to 0.13.27 (#10018)
* chore: bump superset-ui

* Remove redundant control panels
2020-06-10 10:13:00 +03:00
Grace Guo
656cdfb867
fix: [logging] fix render chart error type (#10000) 2020-06-05 14:44:52 -07:00
Ville Brofeldt
5c4d4f16b3
feat: finalize Word Cloud move to new chart data endpoint (#9975)
* remove word cloud from viz.py

* Fix Run in SQL Lab

* remove deprecated python tests

* break out legacy endpoint type into function

* Break out exploreChart from exportChart and implement results type

* Fix jest tests and refactor accordingly

* lint

* Rename v1 payload function

* Add dashboard id to v1 chart data request url params

* Add support for domain sharding to v1 chart data request
2020-06-05 14:08:46 +03:00
ʈᵃᵢ
619fbc9557
fix: remove -1,-1 from owners request in charts, dashboards list and propertiesModal (#9989) 2020-06-04 15:31:42 -07:00
ʈᵃᵢ
d187d2887e
fix: fetch all owners for dashboard, chart listview filters and properties modal (#9784) 2020-06-03 19:57:03 -07:00
Grace Guo
dcac860f3e
feat: [dashboard] notification and warning for auto force refresh (#9886)
* feat: [dashboard] notification and warning for auto force refresh

* fix review comments
2020-06-03 10:20:56 -07:00
Michael Joseph Rosenthal
3fd6e0630e
fix #8302, disabling save button when can_add: false, can_overwrite: false (#9456) 2020-06-02 23:20:52 -07:00
Ville Brofeldt
fc92692f49
feat: implement new version of word cloud (#9962) 2020-06-02 19:28:58 +03:00
Ville Brofeldt
38a6bd79da
feat: expand new chart data endpoint coverage (#9903)
* feat: implement new chart API for additional components

* Fix python tests

* Fix tests

* Fix lint

* fix camel case error in requestParams

* lint

* fix samples row limit

* Add samples row limit to config

* remove unnecessary code

* lint

* Address review comments
2020-06-02 10:47:28 +03:00
Grace Guo
5324e25328
[filter_box] disable instant_filtering by defult (#9952) 2020-05-31 22:12:04 -07:00
Jesse Yang
4fe6f4f38e
fix: FilterBox Select should be Creatable (#9940)
* bugfix: FilterBox Select should be Creatable

* Fix Cypress test
2020-05-28 14:51:51 -07:00
Jesse Yang
359ea8825d
fix(react-select): FilterBox focus event and adhoc filter popup height (#9933)
* fix(react-select): FilterBox focus event and adhoc filter popup height

* Fix flacky cypress test

* Use focus instead of click
2020-05-27 15:15:32 -07:00
Ville Brofeldt
1b72907b18
Revert "feat: bump superset-ui and implement queryFields in formData (#9908)" (#9931)
This reverts commit 2c97e72959.
2020-05-27 22:50:14 +03:00
Ville Brofeldt
5ff61048c6
feat: bump sinon to latest (#9926) 2020-05-27 19:34:40 +03:00
Maxime Beauchemin
92b843e2ae
css: beautify roles CRUD (#9890) 2020-05-26 22:32:13 -07:00
Erik Ritter
848ac91bb6
fix: bump nvd3 plugin for annotation styles (#9919) 2020-05-26 16:59:30 -07:00
Phillip Kelley-Dotson
e0c3da5df1
feat: paired t testchart control migration (#9916)
* cherry pick

* update package
2020-05-26 14:11:03 -07:00
Phillip Kelley-Dotson
1fffa37e85
feat: remove para controls (#9851)
* remove para controls

* update package version
2020-05-26 12:37:33 -07:00
Ville Brofeldt
2c97e72959
feat: bump superset-ui and implement queryFields in formData (#9908)
* feat: Bump superset-ui packages for queryFields

* feat: Implement queryField in formData
2020-05-26 10:19:33 -07:00
Grace Guo
e6a55d8858
fix: [dashboard] should not trigger chart refresh when filter not applicable (#9891)
* fix: [dashboard][filter] should not trigger chart refresh when filter is not applicable

* fix comments
2020-05-26 10:14:12 -07:00
Erik Ritter
9edfc8f68d
chore(ts): convert base js files to typescript (#9826) 2020-05-24 19:50:08 -07:00
Jesse Yang
6d4e23663e
fix: reenable table chart page length (#9884)
Bump @superset-ui/legacy-preset-chart-table to fix disabled
page length support.

See https://github.com/apache-superset/superset-ui/pull/522
2020-05-22 10:35:45 -07:00
Phillip Kelley-Dotson
333dc8529e
feat: tablechart plugin controls migration (#9847)
* delete controls

* move columnoption to controls

* update package and remove columnoption

* fix: remove console and fix import

* fix: lint

* update version

* fix last rebase

* fix: lint:
2020-05-21 12:15:02 -07:00
Christian Murphy
a262ea7487
refactor(frontend): move utils to TypeScript (#9820)
* refactor(frontend): move utils to typescript (#9101)

* refactor(frontend): don't export interfaces

* test(frontend): update types and test for isValidChild
2020-05-20 14:47:40 -07:00
Evan Rusackas
428ad70aac
feat: Adding Emotion ThemeProviders for all React apps (#9853)
* bumping style package (now with typography styles!)

* ThemeProvider ALL the things!

* package lock

* linting

* no need to parseInt here anymore, the values are numeric now.
2020-05-20 12:43:02 -07:00
David Aaron Suddjian
f076485fd7
upgrade plugins, remove unnecessary code (#9848) 2020-05-20 12:41:12 -07:00
Ville Brofeldt
a43a1d6303
feat: Add new result formats and types to chart data API (#9841)
* feat: Add new result formats and types to chart data API

* lint

* Linting

* Add language to query payload

* Fix tests

* simplify tests
2020-05-20 21:36:14 +03:00
Phillip Kelley-Dotson
1a775e2612
feat: markupchart plugin controls migration (#9806)
* remove shims and controls

* update chart version

Co-authored-by: Phillip Kelley-Dotson <pkd@pkd.lan>
2020-05-19 23:04:20 -07:00
Jesse Yang
81ab8dd8b4
feat: upgrade react-select and make multi-select sortable (#9628)
* feat: upgrade react-select v1.3.0 to v3.1.0

Upgrade `react-select`, replace `react-virtualized-select` with a custom
solution implemented with `react-window`.

Future plans include deprecate `react-virtualized` used in other places, too.

Migrate all react-select related components to `src/Components/Select`.

* Fix new list view

* Fix tests

* Address PR comments

* Fix a flacky Cypress test

* Adjust styles for Select in CRUD ListView

* Fix loadOptions for owners select in chart PropertiesModal

TODO: add typing support for AsyncSelect props.

* Address PR comments; allow isMulti in SelectControl, too

* Clean up NaN in table filter values

* Fix flacky test
2020-05-19 16:59:49 -07:00
Grace Guo
5ca6ed716f
[explore view] inline edit slice name should not overwrite (#9817) 2020-05-18 22:53:29 -07:00
Grace Guo
d96bb874f2
fix: [filter_box] fix 2 issues in single value filter_box (#9829)
* fix: [filter_box] fix 2 issues in single value filter_box

* add unit test

* add fix per comments
2020-05-18 21:25:10 -07:00
Phillip Kelley-Dotson
38c57f45ac
feat: partitionchart controls migration (#9768)
* fix lint error

* fix: import lint error

* pull in latests code

* delete control from plugin registry

* fixing again...

* another fix with rebase...

* commit change

* update packages and fix test

* fix: add ignore to lint error

* fix mr

* fix lint

* fix imports

Co-authored-by: Phillip Kelley-Dotson <pkd@pkd.lan>
2020-05-18 12:48:51 -07:00
Jesse Yang
c4016e3b71
feat: bump superset-ui/time-format and big-number (#9808)
* feat: bump superset-ui/time-format and big-number

This is for adding full dates to big number datetime formatted
by weekly interval.

* Bump time-format to v0.13.15

to bring in https://github.com/apache-superset/superset-ui/pull/493
2020-05-18 12:42:27 -07:00
Erik Ritter
b36738cf56
fix: use snake_case for error_type (#9835) 2020-05-18 12:35:55 -07:00
Ville Brofeldt
7a95c52d61
refactor: simplify getExploreUrl functions (#9831)
* remove payload from return signature

* Rename function and fix tests

* Lint

* fix tests

* Move useLegacyApi inquiry to exploreUtils
2020-05-18 19:19:05 +03:00
Christian Murphy
b8eaa114ed
feat(frontend): add ability to download dashboard and chart as image (#9819)
* feat(frontend): add ability to export dashboard and chart as image (#6973)

* refactor: migrate download image as to typescript

* feature(frontend): download as image updates

add toast message if error occurs.
make generate file stem an internal method.

* refactor(frontend): move default background color to a const

* feat(frontend): wrap download image toast in translate function
2020-05-17 14:50:27 -07:00
David Aaron Suddjian
34df11a61c
upgrade migrated plugins, remove controlPanel configs (#9774)
* remove migrated plugins

* remove chord stuff

* upgrade plugin packages

* update package lock
2020-05-14 17:06:49 -07:00
Ville Brofeldt
ed1d030667
fix: invalid JSON in FR and DE translations (#9803)
* fix: invalid JSON in FR translation

* fix: broken or misformatted translations and add unit test for JSON validty

* Move translation lint test to CI task
2020-05-14 15:26:12 -07:00
Erik Ritter
d02f2d1fa7
feat: return security errors in the SIP-40 format (#9796) 2020-05-13 17:10:37 -07:00
Krist Wongsuphasawat
45c8fcfd92
fix: add flag for time series table (#9798) 2020-05-13 13:27:43 -07:00
Erik Ritter
83ec7365a7
feat: convert backend chart errors to the new error type (#9753) 2020-05-12 18:15:53 -07:00
Jesse Yang
0e7888c659
build: disable webpack progress for CI (#9791) 2020-05-12 16:09:18 -07:00
Ville Brofeldt
f369ab35d6
chore: move bullet string manipulation to frontend (#9773) 2020-05-11 11:49:27 -07:00
Phillip Kelley-Dotson
b6df5da195
fix bug where error at import dashboard fails to show toast in "welcome" app (#9714)
* fix bug where error at import dashboard fails

* fix: make reusable component for messages and bring to app level

* fix: add liscence

* fix: lint errors and tests

* fix

* fix: lint

* fix: lint error

* add suggestions

* add suggestions

Co-authored-by: Phillip Kelley-Dotson <pkd@pkd.lan>
2020-05-08 10:50:55 -07:00
David Aaron Suddjian
3a213916c4
use the builtin calendar control panel (#9771) 2020-05-07 21:15:03 -07:00
David Aaron Suddjian
8a49c69f38
use word cloud's built in control panel (#9770) 2020-05-07 18:28:48 -07:00
Jesse Yang
13c5b133a9
test(frontend): use absolute path for src imports (#9761)
* test(frontend): use absolute path for src imports

* Upgrade prettier, fix eslint
2020-05-07 14:18:10 -07:00
Ville Brofeldt
5b430ead42
fix: implement force refresh in chart data request (#9762)
* fix: implement force refresh in chart data request

* unrelated lint
2020-05-07 09:33:41 -07:00
David Aaron Suddjian
80f8349018
Query the new chart data api for charts that support it (#9710)
* calling new chart api (mostly working)

* can't .then when the promise has already been await-ed

* Add handling for v1 API response

* comment

* update word cloud plugin & dependencies

* testing

* try just waiting

* Revert "try just waiting"

This reverts commit 10c092effd.

* tweaking bootstrap types

* Bumping word cloud package version

* new package lock

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-05-07 01:09:28 -07:00
Evan Rusackas
b93bf05bbd
fix: removing controls from incubator-superset that are now in the plugin (#9758) 2020-05-06 17:29:49 -07:00
Krist Wongsuphasawat
52de32b9d7
build: bump superset-ui to 0.13 (#9757)
* chore: bump superset-ui

* build: bump superset-ui to 0.13

* docs: remove comment
2020-05-06 15:44:18 -07:00
Grace Guo
83b4165e61
[perf logging] Add extra logging for new/editMode dash (#9745)
* [perf logging] Add extra logging for new/editMode dash

* fix review comments
2020-05-06 09:03:04 -07:00
Maxime Beauchemin
9aabafe9fe
fix: adhoc filter 'equals' doesn't let you save (#9652)
When altering a filter, when using `equals` or `does not equals`,
the save button is disabled even when it should be enalbed.
2020-05-06 08:38:10 -07:00
Bogdan
292704fec9
Use monospace (#9709)
Update superset-frontend/src/SqlLab/main.less

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-05-06 08:37:16 -07:00
Ville Brofeldt
5485eb993c
feat: Add controlGroups to formData (#9740) 2020-05-06 14:53:13 +03:00
Maxime Beauchemin
67d8b634b8
fix: autocomplete search in AdhocFilter operator dropdown (#9654)
Searching for 'equ' in AdhocFilter's operator dropdown doesn't find the
options who's label contain that substring.

I'd write a unit test but it's pretty tricky.
2020-05-05 21:43:33 -07:00
Erik Ritter
821e7e53a9
chore: update README screenshots (#9728) 2020-05-05 13:02:10 -07:00
Grace Guo
0b963bdbb6
[perf logging] Add timing event when browser tab is hidden (#9733)
* [perf logging] Add timing event when browser tab is hidden

* fix review comment
2020-05-05 10:17:22 -07:00