pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix #8302, disabling save button when can_add: false, can_overwrite: false (#9456)

This commit is contained in:
Michael Joseph Rosenthal 2020-06-03 01:20:52 -05:00 committed by GitHub
parent 1d9dbcd9dc
commit 3fd6e0630e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/src/explore/components/ExploreViewContainer.jsx
View File

@ -349,7 +349,7 @@ class ExploreViewContainer extends React.Component {
}}
>
<QueryAndSaveBtns
canAdd="True"
canAdd={!!(this.props.can_add || this.props.can_overwrite)}
onQuery={this.onQuery}
onSave={this.toggleModal}
onStop={this.onStop}
@ -396,6 +396,7 @@ function mapStateToProps(state) {
datasourceId: explore.datasource_id,
controls: explore.controls,
can_overwrite: !!explore.can_overwrite,
can_add: !!explore.can_add,
can_download: !!explore.can_download,
column_formats: explore.datasource
? explore.datasource.column_formats

4
superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
View File

@ -24,7 +24,7 @@ import classnames from 'classnames';
import Button from '../../components/Button';
const propTypes = {
canAdd: PropTypes.string.isRequired,
canAdd: PropTypes.bool.isRequired,
onQuery: PropTypes.func.isRequired,
onSave: PropTypes.func,
onStop: PropTypes.func,
@ -49,7 +49,7 @@ export default function QueryAndSaveBtns({
errorMessage,
}) {
const saveClasses = classnames({
'disabled disabledButton': canAdd !== 'True',
'disabled disabledButton': !canAdd,
});
let qryButtonStyle = 'default';