From 3fd6e0630e8bfd95fd942bdf6f8db8449f5389b7 Mon Sep 17 00:00:00 2001
From: Michael Joseph Rosenthal <rosenthalm93@gmail.com>
Date: Wed, 3 Jun 2020 01:20:52 -0500
Subject: [PATCH] fix #8302, disabling save button when can_add: false,
 can_overwrite: false (#9456)

---
 .../src/explore/components/ExploreViewContainer.jsx           | 3 ++-
 superset-frontend/src/explore/components/QueryAndSaveBtns.jsx | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/explore/components/ExploreViewContainer.jsx b/superset-frontend/src/explore/components/ExploreViewContainer.jsx
index b7078d8982..d5c7e4536d 100644
--- a/superset-frontend/src/explore/components/ExploreViewContainer.jsx
+++ b/superset-frontend/src/explore/components/ExploreViewContainer.jsx
@@ -349,7 +349,7 @@ class ExploreViewContainer extends React.Component {
               }}
             >
               <QueryAndSaveBtns
-                canAdd="True"
+                canAdd={!!(this.props.can_add || this.props.can_overwrite)}
                 onQuery={this.onQuery}
                 onSave={this.toggleModal}
                 onStop={this.onStop}
@@ -396,6 +396,7 @@ function mapStateToProps(state) {
     datasourceId: explore.datasource_id,
     controls: explore.controls,
     can_overwrite: !!explore.can_overwrite,
+    can_add: !!explore.can_add,
     can_download: !!explore.can_download,
     column_formats: explore.datasource
       ? explore.datasource.column_formats
diff --git a/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx b/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
index 5ea1d65084..bb86b6c679 100644
--- a/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
+++ b/superset-frontend/src/explore/components/QueryAndSaveBtns.jsx
@@ -24,7 +24,7 @@ import classnames from 'classnames';
 import Button from '../../components/Button';
 
 const propTypes = {
-  canAdd: PropTypes.string.isRequired,
+  canAdd: PropTypes.bool.isRequired,
   onQuery: PropTypes.func.isRequired,
   onSave: PropTypes.func,
   onStop: PropTypes.func,
@@ -49,7 +49,7 @@ export default function QueryAndSaveBtns({
   errorMessage,
 }) {
   const saveClasses = classnames({
-    'disabled disabledButton': canAdd !== 'True',
+    'disabled disabledButton': !canAdd,
   });
 
   let qryButtonStyle = 'default';