[filter_box] disable instant_filtering by defult (#9952)

This commit is contained in:
Grace Guo 2020-05-31 22:12:04 -07:00 committed by GitHub
parent 4fe6f4f38e
commit 5324e25328
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 5 deletions

View File

@ -85,6 +85,9 @@ export default () =>
.focus({ force: true })
.type('uth Asia{enter}', { force: true });
// by default, need to click Apply button to apply filter
cy.get('.filter_box button').click({ force: true });
// wait again after applied filters
cy.wait(aliases.filter(x => x !== getAlias(filterId))).then(requests => {
requests.forEach(xhr => {

View File

@ -55,10 +55,10 @@ export default {
type: 'CheckboxControl',
label: t('Instant Filtering'),
renderTrigger: true,
default: true,
description:
'Whether to apply filters as they change, or wait for ' +
'users to hit an [Apply] button',
default: false,
description: t(
'Check to apply filters instantly as they change instead of displaying [Apply] button',
),
},
},
],

View File

@ -89,7 +89,7 @@ const defaultProps = {
showSqlaTimeColumn: false,
showDruidTimeGrain: false,
showDruidTimeOrigin: false,
instantFiltering: true,
instantFiltering: false,
};
class FilterBox extends React.Component {