John Bodley
a8eb3fe8e7
chore: Cleaning up ENABLE_REACT_CRUD_VIEWS config ( #11496 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-10-29 16:47:11 -07:00
Jesse Yang
93693690a3
feat: disable save button when saving datasource ( #11493 )
2020-10-29 16:13:47 -07:00
David Aaron Suddjian
074f8c2e8c
other: Improvements to bug report template ( #11307 )
...
* Update bug_report.md
* more detail!
* Update bug_report.md
2020-10-29 15:44:03 -07:00
Grace Guo
b1263ad568
Revert "fix: change chart title by clicking ( #11335 )" ( #11497 )
...
This reverts commit 1f04db79f7
.
2020-10-29 15:13:29 -07:00
Beto Dealmeida
1d9d905497
fix: prevent race condition when canceling query ( #11449 )
2020-10-29 14:34:58 -07:00
ʈᵃᵢ
f918ca14aa
fix(datasets): add custom filter for virtual datasets based on sql attribute ( #11452 )
2020-10-29 13:11:33 -07:00
Kasia Kucharczyk
ed3dca420f
Added z index to resizible char ( #11456 )
2020-10-29 10:39:35 -07:00
Jesse Yang
e0503408de
feat(explore): change save button text when users cannot override ( #11281 )
2020-10-29 09:41:29 -07:00
Evan Rusackas
68d493ebf5
fix: dashboard tab only shows move cursor when editing ( #11480 )
2020-10-29 00:35:32 -07:00
Tony Klin
62629eceab
Add IBM Cloud deployment guide ( #11473 )
2020-10-28 22:01:39 -07:00
Evan Rusackas
e024267447
fix: Unwinds icon fallout that came along with filters PR ( #11474 )
...
* Unwinds icon revamp that came along with filters PR.
* cleanup/linting
* removing unused import
2020-10-28 19:44:39 -07:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators ( #10936 )
...
* Initial commit of new filters badge.
* refactor applied/rejected filters code
* finished filter indicators
* filter badge tested
* unnecessary imports
* formatting and types
* fixes
* license
* code quality tweaks
* state management for showing focused filter scope
* clean up filter key extraction code
* remove unnecessary styles
* temp css to demonstrate highlighting
* fix focused filter logic
* no more color badges
* new toys for highlighting dash components (#11144 )
* tweak style for the filter chart when filter is focused
* style: Filters p0 css2 (#11151 )
* nixing background tweak
* src paths
* another quick theme color
* src paths, adjusting pill icon color, changing icons, showing applied/busted counts
* linting stuff
* fixing and tweaking tests
* show filter indicator when filters are not active
* chart title bar cleanup
* open the right panel when popover opens
* unused import
* fix EditableTitle tests
* margin on dashboard header
* show the chart dropdown menu
* fix blur filter breaking dropdowns
* style tweak - no pointer events when irrelevant charts are blurred
* fix box shadow on filter highlight
* it's an array
* attempt fixing e2e
* style: filters p0 icon churn (#11215 )
* new filters icon
* icon styling
* bigger icons in list views
* better sizing of table actions and favStars
* more icon sizing...
* fixing more button size jankiness
* linting
* Filters performance (#11255 )
* fixing time filter "ok" button
* making unset filter menu collapsible
* sort alphabetically
* fix highlighting when removing items
* try a flex layout (for browser render perf)
* more specific transitioning
* temp: comment out some code as a test
* temp: comment out more code
* temp: remove possibly expensive computations from ChartHolder
* Revert "temp: comment out some code as a test"
This reverts commit 309b880e90
.
* Revert "temp: comment out more code"
This reverts commit 64c88b2cba
.
* Revert "temp: remove possibly expensive computations from ChartHolder"
This reverts commit 37ce0214f0
.
* experiment: upgrade react-select to v3
* Revert "experiment: upgrade react-select to v3"
This reverts commit c3972ba486
.
* fix the damn problem
* remove code used for testing purposes
* awful hack to avoid adding a class to a container
* approaching infinity... and not beyond!
* fix ref forwarding
* add theme to tests as necessary
* fix(extra-filters): add logic for identifying applied extra filters (#11325 )
* fix: use dashboard id for stable cache key (#11293 )
* fix: button translations missing (#11187 )
* button translations missing
* blank space before text
* feat: update time_compare description and choices (#11294 )
* feat: update time_compare description and choices
* Update sections.jsx
* fix(extra-filters): add logic for identifying applied extra filters
* lint
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* address design feedback
* slight tweak to panel logic, keep panels open that user has opened
* rearrange code to be more graceful
* fix: bump superset-ui/core (#11385 )
* use is_dttm instead of is_temporal
* types, names
* only show unset filter panel if there are unset filters
* fix highlighting the filter control
* fix filterbox layout
* translations
* fix cypress
* actually add the test attribute
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* formatting
* add link comment to hack
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* stop importing lodash
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* skip broken test
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* adjust colors of titles
* linting
* no indicators when chart is loading
* support all time fields
* fix lock file
Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2020-10-28 15:46:24 -07:00
Moriah Kreeger
e9dba18466
feat: annotation layers CRUD list view ( #11432 )
2020-10-28 15:45:07 -07:00
Kamil Gabryjelski
52294c836a
refactor: Replace react-bootstrap Modals with Antd in Datasource ( #11390 )
...
* ChangeDatasourceModal
* DatasourceModal
* DeleteModal, AddDatasetModal
* Fix tests
* Remove unused file
* Fix e2e tests
* Fix test
* Remove it.only
* Fix after rebase
* Fix e2e tests
* Fix data-test in modal
* Lint fix
2020-10-28 14:42:13 -07:00
Ville Brofeldt
e230865216
chore(chart-data): add annotations and url params to chart data schema ( #11393 )
...
* chore(chart-data): add annotations to chart data schema
* bump superset-ui packages
* xit flaky cypress tests
2020-10-28 23:41:39 +02:00
Lily Kuang
e5e35634de
feat: annotations list CRUD view ( #11446 )
...
* annotations list CRUD view
* comment out modal
* update test
* fix lint
2020-10-28 12:19:50 -07:00
Kasia Kucharczyk
d4d547c30a
Disabled chaning caret ( #11459 )
2020-10-28 11:22:26 -07:00
Daniel Vaz Gaspar
81a0526072
docs: improve docs and update apache release scripts ( #11457 )
2020-10-28 18:17:33 +00:00
adam-stasiak-polidea
894b94a345
enabled skipped tests in AdhocMetrics Cypress ( #11455 )
2020-10-28 10:06:16 -07:00
Kamil Gabryjelski
b2636f01bb
fix: Explore popovers issues ( #11428 )
...
* Fix spaces and comas not working in filter popover
* Fix popup not opening automatically
* Add e2e test
* Remove only from test
* Remove redundant test, add checking label content
* Add comments to e2e test
* Fix unit test
* Use destructuring
* Always open popup for functions and saved metrics, too
* Fix popover for adhoc metrics too
* Small refactor to consistency
* Refactor for consistency
* Remove redundant functions
* Test fix
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-10-28 09:38:52 -07:00
Bogdan
88e5e9855d
fix: add init.py to the annotations module ( #11437 )
...
* Add init.py to the annotations module
* Update superset/annotation_layers/annotations/api.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Pylint
* License
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-10-28 07:36:28 -07:00
Evan Rusackas
eecabf9b2e
fix: a space adds the space. ( #11401 )
...
* fix: a space adds the space.
* linting. Ugh.
2020-10-27 23:47:42 -07:00
Evan Rusackas
68411677e9
fix: Fixing broken Cypress test ( #11453 )
...
* fixing bad data-test selector
* linting
* typo... because I got all excited.
2020-10-27 22:51:38 -07:00
Kamil Gabryjelski
155b5edec1
refactor: Use Antd Modals instead of react-bootstrap Modals ( #11366 )
...
* Make Modal responsive
* ErrorAlert
* OmniContainer
* dashboard/PropertiesModal
* Fix e2e tests
* Lint fix
* E2E test fix
* Fix test
* Use grid units
* Change padding to padding-left/right
2020-10-27 13:08:04 -07:00
adam-stasiak-polidea
a99d795eaf
chore: cypress selectors refactor in explore module ( #11309 )
...
* cypress selectors refactor in explore module
* added delay to typing to make test more stable
* fixed missing click
2020-10-27 13:01:45 -07:00
adam-stasiak-polidea
4bebf51453
chore: Cypress chart selectors refactor ( #11312 )
...
* cypress selectors refactor in chart list tests
* fixed wrong selector
2020-10-27 11:38:05 -07:00
Grace Guo
014fe9fd8c
fix: [email report] add multiple schedules per hour ( #11414 )
2020-10-27 09:37:42 -07:00
Beto Dealmeida
98daf0a435
feat: add UUID column to saved_query for export/import ( #11397 )
...
* Add UUID to saved_query
* Reuse function from previous migration
* Point to new head
2020-10-27 08:49:09 -07:00
David Aaron Suddjian
055781f4a9
fix filter highlighting ( #11439 )
2020-10-27 08:38:24 -07:00
Daniel Vaz Gaspar
427058b4dc
fix: bump FAB to 3.1.1 ( #11444 )
2020-10-27 14:54:29 +00:00
Kasia Kucharczyk
b49fd65cf7
fix: added meaningful exception for loading births error ( #11407 )
...
* Added exception for loading data without previous loaded test users.
* Changed general exception to NoDataException
* Changed import to absolute path
2020-10-27 06:28:52 -07:00
John Bodley
8ee6493233
chore: Update testconn logic ( #11315 )
...
* chore: Update testconn logic
* [databases] Address @dpgaspar's comments
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-10-27 09:15:05 +00:00
Ville Brofeldt
ecdff724ea
feat: enable metadata sync for virtual tables ( #10645 )
...
* feat: enable metadata sync for virtual tables
* add migration and check for empty schema name
* simplify request
* truncate trailing column attributes for MySQL
* add unit test
* use db_engine_spec func to truncate collation and charset
* Remove redundant migration
* add more tests
* address review comments and apply templating to query
* add todo for refactoring
* remove schema from tests
* check column datatype
2020-10-27 07:58:38 +02:00
Ville Brofeldt
8575439f48
fix: is_temporal should be overridden by is_dttm value ( #11429 )
2020-10-27 07:22:27 +02:00
Kasia Kucharczyk
94e0f0cc2a
Moved css of inline inputs of DateFilterControl to css of FilterBox where it appears. ( #11427 )
2020-10-26 21:50:27 -07:00
Maxime Beauchemin
5b968e9651
fix: multiple issues with FilterPopover ( #11412 )
...
* fix: Custom SQL in FilterPopover
* Also fix #11394
* linting
* fix tests
2020-10-26 21:48:06 -07:00
adam-stasiak-polidea
df15a6fc51
Configured babel plugin for removing data-test from production code ( #11327 )
2020-10-26 21:16:02 -07:00
Hugh A. Miles II
fd8f4e9215
feat(explore): update the order of datasource dropdown menu ( #11424 )
2020-10-26 20:44:44 -07:00
Hugh A. Miles II
81f77fd28e
feat: hide datasource legacy based on featureflag ( #11371 )
2020-10-26 17:31:29 -07:00
ʈᵃᵢ
2227b13b52
fix: better error messages for dashboard properties modal ( #11382 )
2020-10-26 16:36:37 -07:00
ʈᵃᵢ
59885c4dea
fix: saved query list sort by database ( #11430 )
2020-10-26 16:36:03 -07:00
ʈᵃᵢ
8a2ca84775
build: disable pr reviews for pr-lint action ( #11433 )
2020-10-26 16:32:54 -07:00
ʈᵃᵢ
910791b00b
fix: better error message for chart properties modal ( #11381 )
2020-10-26 13:33:19 -07:00
Evan Rusackas
af337b9e5a
Let the header wrap! ( #10724 )
2020-10-26 13:15:16 -07:00
Kamil Gabryjelski
894ca3c09b
refactor: Use Modals from Antd instead of react-bootstrap ( #11330 )
...
* Refactor ModalTrigger to use antd modal
* Refactor a few components
* dynamic width
* Fix unit tests
* Use i18n for button text
2020-10-26 11:20:10 -07:00
Daniel Vaz Gaspar
144b279aa2
feat: saved queries with execution info ( #11391 )
...
* feat: add rows and last_run info to saved queries
* feat: add rows to saved query
* refactor and tests
* lint
* fix tests
2020-10-26 11:20:07 -07:00
Kasia Kucharczyk
604a519d8b
fix: keeping Markdown content while resizing window on Dashboard ( #11392 )
...
* Fix: keeping markup content while resizing it
* Added bind and fixed linter
* Added resize case in Markdown editor to cypress test
2020-10-26 11:12:49 -07:00
Kasia Kucharczyk
ba314c0f6f
Moved frame from below to currently focused window ( #11423 )
...
Thanks for the fix!
2020-10-26 11:11:51 -07:00
Kamil Gabryjelski
6acae9ab6d
refactor: Replace usages of reactable in TimeTable ( #11239 )
...
* Refactor TimeTable to use react-table
* Fix import
* Refactor TimeTable into functional component
2020-10-26 10:25:41 -07:00
Maxime Beauchemin
10a54b52ac
fix(examples): specify 'time_range_endpoints' to prevent toast warning ( #11417 )
2020-10-26 08:42:57 -07:00