Commit Graph

1907 Commits

Author SHA1 Message Date
Beto Dealmeida
7a1aa6387c
feat(bigquery): get_catalog_names (#23461) 2023-04-05 13:32:28 -07:00
John Bodley
e8cfb31bff
fix: Ensure the reporting framework handles charts with no data (#23585) 2023-04-06 07:30:27 +12:00
John Bodley
b58d17f4b8
fix(revert): "fix: cache warmup solution non legacy charts. (#23012)" (#23579) 2023-04-06 06:16:34 +12:00
Hugh A. Miles II
a4d4084d08
fix: tags features flag on base models (#23548) 2023-04-04 10:32:24 -04:00
Diego Medina
cdc7af11bf
chore: Migrate /superset/user_slices and /superset/fave_slices to API v1 (#22964)
Co-authored-by: hughhhh <hughmil3s@gmail.com>
2023-04-03 13:29:02 -04:00
Ville Brofeldt
500d90058f
feat: add ability to disable cache (#23439) 2023-03-31 11:41:57 +03:00
Ville Brofeldt
330e79bc5d
ci: disable flaky async test (#23527) 2023-03-31 07:59:49 +03:00
Hugh A. Miles II
81b32d1045
chore: allow logs to show error levels for ssh tunnel (#23536) 2023-03-30 18:23:22 -04:00
Diego Medina
f2be53dd53
chore: Migrate /superset/favstar to API v1 (#23165)
Co-authored-by: hughhhh <hughmil3s@gmail.com>
2023-03-29 16:42:23 -04:00
Rémy DUBOIS
07a632891c
fix(chart): non existent time grain no longer breaks the application (#23441)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2023-03-23 16:36:50 +02:00
Beto Dealmeida
8588f81855
feat(DB engine spec): get_catalog_names (#23447) 2023-03-22 13:40:14 -07:00
Elizabeth Thompson
b021f6e05d
feat: add new cache_query_by_user key (#23415)
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2023-03-20 12:17:20 -07:00
Beto Dealmeida
2c6f581fa6
feat(postgresql): dynamic schema (#23401) 2023-03-17 17:53:42 -07:00
Hugh A. Miles II
8fa77adf9a
chore: Hugh/migrate estimate query cost to v1 (#23226)
Co-authored-by: Diego Medina <diegomedina24@gmail.com>
2023-03-17 18:02:25 -06:00
Beto Dealmeida
42e8d1b498
chore: improve schema security (#23385) 2023-03-17 08:05:50 -07:00
Zef Lin
870bf6d0b9
fix: revert back to use security manager authz for dashboard when get by uuid (#23330) 2023-03-16 15:27:02 +00:00
Beto Dealmeida
ec6318b379
fix: permission checks on import (#23200) 2023-03-15 08:31:09 -07:00
Hugh A. Miles II
9920ab3fd9
chore: Migrate /superset/schemas_access_for_file_upload to v1 (#23227)
Co-authored-by: Diego Medina <diegomedina24@gmail.com>
2023-03-14 19:21:10 -06:00
Beto Dealmeida
1874f9a3b6
fix: dataset_macro (#23376) 2023-03-14 16:29:12 -07:00
Beto Dealmeida
1b95da7487
fix: table schema permissions (#23356) 2023-03-14 15:18:18 -07:00
Hugh A. Miles II
b820eb8235
chore: Update pre-commit packages (#23173) 2023-03-13 17:05:13 -06:00
Kamil Gabryjelski
42980a69a7
fix(dashboard): Charts crashing when cross filter on adhoc column is applied (#23238)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2023-03-04 07:57:35 +01:00
John Bodley
5f0c320415
chore: Deprecate show_native_filters (#23228) 2023-03-02 07:29:51 +13:00
Ville Brofeldt
5a099e0762
fix(dao): use explicit id filter (#23246) 2023-03-01 13:32:04 +02:00
Daniel Vaz Gaspar
b479e93b49
fix: add disallowed query params for engines specs (#23217)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2023-02-28 12:00:22 +00:00
Daniel Vaz Gaspar
79274eb5bc
fix: memoized decorator memory leak (#23139) 2023-02-27 15:59:11 +00:00
Antonio Rivero
3484e8ea7b
feat(ssh_tunnel): Import/Export Databases with SSHTunnel credentials (#23099) 2023-02-24 09:36:21 -08:00
Ville Brofeldt
d0c54cddb0
fix(clickhouse): add clickhouse connect driver (#23185) 2023-02-24 14:04:12 +02:00
Ville Brofeldt
89576f8a87
fix(rbac): show objects accessible by database access perm (#23118) 2023-02-24 10:45:16 +02:00
Beto Dealmeida
fbf10c35a9
feat: return UUID on database creation (#23143) 2023-02-21 17:36:16 -08:00
cccs-RyanK
a40c12d63e
feat: Frontend tagging (#20876)
Co-authored-by: cccs-nik <68961854+cccs-nik@users.noreply.github.com>
Co-authored-by: GITHUB_USERNAME <EMAIL>
2023-02-21 13:38:23 -08:00
Daniel Vaz Gaspar
8f8fba2056
fix: gamma sql_json test (#23135) 2023-02-21 15:34:25 +00:00
Daniel Vaz Gaspar
d4362a3676
fix: reorganize role permissions (#23096) 2023-02-21 10:19:42 +00:00
Geido
c7823e32ff
fix: Validate jinja rendered query (#22851) 2023-02-21 11:01:12 +01:00
Josh Soref
dec6ac49f6
chore(backend): Spelling (#19677)
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2023-02-17 10:48:24 -07:00
Daniel Vaz Gaspar
4b03d2553c
fix: missing __init__ on module sqllab commands (#23107) 2023-02-17 11:08:14 +00:00
Elizabeth Thompson
434b445e31
chore: increment statsd as warn (#23041) 2023-02-16 15:43:18 -08:00
Elizabeth Thompson
4ddf67fc14
chore: move dashboard screenshot standalone logic (#23003) 2023-02-15 14:35:08 -08:00
Daniel Vaz Gaspar
c39cf36d27
fix: css template permissions for gamma role (#23083) 2023-02-15 15:26:02 +00:00
Diego Medina
e5a4c78dc7
chore: Migrate /superset/csv/<client_id> to API v1 (#22913) 2023-02-15 10:48:24 +00:00
Jack Fragassi
3fae7dbc34
chore: Migrate get_or_create_table endpoint to api v1 (#22931) 2023-02-15 10:38:51 +00:00
Dheeraj Jaiswal
e755b4f417
fix: cache warmup solution non legacy charts. (#23012) 2023-02-14 23:27:32 +02:00
Cody Leff
684b8888b1
fix(dashboard): Stop updating chart owners for charts removed from dashboard (#21720)
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2023-02-09 12:50:06 -05:00
Artem Shumeiko
efe6d22d4a
fix(dashboard): export & import chart description and certification details (#22471) 2023-02-06 16:30:22 -07:00
Daniel Vaz Gaspar
7a0f350028
fix: add new config to allow for specific import data urls (#22942) 2023-02-06 08:17:08 -08:00
Josh Soref
78ede590ee
chore(frontend): Spelling (#19676)
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2023-02-02 11:23:11 -07:00
JUST.in DO IT
ad1ffbd723
fix(explore): unable to update linked charts (#22896) 2023-02-03 07:07:17 +13:00
Diego Medina
02cd75be8d
chore: Migrate /superset/tables/* to API v1 (#22501) 2023-02-01 12:45:57 +00:00
Ville Brofeldt
cd6fc35f60
chore(db_engine_specs): clean up column spec logic and add tests (#22871) 2023-01-31 15:54:07 +02:00
Daniel Draper
e18bf3f449
fix(dependency): update cryptography import (#22744)
Co-authored-by: Daniel Draper <daniel.draper@understand.ai>
2023-01-31 10:11:26 +00:00
Elizabeth Thompson
f2b61fca15
fix: edit pyarrow stringify to better handle emojis and accents (#22881) 2023-01-30 12:29:19 -08:00
Artem Shumeiko
c839d0daf5
chore: Localization of superset pt. 2 (#22772) 2023-01-30 09:20:43 -07:00
Diego Medina
b94052e438
chore: migrate /sql_json and /results to apiv1 (#22809) 2023-01-30 11:02:34 -05:00
Jack Fragassi
54f7a248a6
chore: deprecate /superset/filter/... endpoint, migrate to apiv1 (#22882) 2023-01-30 11:02:49 +00:00
Igor Șincariov
6cf434e5c1
feat: Add excel export (#22006)
Co-authored-by: Igor Șincariov <igorsinc@pm.me>
Co-authored-by: EugeneTorap <evgenykrutpro@gmail.com>
2023-01-27 11:23:10 -07:00
Diego Medina
14878a160f
chore: Migrate /superset/queries/<last_updated_ms> to API v1 (#22611) 2023-01-27 13:20:56 -05:00
Mayur
8226110be8
fix: revert RESTful apis and react view for RLS (#22818) 2023-01-26 18:04:00 -08:00
Antonio Rivero Martinez
d6a4a5da79
feat(ssh_tunnel): Add feature flag to SSH Tunnel API (#22805) 2023-01-26 16:53:36 -08:00
Geido
3fd4718ecb
fix: Convert TIMESTAMP_* to TIMESTAMP in Snowflake (#22872) 2023-01-26 19:49:44 +01:00
Evan Rusackas
6998f65e1d
chore: removing unnecessary double spaces, a.k.a. "shotgun holes" (#22852) 2023-01-26 11:48:41 -07:00
Josh Soref
02e5dcbbf2
chore(misc): Spelling (#19678)
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2023-01-25 16:35:08 -07:00
Geido
9ed2326a20
feat: Move cross filters to Dashboard (#22785) 2023-01-25 18:01:06 +01:00
Jack Fragassi
050cbe938f
chore: Migrate /superset/recent_activity/<user_id>/ to /api/v1/ (#22789) 2023-01-25 09:26:50 +00:00
Beto Dealmeida
6f0fed77cf
feat: export/import allow_dml flag (#22806) 2023-01-24 19:16:46 -08:00
John Bodley
0b31b2cb87
fix(hive): Regression in #21794 (#22794) 2023-01-21 13:00:36 +13:00
Elizabeth Thompson
d091a68909
fix: better logic to extract errors on databricks (#22792) 2023-01-20 15:35:09 -08:00
John Bodley
92cdb8c282
chore: Add explicit bidirectional performant relationships for SQLA model (#22413) 2023-01-21 10:17:56 +13:00
Antonio Rivero Martinez
ad758c0802
feat(ssh_tunnel): Rename allow_ssh_tunneling and change the default value to False (#22723) 2023-01-17 19:11:41 -08:00
Elizabeth Thompson
c58dbf8b9c
fix: pass in slack error messages properly (#22727) 2023-01-17 13:30:51 -08:00
Elizabeth Thompson
0a2fc9cdde
fix: change order of webdriver timeout checks (#22698) 2023-01-17 10:00:51 -08:00
Daniel Vaz Gaspar
edcbf597f5
chore: re add upload tests (#22753) 2023-01-17 17:33:23 +00:00
Diego Medina
3ed288d4ee
chore: Migrate /superset/stop_query/ to API v1 (#22624) 2023-01-16 14:07:52 +00:00
Elizabeth Thompson
cd1f6d469b
fix: remove whitespace from http_path for databricks (#22671) 2023-01-13 14:50:18 -08:00
Hugh A. Miles II
2de19f1d66
feat: Add logging for ssh tunneling test_connection attempts (#22625) 2023-01-12 21:49:35 +00:00
Usiel Riedl
d5ecfbb901
fix(embed): fix server error due to breaking change on flask-login (#22462)
Co-authored-by: Usiel Riedl <usiel.riedl@automattic.com>
2023-01-12 11:48:01 +02:00
Antonio Rivero Martinez
539936522f
feat(ssh_tunnel): SQLAlchemy Form UI (#22513)
Co-authored-by: hughhhh <hughmil3s@gmail.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2023-01-11 19:29:52 +00:00
Mayur
159dcd7e62
feat(RLS): RESTful apis and react view for RLS (#22325) 2023-01-09 13:34:20 -07:00
Ville Brofeldt
5b2ca97341
fix(sqllab): remove link to sqllab if missing perms (#22566) 2023-01-09 14:02:36 +02:00
EugeneTorap
30dab3a00a
chore: Bump flask libs (#22355) 2023-01-09 10:10:31 +00:00
Elizabeth Thompson
804e89d725
fix: stringify ValueErrors for NaT types (#22628) 2023-01-06 15:15:12 -08:00
Elizabeth Thompson
7591acba54
fix: change type of slack error (#22443) 2023-01-06 17:50:43 -05:00
Hugh A. Miles II
d18c7d6128
fix(ssh-tunnel): fix dataset creation flow through modal for DB with tunnel (#22581) 2023-01-06 13:52:05 -05:00
Daniel Vaz Gaspar
3761694d72
fix: dashboard get by id or slug access filter (#22358) 2023-01-05 17:10:40 +00:00
Ville Brofeldt
037deb9a1d
feat(rbac): add customizable related filters (#22526) 2023-01-05 16:42:08 +02:00
Hugh A. Miles II
ebaad10d6c
feat(ssh-tunnelling): Setup SSH Tunneling Commands for Database Connections (#21912)
Co-authored-by: Antonio Rivero Martinez <38889534+Antonio-RiveroMartnez@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2023-01-03 17:22:42 -05:00
Hugh A. Miles II
9c0d6c51f1
chore(ssh-tunnel): Refactor establishing raw connection with contextmanger (#22366) 2022-12-29 14:20:45 -05:00
Ville Brofeldt
b6d39d194c
feat(trino): support early cancellation of queries (#22498) 2022-12-24 06:31:46 +02:00
Hugh A. Miles II
9b26794419
chore: Update dataset_id & dataset_type datasource_id & datasource_type for SPA explore (#22461) 2022-12-22 19:46:00 -05:00
Stan
7d8fff87b5
fix(assets api): import replaces dashboard (#22208)
Co-authored-by: Stan Houcke <stan.houcke@skyscanner.net>
2022-12-21 15:36:40 -08:00
Ville Brofeldt
b954f8f560
feat(welcome): make examples tab customizable (#22302) 2022-12-21 09:28:41 +02:00
John Bodley
71982ee174
chore: Re-add inheritance of Presto macros for Trino et al. (#22435) 2022-12-20 08:27:20 +13:00
Beto Dealmeida
bdeedaaf80
chore: set Snowflake user agent (#22432) 2022-12-15 17:08:34 -08:00
Michiel De Smet
90d79c78d2
fix(trino): Fix Trino timestamp conversion (#21737) 2022-12-14 10:49:14 -07:00
Ville Brofeldt
aa0cae9b49
feat(thumbnails): add support for user specific thumbs (#22328) 2022-12-14 15:02:31 +02:00
Beto Dealmeida
481b020e9d
chore: show database UUID in API (#22411) 2022-12-13 15:55:27 -08:00
Rui Zhao
d1989a4766
fix(report): Capture unexpected errors in report screenshots. Fixes #21653 (#21724)
Co-authored-by: Rui Zhao <zhaorui@dropbox.com>
2022-12-13 14:31:36 -07:00
Elizabeth Thompson
c3a6327ff0
fix: correct exception level in log and add error message (#22381) 2022-12-12 10:58:58 -08:00
Antonio Rivero Martinez
60a617eaba
fix(bigquery): Properly display errors for BigQuery DBs (#22349) 2022-12-07 13:34:30 -05:00
Geido
e1ffdb95b1
chore: Add Horizontal FilterBar e2e tests (#22305) 2022-12-06 15:01:31 +02:00
Ville Brofeldt
1ad5147016
fix(sqla): use same template processor in all methods (#22280) 2022-12-03 06:19:25 +02:00
Elizabeth Thompson
1c20206057
fix: convert <NA> values to None instead of stringifying (#22321) 2022-12-02 17:15:20 -08:00
Elizabeth Thompson
5c77f1ad2a
feat: add databricks form (#21573) 2022-12-02 10:36:27 -08:00
EugeneTorap
7bc5f04368
chore: Bump bigquery libs (#21466) 2022-12-02 12:48:36 +02:00
Antonio Rivero Martinez
fb3e717573
fix(file_upload): Fix columnar and Excel upload forms (#22249) 2022-11-29 11:27:50 -05:00
Yongjie Zhao
22fab5e58c
feat: Axis sort in the Bar Chart V2 (#21993) 2022-11-26 22:06:26 +08:00
Mayur
a8bc53d805
fix(reports): force data generation in csv reports (#22196) 2022-11-26 13:30:26 +08:00
Daniel Vaz Gaspar
a77b2d6ebf
chore: remove annotation layer FAB CRUD model view (#22178) 2022-11-22 16:19:57 +00:00
Ville Brofeldt
ac0ff78616
fix: chart id mapping in dashboard api (#22179)
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
2022-11-21 18:30:08 +02:00
Antonio Rivero Martinez
6bb4d87deb
feat: CSV File Upload form updates (#21922) 2022-11-21 10:51:18 -05:00
John Bodley
7e54b88a51
chore: Change get_table_names/get_view_names return type (#22085) 2022-11-18 12:41:21 -08:00
Ville Brofeldt
c3f9f0bf69
fix(alerts): execute query as report executor (#22167) 2022-11-18 14:22:56 +02:00
EugeneTorap
394fb2f2d0
fix: slug is empty if filename is non-ASCII (#22118) 2022-11-16 10:53:30 -08:00
EugeneTorap
38a3fbdc33
feat: use a new official CH driver: clickhouse-connect (#22039) 2022-11-16 10:53:15 -08:00
John Bodley
e8a0a5ee5c
fix: Missing applied filters indicator (#22137) 2022-11-16 08:07:42 -08:00
Hugh A. Miles II
e23efefc46
feat: refactor all get_sqla_engine to use contextmanager in codebase (#21943) 2022-11-15 13:45:14 -05:00
Peng Ren
b32de3dd9e
feat: Add a new database driver for Amazon DynamoDB (#22077) 2022-11-14 20:57:04 -08:00
Elizabeth Thompson
ce145c676c
refactor: use exception status for logging (#21971) 2022-11-14 14:14:24 -08:00
Elizabeth Thompson
86d52fcbc4
chore: remove shadow write of new sip 68 dataset models (#21986) 2022-11-14 09:55:53 -08:00
Antonio Rivero Martinez
95b4c7b7fe
chore(bigquery): Add extra logging for BigQuery exceptions so we can have better insight on exceptions (#22024) 2022-11-09 22:56:08 -05:00
John Bodley
9f7bd1e63f
fix(presto/trino): Ensure get_table_names only returns real tables (#21794) 2022-11-09 14:30:49 -08:00
Daniel Vaz Gaspar
e33a08693b
fix: datasource save, improve data validation (#22038) 2022-11-07 10:33:24 +00:00
Daniel Vaz Gaspar
358a4ecedd
fix: deprecate approve and request_access endpoint (#22022)
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-11-07 08:55:15 +00:00
John Bodley
6bbf4f8718
fix: JSON serializers (#22029) 2022-11-03 17:29:10 -07:00
Yongjie Zhao
a9b229dd1d
feat: support mulitple temporal filters in AdhocFilter and move the Time Section away (#21767) 2022-11-02 08:21:17 +08:00
Ville Brofeldt
a02a778cc3
feat(reports): execute as other than selenium user (#21931)
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
2022-10-31 14:32:49 +02:00
AAfghahi
33fc57854d
fix: error_parsing (#21946) 2022-10-28 19:43:37 -04:00
Antonio Rivero Martinez
203b289021
feat(bigquery): Custom message when Service Account doesnt have the correct Roles and Permissions (#21838) 2022-10-26 19:44:09 -04:00
Beto Dealmeida
a88dfe24c7
fix: check that imports are ZIPs (#21875) 2022-10-26 12:15:46 -07:00
Hugh A. Miles II
7600da8041
feat: create function for get_sqla_engine with context (#21790) 2022-10-25 14:12:48 -04:00
Beto Dealmeida
1388f21ee3
fix: accept old database payload (#21923) 2022-10-25 10:29:29 -07:00
AAfghahi
76c865fc56
chore: additional logging in alerts and reports (#21802) 2022-10-24 17:07:21 -04:00
Shubham Sinha
7edf1fbdf0
fix(superset): Fixed API for bulk delete of embedded dashboards (#21911) 2022-10-22 12:25:17 +01:00
Geido
c2834cc14c
chore: Remove CROSS_REFERENCES feature flag (#21815) 2022-10-21 15:11:49 +03:00
Shubham Sinha
decb2fb591
feat(datasets): Change in API to create virtual datasets (#21840) 2022-10-19 15:05:21 +01:00
Ville Brofeldt
52d33b05fd
chore(sqla): refactor query utils (#21811)
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
2022-10-17 10:40:42 +01:00
Ville Brofeldt
4c1777f20d
fix(alerts): restrict list view and gamma perms (#21765) 2022-10-15 10:03:26 +03:00
John Bodley
b1bf25e98c
fix(explore): Persist URL params to form-data (#21792) 2022-10-13 14:25:46 -07:00
Mayur
d1a6f0ebc4
fix: allow adhoc columns in non-aggregate query (#21729) 2022-10-10 12:08:33 +08:00
Elizabeth Thompson
f58227a912
feat: add denylist for db engines (#21486) 2022-10-08 19:45:21 -07:00
Reese
a5ff0949a6
feat(api): Add option to enable sync on import (#20312) 2022-10-07 15:28:38 -03:00
Michael S. Molina
200bed6f7e
feat: Shows related dashboards in Explore (#21685) 2022-10-07 12:59:49 -03:00
Mayur
61319fd759
feat(sqllab): save query parameters in database (#21682) 2022-10-07 12:49:14 +05:30
Hugh A. Miles II
882bfb67ae
fix: gsheets editing with dynamic forms (#21710) 2022-10-06 19:57:12 -07:00
Yongjie Zhao
05648eb489
feat: support None operand in EQUAL operator (#21713) 2022-10-06 16:45:59 +08:00
Daniel Vaz Gaspar
3057e4270c
feat: deprecate created_slices API endpoint (#21664)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-10-04 09:13:11 +01:00
Elizabeth Thompson
e98943e580
refactor: pass all properties to validate_parameters (#21487) 2022-10-03 17:48:54 -07:00
Elizabeth Thompson
4417c6e3e2
chore: add 4xx error codes where applicable (#21627) 2022-10-03 15:19:47 -07:00
Elizabeth Thompson
ef78ec6b30
fix: catch error when masking encrypted extra is none (#21570) 2022-10-02 19:49:01 -07:00
Mayur
5ea9249059
fix: respect chart cache timeout setting (#21637) 2022-09-29 08:26:19 -06:00
Daniel Vaz Gaspar
ab7cfec975
feat: new config to filter specific users from dropdown lists (#21515) 2022-09-29 12:30:07 +01:00
Antonio Rivero Martinez
b36bd3f083
fix(databases): GSheets and Clickhouse DBs are not allowed to upload files (#21065) 2022-09-26 10:08:11 -07:00
Erik Cederstrand
82bd5a31b8
chore(deps): Unpin sqlparse dependency (#21581)
Co-authored-by: Erik Cederstrand <erik@adamatics.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-09-26 17:41:04 +03:00
Michael S. Molina
2ec744da21
feat: Increments charts endpoint with related dashboards (#21518) 2022-09-23 13:21:19 -03:00
cccs-Dustin
2e564897f8
feat: Add dataset tagging to the back-end (#20892)
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-09-23 11:01:17 +03:00
Yongjie Zhao
737d4dcf0c
refactor: refine timestamp expr function (#21510) 2022-09-20 18:51:01 +08:00
Daniel Vaz Gaspar
7e2e8b8ad9
fix: dataset after insert when db relation does not exist (#21492) 2022-09-17 17:16:18 +01:00
Yongjie Zhao
2dfcba04b0
fix: Time Offset in SQLite and refine logic in Date Type conversion (#21378) 2022-09-16 12:02:22 +08:00
Michael S. Molina
2c7323a87d
fix: Supports form_data param in old Explore endpoint (#21469) 2022-09-14 18:00:11 -03:00
Daniel Vaz Gaspar
64d216adb3
fix: permission sqlalchemy events (#21454) 2022-09-13 13:56:59 -07:00
Bogdan
44654e5abc
perf: Memoize the common_bootstrap_payload and include user param (#21018) (#21439)
Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2022-09-13 08:52:08 -07:00
John Bodley
eac6fdcd29
chore(sqllab): Cleanup /tables/... endpoint (#21284) 2022-09-13 08:22:12 -07:00
Ville Brofeldt
05b97fff4d
fix(cache): respect default cache timeout on v1 chart data requests (#21441) 2022-09-13 15:56:04 +02:00
Ville Brofeldt
e1e9fda72b
fix: remove extras from all adhoc_filters controls (#21450)
Co-authored-by: Ville Brofeldt <ville.brofeldt@apple.com>
2022-09-13 15:52:21 +03:00
Daniel Vaz Gaspar
094400c308
fix: cached common bootstrap Revert (#21018) (#21419) 2022-09-10 01:02:24 +01:00
Hugh A. Miles II
14cd8a2160
chore: add test for SPA explore endpoints around missing datasets (#21303) 2022-09-09 10:54:39 -07:00
Yongjie Zhao
ce3d38d2e7
feat: apply Time Grain to X-Axis column (#21163) 2022-09-07 16:24:15 +08:00
Zef Lin
286474c3d8
fix: revert permission refactoring PR (#21313) 2022-09-06 19:18:22 +01:00
Zef Lin
9be4870c7f
feat: only show active user for chart/dashboard/datasource owner drop… (#20837) 2022-09-06 19:17:50 +01:00
Daniel Vaz Gaspar
c3f8417139
fix: disallow users from viewing other user's profile on config (#21302) 2022-09-05 13:32:48 +01:00
Beto Dealmeida
34a79add04
feat: filter parameters from DB API (#21248) 2022-09-02 11:50:04 -07:00
Yongjie Zhao
f71ee2e7bc
fix: flaky test when sync metadata (#21306) 2022-09-02 17:22:49 +08:00
Zef Lin
c4b6fc5a6a
chore: migrate available_domains to api/v1 (#21173) 2022-09-01 16:38:02 +01:00
Daniel Vaz Gaspar
9fd752057e
feat: adds TLS certificate validation option for SMTP (#21272) 2022-09-01 10:51:34 +01:00
Daniel Vaz Gaspar
3f2e894af3
fix: dataset name change and permission change (#21161)
* fix: dataset name change and permission change
2022-08-31 18:11:03 +01:00
Lily Kuang
05354a96bf
feat: filter with created_by for charts and dashboards (#21199)
* feat: filter with created_by for charts and dashboards

* add tests

* update tests

* update tests
2022-08-30 12:27:38 -07:00
ʈᵃᵢ
04dd8d414d
fix(celery cache warmup): add auth and use warm_up_cache endpoint (#21076) 2022-08-30 09:24:24 -07:00
Beto Dealmeida
8772e2cdb3
fix: improve get_db_engine_spec_for_backend (#21171)
* fix: improve get_db_engine_spec_for_backend

* Fix tests

* Fix docs

* fix lint

* fix fallback

* Fix engine validation

* Fix test
2022-08-29 11:42:42 -07:00
Geido
f017f98b88
chore: E2E tests for the Drill to detail modal (#21187)
* Add example ECharts Dashboard

* [WIP] E2E test

* Add echarts interactions

* Lint

* DRY
2022-08-29 11:25:27 +03:00
Đặng Minh Dũng
ccb293a083
fix(Trino): create PrestoBaseEngineSpec base class to share common code between Trino and Presto (#21066)
* chore: create `PrestoBaseEngineSpec` class that share common functions between Presto and Trino

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* feat(Trino): support CertificateAuthentication

* chore(Presto): move `get_function_names` to `PrestoBaseEngineSpec`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores(Presto): remove `is_readonly_query`

* feat(Trino): implement `extra_table_metadata`

* feat(Trino): specify `User-Agent`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* fix: pylint

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores(Presto): move `PrestoBaseEngineSpec` to `presto.py`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* fix(Presto): typing annotations

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
2022-08-29 10:21:28 +03:00
Reese
16032ed3e2
feat: Virtual dataset duplication (#20309)
* Inital duplicate functionality

* Fix formatting

* Create dedicated duplicate API

* Make use of new API

* Make use of new api permissions

* Add integration tests for duplicating datasets

* Add licenses

* Fix linting errors

* Change confirm button to 'Duplicate'

* Fix HTTP status code and response

* Add missing import

* Use user id instead of user object

* Remove stray debug print

* Fix sqlite tests

* Specify type of extra

* Add frontend tests

* Add match statement to test
2022-08-26 16:07:56 -06:00
Bogdan
ed6212a1f9
Reimplement permissions fetching to do it in a single transaction (#21156)
Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2022-08-23 18:45:39 -07:00
Yongjie Zhao
11bf7b9125
feat: generate label map on the backend (#21124) 2022-08-22 21:00:02 +08:00
Diego Medina
15b9f83150
chore: support trailing slashes in database api (#21123) 2022-08-22 15:15:04 +08:00
AAfghahi
dda1dcf8ee
feat: add header_data into emails (#20903)
* test sparkpost

* added logging info

* header function implementation

* added test

* daniel revisions

* daniel revision

* elizabeth review
2022-08-18 10:32:25 -04:00
Yongjie Zhao
1afcdfb9fa
fix: datetime value should be seconds in sqlite (#21113) 2022-08-18 11:42:58 +08:00
Bogdan
495a205dec
Memoize the common_bootstrap_payload (#21018)
Try patch

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2022-08-16 08:27:12 -07:00
Moriah Kreeger
83dd85166f
feat: add extension point for workspace home page (#21033)
* updates to allow insertion of workspace home sidescroll/table UI

* fix types

* fix User type import

* add welcome message to ui registry

* add extra fields to individual chart/query GET results (for workspace home required info)

* update list view card to support a subtitle

* add id to individual chart fetch

* update chart api test

* another test fix

* fix saved query test

* update extension types + insert point

* fix typing

* fix type name
2022-08-15 12:16:40 -07:00
Ville Brofeldt
5113b01031
feat(trino): add query cancellation (#21035) 2022-08-12 07:48:29 +03:00
Hugh A. Miles II
e13c5b2b7b
fix: take form_data reference for metrics for pivot_v2 table reports (#21029)
* take form_data reference for form_data

* better

* remove comments

* remove comments

* Update superset/charts/post_processing.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* add test

* test

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-08-11 12:08:40 -04:00
EugeneTorap
a2b21b55be
fix: Validate required fields in sql_json API (#21003)
* fix: Validate required params for sql_json API

* Test required params in sql_json API

* Refactoring: use marshmallow Schema for validation sql_json API

* Update SqlJsonPayloadSchema

* Update SqlJsonPayloadSchema

* Refactoring

* Refactoring

* Refactoring
2022-08-11 23:37:53 +08:00
Elizabeth Thompson
7445eab5a2
add test for tab state (#20949) 2022-08-10 16:45:31 -04:00
Bogdan
17b58037f8
perf: Implement model specific lookups by id to improve performance (#20974)
* Implement model specific lookups by id to improve performance

* Address comments e.g. better variable names and test cleanup

* commit after cleanup

* even better name and test cleanup via rollback

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2022-08-09 09:59:31 -07:00
Beto Dealmeida
bb3871ddaf
feat: per-db add metrics (#20990)
* feat: per-db add metrics

* Add unit tests
2022-08-08 12:07:16 -07:00
Yongjie Zhao
802b69f97b
feat: supports mulitple filters in samples endpoint (#21008) 2022-08-08 22:42:14 +08:00
Beto Dealmeida
7e501cd816
fix: BigQuery get_parameters_from_uri (#20966) 2022-08-03 17:27:40 -07:00
Jesse Yang
7e836e9b04
test: autouse app_context in unit tests (#20911) 2022-08-02 15:42:50 -07:00
Diego Medina
9291ad5d4c
fix: Change dataset name affect data access role set to this dataset (#20574) 2022-08-02 14:06:53 -06:00
Daniel Vaz Gaspar
bfd2a3d79f
fix: database permissions on update and delete (avoid orphaned perms) (#20081)
* fix: database permissions on update and delete (avoid orphaned perms)

* fix event transaction

* fix test

* fix lint

* update datasource access permissions

* add tests

* fix import

* fix tests

* update slice and dataset perms also

* fix lint

* fix tests

* fix lint

* fix lint

* add test for edge case, small refactor

* add test for edge case, small refactor

* improve code

* fix lint
2022-08-02 18:28:46 +01:00
Hugh A. Miles II
bc435e08d0
fix: overwrite update override columns on PUT /dataset (#20862)
* update override columns

* save

* fix overwrite with session.flush

* write test

* write test

* layup

* address concerns

* address concerns
2022-07-29 21:51:35 -04:00
Jesse Yang
e739ff5076
feat: allow more HTML tags in report description (#20908) 2022-07-29 08:27:39 -07:00
Yongjie Zhao
718bc3062e
fix: invalid metric should raise an exception (#20882) 2022-07-28 08:15:43 +08:00
Jesse Yang
77db0651d8
feat(sql lab): display presto and trino tracking url (#20799) 2022-07-26 20:20:08 -07:00
Elizabeth Thompson
cd578d2865
add having_druid back into the schema (#20879) 2022-07-26 17:54:46 -07:00
Jesse Yang
4d192e6e4d
feat(report): capture dashboard reports in specific states (#20552) 2022-07-26 17:01:56 -07:00
Jesse Yang
6e6d4e3169
test: suppress unnecessary fab and sqla logs (#20870) 2022-07-26 10:36:24 -07:00
Geido
6b0c3032b2
chore: Update color scheme when deleted or changed (#20589)
* feat(explore): Use v1/explore endpoint data instead of bootstrapData

* Add tests

* Fix ci

* Remove redundant dependency

* Use form_data_key in cypress tests

* Add auth headers to for data request

* Address comments

* Remove displaying danger toast

* Conditionally add auth headers

* Address comments

* Fix typing bug

* fix

* Fix opening dataset

* Fix sqllab chart create

* Run queries in parallel

* Fallback to default color scheme

* Fix dashboard id autofill

* Fix lint

* Fix test

* Fix hydrate action

* Update dashboard colors

* Add color scheme domain

* Add check for default scheme

* Make me pretty

* Clean up

* Nit

* Clean up

* Pretty

* Fix missing sequential

* Lint

* Enhance test

* Lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-07-25 18:50:49 -04:00
Yongjie Zhao
f011abae2b
feat: the samples endpoint supports filters and pagination (#20683) 2022-07-22 20:14:42 +08:00
Hugh A. Miles II
84b852c457
fix: properly set owners to Sqlatable.owners_data inside payload (#20794)
* properly set owners_data for sqlatabl

* fix test
2022-07-20 14:56:08 -04:00
Cody Leff
84d4302628
fix(explore): Fix chart standalone URL for report/thumbnail generation (#20673)
* Update explore URLs.

* More URL fixes.

* Make frontend accept true/false query params case-insensitively.

* Fix URL mistake.

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-07-19 13:53:55 -03:00
John Bodley
8c0ac9017f
fix: Presto _show_columns return type (#20757) 2022-07-19 09:52:22 -07:00
Jesse Yang
e2d3ea831a
fix(db): use paginated_update for area chart migration (#20761) 2022-07-19 07:20:46 -07:00
Beto Dealmeida
e60083b45b
chore: upgrade SQLAlchemy to 1.4 (#19890)
* chore: upgrade SQLAlchemy

* Convert integration test to unit test

* Fix SQLite

* Update method names/docstrings

* Skip test

* Fix SQLite
2022-07-18 15:21:38 -07:00
Elizabeth Thompson
bbaa4cc65d
use existing row when id is found (#20661) 2022-07-16 00:00:39 -07:00
Jesse Yang
2cb4fd31f1
refactor(test): add login_as_admin in global conftest (#20703) 2022-07-14 18:10:31 -07:00
Jesse Yang
c3ac61271a
feat(dashboard): make permalink deterministic (#20632) 2022-07-12 16:33:18 -07:00
Elizabeth Thompson
c2be54c335
fix: pandas bug when data is blank on post-processing (#20629)
* fix pandas bug when data is blank on post-processing

* account for multiple queries when data is blank
2022-07-08 16:33:53 -07:00
AAfghahi
0ce0c6e1eb
chore: removing Druid from front- and back- end (#20338)
* first pass at removing native Druid nosql

* removing having_druid

* addressing comments, linting

* fixed all tests

* addressing comments

* redirected to ui-core TimeGranularity type

* query form metric linting

* fixed broken chart type

* implementing feedback
2022-07-08 17:57:03 +02:00
Yongjie Zhao
4e6e87f62e
feat: Area viz migration (#20359) 2022-07-08 19:56:03 +08:00
John Bodley
f0ca158989
fix: Refactor ownership checks and ensure consistency (#20499)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-07 11:04:27 -07:00
Smart-Codi
e7b965a3b2
fix: Bad date type in email text report for table chart (#20119)
* fix bad date type in email text report for table chart

* fix test, pylint issue

* add test case for date type
2022-07-07 11:31:50 -06:00
Yongjie Zhao
7626c31372
feat: TreeMap migration (#20346) 2022-07-07 19:37:18 +08:00
Yongjie Zhao
414cc99ca2
fix: datetime.data in series (#20618) 2022-07-07 09:33:44 +08:00
Reese
f9109583ce
fix: Allow dataset owners to explore their datasets (#20382)
* fix: Allow dataset owners to explore their datasets

* Re-order imports

* Give owners security manager permissions to their datasets

* Update test suite

* Add SqlaTable to is_owner types

* Add owners to datasource mock

* Fix VSCode import error

* Fix merge error
2022-07-06 11:27:50 -03:00
Daniel Vaz Gaspar
f38dd1d42d
feat: add hooks on set_perm for new data permissions (#20600)
* feat: add hooks on set_perm for new data permissions

* fix lint
2022-07-06 09:54:18 +01:00
Rui Zhao
818962cc89
fix(embedded): Retry when executing alert queries to avoid sending transient errors to users as alert failure notifications (#20419)
Co-authored-by: Rui Zhao <zhaorui@dropbox.com>
2022-07-05 13:23:05 -07:00
Michael S. Molina
662bab1e6d
feat: Renders Explore in SPA (#20572)
* feat: Renders Explore in SPA

* Adds permalink support

* Replaces navigation from Welcome page

* Fix initializing feature flags

* Remove redundant import

* Adds saveSlice workaround

* Fixes paths

* Fixes lint error

* Fixes tests

* Fix url to explore from Datasets view

* Fix explore page height

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-07-05 16:58:09 -03:00
John Bodley
94b3d2f0f0
refactor: Deprecate ensure_user_is_set in favor of override_user (#20502)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-05 10:57:40 -07:00
John Bodley
ad308fbde2
chore(rls): Remove passing global username (#20344)
* chore(rls): Remove passing global username

* Update manager.py

* Update manager.py

* Update manager.py

* Update manager.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-07-05 10:51:24 -07:00
Yongjie Zhao
b870a21eaa
refactor: remove unused flatten function (#20582) 2022-07-01 19:17:55 +08:00
Jesse Yang
cadd259788
feat: save active tabs in dashboard permalink (#19983) 2022-06-29 09:43:52 -07:00
John Bodley
3483446c28
refactor: Cleanup user get_id/get_user_id (#20492)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-24 17:57:04 -07:00
Michael S. Molina
20163361b9
feat: Adds the /explore endpoint to the v1 API (#20399)
* feat: Adds the /explore endpoint to the v1 API

* Fixes pylint errors

* Fixes tests

* Changes the tests logic

* Removes ABC reference

* Improves indentation

* Addresses review comments

* Rebases code

* Improves dataset and slice assertions

* Fixes tests

* Removes schema and table name assertions

* Removes fixed IDs

* Fixes datasource ID
2022-06-24 08:23:30 -03:00
Elizabeth Thompson
44f0b511dd
remove autoflush for queries during dual write (#20460) 2022-06-23 14:50:30 -07:00
Beto Dealmeida
f3b289d3c3
fix: ensure column name in description is string (#20340)
* fix: ensure column name in description is string

* Add unit test
2022-06-21 10:10:46 -03:00
Hugh A. Miles II
e3e37cb68f
chore: switching out ConnectorRegistry references for DatasourceDAO (#20380)
* rename and move dao file

* Update dao.py

* add cachekey

* Update __init__.py

* change reference in query context test

* add utils ref

* more ref changes

* add helpers

* add todo in dashboard.py

* add cachekey

* circular import error in dar.py

* push rest of refs

* fix linting

* fix more linting

* update enum

* remove references for connector registry

* big reafctor

* take value

* fix

* test to see if removing value works

* delete connectregistry

* address concerns

* address comments

* fix merge conflicts

* address concern II

* address concern II

* fix test

Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
2022-06-21 13:22:39 +02:00
Daniel Vaz Gaspar
60eb1094a4
feat: add name, description and non null tables to RLS (#20432)
* feat: add name, description and non null tables to RLS

* add validation

* add and fix tests

* fix sqlite migration

* improve default value for name
2022-06-20 13:52:05 +01:00
John Bodley
8b0bee5e8b
[fbprophet] Fix frequencies (#20326) 2022-06-19 21:53:09 -07:00
Lily Kuang
ab9f72f1a1
fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00
mohittt8
41bbf62e58
fix(presto): use correct timespec for presto (#20333) 2022-06-16 16:43:17 -07:00
Beto Dealmeida
998624b1a5
feat: allow setting db UUID (#20412)
* WIP

* feat: allow passing UUID when creating a DB

* Test

* Fix field
2022-06-16 15:53:59 -07:00
Elizabeth Thompson
12436e47c9
fix key error on permalink fetch for old permalinks (#20414) 2022-06-16 15:51:17 -07:00
Diego Medina
3fe53f735e
fix: Unable to export multiple Dashboards with the same name (#20383) 2022-06-15 00:27:24 -06:00
Elizabeth Thompson
5a137820d0
fix: catch some potential errors on dual write (#20351)
* catch some potential errors on dual write

* fix test for sqlite
2022-06-13 17:30:13 -07:00
Reese
11b33de61b
feat(api): Added "kind" to dataset/<pk> endpoint (#20113) 2022-06-10 13:03:48 -07:00
Craig Rueda
d1c24f81f2
chore(migrations): Renaming migration files so that they're easier to keep track of (#20284)
* Renaming migration files so that they're easier to keep track of

* Fixing broken import

* Fixing broken import again

* Fixing broken tests
2022-06-07 10:30:09 -07:00
AAfghahi
c131f025f8
chore: add event logger to reports/alerts CRUD (#20249)
* add event logger to report CRUD

* added assert metric to tests

* added unique name to action

* testing

* with inline log context
2022-06-06 16:13:22 +02:00
John Bodley
b08e21efd9
[requirements] Resolve rebase conflicts (#20152)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-03 15:27:35 -07:00
Elizabeth Thompson
32bb1ce3ff
feat!: pass datasource_type and datasource_id to form_data (#19981)
* pass datasource_type and datasource_id to form_data

* add datasource_type to delete command

* add datasource_type to delete command

* fix old keys implementation

* add more tests
2022-06-02 16:48:16 -07:00
Diego Medina
8638f59b4c
fix: Box Plot Chart throws an error when the average (AVG) / SUM is being calculated on the Metrics (#20235)
* fix: Box Plot Chart throws an error when the average (AVG) / SUM is being calculated on the Metrics

* add test
2022-06-02 10:00:04 +08:00
Beto Dealmeida
05a138a191
feat: query datasets from SQL Lab (#15241)
* feat: Jinja2 macro for querying datasets

* Add docs

* Address comments
2022-06-01 15:18:40 -07:00
Smart-Codi
74c5479926
fix: datatype tracking issue on virtual dataset (#20088)
* Fix datatype tracking issue on virtual dataset

* fix pytest issue on postgresql
2022-06-01 13:43:11 -06:00
Yongjie Zhao
1530c34792
fix: failed samples should throw exception (#20228) 2022-06-01 18:24:01 +08:00
John Bodley
97ce920d49
fix(csv): Ensure df_to_escaped_csv handles NULL (#20151)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-05-31 09:56:25 -07:00
Daniel Vaz Gaspar
77ccec50cc
feat: add statsd metrics for notifications (#20158)
* feat: add statsd metrics for notifications

* fix import

* fix lint

* add decorator arg for custom prefix

* add tests
2022-05-26 15:43:05 +01:00
Ville Brofeldt
64c4226817
fix(temporary-cache): when user is anonymous (#20181)
* fix(temporary-cache): fail on anonymous user

* make exceptions generic

* fix test

* remove redundant bool return

* fix unit tests
2022-05-26 14:45:20 +03:00
Phillip Kelley-Dotson
0501ad25e8
fix: always create parameter json field (#19899)
* fix: always create parameter json field

* ensure validation for empty catalog

* check engine instead of name

* put validation in be

* fix test

* fix test

* remove test
2022-05-25 14:23:25 -07:00
Yongjie Zhao
40abb44ba1
feat: add samples endpoint (#20170) 2022-05-25 18:18:58 +08:00
cccs-tom
b0c6935f06
fix: Allow dataset owners to see their datasets (#20135) 2022-05-25 09:58:15 +01:00
Hugh A. Miles II
f8ea7788a9
feat: Add Certified filter to Datasets (#20136) 2022-05-23 17:58:15 -04:00
Daniel Vaz Gaspar
b9a98aae79
fix: None dataset and schema permissions (#20108)
* fix: None dataset and schema permissions

* fix pylint

* add migration and test

* fix migration
2022-05-20 09:40:10 +01:00
Ville Brofeldt
e2f11d3680
fix(presto,trino): use correct literal dttm separator (#20123)
* fix(presto,trino): use correct literal dttm separator

* remove redundant tests
2022-05-19 20:42:31 +03:00
Hugh A. Miles II
660af409a4
feat: Save column data into json_metadata for all Query executions (#20059)
* add save_metadata function to QueryDAO

* use set_extra_json_key

* added test

* Update queries_test.py

* fix pylint

* add to session

* add to session

* refactor

* forgot the return
2022-05-18 13:11:14 -04:00
AAfghahi
e69f6292c2
chore: Set limit for a query in execute_sql_statement (#20066)
* test for query limit

* fixed tests
2022-05-16 17:56:46 -04:00
cccs-RyanS
ddc01ea781
feat(business-types): initial implementation of SIP-78 (#18794)
* add BUSINESS_TYPE_ADDONS to config with example callback

* Removing uneeded whitespace

* [Work in progress] Modifying cidr function to allow for  single ip and adding port outline

* Added test REST endpoint, added some more ports

I've thrown in a test.py script as well that will try to connect to the
business_type endpoint.

* Moving code from config.py into the business api

Very simple api is exposed that will allow someone to call a checkport
endpoint and get back a response.

* Removing commented out bits.

* Adding fucntion dict back to the config

* Moving business_type endpoint to charts

* Adding schema for get endpoint

* Removing imports, updating docstring, fixing typo

Just some small changes as described in the title.  I've updated the
test.py as well so it functions with the endpoint changes.

* Adding translation dict

* Fixing ops

* Adding check for list

* Modifying changes to add quotes where needed

Also changed BusinessTypeResponse to resp.

* Adding in some code to call the filter config

If a column starts with "cidr_" it will call the code in config.py to
try to translate the filter.  Nothing is changed in the JSON being
executed, just some information is dumped to console.

* Porting Ryan's changes

* Adding migration script (as per Ryan's PR)

* Fixing typo

* Prettier fixes

* [CLDN-1043] Adding rough version of filter changes for business types

* fix down migration

* Fixing bugs after merge

* adding functionality to appy filters in back end

* Fixing linting issues

* fix down revision

* Changing conversion callback to handle multiple values at once

* Adding string representation of values

* Code cleanup plus fixing debouce to only be called once for each entry

* Removing non needed logginh

* Changing operator list to use sting values

* Using text value operators

* Removing clear operator call

* Moving business type endpoints

* fix down revision

* Adding port functions

* update migration

* fix bad rebase and add ff

* implement validator

* dont add invalid values to response

* [CLDN-1205] Added a new exception type for a business type translation error. Added the error message in the display_value field within the business type response. Modified the IP and Port business types to populate the error message field in the response if an error occurs

* [CLDN-1205] Added meaningful error message for port translation errors

* Removing status field from businesstype Response and adding in error message

* [CLDN-1205] Added check to make sure the port business type is within the valid range of ports, if it is not, it will populate the error message

* [CLDN-1205] Fixed the if statement that checks to see if the string_value is in the valid range of port numbers. It did not corrently verify this before now.

* [CLDN-1205] Fixed an error where it was trying to use string_value in <= statements. I just casted string_value to an integer if it is numeric, which allows <= operators to be used on it

* [CLDN-1207] Added unit tests for the cidr_func and port_translation_func functions which are located in /superset/config.py

* [CLDN-1207] removed the assertRaises line as it does not work with the cidr_func and port_translation_func functions

* [CLDN-1207] Added the skeleton of the test_cidr_translate_filter_func unit test, still need to update what the expected response from the function will be.

* [CLDN-1207] Added the remainder of the back-end unit tests for the business types

* [CLDN-1207] Fixed the syntax error which caused the test_cidr_translate_filter_func_NOT_IN_double unit test to fail

* [CLDN-1207] Removed the logging that was added for debugging purposes

* [CLDN-1207] Formatted the commands_tests.py file to make it nicer to look at/read through

* [CLDN-1207] Fixed the code so that it conformed to the pylint requirements (i.e., pylint no longer complains about the code in commands_tests.py)

* [CLDN-1207] Modified some of the docstrings so they made better use of the 100 character per line, line limit

* [CLDN-1207] Added the beginnings of the unit tests for the
business types API

* [CLDN-1207] Added a comment to the top of the commands_tests.py file explaining how to run the unit tests. This prevents the next person who tries to run them from having to waste time trying the different forms of testing that Superset supports (e.g., pytest, tox, etc.)

* [CLDN-1207] Added a grammar fix to the comments describing how to run the unit tests

* [CLDN-1207] Modified the description of the business_type API endpoints as they did not represent what the API was actually doing

* [CLDN-1207] Added further instructions on how to run the unit tests that are within the business_type/api_tests.py file

* add request validation

* disable request if business type missing

* [CLDN-1207] Unit tests for the business type API are now working, however, they need to be modified to make use of @mock as we don't want to have to run the server to be able to run the unit tests

* Removing businesss types deffinitons from config

* Adding select to only show valid business types

* Fixed Enzyme tests

* Added scalfolding for selecting filter dropdown

* Adding intigration tests

* fix revision

* fix typos and unnecessary requests

* break out useBusinessTypes

* Added front-end RTL unit tests for the business type API endpoint

* Fixed error from unit tests

* Added a unit test to ensure the operator list is updated after a business type API response is received

* Removing elect compoenet for business types

* Adding feature flag and allowing saving when no business type present

* fixing useEffect hooks

* Adding feature flag to model

* Changing behavior such that an empty string returns a default response

* add form validation

* Modified comments in unit test as command to run test has changed

* Modified comments in unit test as filename to run test has changed

* Modified the api_tests.py file to conform to the linting requirements

* Changed the name of one of the tests to reflect what the test is actually testing

* Added cypress back to the package.json

* Added informative comments

* Updated comments in files as well as removed imports which were not being used

* Changes made by npm run prettier

* Fixed spelling mistakes

* Updated models.py to remove placeholder comments used in development

* Added feature flag mocking in unit test

* Fixing open api failure

* Fixing business types to pass unit tests

* Reverting unsafe connections back to false

* Removing print statement

* Adding business tpye to export test

* setting default feature flag to false for business type

* Reverting pre commit

* Reverting pre commit and running pre commit

* Reverting pre commit and running pre commit

* Fixing formatting

* Adding license

* Fixing Linting

* Protecting api enpoints

* updating model

* Fixing code path when business type exists

* Linting

* Linting

* Fixing linting

* Fixing spelling

* Fixing schemas

* Fixing app import

* fixing item render

* Added RTL test to make sure business type operator list is updated after API response

* Fixing linting

* fix migration

* Changing unit tests

* Fixing import and DB migration after rebase

* Renaming to advanced types

* Fixing Linting

* More renaming

* Removing uneeded change

* Fixing linting and test errors

* Removing unused imports

* linting

* Adding more detailed name for migration

* Moving files to plugins

* more renaming

* Fixing schema name

* Disabling feature flag that should not be enabled by default

* Adding extra cehck

* NameChange

* formatting

* Fixing equals check

* Moveing all advanced type classes and types to one file, and converting tests to functional

* Adding advanced type to test and fix linitng

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Dan Parent <daniel.parent@cse-cst.gc.ca>
Co-authored-by: GITHUB_USERNAME <EMAIL>
Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com>
2022-05-16 17:58:21 +03:00
thinhnd2104
85315460cb
fix: Athena timestamp literal format (#19970)
* Fix Athena timestamp literal format

related: [#19969]

* Update test_athena.py

Update test

* Update athena.py

* Resolving CI/CD

* lint

Co-authored-by: Thinh Nguyen Duc <thinhnd.it@tripi.vn>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2022-05-16 09:50:20 +03:00
Jesse Yang
6139057dcf
test: make tabbed dashboard a little more complex (#19966) 2022-05-13 17:31:23 -07:00
Hugh A. Miles II
21c5b26fc8
feat(sip-68): Add DatasourceDAO class to manage querying different datasources easier (#20030)
* restart

* update with enums

* address concerns

* remove any
2022-05-13 12:28:57 -04:00
John Bodley
89a844a40f
fix(reports): Clear last value when state is WORKING (#19941)
* fix(reports): Clear last value when state is WORKING

* Update cbe71abde154_fix_report_schedule_and_log.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-05-12 21:54:23 -07:00
John Bodley
449d08b25e
fix: Refactor SQL username logic (#19914)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-05-12 21:03:05 -07:00
Beto Dealmeida
f2881e5bbd
feat: RLS for SQL Lab (#19999)
* feat: RLS for SQL Lab

* Small fixes

* Pass username to security manager

* Update docstrings

* Add tests

* Remove type from docstring
2022-05-12 11:03:01 -07:00
AAfghahi
fd611d7653
refactor: Refactor reports for Charts and Dashboards (#19130)
* bumping shillelagh

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* Preset io ch28954 refactor reports (#19129)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* refactoring reports

* ready for review

* added testing

* removed user reducer

* elizabeth suggestions

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* deleted additional folder

* fixing tests

* all but styling

* bumping shillelagh

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* Preset io ch28954 refactor reports (#19129)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Arash/new state report (#16987)

* code dry (#16358)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor(reports): Arash/refactor reports (#16855)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* report pickup

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor(reports):  Arash/again refactor reports (#16872)

* pexdax refactor (#16333)

* refactor progress (#16339)

* fix: Header Actions test refactor (#16336)

* fixed tests

* Update index.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* code dry (#16358)

* Fetch bug fixed (#16376)

* continued refactoring (#16377)

* refactor: Reports - ReportModal (#16622)

* refactoring progress

* removed consoles

* Working, but with 2 fetches

* it is still not working

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* next changes

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* refactor: Reports code clean 10-29 (#17424)

* Add delete functionality

* Report schema restructure progress

* Fix lint

* Removed console.log

* fix(Explore): Remove changes to the properties on cancel (#17184)

* Remove on close

* Fix lint

* Add tests

* fix(dashboard): don't show report modal for anonymous user (#17106)

* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>

* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503)

* Add functionality is now working (#17578)

* refactoring reports

* ready for review

* added testing

* removed user reducer

* elizabeth suggestions

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>

* deleted additional folder

* fixing tests

* all but styling

* fixed tests

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-05-11 14:19:51 -04:00
Daniel Vaz Gaspar
87a4379d0a
feat: deprecate /superset/validate_sql_json migrate to api v1 (#19935)
* feat: deprecate /superset/validate_sql_json migrate to api v1

* use new error handling

* migrate SQLLAb frontend and add tests

* debug test

* debug test

* fix frontend test on sqllab

* fix tests

* fix frontend test on sqllab

* fix tests

* fix tests

* fix tests

* fix tests
2022-05-10 21:25:39 +01:00
Jesse Yang
7b88ec7e25
refactor(ReportModal): simplify state reducer and improve error handling (#19942) 2022-05-05 10:06:40 -07:00
Elizabeth Thompson
060b5c0e17
chore: remove druid datasource from the config (#19770)
* remove druid datasource from the config

* remove config related references to DruidDatasource

* Update __init__.py

* Update __init__.py

* Update manager.py

* remove config related references to DruidDatasource

* raise if instance type is not valid
2022-05-04 12:48:48 -07:00
Daniel Vaz Gaspar
4fdf230a56
feat: deprecate /superset/extra_table_metadata migrate to api v1 (#19921)
* feat: deprecate /superset/extra_table_metadata migrate to api v1

* use can_read to table_extra_metadata

* troubleshoot sqlite

* fix test

* fix test

* fix test

* fix frontend test on sqllab
2022-05-04 14:55:52 +01:00
Yeachan Park
8b72354654
fix(sqllab/charts): casting from timestamp[us] to timestamp[ns] would result in out of bounds timestamp (#18873)
* fix casting from timestamp[us] to timestamp[ns] would result in out of bounds timestamp from sqllab and charts

* Add unittests

* Lint changes and parameter variable rename

* Fix linting
2022-05-04 09:47:12 +03:00
David Aaron Suddjian
7f8279b4b3
chore: get embedded user with roles and permissions (#19813)
* feat: get user roles endpoint

* add tests

* fix test

* get user with permission and roles with full user

* frontend

* type juggling

* the hash slinging slasher

* user reducer and action

* make it happy

* result

* lint

Co-authored-by: Lily Kuang <lily@preset.io>
2022-05-03 12:58:06 -07:00
Beto Dealmeida
90130e4b4f
feat: simplify SQLite time grain (#19745) 2022-05-03 07:13:33 -07:00
Ville Brofeldt
99f1f9ec61
fix(sqla): replace custom dttm type with literal_column (#19917) 2022-05-03 07:19:36 +03:00
Beto Dealmeida
1ebdaac487
fix: memoize primitives (#19930) 2022-05-02 14:50:56 -07:00
Beto Dealmeida
aff10a7fad
feat: simplify memoized_func (#19905) 2022-04-29 15:55:58 -07:00
Hugh A. Miles II
8b15b68979
fix: Alpha should not be able to edit datasets that they don't own (#19854)
* fix api for checking owners

* fix styles for disabling

* fix styles for disabling

* fix lint

* fix lint

* add owners key

* plzz

* remove

* update test

* add tooltip

* add type

* fix test

* fix user reference

* lit

* fix test

* work
2022-04-29 14:21:05 -07:00
Phillip Kelley-Dotson
ad715429f9
chore: simplify error messaging in database modal (#19165)
* testing for dbconn modal error message

* remove consoles and error alert mapping

* lint fix

* update url message

* add modal fix

* update comments

* fix err msg bugs

* fix pylint

* fix line

* fix tests

* fix assertions
2022-04-21 12:44:21 -07:00
Yongjie Zhao
3c28cd4625
feat: add renameOperator (#19776) 2022-04-20 19:48:12 +08:00
Jesse Yang
231716cb50
perf: refactor SIP-68 db migrations with INSERT SELECT FROM (#19421) 2022-04-19 18:58:18 -07:00
Hugh A. Miles II
a6f46013d9
feat: 10/15/30 min grain to Pinot (#19724)
* add new grains to pinot

* update test
2022-04-19 11:16:48 -07:00
Hugh A. Miles II
7e92340c70
fix: Fix migration for removing time_range_endpoints 3 (#19767)
* fix migration

* so dumb

* update test

* add code change

* retest
2022-04-19 09:49:50 -07:00
AAfghahi
57157c8b15
fix: remove expose (#19700)
* bumping shillelagh

* remove expose
2022-04-16 22:02:23 -07:00
David Aaron Suddjian
ae70212df3
fix: deactivate embedding on a dashboard (#19626)
* fix tests

* commit it properly

* unnecessary commit, correct type in docstring

* unused import
2022-04-15 16:15:27 -07:00
Hugh A. Miles II
86642025ba
fix: Removetime_range_endpoints from query context object pt 2 (#19728) 2022-04-15 13:17:05 -04:00
Yongjie Zhao
9425dd2cac
fix: drop the first level of MultiIndex (#19716) 2022-04-14 23:40:38 +08:00
Lily Kuang
224769bd45
feat(embedded): API get embedded dashboard config by uuid (#19650)
* feat(embedded): get embedded dashboard config by uuid

* add tests and validation

* remove accidentally commit

* fix tests
2022-04-12 15:14:08 -07:00
Yongjie Zhao
d7dd4119d4
fix: time comparision (#19659) 2022-04-12 18:19:22 +08:00
AAfghahi
4bf4d58423
fix: update Permissions for right nav (#19051)
* draft pr

* finished styling

* add filter

* added testing

* added tests

* added permissions tests

* Empty-Commit

* new test

* Update superset-frontend/src/views/components/MenuRight.tsx

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* revisions

* added to CRUD view

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-04-11 16:50:59 -04:00
Jesse Yang
b45f89b954
refactor: consistent migration tests organization (#19635) 2022-04-09 07:50:52 -07:00
Jesse Yang
ce2bd98442
test: freeze time for dashboard export test (#19634) 2022-04-09 07:49:39 -07:00
Jesse Yang
738bd04b4f
fix(test): make test_clean_requests_after_schema_grant more idempotent (#19625) 2022-04-09 07:48:37 -07:00
Ville Brofeldt
9a9e3b6e3b
test(jinja): refactor to functional tests (#19606) 2022-04-08 20:32:38 +03:00
Daniel Vaz Gaspar
d6d2777ada
feat: deprecate old API and create new API for dashes created by me (#19434)
* feat: deprecate old API and create new API for dashes created by me

* add tests

* fix previous test

* fix test and lint

* fix sqlite test

* fix lint

* fix lint

* lint

* fix tests

* fix tests

* use dashboards get list instead

* clean unnecessary marshmallow schema

* Update superset/views/core.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* lint

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-04-08 09:05:22 +01:00
Beto Dealmeida
83c3779a6c
feat: add a where_in filter for Jinja2 (#19574) 2022-04-07 07:27:23 -07:00