pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: always create parameter json field (#19899) 

* fix: always create parameter json field

* ensure validation for empty catalog

* check engine instead of name

* put validation in be

* fix test

* fix test

* remove test
This commit is contained in:
Phillip Kelley-Dotson 2022-05-25 14:23:25 -07:00 committed by GitHub
parent 73443cea2f
commit 0501ad25e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
superset/db_engine_specs/gsheets.py
View File

@ -171,6 +171,14 @@ class GSheetsEngineSpec(SqliteEngineSpec):
if not table_catalog:
# Allowing users to submit empty catalogs
errors.append(
SupersetError(
message="Sheet name is required",
error_type=SupersetErrorType.CONNECTION_MISSING_PARAMETERS_ERROR,
level=ErrorLevel.WARNING,
extra={"catalog": {"idx": 0, "name": True}},
),
)
return errors
# We need a subject in case domain wide delegation is set, otherwise the

9
tests/unit_tests/db_engine_specs/test_gsheets.py
View File

@ -40,7 +40,14 @@ def test_validate_parameters_simple(
"catalog": {},
}
errors = GSheetsEngineSpec.validate_parameters(parameters)
assert errors == []
assert errors == [
SupersetError(
message="Sheet name is required",
error_type=SupersetErrorType.CONNECTION_MISSING_PARAMETERS_ERROR,
level=ErrorLevel.WARNING,
extra={"catalog": {"idx": 0, "name": True}},
),
]
def test_validate_parameters_catalog(