refactor: consistent migration tests organization (#19635)

This commit is contained in:
Jesse Yang 2022-04-09 07:50:52 -07:00 committed by GitHub
parent ce2bd98442
commit b45f89b954
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 15 deletions

View File

@ -21,20 +21,17 @@ from superset.migrations.versions.fb13d49b72f9_better_filters import (
upgrade_slice,
)
from .base_tests import SupersetTestCase
def test_upgrade_slice():
slc = Slice(
slice_name="FOO",
viz_type="filter_box",
params=json.dumps(dict(metric="foo", groupby=["bar"])),
)
upgrade_slice(slc)
params = json.loads(slc.params)
assert "metric" not in params
assert "filter_configs" in params
class TestMigration(SupersetTestCase):
def test_upgrade_slice(self):
slc = Slice(
slice_name="FOO",
viz_type="filter_box",
params=json.dumps(dict(metric="foo", groupby=["bar"])),
)
upgrade_slice(slc)
params = json.loads(slc.params)
self.assertNotIn("metric", params)
self.assertIn("filter_configs", params)
cfg = params["filter_configs"][0]
self.assertEqual(cfg.get("metric"), "foo")
cfg = params["filter_configs"][0]
assert cfg.get("metric") == "foo"