* Force refresh the chart on toggle display description
* Use forceUpdate instead of forceRefresh
* Instead of forceUpdate, add a state for desciption height
Co-authored-by: Ajay Mancheery <ajaymancheery@Ajays-MacBook-Pro.local>
* chore(dashboard): Integrate dashboard app into the SPA bundle
* fix url params
* change variable name
* change title correctly
* custom css
* lint
* remove unused file
* remove content assertions from dashboard tests
* fix case with missing bootstrap data
* fix: respect crud views flag
* crud views -> spa
* remove unused dashboard templates
* fix: remove unused variable
* fix: missed a spot with the crudViews -> spa
* router link to dashboard from dashboard list page
* link using the router when in card mode
* lint
* fix tests, add memory router
* remove dashboard app files
* split up the bundle a little more
* use webpack preload
* Add aria-label and twotone
* Enhance LazyIcon
* Fix tests and solve ject warnings
* Add new line
* Revert package-lock to master
* Fix failing test
* Implement icon overrides
* Fix failing storybook
* Clean up
* Improve var name
* fix:fix get permission function
* feat: hide native filters by metadata
* fix: fix show_native_filters name
* fix: metadata
* chore: add migration to hide native_filters in all existing dashboards
* chore: fix pre-commit
* fix: make migration migration dashboard with filter_box only
* fix: pre-commit
* feat: hide filter bar if no permission edit and no filters
* fix: remove migration
Co-authored-by: amitmiran137 <amit.miran@nielsen.com>
* feat(native-filters): add optional sort metric to select filter
* use verbose name when defined
* fixes
* lint
* disable flaky test
* disable flaky test
* disable flaky test
* Implement adhoc filters in Range and Select native filters
* Add time picker
* Remove additional filters from datamask
* Create separate stylesheet for AdhocFilterControl in native filters
* Rename Time picker to Time range
* Fix columns in AdhocFilter empty when creating a new filter
* Skip flaky test
* fix:fix get permission function
* fix: not reload charts after save filters
* fix: not reload charts after save filters
* fix: temp commit type
* lint: add typing
* restyle database modal
* change name of tab to Basic
* update test with RTL better RTL render statement
* change color and position of required asterisk
* refactor db logic
* test: add tests for filter bar
* test: merge filter bar tests with master
* test: add test for filter set
* test: filter set tests
* test: merge with master
* test: fix tests for filter bar
* fix: fix CR notes
* fix: fix CR notes
* chore: type some SQL Lab components
* Update superset-frontend/src/SqlLab/components/QueryHistory.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* add ui for setting report format
* refactor default notification format
* init csv data alert report
* add report format to report_schedule model
* add ALERTS_ATTACH_REPORTS feature flag
* fix lint
* update check image tag
* fix migrations
Co-authored-by: samtfm <sam@preset.io>
* add hook for future async api calls
* test to see conflict
* add async middleware and update reducers
* working async dashboard load
* implement getcharts api
* add user permissions to explore and dashboard bootstrap data
* integrate api calls with getinitial state
* update namings
* accept an id or a slug in the dashboard charts api
* add permissions function
* fix merge
* update state
* get dashboard charts by id or slug
* fix undefined states
* variable names
* stop using some more bootstrap data
* fix metadata reference
* remove unused bootstrap from the template
* add errorboundry to dashboard
* refactoring, fixing
* update permissions
* add just roles
* id is supposed to be a string
* unused vars
* get datasources from api
* make onError optional
* use resource hooks, better error boundary
* add loading state for dashboardroute
* remove console
* add conditional
* more conditionals
* testing out a possible fix for cypress
* convert edit/standalone test to cypress
* remove bootstrappy assertions
* lint
* fix dashboard edit history issue
* rename stuff
* address recent native filters schema change
* remove unused getInitialState
* remove .only from test
* hooksy redux usage
* Revert "more conditionals"
This reverts commit 25c8ed61b4.
* cleanup
* undo unnecessary change
* actually need conditions here
* certainty
* Revert "certainty"
This reverts commit 77dea1915b.
* more permutations (untested yolo)
* Update superset-frontend/src/chart/chartReducer.ts
Co-authored-by: Evan Rusackas <evan@preset.io>
* import style
* comment
* cleaner dashboardInfo
* remove debug code
* use memo for getPermissions
* fix lint
* adjust name/location of DashboardPage
* move logic for REMOVE_SLICE_LEVEL_LABEL_COLORS to DAO
* stop using full_data()
* remove unused (and now useless) json=true query param
Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
* Tests for "nativeFilters/FilterBar/FilterSets/utils"
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/findExistingFilterSet.test.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterSets/utils/generateFiltersSetId.test.ts
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Fix: Lint error
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* replace Well componenet with Card component
* Fix lint errors
* Fix lint
* Addressing comments
* Addressing comments
* Fix lint errors
* Exporting Card from index.tsx and adding storybook variants
* Fix some refactoring
* Fix errors
* solving conflicts and lint errors
* Update superset-frontend/src/common/components/Card.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/Card.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/common/components/common.stories.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Nikola Gigic <nik.gigic@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Test for Tabs component
* Fix: "creteProps" to "createProps"
* Update superset-frontend/src/dashboard/components/gridComponents/Tabs.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for Tab component
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/gridComponents/Tab.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* tests for SliceHeader
* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeader/SliceHeader.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for ShareMenuItems
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DataTablesPane
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Using factory for props
* replacing "data-test"
* removing "act" from tests and fix error
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* test: prevent flaky unit test case
* Update superset-frontend/spec/javascripts/datasource/ChangeDatasourceModal_spec.jsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* tests for SliceHeaderControls
* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* fix lint error
* Improving accessibility
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* tests for CrossFilterScopingForm
* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingForm/CrossFilterScopingForm.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DisplayQueryButton component
* add factories to props and fetch-mock
* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DisplayQueryButton/DisplayQueryButton.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DatasourceControl
* fix: lint error
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/controls/DatasourceControl/DatasourceControl.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Remove error comment
* replace component data-test
* factory to props
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Tests for DataTableControl
* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/explore/components/DataTableControl/RowCount.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Prep for migration
* Migration for execution id column
* Generate execution ids for alerts and reports
* Change execution id range
* Add execution id to API endpoint
* Add execution id to execution log view
* Change execution id range
* Change execution id to a uuid
* Fix execution id type
* Switch state and exec. id columns
* Change db column to UUIDType
* Python lint
* Fix failing frontend tests
* execution_id -> uuid
* Fix migration head
* lint
* Use celery task id as the execution id
* lint
* lint for real
* Fix tests
* fix(native-filters): improve loading styles for filter component
* round up fractional grid unit
* fix(native-filters): add support for global async queries
* move form item out of default value component
* move default value hook declaration to form
* delete LoadingBox
* added support to configure the default explorer viz
* code review fix
* lint
Co-authored-by: cccs-jc <cccs-jc@cyber.gc.ca>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
* chore(cypress): make the load dashboard test behavior driven
* remove bootstrap usage from controls test, + new utils
* fix save test to not use bootstrap dat
* remove bootstrap usage from the filter test
* fix race condition
* remove bootstrap from url params test
* fix lint
* remove unused const
* add chart specs for the tab test
* attempt removing bootstrap data from tabs tests
* fix cypress async/sync confusion
* remove redundant assertions
* attempt fixing tab test
* attempt fixing tabs test
* cleanup commented code
* better aliases so you can tell what they are in the logs
* remove unused imports
* get the line chart alias before clicking the tab
* simplify getChartGridComponent
* wait for all the charts before force refresh
* fix tabs test
* one more time with the tabs test
* another edit to tabs test
* fix flaky test
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
* Moving DatabaseSelector to a folder
* Tests for DatabaseSelector
* Using factory for props
* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/components/DatabaseSelector/DatabaseSelector.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* apply waitFor and remove act
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* separate out api calls
* add new loading states
* remove consoles
* update tests
* fix types and lint
* make code more robust and add test
* address comments
* address comments
* fix lint
* fix(query): properly select adhoc metrics in orderby
* Throw error when sql is empty
* Allow `metrics` to be None
* Always use alias in orderby for metrics
* Bump table chart version and migrate histogram to typescript
* Fix Histogram without groupby
* Fix Presto birth names test
* Raw records mode should not aggregate
* Create a metric immediately when saved metric is dropped
* Display borders around control boxes when metric or column is dragged
* Fix imports
* Display ghost button
* Rename placeholder to ghostButton
* add custom error pages for 404 and 500 responses
* refactor error page styles into separate template
* move error pages to superset-frontend
* fix whitespace on error pages
* refactor error pages to be generated by jinja
* generate static error pages with webpack