Commit Graph

1698 Commits

Author SHA1 Message Date
Phillip Kelley-Dotson c211f7df8e
refactor: icon to icons in DatasourceEditor (#15240)
* intial commit

* lint

* fix test

* fix lint

* remove console.

* Removing pixel placement override.

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-06-22 15:07:09 -07:00
Michael S. Molina fc1a62b78c
chore: Improves the Select component UI/UX - iteration 2 (#15235) 2021-06-22 16:04:01 -03:00
Grace Guo 5b2eb8d933
Revert "fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)" (#15301)
This reverts commit 408d58f937.
2021-06-22 11:08:29 -07:00
Ben Reinhart ab153e66cc
feat: Synchronously return cached charts (#15157)
* feat: Synchronously return cached charts

* Fix lint issue

* Fix python lint error

* Change getChartDataRequest to return response

* Fix lint errors

* Add test

* explore_json: skip cached data check for forced refresh

Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
2021-06-22 10:00:57 -07:00
Ville Brofeldt cef3dc0b02
fix(native-filters): improve time range filter performance (#15295)
* fix time range default value

* defer time filter rendering to inView event

* avoid double fetching of time ranges

* lint

* move set to resolved promise
2021-06-22 14:38:16 +03:00
simcha90 048609d120
feat(native-filters): Show/Highlight errored/focused status (#15276)
* fix:fix get permission function

* feat: show error status for required filters

* test: fix tests

* refactor: fix CR notes
2021-06-22 14:25:08 +03:00
Ville Brofeldt b28d7eace3
fix(native-filters): default value checkbox in config modal (#15257)
* fix(native-filters): default value checkbox in config modal

* disable checkbox if required

* simplify styling logic

* make default value mandatory if checked

* address comments
2021-06-21 15:58:30 +03:00
Matan Borenkraout 14598d4d5d
chore: add dry false config to CleanWebpackPlugin (#14691) 2021-06-21 10:21:45 +03:00
Phillip Kelley-Dotson cee403212b
initail commit (#15261) 2021-06-19 19:06:10 -07:00
Andrew Bastian 2cf99467fc
chore: Add height/width TrashIcon SVG(18px/18px)-Edit Dataset modal (#14956)
* Add min-height/width TrashIcon SVG(18px/18px)-Edit Dataset modal

* Reworked styling to be inline on SVG component via CSS from `emotion`

* Changed parameter from `css` to 'style'

* Fixed lint error.

* Changed `style` back to `css`

Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
2021-06-18 08:50:11 -07:00
Kamil Gabryjelski c7c63751e9
feat(native-filters): Hide time filters if loaded datasets don't have temporal columns (#15225)
* feat(native-filters): Hide time filters if loaded datasets don't have temporal columns

* Remove "px" suffixes to fix warnings

* Disable an option instead of hiding filter types

* Fix tests

* Add 2 more tests
2021-06-17 16:51:11 +02:00
Michael S. Molina ea8507b4e2
fix: Filter bar not occupying 100% height when filter sets FF unset (#15228) 2021-06-17 16:38:14 +03:00
simcha90 388eb01f06
feat(native-filters): Disable Apply button if filter required (#15222)
* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint

* feat: disable select on missed value

* fix: refactor ff

* feat: connect nulls for line chart

* lint: fix lint

* docs: fix message

* fix: fix CR comments

* fix: fix Collapsed items

* fix: fix Collapsed items
2021-06-17 16:35:33 +03:00
Ville Brofeldt 7237324983
chore: bump superset-ui to 0.17.58 (#15220) 2021-06-17 11:21:27 +03:00
simcha90 fe5381dcb8
fix(native-filters): Fix Select `Default First Value` by clicked `Clear All` (#15219)
* fix:fix get permission function

* fix: fix select first value by clear all

* lint: fix lint
2021-06-17 11:14:21 +03:00
Yaozong Liu e5187a479a
fix(dashboard): fix nested tab (#15134) 2021-06-16 23:31:52 -06:00
Phillip Kelley-Dotson cb10427b1e
fix dataset select list (#15203) 2021-06-16 21:56:40 -06:00
Grace Guo 408d58f937
fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)
* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments
2021-06-16 16:57:31 -07:00
Phillip Kelley-Dotson ca89292faa
refactor: refactor Icon to Icons in sqlEditor component (#14463)
* add triangle-down

* lint fix

* add suggestions
2021-06-16 14:14:36 -06:00
Beto Dealmeida d625f5f111
feat: show rich error messages on past failed queries (#15158)
* feat: store SIP-40 error payload with queries

* Set errors in query on load
2021-06-16 12:58:14 -07:00
Yaozong Liu e689b0d445
fix(dashboard): duplicated toast (#15138) 2021-06-16 21:44:37 +03:00
Geido d578ae9897
feat: Select component (Iteration 1) (#15121)
* Implement initial structure

* Add aria-label

* Rename files

* Refactor single mode new options

* Clean up

* Add select at every corner in storybook

* Clean up

* Add pagination

* Move selected options at the top

* Clean up

* Add license

* Refactor

* Improve pagination

* Fetch when allowNewOptions

* Clean up
2021-06-16 11:05:58 -06:00
Michael S. Molina dafaaaeb28
chore: Changes the dashboard highlight color when selecting a filter (#15192) 2021-06-16 15:45:31 +02:00
Michael S. Molina fc8ad4f984
chore: Makes the refresh button only appear when the filter has a dataset (#15194) 2021-06-16 16:07:23 +03:00
Michael S. Molina 4289929745
chore: Allows the user to force fetch the default values (#15178) 2021-06-16 14:17:34 +03:00
Michael S. Molina 0c22266041
chore: Improves the native filters bar layout (#15115) 2021-06-16 14:17:14 +03:00
Phillip Kelley-Dotson d30f3c8149
fix space (#15175) 2021-06-15 16:16:59 -07:00
Corbin Robb b179863e25
refactor: Convert TableElement to TypeScript (#14978)
* Convert TableElement to typescript

* Change type names to better match naming conventions in other files

* Fix import order and update tests on TableElement

* Remove defaultProps

* Destructure the props

* Use Rest and Spread syntax to condense props destructuring

* Fix TypeScript errors and add comment to explain antd props and types weirdness

* Remove comment, add consistency with other files, and use method chaining to make more concise

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-15 13:29:45 -07:00
Elizabeth Thompson 7dc0cee5be
add another wait for chart element (#15108) 2021-06-15 10:00:36 -07:00
Kamil Gabryjelski 5316dc89a8
fix(dashboard): Prevent rerendering View Query modal on window resize (#15172)
* fix(dashboard): Prevent rerendering View Query modal on window resize

* Fix lint
2021-06-15 13:16:31 +02:00
Matan Borenkraout 53225e8d17
refactor(explore): remove side effect in render from CalendarFrame for DatePicker (#15147) 2021-06-15 13:26:42 +03:00
Ville Brofeldt 9c3c3fa125
feat(native-filters): add optional time col to time range (#15117) 2021-06-15 13:25:28 +03:00
Kamil Gabryjelski 9ba2983f42
chore: Bump plugin-chart-pivot-table to 0.17.57 (#15168)
* chore: Bump plugin-chart-pivot-table to 0.17.57

* Bump other superset-ui packages to 0.17.56

* Fix package-lock
2021-06-15 12:02:40 +02:00
Michael S. Molina b3c197903c
chore: Scrolls top when opening a select filter (#15141) 2021-06-15 10:10:23 +02:00
ʈᵃᵢ 98ec365374
feat(webpack): configure publicPath via ASSET_BASE_URL env var (#15105) 2021-06-14 18:55:58 -06:00
Phillip Kelley-Dotson e2abf59534
feat(Explore): add sort to edit dataset modal (#14872)
* inital commit

* refac

* fix ui issues and sort

* fix lint

* add suggestions

* lint

* add suggestions

* add enum

* add enum to inter
2021-06-14 15:20:22 -07:00
Ajay M 045fa1bc7a
feat(dashboard): Let users download full CSV of a table (#15046)
* - Convert SliceHeader to TSX in progress
- Add menu option to download full CSV. Probably will change it

* Add Download Full CSV feature, and tests

* Added more tests, more TS fixes

* Added feature flag

* Update @superset-ui package versions

* Update @superset-ui packages versions

* use backend config instead of hardcoding number of rows

* Update tests

* front end test fix

* Lint fixes and test fixes
2021-06-14 14:26:18 -07:00
Michael S. Molina 82ad053e50
fix: Filter overlay in dashboard when scrolling (#15140) 2021-06-14 15:34:36 +02:00
Kamil Gabryjelski 3866044938
fix(native-filters): Don't send unnecessary PUT request on dashboard render (#15146)
* fix(native-filters): Don't send unnecessary PUT request on dashboard render

* Run native filters scopes only if feature flag is enabled

* Change action name

* Run native filters scopes only if at least 1 filter added

* Fix lint
2021-06-14 14:33:59 +02:00
gordern 57035c1b93
fix: improve dashboard fullscreen text (#15139) 2021-06-14 17:54:37 +08:00
Yaozong Liu 856a2bd5ed
fix(explore): fix y-axis lower bound 0 value (#15091) 2021-06-13 11:24:39 +08:00
Phillip Kelley-Dotson 8e6a5a6f52
chore: Homepage cleanup (#14823)
* initial commit

* update welcome

* fix lint

* add enum

* more choring

* fix lint

* redo logic for api stick api calls

* fix test

* fix chart test

* lint fix and remove unused code

* fix flicker and add suggestions

* lint

* fix test

* add suggestions

* add suggestions and fix test

* revert packagelock

* fix space
2021-06-11 18:47:42 -07:00
Beto Dealmeida 53df152362
feat: show spinner on exports (#15107)
* feat: show spinner on exports

* Set cookie only if token is passed

* Use iframe

* Small fixes

* Fix lint

* Remove stale test

* Add explicit type
2021-06-11 17:25:00 -07:00
Kamil Gabryjelski ff2d5888d9
feat(native-filters): Defer loading filters data until filter is visible (#15120)
* feat(native-filters): Defer running query until native filter is in view

* Fix default values not displaying
2021-06-11 11:10:16 -07:00
Kamil Gabryjelski 51f0d4fd98
feat(native-filters): Hide filters which don't affect any visible charts (#15063)
* feat(native-filters): Hide filters which don't affect any visible charts

* Fix lint errors

* Add comments

* Code review fix

* Fix tests

* Refactor logic in FilterControls
2021-06-11 13:41:08 +02:00
Ville Brofeldt 5e825cf063
fix(native-filters): handle descending sorting correctly (#15112) 2021-06-11 11:44:16 +03:00
Kamil Gabryjelski 3456dd571c
fix(native-filters): fix Select filter crashing when changing filter type (#15090) 2021-06-10 18:11:31 -06:00
Ajay M f8b270d419
fix(explore): Explore page boolean filter is broken for Presto DB (#14952)
* Front end update - modify OPERATORS, to have SQL operation and display value

* Updated tests

* More tests

* Remove OPERATOR imports

* Fix break tests

* PR comments

* fix issue with comparator loading

* rename a variable

* Linting
2021-06-10 09:08:04 -07:00
Ville Brofeldt c0eff8faf6
fix(native-filters): empty label indicator (#15084) 2021-06-10 16:56:55 +03:00
Ville Brofeldt 6c9f15a6e4
fix(native-filters): show error if default value query failed (#15005)
* fix(native-filters): show error if query failed

* address comments
2021-06-10 16:56:31 +03:00
Michael S. Molina 1468026883
chore: Improves the native filters UI/UX - iteration 7 (#15017) 2021-06-10 15:24:00 +03:00
Ville Brofeldt 8aaa6036d7
fix(native-filters): remove hard-coded default time range (#15015)
* fix(native-filters): use default for time range from explore

* fix tests
2021-06-10 14:49:37 +03:00
Ville Brofeldt 65714cc201
fix(dnd): add isExtra prop to Option (#15080) 2021-06-10 12:13:20 +03:00
Yongjie Zhao 834bb9409d
fix(datasets): consistent dataset list (#15014) 2021-06-10 10:05:33 +08:00
Erik Ritter e8414dfb52
fix: disappearing tooltips on dashboards (#15073) 2021-06-09 18:41:40 -07:00
Beto Dealmeida 4d24d4dc9a
fix: confirm overwrite and password on import (#15056)
* fix: confirm overwrite and password on import

* Add tests
2021-06-09 18:05:31 -07:00
Beto Dealmeida 1db92cc13a
feat: spinner for imports (#15055)
* Update tests

* feat: spinner for imports

* Use loading button instead

* Small fixes

* Small fix
2021-06-09 16:14:49 -07:00
AAfghahi 2d3f552b51
adding fetching to query status (#15064) 2021-06-09 16:11:49 -07:00
Beto Dealmeida 256e1452fe
feat: style import button (#15057)
* feat: style import button

* Update tests

* Update test
2021-06-09 15:40:53 -07:00
Elizabeth Thompson 0c470feaef
move metric parsing to state instantiation (#15069) 2021-06-09 14:54:25 -07:00
ʈᵃᵢ 821519fcfa
build(webpack): use [contenthash] instead of [chunkhash] (#14942) 2021-06-09 13:59:17 -06:00
Beto Dealmeida 3f527c7a45
fix: font regression in SQL Lab (#14960)
* fix: font regression in SQL Lab

* Fix tests
2021-06-08 15:52:57 -07:00
Lyndsi Kay Williams 6cc179b7bf
close icon aligned (#14870) 2021-06-08 13:10:13 -04:00
Lyndsi Kay Williams 94c86c3837
Centered down-arrow icons in top navbar (#14846) 2021-06-08 13:09:35 -04:00
Michael S. Molina 1af91ed756
fix: Adds left padding to dashboard edit mode when filter bar is closed (#15024) 2021-06-08 15:58:15 +03:00
Ville Brofeldt efd7007701
fix(native-filters): show overridden chart name on scoping tree (#15038) 2021-06-08 14:55:11 +03:00
Kamil Gabryjelski 0e07a5ca03
fix(explore): Datepicker glitch on hover outside the modal (#15033) 2021-06-08 07:46:09 +02:00
Geido a1ca0b2e6b
Add ming-height to empty tab (#14878) 2021-06-07 22:55:16 -06:00
Geido 12fcb3132c
Remove nowrap (#14954) 2021-06-07 22:50:05 -06:00
Elizabeth Thompson 21aa3daae3
display all metric results in editor (#15031) 2021-06-07 19:12:56 -07:00
David Aaron Suddjian cf15fe0d03
fix(dashboard): custom css should be removed on unmount (#15025)
* fix(dashboard): custom css should be removed on unmount

* better comment

* remove unnecessary typecast

* move type to top level scope
2021-06-07 14:04:56 -07:00
Ville Brofeldt 422c32cb7d
feat(filter-box): hide druid options if druid not enabled (#14921)
* feat(filter-box): hide druid options if druid not enabled

* add bootstrap export
2021-06-07 13:49:56 -06:00
AAfghahi 7f4e036433
fix: adding additional configs and colors for queryHistory (#14995)
* added additional configs and colors for queryHistory

* added condition to status icon

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx
2021-06-07 14:10:28 -04:00
Maxime Beauchemin 8798da41a7
chore: rename 'Source' to 'Database' for consistency (#15021) 2021-06-07 10:34:52 -07:00
Ville Brofeldt de1b140617
chore(ci): fix ci conflict (#15016) 2021-06-07 18:27:54 +03:00
Ville Brofeldt d2a6e8cd20
fix(native-filters): avoid double load on initialization (#15012) 2021-06-07 13:47:02 +03:00
simcha90 1fc08523af
feat(native-filters): Support default to first value in select filter (#14869)
* fix:fix get permission function

* feat: add async filters support

* revert: revert ff

* feat: add async filters support

* fix: merge with master

* fix: remove tests

* lint: fix lint

* fix: fix CR notes

* fix: fix with master

* test: fix tests

* refactor: update logic for default first value

* fix: get requiredFirst

* fix: support instant

* docs: update text

* docs: fix comments

* docs: update texts
2021-06-07 13:41:19 +03:00
Yongjie Zhao c8cf4b6bbf
fix: toggle fullscreen on the dashboard (#14979) 2021-06-04 22:24:57 +08:00
Ville Brofeldt 355223d3fe
feat(native-filters): add markers and number formatter + simple tests (#14981) 2021-06-04 16:22:54 +03:00
Kamil Gabryjelski 8c01c13d90
fix(native-filters): Fix "undefined" error after editing a filter (#14984)
* fix(native-filters): Fix "undefined" error after editing a filter

* Remove console log
2021-06-04 15:15:37 +02:00
Ville Brofeldt 6955ed287b
fix(native-filters): remove implied fetch predicate (#14982) 2021-06-04 13:45:53 +03:00
Ville Brofeldt 61a438a0cd
fix(native-filters): update cascaded filter state on change (#14980) 2021-06-04 14:01:44 +08:00
Ville Brofeldt 20b86f81e7
fix(filter box): replace freeform where clause with ilike (#14900) 2021-06-04 06:43:07 +03:00
Corbin Robb 004a6d9e54
refactor: Convert TableElement.jsx component from class to functional with hooks (#14830)
* Change TableElement from a class component to a functional component

* Replace class state checks in TableElement_spec.jsx with checks testing elements they change

* Refactor small bit of logic to use optional chaining

* Add optional chaining to some logic

* Fix IconTooltip and add IconTooltip to the collapse button

* Fix custom icon using IconToolTip so it better matches the original

* Update collapse/expand icon to use Icons component instead of importing from antdesign directly

* Fix eslint errors

* Clean up some code for readability

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-06-03 16:04:56 -07:00
cccs-jc f652908a70
fix: renamed sqllab filters to _filters (#14971) 2021-06-03 21:22:50 +03:00
Ville Brofeldt 765e9dd932
feat(native-filters): apply cascading without instant filtering (#14966) 2021-06-03 17:48:46 +03:00
Ville Brofeldt 78d30896f3
chore: bump superset-ui to 0.17.53 (#14968) 2021-06-03 16:37:42 +03:00
Ville Brofeldt f94c6d2763
fix(native-filters): cascading filters not rendering in tab (#14964) 2021-06-03 12:04:23 +03:00
Yongjie Zhao e6bc7c99e7
feat: add type_generic and is_dttm to table metadata (#14863) 2021-06-03 08:20:47 +08:00
AAfghahi 53505c2acb
additional safeguard (#14953) 2021-06-02 12:02:22 -07:00
Kamil Gabryjelski 405f95b6af
feat(dashboard/native-filters): Hide filters out of scope of current tab (#14933)
* Optimize finding charts and tabs in scope

* Put filters out of scope in Collapse

* Use lastFocusedTabId instead of directPathToChild

* Fix tests

* Fix cypress test

* Uncomment e2e test
2021-06-02 20:38:18 +02:00
Michael S. Molina b6f00e69e1
chore: Improves the native filters UI/UX - iteration 6 (#14932) 2021-06-02 09:03:13 +03:00
Lyndsi Kay Williams 06945ccbcf
feat: Icon Button (#14818)
* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
2021-06-01 20:47:42 -07:00
Elizabeth Thompson 8cc97e4790
feat: validation db modal (#14832)
* split db modal file

* hook up available databases

* use new validation component
2021-06-01 18:18:17 -04:00
AAfghahi fac6b7c207
fix: Remove Icon and align close button on DatasetModal (#14902)
* aligned DatabaseModal header

* revisions
2021-06-01 14:53:59 -04:00
AAfghahi eced510708
fix: Query History cosmetic issues (#14885)
* easiest fix

* Query History Cosmetic Issues

* added revisions

* beto revisions
2021-06-01 14:53:12 -04:00
cccs-jc eef489c667
feat: add support for filters in sqlLab (#14765) 2021-06-01 21:23:51 +03:00
Ville Brofeldt 66282c3313
chore: customize adhoc filter icon and fix creatable label (#14896)
* chore: customize adhoc filter icon and fix creatable label

* use common icon component

* simplify code
2021-05-31 09:45:12 +03:00
simcha90 e43112c5f9
feat(native-filter): Hide native filters (#14784)
* fix:fix get permission function

* feat: support showFilters

* fix: fix CR notes

* fix: fix lint issues
2021-05-31 09:05:57 +03:00
simcha90 50c5dcbb0a
test(native-filters): add test for Select filter (#14919)
* fix:fix get permission function

* test: tests for select filter
2021-05-31 09:02:46 +03:00