Commit Graph

6502 Commits

Author SHA1 Message Date
dependabot[bot]
230c0c2357
build(deps-dev): bump storybook-addon-paddings in /superset-frontend (#12192)
Bumps [storybook-addon-paddings](https://github.com/rbardini/storybook-addon-paddings) from 2.0.2 to 3.2.0.
- [Release notes](https://github.com/rbardini/storybook-addon-paddings/releases)
- [Commits](https://github.com/rbardini/storybook-addon-paddings/compare/v2.0.2...v3.2.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-05 15:08:37 -08:00
Hugh A. Miles II
95f0ead8eb
fix: SaveDatasetModal save state on back button (#12205) 2021-01-05 15:07:23 -08:00
Daniel Vaz Gaspar
673dea76f1
docs: fix build status badge to github actions (#12251) 2021-01-05 13:48:09 +00:00
Victor Malai
d4a854e84b
fix : Style caret for profile page (#12215)
* Add flex to panel

* Remove hover effect, remove undeline

* FIx lint
2021-01-04 23:31:52 -08:00
Kamil Gabryjelski
d204b024b7
Set datasource panel open by default (#12211) 2021-01-04 22:41:50 -08:00
Ville Brofeldt
8afc4c4a44
fix(explore): bump superset-ui to 0.16.3 and fix DeckGL bug (#12242) 2021-01-04 22:01:09 -08:00
Yongjie Zhao
b349edef29
feat(explore): Time picker enhancement follow up (#12208)
* refactor layout

* WIP

* fix typing

* styling

* fix lint

* frontend IT

* rename variable

* added quarter

* typos

* refine code structure
2021-01-04 18:29:17 -08:00
Kamil Gabryjelski
811e1b273b
fix: Altered button crashing and title not updating on Explore view (#11960)
* Fix chart name not updating

* Fix AlteredSliceTag crashing

* Update name after it's changed in another modal
2021-01-04 16:14:06 -08:00
Victor Malai
8ecf82de5a
Remove uppercase for tab names (#12217) 2021-01-04 14:58:45 -08:00
dependabot[bot]
95296df507
build(deps): bump node-fetch in /.github/actions/file-changes-action (#12248)
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-04 14:40:01 -08:00
dependabot[bot]
e853c16a3d
build(deps): bump @actions/core in /.github/actions/file-changes-action (#12246)
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.2.4 to 1.2.6.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-01-04 14:08:53 -08:00
Rob DiCiuccio
62e7706035
docs(api): Script to generate API docs (openapi.json) (#12050)
* update_api_docs CLI command for regenerating openapi.json

* Fix /api/v1/async_events spec

* Regenerate openapi.json (docs)

* Pylint fixes
2021-01-04 13:47:01 -08:00
Hugh A. Miles II
7d88e6b891
fix: Change Datasource styling fixes (#12165) 2021-01-04 14:51:15 -05:00
Beto Dealmeida
164db3e5a1
fix: CTAS on multiple statements (#12188)
* WIP

* Add unit tests for sql_parse

* Add unit tests for sql_lab
2021-01-04 09:22:35 -08:00
Lily Kuang
ff0fe434e4
feat(report): add/edit modal improvements (#12183)
* alert/report modal improvements

* update spec for alert report modal
2021-01-04 09:15:55 -08:00
Jesse Yang
a3bbbf8ea3
build: inline external Github Actions to unblock CI (#12241)
* build: inline cached-dependencies to unblock CI

* Run E2E on pull_request on;y

* Inline all external actions

* Checkout needed for internal actions

Also fixes pre-commit

* Add missing files
2021-01-04 14:16:07 +02:00
Kamil Gabryjelski
7cc0de1694
Refetch samples only when filters change (#11999) 2021-01-01 16:08:19 -08:00
Kamil Gabryjelski
f3ab1f41ee
feat: Implement drag & drop for metrics and filters labels (#12184) 2020-12-24 20:46:37 -08:00
Daniel Vaz Gaspar
74f3faf1cd
fix(reports): make name unique between alerts and reports (#12196)
* fix(reports): make name unique between alerts and reports

* add missing migration

* make it work for mySQL and PG only (yet)

* fixing sqlite crazy unique drop

* fixing sqlite missing one col
2020-12-24 09:18:46 +00:00
Victor Malai
b75a1ec71e
fix: align submenu items (#12193) 2020-12-23 16:58:55 -08:00
Beto Dealmeida
3acfd826de
feat: add new dashboard with FCC data (#12163) 2020-12-23 14:54:50 -08:00
ʈᵃᵢ
3fb4e54690
fix(alerts/reports): ensure correct type is sent to api (#12189)
* fix(alerts/reports): ensure correct type is sent to api

* fix: chane actions labels to generic Edit/Delete

* fix: ts-ignore

* fix: add more dependencies to callback functions

* fix: remove duplicate api calls when toggling between types

* lint
2020-12-23 12:38:11 +00:00
Daniel Vaz Gaspar
e5e9a5f05c
docs: update UPDATING.md with security simplification info (#12097)
* docs: update UPDATING.md with security simplification info

* update docs better readability
2020-12-23 12:24:59 +00:00
Daniel Vaz Gaspar
09a381da1d
fix(reports): notification without standalone link back to superset (#12174)
* fix(reports): notification without standalone link back to superset

* fix comment
2020-12-23 11:31:08 +00:00
Jagadish
732d1ed40b
updated SQLAlchemy=1.3.21 is incompatible in setup.py file. (#12191) 2020-12-23 13:23:29 +02:00
Agata Stawarz
4ac00a0954
fix(chart): rendering standalone chart and errors (#12179) 2020-12-23 11:06:08 +00:00
Agata Stawarz
93af329078
chore: Add Loading icon to Filter Bar (#12158)
* Add Loading icon to Filter Bar

* Change Loading Box height to gridUnits
2020-12-22 18:19:18 -08:00
Jesse Yang
d2da25a621
refactor: remove queryFields in QueryObject and update chart control configs (#12091)
* Clean up queryFields

* Clean up unused vars

* Bump chart plugins

* Bringing changes in #12147
2020-12-22 17:10:19 -08:00
Beto Dealmeida
de61859e98
fix: SQL Lab vertical space (#12187) 2020-12-22 17:05:52 -08:00
Beto Dealmeida
ca680cf976
fix: append ID to filename when exporting chart (#12166) 2020-12-22 14:19:05 -08:00
Beto Dealmeida
a85bb4a3f2
fix: remove uniqueness for MySQL (#12185) 2020-12-22 13:39:56 -08:00
Beto Dealmeida
8e3f71df4d
fix: specify VARCHAR size when loading examples (#12186) 2020-12-22 13:39:40 -08:00
Ville Brofeldt
41fac6b0d9
fix(explore): save chart not working (#12178)
* fix(explore): save to dashboard not working

* fix test
2020-12-22 23:18:36 +02:00
Nikola Gigić
a52031a55e
chore: Change chart_is_fav to chart_is_favorite (#12075)
* Change chart_is_fav to chart_is_favorite

* Trigger cypress tests

* Retrigger cypress tests

* Retrigger all tests

* Dashboard

* Additions
2020-12-22 10:03:26 -08:00
Victor Malai
9b110b2aa5
refactor: Refresh interval typescript (#12168)
* Refresh interval

* WIP
2020-12-22 09:55:42 -08:00
Beto Dealmeida
c281e52f81
feat: add new dashboard with video game sales (#12162) 2020-12-22 08:53:18 -08:00
Agata Stawarz
942e3210b5
Fix Filter Bar scrolling (#12156) 2020-12-22 12:09:13 +02:00
Michael S. Molina
8682c6fc1c
refactor: Fix anchor-is-valid lint warnings (#12010)
* Fix anchor-is-valid lint warnings

* Change IconTooltip to use named exports
2020-12-21 23:58:05 -08:00
Jesse Yang
e2f676445b
test(dashboard): fix flaky Cypress test (#12151) 2020-12-21 20:40:33 -08:00
Beto Dealmeida
ce1abc98df
chore: rename variable for clarity (#12159) 2020-12-21 13:39:13 -08:00
Daniel Vaz Gaspar
2f0add3aec
fix: database alpha permissions (#12136)
* fix: database alpha permissions

* add test
2020-12-21 19:17:58 +00:00
Daniel Vaz Gaspar
8d5dcc5784
fix(report): fix last_eval_dttm sort and more tests (#12121)
* fix(report): fix last_eval_dttm sort and more tests

* remove unnecessary permissions and split code path

* remove SIP_34_ALERTS_UI

* disabling an alert that is working will turn it to not triggered
2020-12-21 19:07:30 +00:00
Agata Stawarz
17769ca96e
Fix Reset All filters button (#12157) 2020-12-21 20:11:39 +02:00
Victor Malai
eecdd20301
refactor: Explore SaveModal to typescript (#11997)
* Explore SaveModal to typescript

* Fix test

* Fix

* Fix lint

* update SaveModal without any type

* Update

* Fix lint

* Fix lint

* Fix test

* Fix

* Fix

* Fix lint

* Refactor

* Fix
2020-12-21 08:56:36 -08:00
Lily Kuang
0d9c863b6e
fix(report): fix start date format and paginated query (#12132)
* fix: start date format for executation log

* fix: paginated query
2020-12-21 13:01:47 +00:00
ʈᵃᵢ
ba952ba39d
fix(database): adjust column sizing for list view (#12146) 2020-12-20 21:26:20 -08:00
David Aaron Suddjian
b5dd0f32cc
feat: Dynamically imported viz plugins (#10288)
* first attempts at dynamic plugin loading

* dynamic import working for explore

* memoize appropriately

* add a backend for dynamic plugins

* hack at getting dynamic plugins working with dashboards

* more work on making it work, + feature flag

* lint

* actions to fix explore state when plugins load

* handle dynamic control panel, functionify ExploreViewContainer

* fix: rearrange migrations branch

* fix: name and key as strings with length 50

* bundle url length 2000

* bundle url to text
for some reason not supported on my sql

* fix: too long varchart

* fix: pre-commit typing

* fix: licenses

* fix: add slice container was not initing feature flags

* fix: undo linting issue

* fix: adjust down revision again

* fix: adjust down revision again

* isort

* pylint

* god damn linters

* remove unnecessary(?) loading message

* only log non-standard errors

* testing

* python is terrible

* see above commit message

* fix imports in DynamicPluginProvider

* fix

* shift migration forward

* lint

* fix form data calculations to handle missing control config

* temp commit - waiting for superset-ui changes and crud fixes

* remove unnecessary todo

* use new superset-ui shared module function

* fetch the plugins instead of hardcoding the test one

* migration sort

* remove duplicated import statement

* format

* try moving the import 🙄

* copy

* fix frontend tests

* safe access

* comment out dead code

* isort

* disable pylint on necessary lines

* use @superset-ui/logging instead of console

* remove temp code

* rearrange some code

* try triggering mouseover in cypress before click

* use loading spinner instead of text

* trying to fix cypress

* attempt cypress fix

* customize permissions

* update package lock

* only admins can write to plugins by default

* better copy

* disable flaky tests

* use makeApi

* flaky tests

* cleanup code

* flaaaakkkyyyyyy

* dry

Co-authored-by: amitNielsen <amit.miran@nielsen.com>
2020-12-19 07:06:11 -08:00
Evan Rusackas
4a471b8c71
feat: Native filters fast-follow (#12138)
* wip: filter create modal

* add a feature flag

* automatic changes to package lock

* wip

* filter sidebar and basic state management

* move create button to the sidebar

* first step for edit filterconfig

* partially fix tests...

* edits to types and comments

* respect feature flag on the filter sidebar

* add filterconfig form

* get input state working

* feat: tree filter scopes UI

* fix: turn on flag

* sticky filter bar

* stop preferring default export

* feat: finish filter scoping

* fix: under toggle

* fix: title

* fix: add licence

* refactor: update TS

* fix: fix on reopen modal + validation

* new filter bar menu

* adding, but commenting out, bulk scoping action

* adding some placeholder buttons and styles therefor

* feat: add filter chart

* add relative path to package.json

* update modal

* a little input styling... just getting warmed up

* Revert "feat: add filter chart"

This reverts commit b1302d35b6.

* Revert "add relative path to package.json"

This reverts commit 26a7b40e18.

* https package lock idk

* feat: add filter chart

* add relative path to package.json

* flexboxes all the way down

* dynamically generate groupby and datasource in select control

* big wip

* fix target column name

* no importing nonexistent things

* styles and name editing

* Add hook for retrieval of all filter states

* start with a new filter when clicking add filter

* handle removed filters gracefully

* fix incorrect default filter configuration

* add fields to useAllFilterState

* add redux for filterconfigs

* add support for native_filters

* remove consoles

* improve filter removal

* unbreak infinite loop

* basic sidebar toggling working!

* collapsing and menu working more smoothly

* linting

* make dataset and column inputs work

* save filter values properly

* add dashboard event for filter updates

* guarded

* apply filters properly

* fix schema

* making New Filter button a link

* gridunits ftw

* centering modal

* tis not a button anymore! nixing type.

* plus and collapse buttons instead of "more" menu

* updating full size filter icons

* adding icons to filter collapsing/expanding

* turning off animation, but leaving class-based animation css

* fix linting error

* fix native filters for legacy charts

* updates test

* no individual apply buttons

* fix bugs with filter config modal

* remove redundant code

* switch to the filter with validation errors on submit

* separate form validation

* switch config button from add to edit

* switch to the filter with validation errors on submit

* separate form validation

* switch config button from add to edit

* update tests

* oops forgot to add the fancy new useChangeEffect hook

* comments and code reorganization

* rename native_filters to extr_form_data and move hook

* disable native filters in viz selector

* add cascading

* implement new extra form data api

* cleanup

* updates tests

* bump npm packages

* fix bad merge on package.json + lock

* lint

* replace in and not in with uppercase

* lint

* lint

* lint

* lint

* bulk test fix

* Sort select input alphabetically

* Change type for sorting elements

* sleeker filter removal UX

* fix rest of unit tests

* make filter operators all uppercase

* Hide Filter bar when there are no filters

* Show edit button for dashboard owners only

* Add visible argument to filters toggle function to avoid future regression

* Improve Toggle filters bar function

* lint

* fix js lint + set createNewOnOpen

* Handle setting extra form data in Filter Bar instead of Filter Control

* Add Handle apply filter function to Apply button

* Allow applying changes instantly

* Fix types

* remove console logs

* fix package

* Add Error Boundary component to Filter bar and Filter Config Modal

* fix jest tests

* update native filters tests to pass

* reset cypress baseUrl

* remove unnecessary field

* Add Parent Filter input field to Config Modal

* Create Cascade Filter & display children filters

* Add Cascade Popover

* Display Filter value both in Filter Bar and in Cascade Popover

* Display the youngest filter value label in the Filter bar

* Add styles to Cascade Popover and filters

* Force to apply changes instantly for parent filters and refactor styles

* Show error for no cyclical hierarchy and refactor

* Add validation for parent filter to be applied instantly

* Add Error Boundary to Filter Config Modal

* cleanup: remove unused state fields

* move unrelated types to an appropriate location

* remove misplaced resource fetch error logic

* fix cascadeParentIds error

* fix cypress password

* initial attempt at fixing scope issue

* fix bad merge

* fix lint

* trying out makeApi for saving filters

* remove unused import

* fix test

* silence bad test

* Improve styling of Filter Config Modal

* Improve styles for whole native filters feature

* Add styles for active filter tab

* Fix text for scoping

* Clean up Filter Bar and Config Modal styles

* Remove fractional gridUnits. Change name for CheckboxFormItem. Add placeholder to Parent Filter select.

* Remove unnecessary button size for Config Modal

* add native-filter feat flag config

* oops fix here

* remove space

* Update superset-frontend/src/common/components/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* Add Cache Wrapper helper to avoid datasets requests deduplication

* Add license to new Cache Wrapper helper

* Add Cache Wrapper tests

* Fix expanding Filter Bar

* use styledMount in tests

* comment

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigurationLink.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* address PR feedback

* fix package lock

* null guards

* Fix charts resizing

* removing emotion/react and going old school on css animation

* fxing css glitch on scoping disclaimer

* src paths.

* using gridUnits

* nixing unnecessary diamonds

* linting

* fix type errors

* Inverting collapsed icons... closer to data src selector design

* restoring feature flag to proper default setting

* missing condition

* fix tests

* patching test

* just a button

* flaky tests

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Simcha Shats <simcha.shats@nielsen.com>
Co-authored-by: amitNielsen <amit.miran@nielsen.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-19 01:57:06 -08:00
ʈᵃᵢ
de047c6c31
fix(chart): replace viz_type with viz name from registry for list view (#12144) 2020-12-18 23:22:47 -08:00
Phillip Kelley-Dotson
585c8acd75
fix height (#12145) 2020-12-18 22:33:40 -08:00