pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix(report): fix start date format and paginated query (#12132) 

* fix: start date format for executation log

* fix: paginated query
This commit is contained in:
Lily Kuang 2020-12-21 05:01:47 -08:00 committed by GitHub
parent ba952ba39d
commit 0d9c863b6e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
View File

@ -33,6 +33,8 @@ import Owner from 'src/types/Owner';
import { AlertReportCronScheduler } from './components/AlertReportCronScheduler';
import { AlertObject, Operator, Recipient, MetaObject } from './types';
const SELECT_PAGE_SIZE = 2000; // temporary fix for paginated query
type SelectValue = {
value: string;
label: string;
@ -616,7 +618,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
// Fetch data to populate form dropdowns
const loadOwnerOptions = (input = '') => {
const query = rison.encode({ filter: input });
const query = rison.encode({ filter: input, page_size: SELECT_PAGE_SIZE });
return SupersetClient.get({
endpoint: `/api/v1/report/related/owners?q=${query}`,
}).then(
@ -633,7 +635,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
};
const loadSourceOptions = (input = '') => {
const query = rison.encode({ filter: input });
const query = rison.encode({ filter: input, page_size: SELECT_PAGE_SIZE });
return SupersetClient.get({
endpoint: `/api/v1/report/related/database?q=${query}`,
}).then(
@ -682,7 +684,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
};
const loadDashboardOptions = (input = '') => {
const query = rison.encode({ filter: input });
const query = rison.encode({ filter: input, page_size: SELECT_PAGE_SIZE });
return SupersetClient.get({
endpoint: `/api/v1/report/related/dashboard?q=${query}`,
}).then(
@ -731,7 +733,7 @@ const AlertReportModal: FunctionComponent<AlertReportModalProps> = ({
};
const loadChartOptions = (input = '') => {
const query = rison.encode({ filter: input });
const query = rison.encode({ filter: input, page_size: SELECT_PAGE_SIZE });
return SupersetClient.get({
endpoint: `/api/v1/report/related/chart?q=${query}`,
}).then(

2
superset-frontend/src/views/CRUD/alert/ExecutionLog.tsx
View File

@ -104,7 +104,7 @@ function ExecutionLog({ addDangerToast, isReportEnabled }: ExecutionLogProps) {
row: {
original: { start_dttm: startDttm },
},
}: any) => moment(new Date(startDttm)).format('ll'),
}: any) => moment(new Date(startDttm)).format('MM/DD/YYYY hh:mm:ss a'),
Header: t('Start At'),
accessor: 'start_dttm',
},