pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

chore: Change chart_is_fav to chart_is_favorite (#12075) 

* Change chart_is_fav to chart_is_favorite

* Trigger cypress tests

* Retrigger cypress tests

* Retrigger all tests

* Dashboard

* Additions
This commit is contained in:
Nikola Gigić 2020-12-22 19:03:26 +01:00 committed by GitHub
parent 9b110b2aa5
commit a52031a55e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/cypress-base/cypress/integration/dashboard/controls.test.js
View File

@ -79,7 +79,7 @@ describe('Dashboard top-level controls', () => {
'ant-dropdown-menu-item-disabled',
);
// wait all charts force refreshed
// wait all charts force refreshed.
cy.wait(aliases, { responseTimeout: 15000 }).then(xhrs => {
xhrs.forEach(async xhr => {
const responseBody = await readResponseBlob(xhr.response.body);

8
superset-frontend/src/components/ListView/types.ts
View File

@ -56,8 +56,8 @@ type FilterOperator =
| 'chart_all_text'
| 'dataset_is_null_or_empty'
| 'between'
| 'dashboard_is_fav'
| 'chart_is_fav';
| 'dashboard_is_favorite'
| 'chart_is_favorite';
export interface Filter {
Header: ReactNode;
@ -123,6 +123,6 @@ export enum FilterOperators {
chartAllText = 'chart_all_text',
datasetIsNullOrEmpty = 'dataset_is_null_or_empty',
between = 'between',
dashboardIsFav = 'dashboard_is_fav',
chartIsFav = 'chart_is_fav',
dashboardIsFav = 'dashboard_is_favorite',
chartIsFav = 'chart_is_favorite',
}

2
superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
View File

@ -92,7 +92,7 @@ function ChartTable({
} else {
filters.push({
id: 'id',
operator: 'chart_is_fav',
operator: 'chart_is_favorite',
value: true,
});
}

2
superset-frontend/src/views/CRUD/welcome/DashboardTable.tsx
View File

@ -99,7 +99,7 @@ function DashboardTable({
} else {
filters.push({
id: 'id',
operator: 'dashboard_is_fav',
operator: 'dashboard_is_favorite',
value: true,
});
}

2
superset/charts/filters.py
View File

@ -50,7 +50,7 @@ class ChartFavoriteFilter(BaseFavoriteFilter): # pylint: disable=too-few-public
Custom filter for the GET list that filters all charts that a user has favored
"""
arg_name = "chart_is_fav"
arg_name = "chart_is_favorite"
class_name = "slice"
model = Slice

2
superset/dashboards/filters.py
View File

@ -51,7 +51,7 @@ class DashboardFavoriteFilter(
Custom filter for the GET list that filters all dashboards that a user has favored
"""
arg_name = "dashboard_is_fav"
arg_name = "dashboard_is_favorite"
class_name = "Dashboard"
model = Dashboard

2
tests/charts/api_tests.py
View File

@ -923,7 +923,7 @@ class TestChartApi(SupersetTestCase, ApiOwnersTestCaseMixin):
)
arguments = {
"filters": [{"col": "id", "opr": "chart_is_fav", "value": True}],
"filters": [{"col": "id", "opr": "chart_is_favorite", "value": True}],
"order_column": "slice_name",
"order_direction": "asc",
"keys": ["none"],

4
tests/dashboards/api_tests.py
View File

@ -368,7 +368,7 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin):
)
arguments = {
"filters": [{"col": "id", "opr": "dashboard_is_fav", "value": True}],
"filters": [{"col": "id", "opr": "dashboard_is_favorite", "value": True}],
"order_column": "dashboard_title",
"order_direction": "asc",
"keys": ["none"],
@ -431,7 +431,7 @@ class TestDashboardApi(SupersetTestCase, ApiOwnersTestCaseMixin):
.all()
)
arguments = {
"filters": [{"col": "id", "opr": "dashboard_is_fav", "value": False}],
"filters": [{"col": "id", "opr": "dashboard_is_favorite", "value": False}],
"order_column": "dashboard_title",
"order_direction": "asc",
"keys": ["none"],