Commit Graph

504 Commits

Author SHA1 Message Date
ʈᵃᵢ
bc0fc4ea25
fix: SubMenu css (#10682) 2020-08-26 14:00:20 -07:00
Evan Rusackas
a95e5c9327
fix: layout flexiness (#10681) 2020-08-26 09:49:58 -07:00
Evan Rusackas
4b40d44b5c
style: Fancier menus, more SIP-34-ish (#10423)
* style: shinier menus

* fixing mouseover glitch

* unused import

* rm emotion-reset

* restoring default config values

* lint fixes 

* a bit more pizzaz to the underlines (max's idea), fading active background

* simplifying navtitle -> label

* RBNavDropdown  -> ReactBootstrapNavDropdown

* nixing whitespace

* replacing !importants with better selector specificity

* moving Menu LESS into Emotion

* no more border!

* fixing border issue

* language picker, account dropdown now use new dropdown component

* nixing whitespace in comment

* nixing duplicate styling

* removing borders on FAB navbar

* explicit font coloring

* linting
2020-08-24 23:16:44 -07:00
Evan Rusackas
fdfb7cdfd2
Eslint error cleanup (#10657)
* moving two console errors to logger errors

* nixing unused map index

* nixing unused param

* linting

* changing an alert to a toast

* fixing tests

* lint fix

* one letter change, just to see if iti gets CI to pass this test.
2020-08-24 14:04:27 -07:00
auxten
0f44d3edf2
Fix add chart page frontend i18n issue (#9321) 2020-08-22 21:04:18 +03:00
ʈᵃᵢ
45fee60b62
fix: remove FAB rendered menu in favor of react based one (#10401) 2020-08-21 17:19:00 -07:00
Grace Guo
aa8ff8759c
feat: use shorten url in standalone iframe (#10651) 2020-08-21 15:27:15 -07:00
ʈᵃᵢ
b86c0e5727
feat(listview): skeleton loading states for table and card collections (#10606) 2020-08-21 10:32:37 -07:00
Evan Rusackas
878f06d133
feat: Getting fancier with Storybook (#10647)
* Niftier paddings

* upgrading storybook, fixing glob pattern

* moving a couple storybook dependencies to dev dependencies

* fixing annoying lint issue about dev dependencies needing to be dependencies

* adds essential addons, fixes backgrounds

* newline tweaks

* comment about no-extraneous-dependencies, higher specificity on that rule, other linting stuff

* a *python* linter doesn't like this whitespace?!

* putting the linespace back

* ugh, found the space causing CI issues... I think
2020-08-20 22:41:25 -07:00
Erik Ritter
cb1989a4fd
feat: bump superset-ui for certified tag (#10650) 2020-08-20 16:56:18 -07:00
ʈᵃᵢ
7301a363c1
feat: setup react page with submenu for datasources listview (#10642) 2020-08-20 11:42:17 -07:00
Erik Ritter
38da552a57
feat: add certification to metrics (#10630) 2020-08-19 20:45:33 -07:00
Ville Brofeldt
5136c5c16e
feat(viz-plugins): add date formatting to pivot-table (#10637)
* feat: make pivot table dates formattable

* Bump npm packages
2020-08-19 23:55:59 +03:00
Evan Rusackas
84d08cb8da
fix: controls scroll issue (#10644) 2020-08-19 13:19:40 -07:00
Evan Rusackas
b0380befa1
feat: Allow tests files in /src (plus Label component tests) (#10634)
* allow tests in jest confg

* sample stories for Label component

* passing tests

* stories to tsx!

* excluding knobs exports from published stories

* ts fix

* ts fix

* Label test to TS

* explicitly ignoring test files in webpack bundling

* linting stuff

* adding comment about test file exclusions
2020-08-19 12:54:26 -07:00
Evan Rusackas
d0953874f2
chore: splitting button stories into separate stories (#10631)
* splitting button stories into separate stories

* lint
2020-08-18 22:47:27 -07:00
Lily Kuang
a3ac5061fe
feat: card view bulk select (#10607) 2020-08-18 18:04:36 -07:00
Evan Rusackas
ec7874ff98
style: Label styling/storybook touchups (#10627)
* colors corrected, hover/cursory only change if there's an onClick

* adding info label, breaking gallery out to its own story

* linting

* fixing bad class name

* now with fading!

* now supporting additional (non-bootstrap) label styles

* adding new secondary/primary labels to gallery

* fixing map key react warning

* using the new secondary label in the ChartList view

* linting

* fixing TS issue
2020-08-18 15:42:00 -07:00
Evan Rusackas
844b471509
fix: removing unsupported modal sizes (#10625)
* fix: removing unsupported modal sizes

* linting!

* NOT specifying bsSize seems to have the same effect as (unsupported) "medium"

* supporting 'large' and 'small' over 'lg' and 'sm'
2020-08-18 14:33:39 -07:00
Ville Brofeldt
ca5dc4256f
feat(datasource): remove deleted columns and update column type on metadata refresh (#10619)
* fix: remove missing columns on metadata refresh

* add tests

* lint and simplify

* lint

* reduce locals

* fix label style
2020-08-18 21:47:13 +03:00
Maxime Beauchemin
0d3caf08e5
chore: npm audit fix as of 2020-08-15 (#10613)
* chore: npm audit fix as of 2020-08-15

* --force

* fixing copy-webpack-plugin

* lint

* resolve conflicts
2020-08-17 15:27:01 -07:00
Evan Rusackas
f868580f64
chore: bump react-redux to 5.1.2, whittling console noise (#10602)
* chore: bump react-redux to 5.1.2

* fixing spy, and thus the breaking test.

* relabeling tests to UNSAFE_componentWillReceiveProps because why not.
2020-08-16 21:29:08 -07:00
Evan Rusackas
ed9b6dbf2b
fixing console error about bad html attribute (#10604) 2020-08-16 20:21:21 -07:00
Evan Rusackas
08211953b2
chore: migrate console logs to logging service (#10608) 2020-08-16 20:20:47 -07:00
Grace Guo
ca9ca99510
refactor: [migration] convert iframe chart into dashboard markdown component (#10590)
* refactor: [migration] convert iframe chart into dashboard markdown component

* remove 3 viz_types

* fix comments
2020-08-16 14:43:30 -07:00
Lily Kuang
03a62f15d8
feat: sort card view by Alphabetical, Recently Modified, and Least Recently Modified (#10601) 2020-08-14 15:07:37 -07:00
ʈᵃᵢ
db88cec431
feat: SIP-34 card/grid views for dashboards and charts (#10526) 2020-08-13 14:46:56 -07:00
Evan Rusackas
a3fd2b420e
fix: More tweaks needed after adding Doctype tag (#10504)
* fixing last-of-type specificity

* Simplifying/consolidating styles

* fixing filterbox in explore

* linting

* adding some px to font sizes

* fixing in-dash overflow

* removing px for one special fontsize case

* simplifying, addressing comments
2020-08-13 11:50:14 -07:00
Erik Ritter
a8197976fe
fix: error message modal overflow (#10580) 2020-08-11 17:20:39 -07:00
Jesse Yang
1b111b677e
feat(table-viz): translation and metric column header align right (#10549) 2020-08-11 12:56:32 -07:00
David Aaron Suddjian
83af9d12f8
fix(sqllab): Handle long table names in SQL Lab (#10518)
* widen the autocomplete menu for table names

* display the full table name in a tooltip

* license

* Update superset-frontend/src/SqlLab/components/AceEditorWrapper/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* src importing

* move autocomplete width css to main.less

* use html title attribute instead of tooltip

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-11 09:50:46 -07:00
Jesse Yang
a37b635674
fix(dashboard): add animation state to fix tab switch re-renders (#10475) 2020-08-11 00:57:50 -07:00
Maxime Beauchemin
613dd12fbf
fix: misaligned LimitControl buttons and port jsx->tsx (#10529)
* fix: misaligned LimitControl buttons and port jsx->tsx

* addressed comments
2020-08-10 15:35:39 -07:00
David Aaron Suddjian
7f84927504
fix(dashboard): changing the chart title, except not (#10527)
* changing slice names in dashboard should not change chart title

* comprehensions > loops
2020-08-07 18:06:58 -07:00
Jesse Yang
b6c6b6800a
fix: table viz query mode switch not working (#10552) 2020-08-07 14:15:03 -07:00
Erik Ritter
4765f8b10d
fix: embedded chart height (#10551) 2020-08-07 13:53:18 -07:00
Tanmay Laud
a6fa02aaec
chore: Migrate Timer component from jsx to tsx (#10455)
* migrated LanguagePicker.jsx to tsx

* Migrated Menu.jsx to tsx

* migrated MenuObject.jsx to tsx

* migrated NewMenu.jsx to tsx

* Migrated UserMenu.jsx to tsx

* removed unnecessary export from UserMenu

* added language definition in LanguagePicker

* removed unnecessary exports from Menu.tsx

* used typeof guard for childs

* changed LanguageProps to Languages

* removed unnecessary type casting

* fixed linting errors

* migrated Checkbox to tsx

* Migrated Timer component to tsx

* fixed linting errors

* fixed test cases

* removed unused import in timer spec

* reverting changes

* renamed and then modified Timer

* changes for review comments

* fixed incorrect clear

* using stopTimer in stopwatch

* fixed lint issues

* added explicit timer cleanup

* fixed lint issue

* fixed memory leak

* renamed Timer

* added changes after git mv
2020-08-07 09:30:17 -07:00
Jesse Yang
ea0db0d195
bugfix: table chart query mode initial value (#10544) 2020-08-07 02:25:48 -07:00
Maxime Beauchemin
0bad77f0fe
chore: TypeScript <Label /> (#10494)
* chore: TypeScript <Label />

* rebase

* chore: TypeScript <Label />

* rebase

* A bunch o' test fixes. One more to go!

* helper for mountying Emotional components with Enzyme

* asf license

* fixed last test, some linting

* improve the storybook

* Adressing comments

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-08-06 22:33:07 -07:00
Erik Ritter
2055ecc1ba
feat: refactor error components and add database issue code (#10473)
* feat: refactor error components and add database issue code

* Apply suggestions from code review

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2020-08-06 13:22:24 -07:00
Maxime Beauchemin
ece91928a9
style: use tabs in dashboard edit pane (#10394)
* style: use tabs in dashboard edit pane

* fix tests

* more hackin'

* getting ready to rip cell measurer

* working

* pogress

* Fix cards

* done

* fix jest

* fix cy
2020-08-05 18:53:53 -07:00
Natalie Ruhe
51a88cb19b
feat: Add antd to the codebase (#10508) 2020-08-05 13:50:30 -07:00
simchaNielsen
57dc7622b4
fix: show label for filters in filter box in explore (#10412)
* fix: show label for filters in filter box in explore

* test: add test for label in filter box

* test: add test / fix lint

* fix: fix CR notes

* refactor: add label propType to FilterBoxItemControl.jsx
2020-08-05 09:23:11 +03:00
Evan Rusackas
3d74c3ce56
feat: storybook for Icon component (#10515)
* storybook for Icon component

* fixing webpack aliases

* linting 

* Icons are now in a nice little grid.

* lint

* EOF fix for alert.txt. Ugh.
2020-08-04 22:39:14 -07:00
Moriah Kreeger
e040bf7acf
feat: add favorite star to dashboard and chart lists (#10510) 2020-08-04 16:34:50 -07:00
Moriah Kreeger
523c6b77bf
fix: update time range select tooltip (#10458) 2020-08-04 16:34:20 -07:00
Jesse Yang
246add45a0
fix: explore panel missing padding (#10505) 2020-08-04 15:08:28 -07:00
Lily Kuang
fa07506d0d
feat: dataset editor improvements (#10444) 2020-08-04 11:52:35 -07:00
kxu
d6b7cae5de
docs: Add supported database logos (#10368) 2020-08-03 13:50:52 -07:00
John Bodley
821916a681
chore: pre-commit run --all-files (#10500)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-08-02 14:32:17 -07:00
Ville Brofeldt
a43ee22f11
style: replace inclusive/exclusive on DateFilterControl with </≤ (#10420)
* feat: improve filter control tooltips

* add styles

* break out utils into own file

* lint

* add tests

* styled component now working

* lint

* add license headers

* replace shallow with mount due to withTheme

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-07-31 20:06:04 +03:00
Ville Brofeldt
9eab29aeaa
fix: enforce mandatory chart name on save and edit (#10482)
* fix: show empty charts as empty in chart list view

* migrate ControlLabel to FormLabel and enforce requred fields

* lint

* reorder buttons
2020-07-31 19:30:02 +03:00
Ville Brofeldt
6243a46ca6
feat: add linear color scale to sunburst chart (#10474) 2020-07-31 19:29:27 +03:00
Evan Rusackas
16459ad401
style: DOCTYPE tag, and related CSS cleanup/refactoring (#10302) 2020-07-29 18:49:32 -07:00
Maxime Beauchemin
e6e6b49372
style: FilterSelect style tweaks (#10446)
* style: FilterSelect style tweaks

* using withTheme to avoid raw supersetTheme

* lint

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-07-29 16:55:02 -07:00
Maxime Beauchemin
edaf785815
fix(sqllab): button width isn't wide enough for 'Run Selection' (#10461) 2020-07-29 16:21:21 -07:00
Erik Ritter
1fbd920902
fix: timeout error message (#10478) 2020-07-29 15:58:46 -07:00
ʈᵃᵢ
78cad9a4a8
refactor(listviews): use correct filter endpoints for charts and datasets (#10442) 2020-07-29 11:00:19 -07:00
David Aaron Suddjian
7f70a241f9
test: Add jest-enzyme assertion library for better frontend tests (#10459)
* adding jest-enzyme

* enzymeify lots of assertions

* types for jest-enzyme
2020-07-29 10:53:06 -07:00
Daniel Vaz Gaspar
671461d0d0
feat(api): database schemas migration to new API (#10436)
* fix(log): log crashes if expired or not authenticated

* fix lint and rison

* add tests

* more tests

* perm fix

* fix test not found

* JS lint

* fix Jest test
2020-07-29 09:33:15 +01:00
Lily Kuang
39fad8575c
feat: update dataset editor modal (#10347) 2020-07-28 15:53:20 -07:00
Moriah Kreeger
e89e60df76
style: update +NEW button to use Button component, add dropdownItems prop to Button (#10422) 2020-07-28 14:29:52 -07:00
Tanmay Laud
9914ae1b52
chore: migrate Checkbox to tsx (#10453) 2020-07-28 11:46:36 -07:00
Evan Rusackas
98437fb3c9
chore: removing VictoryTheme.js (#10445) 2020-07-27 21:12:45 -07:00
ʈᵃᵢ
6f56cd5e9d
feat(listviews): SIP-34 filters for charts, dashboards, datasets (#10335) 2020-07-27 10:14:11 -07:00
Tanmay Laud
4b3d6d1fbd
chore: migrated Menu component to tsx (#10426)
* migrated LanguagePicker.jsx to tsx

* Migrated Menu.jsx to tsx

* migrated MenuObject.jsx to tsx

* migrated NewMenu.jsx to tsx

* Migrated UserMenu.jsx to tsx

* removed unnecessary export from UserMenu

* added language definition in LanguagePicker

* removed unnecessary exports from Menu.tsx

* used typeof guard for childs

* changed LanguageProps to Languages

* removed unnecessary type casting

* fixed linting errors
2020-07-27 09:03:24 -07:00
Stuart Hu
f7465902e4
update code (#10430)
Signed-off-by: Stuart Hu <shijiehu@improbable.io>
2020-07-27 12:48:11 +03:00
Jesse Yang
d45ef1c513
fix(dashboard): chart rerender when switching tabs (#10432) 2020-07-27 11:50:08 +03:00
Ville Brofeldt
5b6ff4944c
fix: incorrect filter operator emitted by Filter Box (#10421)
* fix: equals operator in filter box

* fix time range endpoint schema

* fix test

* bump packages

* fix tests

* lint
2020-07-26 12:40:03 +03:00
Maxime Beauchemin
ea3c3bbae4
style: SIP-34 labels (#10403)
* style: SIP-34 labels

Aligning with SIP-34 designs for labels/pills. Going uppercase fixes the
padding issues we had before, and the rounder pills look better.

Cleaning up some CSS in the process

* lint
2020-07-24 18:03:38 -07:00
ʈᵃᵢ
09dfbab7ed
fix: allow creating table option and remove schema requirement in dataset add modal (#10369) 2020-07-24 13:17:44 -07:00
Maxime Beauchemin
0483c26254
style(sqllab): fixed button width as label changes (#10404)
As the label change from RUN to STOP, the row of button shifts
left/right. This fixes the width so that it doesn't jitter.
2020-07-24 10:05:07 -07:00
Maxime Beauchemin
a10b185248
chore: deactive flaky filter test (#10406)
Flaky tests hurt everyone's cognitive load. Let's deactivate for now and
revisit.
2020-07-23 23:33:26 -07:00
Moriah Kreeger
6fde7f8984
style: add fade transition to bottom border on navbar menu items (#10402)
* Add fade transition to bottom border on navbar menu items

* lint fix

* use theme variables

* fix spec
2020-07-23 12:49:28 -07:00
Daniel Vaz Gaspar
2fd37b18e3
fix(api): fixes perf on charts and introduces sorting by database on datasets (#10392) 2020-07-23 11:19:05 -07:00
Maxime Beauchemin
b438ba9ed5
chore: wiring ControlLabel to a new FormLabel (#10388)
* chore: wiring ControlLabel to a new FormLabel

Creating new simple <FormLabel /> component and wiring all <label>
and react-bootstrap.ControlLabel towards it.

FormLabel becomes a pivotal point that can be altered to point to AntD
when we're ready.

* lint

* ViewportControl

* addressing comments
2020-07-23 00:27:22 -07:00
Maxime Beauchemin
ea53916730
feat: SIP-34 explore save modal (#10355)
* feat: SIP-34 explore save modal

* using a const for the session storage key

* backend changes

* minor tweaks

* more tweaks

* radio cosmetics

* styles

* fix tests

* CreatableSelect\!

* Fix cypress & lint

* fix unit

* lint
2020-07-23 00:26:29 -07:00
Lily Kuang
37f9b513fe
fix: dataset list filters bug (#10398)
* fix dataset list filters

* update database endpoint query params using rison encode
2020-07-22 22:23:44 -07:00
Ville Brofeldt
3fdc141b82
fix: bump pivot-table and rose (#10400) 2020-07-23 01:02:08 +03:00
Evan Rusackas
ca71d4d6ee
feat: adding Storybook to Superset (#10383)
* Storybook added!

* starting to configure junk....

* Storybook works!!!

* Now with theme!

* apache boilerplate

* more apache comments

* lots o' knobs for the Button.... taking stock of the codebase

* more classes, but killing the knob for now.

* nixing unused module

* linting

* fresh package-lock

* now with tooltip!

* adding path and zlip because the linter told me to

* upgrading storybook packages from devdeps

* linting

* removing cruft

* killing an annoying (and old?) lint issue

* lint fix, take 2.

* removing zlib/path

* package lock reset from master

* re-adding new packages for this here PR

* nixing console log, simplifying

* nixing comment TODOs (done enough!)

* basic docs.
2020-07-22 10:21:25 -07:00
Daniel Vaz Gaspar
961108625e
fix(datasets): sort and humanized modified by (#10380)
* fix(datasets): sort and humanized modified by

* size xl on changed_on_delta_humanized

* Fix, tests

* Fix, tests

* Fix, frontend tests

* remove debug flag
2020-07-22 11:34:47 +01:00
Ville Brofeldt
5f7bb8e7bd
fix: treemap template literal (#10382) 2020-07-22 07:49:35 +03:00
ʈᵃᵢ
4cb44561d7
style: make listviews overflow scroll; convert less to emotion (#10384) 2020-07-21 21:41:09 -07:00
Maxime Beauchemin
485cd11ebb
style: SIP-34 control-label (#10381) 2020-07-21 20:30:36 -07:00
Maxime Beauchemin
dc4b1b1271
style: add warning msg to "Change Datasource" modal (#10379) 2020-07-21 10:07:58 -07:00
Ville Brofeldt
3c39b26c99
fix: extra filters for chart data endpoint (#10359)
* fix: extra filters

* fix old test and add new test

* add test for null filter value

* leave lowercase until all operators are fully uppercased

* bump packages

* rename test
2020-07-21 08:24:50 +03:00
Maxime Beauchemin
61544de6c3
chore: uniform icons across list views (#10363)
* chore: uniform icons across list views

* smaller modals

* integrating comments
2020-07-20 19:56:51 -07:00
Erik Ritter
5fa4680447
feat: update timeout error UX (#10274) 2020-07-20 15:32:17 -07:00
Phillip Kelley-Dotson
7d10669ca8
move control panel to filterbox folder (#10346) 2020-07-20 13:40:00 -07:00
Erik Ritter
5984df3522
chore: enable no-static-element-interactions eslint rule (#10351) 2020-07-17 09:19:16 -07:00
Erik Ritter
09de805017
chore: enable no-unused-vars and prefer-template eslint rules (#10350) 2020-07-16 19:13:59 -07:00
ʈᵃᵢ
0eee6785a8
feat(listviews): SIP-34 Bulk Select (#10298) 2020-07-16 16:07:49 -07:00
Daniel Vaz Gaspar
2b061fc64b
fix: modified by column on charts and dashboards (#10340) 2020-07-16 23:15:47 +01:00
Ville Brofeldt
611dd7a8f6
fix: make __time an ok column name in SQL Lab (#10336) 2020-07-16 10:34:50 +03:00
Grace Guo
2f147cfedc
fix: add additional ui tweaks (#10275)
* fix: add additional ui tweaks

* use fa fa-close class for x icon

* use new svg icons
2020-07-15 14:05:30 -07:00
Jesse Yang
a94744b984
fix(table-viz): value "undefined" for column.name (#10325)
Bump table viz plugin to fix a bug: apache-superset/superset-ui#686
2020-07-15 13:24:56 -07:00
Daniel Vaz Gaspar
74cb82e1ad
fix: humanised changed on UTC on dashboards and charts (#10321)
* fix: API marshmallow3 drop utc for naive datetime fields

* fix: API marshmallow3 drop utc for naive datetime fields

* fix, tests

* isort and test

* black

* add and fix test

* fix comment
2020-07-15 19:09:32 +01:00
Erik Ritter
66b0239eca
chore: type welcome (#10317) 2020-07-15 08:38:43 -07:00
Erik Ritter
6ae9f3af8e
feat: add download as image button to explore (#10297) 2020-07-14 16:40:12 -07:00
Erik Ritter
518dbd05b6
chore: add typing to more sqllab components (#10278) 2020-07-14 16:39:56 -07:00
Erik Ritter
80902bca50
chore: add typing to profile (#10282) 2020-07-14 16:39:37 -07:00
Maxime Beauchemin
11ae48062f
fix: broken glyphicons used in react-json-schema (#10267)
I'm working on a talk for the Airflow Summit
"Advanced Apache Superset for Data Engineers" and showing the "Schedule
Query" feature that Beto contributed a while back (behind a feature flag).

I found that the glyphicons used in `react-json-schema` are broken and
came up with an easy fix.

Also other minor tweaks on the feature.
2020-07-14 15:40:39 -07:00
Ville Brofeldt
7eb00481de
fix: leave null timestamp unformatted in view results table (#10313) 2020-07-14 19:12:06 +03:00
Ville Brofeldt
c44ee06b5d
fix(chart-data-api): improve chart data endpoint errors (#10300)
* fix: improve chart data error response

* Populate error_message in QueryResult

* add tests

* Lint + fix incorrect raise

* add more tests
2020-07-14 12:40:00 +03:00
Jesse Yang
96e0da9fea
fix(table-viz): table chart time column should use default (#10293) 2020-07-13 23:44:57 -07:00
Erik Ritter
f9c2600efc
chore: clarify logging source field (#10306) 2020-07-13 21:16:51 -07:00
Evan Rusackas
93753cf2f8
fix: saving custom CSS correctly (#10289) 2020-07-12 21:14:10 -07:00
Lily Kuang
9d757403be
fix: fetch datasets list after dataset created successfully (#10290) 2020-07-11 20:57:54 -07:00
Evan Rusackas
06fd1b5e4d
logo gets the vertically-centered flexbox treatment in jinja template (#10281) 2020-07-10 16:11:49 -07:00
Lily Kuang
3b4df51848
style: new toast design closer to SIP-34 (#10178) 2020-07-10 14:58:59 -07:00
Lily Kuang
80b06f6827
feat: update delete modal for dataset (#10258)
* update delete modal for dataset

* update datasetList to use hooks

* fix typo on dataset delete modal
2020-07-10 14:23:17 -07:00
Jesse Yang
4d179622fa
fix(explore): edit datasource does not update control states (#10284) 2020-07-10 12:46:25 -07:00
Maxime Beauchemin
7d4d2e7469
fix(explore): 'Edit Datasource' is missing from btn-dropdown (#10283)
Not sure how it got broken but he's a fix. I'm thinking this is related
to the controls refactor.

closes https://github.com/apache/incubator-superset/issues/10247
2020-07-10 00:11:53 -07:00
Jesse Yang
af864e9fff
fix: deckgl dimension select missing options (#10277)
Fixes #10246
2020-07-09 18:27:05 -07:00
Ville Brofeldt
c0d663db9a
feat: show formatted dates instead of epoch on results (#10268) 2020-07-09 20:48:53 +03:00
Jesse Yang
e94c9804a2
fix: optimize mapStateToProps for chart controls (#10264) 2020-07-09 00:33:48 -07:00
Evan Rusackas
8d9bb5f472
feat: revised icons (#10263)
* fix: recoloring favicon

* fix: recoloring readme logo
2020-07-08 17:49:12 -07:00
Grace Guo
ab5ce82f7b
fix: issue in getting filter_box config (#10262) 2020-07-08 17:24:21 -07:00
Evan Rusackas
3dfa4aa15d
chore: nixing requiresTime (#10259) 2020-07-08 17:10:03 -07:00
Grace Guo
f6ccd61547
[fix] disable search all options by default (#10260) 2020-07-08 16:43:38 -07:00
Grace Guo
6690963ec2
feat: minor reorder SQL Lab Tab controls (#10257) 2020-07-08 16:21:47 -07:00
Jesse Yang
e5761d3cf7
fix(table-viz): JS error when sort time column (#10250) 2020-07-07 21:28:09 -07:00
Grace Guo
f849103374
feat: Typeahead searchable filter_box for dashboard (#10210)
* [WIP] Typeahead dashboard filter_box

* Make it work

* add config option for async filter_box

* enable for > 1000 options only

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-07-07 09:31:18 -07:00
Evan Rusackas
569e4a7c50
chore: Revised logo (new color), w/CSS for vert alignment (#10237)
* out with the old, in with the new

* vertically centering logo once and for all

* lint: black instead of IDE formating

* touch config.py

* Styles -> StyledHeader

* nixing vestigial SVG

* removing trademark

Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
2020-07-06 17:30:18 -07:00
Erik Ritter
9a5195ab85
feat: support new errors payload in SQL Lab (#10243) 2020-07-06 09:49:32 -07:00
Maxime Beauchemin
2314aad450
feat: add database dropdown to dashboard import (#10118)
* feat: add database dropdown to dashboard import

Currently, when importing a database from a JSON file, the process
looks at the database name from the source (the info is in the file)
and matches the datasources to that name. If no database by that name
exists, it simply fails.

With this PR, we add a database dropdown that allows the user to specify
which databases the datasources should target as the get upserted.

I want to stress that the code in this area is not in a great shape,
and that the challenge of serializing/deser the nested objects is
challenging, but that there should be a much better way to do this.
One of the improvement (out of scope for this PR) that would allow to
simplify those import/export would be to use UUIDs for
importable/exportable objects.

Another identified issue is the indirections between
`utils/import_expor_{model}.py` on top of `{Model}.import_object`. Not
addressing that here.

Next topic is the MVC stuff. Decided to stick with it for now as this is
more of a [obious missing feat:] than a rewrite.

* isort \!? 0%^$%Y$&?%$^?%0^?

* fix tests

* pre-committing to py3.6

* address dpgaspar's comments

* revert isort
2020-07-05 15:08:37 -07:00
Jesse Yang
a6751bf49a
fix(table-viz): format non-numeric metrics (#10234) 2020-07-02 14:44:15 -07:00
Erik Ritter
4281ad5486
chore: type ResultSet.tsx (#10226) 2020-07-02 10:12:31 -07:00
ʈᵃᵢ
0afa15138b
fix(listview): use disableSortBy to disable sorting in table columns (#10223) 2020-07-02 10:00:37 -07:00
Jesse Yang
dbd4588e4f
fix(table-vis): bump to v0.14.6 to fix missing anchor links (#10225) 2020-07-01 19:18:23 -07:00
Jesse Yang
700429f431
fix: chart validation error not cleared on control value update (#10224) 2020-07-01 18:32:27 -07:00
Jesse Yang
f7a024d7de
fix: better backward compatibility for table viz (#10219) 2020-07-01 11:23:08 -07:00
Erik Ritter
1606d80490
fix: tooltips on nvd3 charts rendering in the wrong location (#10211) 2020-06-30 18:02:29 -07:00
Jesse Yang
538f7e0f73
build: enable Cypress tests for visualizations (#10206) 2020-06-30 17:10:17 -07:00
Jesse Yang
9664705435
fix: datatable dependencies for pivot-table in dev (#10205) 2020-06-30 11:38:36 -07:00
Jason Davis
72fc581b15
added explore database for ctas/cvas (#10174)
Co-authored-by: Jason Davis <@dropbox.com>
2020-06-29 11:13:54 -07:00
Jesse Yang
4342c33d0e
build: enable typescript for cypress (#10170) 2020-06-29 10:53:33 -07:00
Jesse Yang
9bdfa055ac
feat(viz): add query mode switch to table chart (#10113)
1, Replace table chart rendering from jquery.DataTables to react-table: apache-superset/superset-ui#623
2. Rearrange the control panel, replace GROUP BY and NOT GROUP BY with a "Query Mode" switch: apache-superset/superset-ui#609
2020-06-28 21:37:04 -07:00
ʈᵃᵢ
3414f35792
refactor: better naming for config flags (#10180) 2020-06-26 17:36:50 -07:00
Erik Ritter
8bdc6b1771
fix: row count container alignment (#10179) 2020-06-26 16:07:29 -07:00
Maxime Beauchemin
f888656e6d
style: bring new SIP-34 palettes in controls (#10121) 2020-06-26 13:27:51 -07:00
Jason Davis
9de9e1c19d
feat: Added configuration to SQL Lab results "Explore" button (#10164)
* added configuration to virtual table explore button

* added description to mixin

* fixed unit tests

Co-authored-by: Jason Davis <@dropbox.com>
2020-06-26 09:54:55 -07:00
oashton
d8314eeb0d
Add maximize and minimize feature to charts (#9210)
* Add maximize and minimize feature to charts

* Fixed lint issues

* Update superset-frontend/src/dashboard/components/SliceHeaderControls.jsx

Add translation function

Co-Authored-By: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Remove resizeEvent property, change condition to use the nextProps

* Minor changes, improve source code

* Fixed lint issues

* Remove unnecessary resizeEvent props

* Move inline style to css class style

* Minor fixes, improvements css

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2020-06-26 09:12:53 -07:00
Jesse Yang
ece4f6d0b5
build: upgrade Cypress and re-enable visualization tests (#10158) 2020-06-25 15:24:23 -07:00
Maxime Beauchemin
1781ebbaa4
fix: [search query view] edit link is broken (#10128)
* fix: [search query view] edit link is broken

* eslint + mypy

* rever app.py changes

* addressing comments

* use api/v1/query

* fix test
2020-06-25 12:20:10 -07:00
Jesse Yang
ecb44a4243
refactor: import emotion-theming methods from @superset-ui/style (#10157)
This makes the code cleaner and fixes missing theme variables when `npm link @superset-ui/style`.
2020-06-24 19:23:51 -07:00
Evan Rusackas
36ea42f092
fix: Loading overlay bugfix and cleanup (#10105)
* fix: reordering DOM output, simplifying styles, Emotionalizing

* simplification

* converting RefreshChartOverlay to TS

* Loading -> TS, stripping unused size prop

* simplification...

* just letting "position" prop act as a class name. Simpler!

* consolidating styles, changing a className prop to a position prop.

* nixing (unused) classname prop

* replacing inline loading img with the proper Loading component

* BY THERE.

* position prop is optional!
2020-06-24 14:21:45 -07:00
Bogdan
3db76c6fdc
Implement create view as functionality (#9794)
Implement create view as button in sqllab

Make CVAS configurable

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-06-24 09:50:41 -07:00
Ville Brofeldt
38667b72b1
fix: refine shouldUseLegacyApi and add tests (#10148)
* fix: refine shouldUseLegacyApi and add tests

* address review comments
2020-06-24 19:38:36 +03:00
Jesse Yang
4e71491d86
fix: FilterBox JS when no results (#10143) 2020-06-24 08:09:14 -07:00
Bogdan
763b38591c
Fix CTAS explore flow (#10147)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-06-23 22:36:05 -07:00
ʈᵃᵢ
be936c2eb8
style: listviews closer to SIP-34 (#10094) 2020-06-23 14:17:28 -07:00
Lily Kuang
4d1d40989c
feat: dataset add modal (#10104) 2020-06-23 10:15:35 -07:00
Jesse Yang
ed4f6e93ac
chore: bump superset-ui to v0.14.1 (#10112) 2020-06-22 11:14:23 -07:00
Grace Guo
a80453d945
fix: dashboard filter scope bug (#10114)
* fix: dashboard filter scope bug

* add extra comments per review
2020-06-22 10:18:04 -07:00
Grace Guo
221f38099b
[logging] add selected tab name into perf logging (#10080) 2020-06-22 10:14:29 -07:00
Erik Ritter
cb1705fdae
chore: type src/addSlice (#10127) 2020-06-22 08:14:27 -07:00
Erik Ritter
231c2b395d
chore: fix add datasource help string (#10129) 2020-06-22 07:51:50 -07:00
Maxime Beauchemin
cf0f1d568d
style: replace broken glyphs with font-awesome (#10123)
Glyphicons stopped working recently, not sure why, but let's get rid of
them and double down on font-awesome that we use a lot more in the
codebase. There's only a few instances of glyphicons and they all are
broken ATM.

Also a few other minor style tweaks
2020-06-21 21:38:08 -07:00
Grace Guo
69100536de
fix: dashboard should not add extra_filters onto chart annotation (#10115) 2020-06-20 18:08:45 -07:00
Will Barrett
961b55cfba
fix: Visualization settings were lost when editing a datasource from Explore (#10092) 2020-06-19 12:55:49 -07:00
Erik Ritter
2e76fbb7e5
chore: type FilterableTable (#10073) 2020-06-18 21:57:11 -07:00
Maxime Beauchemin
a6390afb89
style: push bootstrap theme towards SIP-34 styles (#10056)
* feat: cartel theme

* piling

* more tweaks

* Make things look better

* lint

* fix tests

* paint it black

* tweaks
2020-06-18 15:01:58 -07:00
Phillip Kelley-Dotson
02fee35314
chore(metricoption): remove metricoption and columntypelable dependency (#10077)
* remove columntypeLabel and metricoptions from superset

* fix lint

* remove old test

* update pakage

* add suggestions

* fix merge conflict
2020-06-17 19:55:17 -07:00
Will Barrett
817b7aaf29
style: Change logo color to new branding (#10090)
* Change logo color to new branding

* Add back Apache licenses

* Fix SVG format

* Fix one more license

* Bigger pngs
2020-06-17 19:47:02 -07:00
ʈᵃᵢ
c914af0bc4
fix: adds pagination/infinite scroll to owners select in DashboardList and ChartList (#10035) 2020-06-17 16:27:21 -07:00
Erik Ritter
987cb6e1fe
chore: type src/dashboard/util/charts (#10068) 2020-06-17 12:34:04 -07:00
Jesse Yang
5d4d50a609
fix(sqllab): table refresh API endpoint (#10076) 2020-06-17 12:24:10 -07:00
ʈᵃᵢ
8c012f7941
feat: add more columns and icons to dataset listview (#10043) 2020-06-16 17:30:10 -07:00
Evan Rusackas
00e6d7d706
chore: bumping superset-ui theme version (#10059) 2020-06-16 16:33:14 -07:00
Ville Brofeldt
d3a9ce5afc
fix: chart export fails when buildQuery not present (#10062) 2020-06-16 09:25:10 -07:00
Maxime Beauchemin
280ade826c
fix: dashboard export raises schema issues (#10060)
* fix: dashboard export raises schema issues

* Fix isort
2020-06-15 21:43:05 -07:00
Lily Kuang
98ab95e4c0
feat: owners profile icon on dataset list view (#10041) 2020-06-15 09:52:09 -07:00
Ville Brofeldt
ee77707532
feat: add deafult buildQuery for V1 chart data requests (#10048) 2020-06-12 07:49:13 -07:00
Grace Guo
0724eddb7c
other: [logging] add dashboard is_published into perf logging (#10042) 2020-06-11 18:57:52 -07:00
Natalie Ruhe
d1588c7658
Fix chart annotation source type showing perpetual loading when re-selecting the same value. (#10036)
Remove accidental console.log used during testing.

Co-authored-by: Natalie Ruhe <natalie@preset.io>
2020-06-10 16:17:56 -07:00
Lily Kuang
5339d31ed1
feat: implement secondary navigation for datasets (#9982) 2020-06-10 11:55:51 -07:00
Ville Brofeldt
56397d75cc
fix: raise error in sqllab when using reserved column name (#9859) 2020-06-10 16:32:43 +03:00
Ville Brofeldt
a8db78b069
chore: bump superset-ui to 0.13.27 (#10018)
* chore: bump superset-ui

* Remove redundant control panels
2020-06-10 10:13:00 +03:00
Grace Guo
656cdfb867
fix: [logging] fix render chart error type (#10000) 2020-06-05 14:44:52 -07:00
Ville Brofeldt
5c4d4f16b3
feat: finalize Word Cloud move to new chart data endpoint (#9975)
* remove word cloud from viz.py

* Fix Run in SQL Lab

* remove deprecated python tests

* break out legacy endpoint type into function

* Break out exploreChart from exportChart and implement results type

* Fix jest tests and refactor accordingly

* lint

* Rename v1 payload function

* Add dashboard id to v1 chart data request url params

* Add support for domain sharding to v1 chart data request
2020-06-05 14:08:46 +03:00
ʈᵃᵢ
619fbc9557
fix: remove -1,-1 from owners request in charts, dashboards list and propertiesModal (#9989) 2020-06-04 15:31:42 -07:00
ʈᵃᵢ
d187d2887e
fix: fetch all owners for dashboard, chart listview filters and properties modal (#9784) 2020-06-03 19:57:03 -07:00
Grace Guo
dcac860f3e
feat: [dashboard] notification and warning for auto force refresh (#9886)
* feat: [dashboard] notification and warning for auto force refresh

* fix review comments
2020-06-03 10:20:56 -07:00
Michael Joseph Rosenthal
3fd6e0630e
fix #8302, disabling save button when can_add: false, can_overwrite: false (#9456) 2020-06-02 23:20:52 -07:00
Ville Brofeldt
fc92692f49
feat: implement new version of word cloud (#9962) 2020-06-02 19:28:58 +03:00
Ville Brofeldt
38a6bd79da
feat: expand new chart data endpoint coverage (#9903)
* feat: implement new chart API for additional components

* Fix python tests

* Fix tests

* Fix lint

* fix camel case error in requestParams

* lint

* fix samples row limit

* Add samples row limit to config

* remove unnecessary code

* lint

* Address review comments
2020-06-02 10:47:28 +03:00
Grace Guo
5324e25328
[filter_box] disable instant_filtering by defult (#9952) 2020-05-31 22:12:04 -07:00
Jesse Yang
4fe6f4f38e
fix: FilterBox Select should be Creatable (#9940)
* bugfix: FilterBox Select should be Creatable

* Fix Cypress test
2020-05-28 14:51:51 -07:00
Jesse Yang
359ea8825d
fix(react-select): FilterBox focus event and adhoc filter popup height (#9933)
* fix(react-select): FilterBox focus event and adhoc filter popup height

* Fix flacky cypress test

* Use focus instead of click
2020-05-27 15:15:32 -07:00
Ville Brofeldt
1b72907b18
Revert "feat: bump superset-ui and implement queryFields in formData (#9908)" (#9931)
This reverts commit 2c97e72959.
2020-05-27 22:50:14 +03:00
Ville Brofeldt
5ff61048c6
feat: bump sinon to latest (#9926) 2020-05-27 19:34:40 +03:00
Maxime Beauchemin
92b843e2ae
css: beautify roles CRUD (#9890) 2020-05-26 22:32:13 -07:00
Erik Ritter
848ac91bb6
fix: bump nvd3 plugin for annotation styles (#9919) 2020-05-26 16:59:30 -07:00
Phillip Kelley-Dotson
e0c3da5df1
feat: paired t testchart control migration (#9916)
* cherry pick

* update package
2020-05-26 14:11:03 -07:00
Phillip Kelley-Dotson
1fffa37e85
feat: remove para controls (#9851)
* remove para controls

* update package version
2020-05-26 12:37:33 -07:00
Ville Brofeldt
2c97e72959
feat: bump superset-ui and implement queryFields in formData (#9908)
* feat: Bump superset-ui packages for queryFields

* feat: Implement queryField in formData
2020-05-26 10:19:33 -07:00
Grace Guo
e6a55d8858
fix: [dashboard] should not trigger chart refresh when filter not applicable (#9891)
* fix: [dashboard][filter] should not trigger chart refresh when filter is not applicable

* fix comments
2020-05-26 10:14:12 -07:00
Erik Ritter
9edfc8f68d
chore(ts): convert base js files to typescript (#9826) 2020-05-24 19:50:08 -07:00
Jesse Yang
6d4e23663e
fix: reenable table chart page length (#9884)
Bump @superset-ui/legacy-preset-chart-table to fix disabled
page length support.

See https://github.com/apache-superset/superset-ui/pull/522
2020-05-22 10:35:45 -07:00