Commit Graph

2282 Commits

Author SHA1 Message Date
Maxime Beauchemin
254645773c Better looking checkboxes (#3345)
Also showing icon only on hover on control headers
2017-08-21 13:47:50 -07:00
Maxime Beauchemin
e79adbbc5f [hotfix] self-immune filter_box fix (#3338) 2017-08-18 17:43:11 -07:00
Dmitry Goryunov
75e69f02e8 [sql lab] Make sql editor resizable (#3242)
* Update to the version of react-ace with the fixed sizing issues

* Make ace editor resizable

* Use small util method for offset calculation instead of $

* Test ResizableAceEditor

* Make the right pane of the Sql Lab scrollable

* Add default and min height to the ResizableAceEditor

* Implement SplitPane

* Make Splitter fullscreen

* React on resize of the window

* Implement min and max

* Get rid of a magic number + add margin

* Handle resize event with delay + cleanup the code

* Make ResultSet adjustable

* Make QueryHistory adjustable

* Remove ResizableAceEditor

* Make linter happy

* Test SplitPane

* Init sizes properly
2017-08-18 17:15:25 -07:00
Maxime Beauchemin
6fc837db51 [sql lab] improve error messages (#3308)
* [sql lab] improve error messages

Some error messages in non-async mode were showing as JSON or sometimes
as tuples. This fixes that.

* linting
2017-08-18 15:50:07 -07:00
Maxime Beauchemin
2923a125db Syncing the timeout param from backend (#3329)
* Syncing the timeout param from backend

* Linting
2017-08-18 15:49:47 -07:00
Maxime Beauchemin
527572c3eb [dashboard] re-enabling cascading filters (#3335)
* [dashboard] re-enabling cascading filters

https://github.com/apache/incubator-superset/pull/3183 disabled the
ability of a filterbox to get filtered by another filterbox

* linting
2017-08-18 15:49:29 -07:00
Maxime Beauchemin
a7ba6e4a5d [nvd3] fix bubble axis (#3332)
number of issues are addressed here:
* x axis formatting doesn't apply in bubble chart
* adding option to show/hide bounds of x and y axis
* with a flaky 'auto' margin mode, allow user to specify hard values or
  auto
* x label font-size was different than y axis
* show more options and reorg Control panels for Axes in `line` viz
2017-08-18 11:56:34 -07:00
Maxime Beauchemin
e31ad22f50 [hotfix] hotfixing the hotfix (#3333) 2017-08-17 23:18:41 -07:00
Rogan
813ed6018d Unnecessary to specify order_columns for DatasourceModelView (#3331) 2017-08-17 22:18:32 -07:00
Grace Guo
0454ef3726 disable immediately re-render for color scheme change (#3328)
for chart type: bubble, area, treemap and country map, color scheme change cannot take effect immediately. So have to disable immediately re-render function and hide lightening icon for these chart type.
2017-08-17 21:38:34 -07:00
Maxime Beauchemin
afedcdf0d8 [hotfix] dashboard widget resize is broken (#3330)
blame https://github.com/apache/incubator-superset/pull/3315
2017-08-17 21:20:51 -07:00
Riccardo Magliocchetti
9f3aeb22d9 docs: add references to Flask-Appbuilder Security documentation (#3322)
And a specific link to an oauth example configuration.
2017-08-17 11:48:22 -07:00
Maxime Beauchemin
59268e978a Use react-alert for backend message flashing (#3315) 2017-08-16 23:00:23 -07:00
Grace Guo
b9a2fa4015 Allow for multiple color schemes (#3295)
* Allow for multiple color schemes

1. create ColorSchemeControl component
2. using the same new control component for linear colors

* add color spectum for linear color scheme

* remove dup css

* fix controls setting for linear color scheme

* minor fix by code review comment
2017-08-16 22:20:11 -07:00
Invenis
3c8577b853 French translation (#3313) 2017-08-16 20:29:18 -07:00
Maxime Beauchemin
0aa3d2a818 [hive] improve error messages (#3305)
* [hive] improve error messages

* Addressing comments
2017-08-16 17:40:28 -07:00
Maxime Beauchemin
fbd0d46e8a Fix styles in Separator widget (#3309)
Style wasn't working right for separator widget since the iframe sandboxing of
the markup widget. This addresses this small issue and also now allows
for html in the separator widget
2017-08-16 17:40:06 -07:00
Maxime Beauchemin
c4e056929d [sql lab] run button shortcut tooltip (#3310) 2017-08-16 17:39:48 -07:00
Maxime Beauchemin
84e59a11f1 [bugfix] Presto KeyError 'errorLocation' (#3291) 2017-08-16 13:25:09 -07:00
Maxime Beauchemin
9fcd5d67e4 [sql lab] add pending to the list of searchable statuses (#3292) 2017-08-16 13:24:43 -07:00
Maxime Beauchemin
ccf505a480 [mapbox] fix viewport alterations (#3293)
* [mapbox] fix viewport alterations

Since explorev2 it appears that altering the viewport hasn't been
changing the controls as it used to. This PR addresses it.

* lint
2017-08-16 11:23:01 -07:00
Rogan
d1d1c49009 Fix raise error when query datasource (#3298)
* Catching the 'NoResultFound' exception when the datasource does't exist

* change one() to first()

* revert modify

* remove import
2017-08-16 10:18:43 -07:00
Maxime Beauchemin
232a5c392e [docs] document how to compile/publish docs (#3296) 2017-08-15 16:37:40 -07:00
Maxime Beauchemin
9c6248f3ba [dashboard] add link to export CSV from dashboard (#3280)
* [dashboard] add link to export CSV from dashboard

fixes #1304

* Fix tests
2017-08-14 18:25:36 -07:00
Maxime Beauchemin
6841697917 FAQ entry for backend support (#3282)
so that I can close:
https://github.com/apache/incubator-superset/pull/1470/files
2017-08-14 17:57:09 -07:00
Maxime Beauchemin
81817309d3 [sql lab] fix sluggish backspace in editor (#3286)
Somehow Ace's "changeSelection" event is triggered when hitting
backspace (and shouldn't!).

changeSelection on our side triggers enough work to make the
holding backspace sluggish and laggy.

This fix ignores selection with a length of 1, avoiding mutating the
state altogether when hitting/holding backspace.
2017-08-14 17:55:30 -07:00
Grace Guo
025ef5a0f1 Fix Chart Error Message Display (#3287) 2017-08-14 12:24:35 -07:00
Maxime Beauchemin
9a4e4d0443 [dashboard] fix standalone mode that hides the navbar (#3284) 2017-08-14 12:24:05 -07:00
Grace Guo
c9c6bcaabe Improve superset list view content layout (#3031)
* improve superset list view page layout

- less header spaces and stacks
- move pagination down to bottom
- apply material design style to 'add' action button
- will apply to all superset list view, like slices list, security tab lists etc.

* improve superset list view page layout

- less header spaces and stacks
- move pagination down to bottom
- apply material design style to 'add' action button
- will apply to all superset list view, like slices list, security tab lists etc.

* improve superset list view page layout

- less header spaces and stacks
- move pagination down to bottom
- apply material design style to 'add' action button
- will apply to all superset list view, like slices list, security tab lists etc.

* improve superset list view page layout

- less header spaces and stacks
- move pagination down to bottom
- apply material design style to 'add' action button
- will apply to all superset list view, like slices list, security tab lists etc.

* improve superset list view page layout

- less header spaces and stacks
- move pagination down to bottom
- apply material design style to 'add' action button
- will apply to all superset list view, like slices list, security tab lists etc.

* remove tabs from indentation

* fix merge conflicts

* adjust css after code merge
2017-08-11 15:34:29 -07:00
Maxime Beauchemin
144f516700 [markup] fix CSS, remove scrollbar (#3281) 2017-08-11 08:26:47 -07:00
Emanuele Cesena
c17ffc1e9c Fix returned time parse_human_datetime (#2033)
parse_human_datetime parses date-only strings, e.g. "today", returning the correct date but time set at 9am. This is an internal implementation in parsedatetime. This patch resets to midnight. If time is specified and parsed, it is correctly returned.
2017-08-10 23:04:49 -07:00
Rogan
0d4137d21e Add translatable columns in label_columns of the view (#3032)
* add translatable columns in label_columns of the view

* display the verbose_name of columns in list view, just like in the metrics list

* Revert "display the verbose_name of columns in list view, just like in the metrics list"

This reverts commit f815d3b3ed.
2017-08-10 22:28:06 -07:00
Maxime Beauchemin
0c5db55d55 [security] prevent XSS markup viz (#3211)
* Prevent XSS in Markup viz

We protect the browser by sandboxing the user code inside an iframe

* Helvetica
2017-08-10 21:38:33 -07:00
Rogan
bd4a4c2753 add _() to Exception messages (#3034)
* add `_()` to Exception messages

* fix error
2017-08-10 20:57:05 -07:00
Rogan
f399fcd624 display the verbose_name of columns in list view, just like in the metrics list (#3275) 2017-08-10 20:52:24 -07:00
Rogan
08e40e2d78 add placeholder to Select components (#3274) 2017-08-10 20:51:36 -07:00
Luis Rodriguez
2898f9d379 Added Konfio to 'Who uses Superset' list. (#3277) 2017-08-10 20:50:49 -07:00
Alex Guziel
dfea8df7c9 Fix celery worker (#3278) 2017-08-10 20:50:21 -07:00
Rogan
a5320a0f37 [add] Save filters to dashboard (#3183)
* [add] Save filters to dashboard

* format code

* fix CI error

* add semicolon  semi

* fix none object

* add test data
optimize the js code
fix the compatibility issue

* fix urllib to urllib.parse

* add space

* update test case

* remove  'return'

* fix error

* update test case
2017-08-10 20:49:49 -07:00
Grace Guo
b68084b9ac Explore view save modal spec (#3110)
* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* improve test coverage for explore view components:
- SaveModal component
- URLShortLinkButton

* remove comment-out code

* [bugfix] wrong 'Cant have overlap between Series and Breakdowns' (#3254)

* [explore] make edit datasource a basic link (#3244)

* Relying on FAB for font-awesome.min.css (#3261)

* Modernize SQLA pessimistic handling (#3256)

Looks like SQLAlchemy has redefined the best practice around
pessimistic connection handling.

* [webpack] break CSS and JS files while webpackin' (#3262)

* [webpack] break CSS and JS files while webpackin'

* cleaning up some templates

* Fix pylint issue

* import logging (#3264)

* [bugfix] preserve order in groupby (#3268)

Recently in
4c3313b01c
I introduced an issue where the order of groupby fields might change.

This addresses this issue and will preserve ordering.

* Explicitly add Flask as dependancy (#3252)

* Use sane Celery defaults to prevent tasks from being delayed (#3267)

* Improve the chart type of Visualize in sqllab (#3241)

* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar

* add vizTypes filter

* Set default ports Druid (#3266)

For Druid set the default port for the broker and coordinator.

* [explore] Split large reducer logic in ExploreViewContainer (#3088)

* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts
2017-08-10 17:04:44 -07:00
timifasubaa
3b24d7df83 [explore] fixed padding bug on filter section (#3279) 2017-08-10 16:48:30 -07:00
Grace Guo
b3107bb603 [explore] Split large reducer logic in ExploreViewContainer (#3088)
* split reducer logic for ExploreViewContainer

* fix saveModal component and unit tests

* revert changes in SaveModal_spec.
will make another commit just to improve test coverage for SaveModal component.

* remove comment-out code

* fix merge confilicts
2017-08-10 14:21:45 -07:00
Alex Guziel
08b7e891a7 Use sane Celery defaults to prevent tasks from being delayed (#3267) 2017-08-09 22:34:39 -07:00
Maxime Beauchemin
57421d14d0 [bugfix] preserve order in groupby (#3268)
Recently in
4c3313b01c
I introduced an issue where the order of groupby fields might change.

This addresses this issue and will preserve ordering.
2017-08-09 18:06:18 -07:00
Fokko Driesprong
0cf0860a3d Set default ports Druid (#3266)
For Druid set the default port for the broker and coordinator.
2017-08-09 17:25:00 -07:00
Maxime Beauchemin
327c052456 [webpack] break CSS and JS files while webpackin' (#3262)
* [webpack] break CSS and JS files while webpackin'

* cleaning up some templates

* Fix pylint issue
2017-08-09 09:52:43 -07:00
eeve
033ba2cb66 Improve the chart type of Visualize in sqllab (#3241)
* Improve the chart type of Visualize in sqllab & Add some css & Fix the link address in the navbar

* add vizTypes filter
2017-08-09 09:12:21 -07:00
Maxime Beauchemin
cc36428260 Modernize SQLA pessimistic handling (#3256)
Looks like SQLAlchemy has redefined the best practice around
pessimistic connection handling.
2017-08-09 09:10:12 -07:00
Fokko Driesprong
6da68ab271 Explicitly add Flask as dependancy (#3252) 2017-08-09 09:09:02 -07:00
Maxime Beauchemin
be01851ef7 Relying on FAB for font-awesome.min.css (#3261) 2017-08-09 09:04:29 -07:00