Commit Graph

4443 Commits

Author SHA1 Message Date
Erik Ritter 11935ce118
Add commit to attempt to resolve query table lock (#8262) 2019-09-23 14:37:50 -07:00
Maxime Beauchemin 09bbdd277c
chore: skip flaky SQL Lab test (#8282)
Tried 2-3 difference approaches to fix the flaky SQL Lab test that has
been biting us for a while. My guess is that the flakiness comes from
brace (the editor). Hoping a future release of brace and/or cypress
may help with this.

But for now, no test is better than a flaky one.
2019-09-23 11:28:10 -07:00
John Bodley d46510779f
[migration] Stripping leading and trailing whitespace (#8261) 2019-09-23 09:13:01 -07:00
John Bodley 5d1bf4245d
[sql_json] Ensuring the request body is JSON encoded (#8256) 2019-09-23 09:09:12 -07:00
Daniel Vaz Gaspar f3065a763f [database] Improve form and API validation for invalid URI (#8240)
* [database] Improve form and API validation for invalid URI

* [database] Added missing EOL

* [database] lint
2019-09-23 08:28:08 -07:00
kuckjwi 6a08f25b15 Fixed korean translation error. (#8265) 2019-09-22 16:25:56 -07:00
Ben bc83b5fbe6 More intuitive display of negative time deltas (#8274) (#8276)
* WIP - Add easily interpretable negative timedelta formatting

* Add unit tests for utils.core.timedelta_f

* Reformat tests.utils_tests.test_timedelta_f test code. Fixes #8274.

* Add type annotations to utils.core.timedelta_f (#8274)

* Replace recursion with absolute value in utils.core.timedelta_f (#8274)

* Rename utils.core.timedelta_f to format_timedelta (#8274)

* Fix small typo (#8274)
2019-09-22 19:37:43 +03:00
Beto Dealmeida 7090725de9
Fix no data in Presto (#8268)
* Fix no data in Presto

* Fix test
2019-09-20 14:31:13 +02:00
Krist Wongsuphasawat 731c19b630
refactor: use deck.gl plugins from npm package (#8258)
* refactor: use deck.gl plugins from npm package

* fix: remove test files
2019-09-19 16:55:44 -07:00
serenajiang dfb3bf69a0 [typing] add typing for superset/connectors and superset/common (#8138) 2019-09-19 16:51:01 -07:00
Daniel Vaz Gaspar 8bc5cd7dc0 [SQLLab] Refactor sql json endpoint (#8163)
* [superset] sql_json endpoint refactor

* [superset] sql_json endpoint refactor sync

* [superset] Fix, wrong parameter name

* [superset] flake8 and black

* [SQLLab] Don't need to pass request to helper SQLJsonParams

* [SQLLab] try except on query add

* [SQLLab] Remove unwanted changes

* [SQLLab] refactor (cont.)

* [superset] black

* [SQLLab] Remove SQLJsonParams class

* [SQLLab] Fix, add missing type annotations

* [superset] Better exception handling when saving query

* [superset] Remove unnecessary commit

* [superset] one or none instead of first

* [superset] Fix, missing return on error sql_json

* [superset] Fix, black

* [database] Use f strings
2019-09-19 12:15:40 -07:00
Yongjie Zhao 2cd631a26c Fix sync failed when datasource is schema-less (#8223) 2019-09-19 09:11:21 -07:00
Beto Dealmeida 6df74c6b8e
Remove __row_id (#8257) 2019-09-18 20:32:33 -07:00
Erik Ritter 799e08d76f
Update another pypi case from superset to apache-superset (#8250) 2019-09-18 16:36:08 -07:00
Maxime Beauchemin 115bc83b28
docs: reflect the pypi move from superset to apache-superset (#8244) 2019-09-18 14:55:20 -07:00
serenajiang 0c94f0fd82 [sqllab] create query slightly earlier (#8224) 2019-09-18 14:29:07 -07:00
Beto Dealmeida 8e1fc2b0ba
Fix array casting (#8253) 2019-09-18 13:32:58 -07:00
Beto Dealmeida 12fb8e70cc
Show Presto views as views, not tables (#8243)
* WIP

* Implement views in Presto

* Clean up

* Fix CSS

* Fix unit tests

* Add types to database

* Fix circular import
2019-09-18 12:47:10 -07:00
Beto Dealmeida 4088a84eb4
Small fix for Presto dtype map (#8251)
* Small fix for Presto dtype map

* Add unit test
2019-09-18 12:46:50 -07:00
MaiTiano 8d04e1f55f Update README.md (#8246) 2019-09-18 08:15:47 -07:00
1AB9502 0cd4ef54f8 Add RegisteredLookupExtraction support to extraction function (#8185)
* Add RegisteredLookupExtraction support to extraction function

* Fix formatting issues

* Reformat druid_func_tests through black
2019-09-17 23:45:47 -07:00
Beto Dealmeida 88777943fa
Better distinction between tables and views, and show CREATE VIEW (#8213)
* WIP

* Add missing file

* WIP

* Clean up

* Use label instead

* Address comments

* Add docstring

* Fix lint

* Fix typo

* Fix unit test
2019-09-17 14:24:38 -07:00
Beto Dealmeida 4132d8fb0f
Simplify and improve `expand_data` in Presto (#8233)
* WIP

* Working version, needs cleanup

* Add unit tests to split

* Small fixes

* Dedupe array columns

* Fix lint
2019-09-17 14:04:14 -07:00
Beto Dealmeida 8847e10529
Allow users to estimate query cost before executing it (#8172)
* WIP

* Basic functionality working

* Enable per DB

* Show error message

* Small improvements

* Fix lint

* Address comments

* Address comments

* Remove logging, fix exception

* Fix tests

* Bump FAB requirements
2019-09-17 09:09:40 -07:00
Beto Dealmeida b9be01fcd8
Handle int64 columns with missing data in SQL Lab (#8226)
* Handle int64 columns with missing data in SQL Lab

* Fix docstring

* Add unit test

* Small fix

* Small fixes

* Fix cursor description update

* Better fix

* Fix unit test, black

* Fix nan comparison in unit test
2019-09-17 08:16:09 -07:00
Erik Ritter 1ad17936ba [SQL Lab] Fix bug when filtering on results that include nulls (#8231) 2019-09-16 21:05:58 -07:00
Krist Wongsuphasawat bf7ce62166
refactor: prepare control panel configs for separation into plugins (#8222)
* move paired t-test

* fix: remove nvd3sections

* move more controls
2019-09-13 15:52:51 -07:00
Krist Wongsuphasawat 1522d3fbaa
fix: initialize control state for inline control config object (#8221) 2019-09-13 10:36:53 -07:00
John Bodley 762edf430b
[talisman] Enforcing HTTP for status checks (#8214) 2019-09-12 15:54:57 -07:00
Krist Wongsuphasawat c566141f25
feat: read control panel configs from registry (#8173)
* feat: read control panel configs from registry

* fix: order imports

* fix: remove index.js and get items on-the-fly, remove extraOverrides

* fix: lint

* fix: unit tests

* fix: unit tests

* fix: lint

* fix: unit tests
2019-09-11 08:58:24 -07:00
Maxime Beauchemin 30483cee31
chore: fix version info (#8196)
* Fix version info

Ran into Cypress issues while getting too ambitious in #8157
this is a simplified more targeted version of it

* include package.json (but not under static/)
* use package.json as single source of truth for version info

* typo
2019-09-10 22:25:58 -07:00
Maxime Beauchemin cb6abe343b
fix: attempt to fix the flaky SQL Lab test (#8212)
* fix: attempt to fix the flaky SQL Lab test

https://docs.cypress.io/api/commands/clear.html#Syntax

doubling our chances to selectall and clear the text box

* Add {force: true}

* fix typo

* more clears
2019-09-10 22:16:26 -07:00
klxiang 50cd558d40 Update messages.json (#8210) 2019-09-10 15:51:51 -07:00
Grace Guo b4a1234670
[feature][dashboard] Show/hide filter indicator on the applicable charts when filter options are open/close (#8166)
* show ellipsis for long filter name in tooltip

* show filter indicator color bar when filter is applied

* show/hide filter indicator when filter is showing/hiding options

* use component local state to hide/show chart outline

* fix review comments + unit tests
2019-09-10 15:29:13 -07:00
garnservo 296f3e81a7 Update README.md (#8206)
Corrected typos
2019-09-10 11:11:42 -07:00
Maxime Beauchemin b8819226b9
chore: update UPDATING.md with a 0.34.0 section (#8208)
Also documenting this step under RELEASING/README.md
2019-09-10 10:36:07 -07:00
John Bodley 84bf5b40fa
[viz] Adding get_def typing (#8034) 2019-09-10 09:55:17 -07:00
Daniel Vaz Gaspar 83f7038374 [examples] Fix, sf population polygons div by zero error (#8209) 2019-09-10 09:53:27 -07:00
Maxime Beauchemin 9d4b955cc7
chore: deprecate restricted metrics (#8197)
* chore: deprecate restricted metrics

An early community contribution added the concept of restricted metrics.

The idea was to allow for some metrics to be restricted, and if a metric
was tagged as such, a user would need to be given access to that metric
more explicitely, through a special perm we would maintain for that
metric.

Now since the new concept of "Adhoc Metrics", the popover that lets a
user pick a column and an aggregate function or to write their own SQL
expression inline, this restriction is completely bypassed. Adhoc
metrics was developed without the restricted metrics in mind.

Anyhow, in the near future, we'll be rethinking the ideas behind
data-access permissions, and things like column-level or row-level
security will be redesigned from scratch.

By deprecating this feature, we're removing a confusing and mostly broken
feature, and making it easy to move forward

* Use context manager to drop columns

* disable jest's maxWorkers
2019-09-09 17:20:32 -07:00
klxiang 7546ea3191 Update messages.json (#8198)
"dashboards" 有的翻译成"看板", 有的翻译成"仪表盘". 为了统一现在全部改为"看板".
2019-09-09 11:25:01 -07:00
Dave Smith 1a02d61582 change log from csv_export to data_export; fix db name in log (#8204)
* change log from csv_export to data_export; fix db name in log

* add exported_format field to data_export event log
2019-09-09 11:08:47 -07:00
serenajiang 4e2d1c1a62 more detailed async error messages (#8164) 2019-09-09 09:09:15 -07:00
Erik Ritter c053e23397
[Config] Disable celery acks late (#8182) 2019-09-09 09:07:38 -07:00
Daniel Vaz Gaspar 055d2ef252 Bump FAB to 2.1.13 (#8176)
* Bump FAB to 2.1.13

* [SQLLab] dummy commit

* [SQLLab] remove dummy commit

* [SQLLab] test

* [SQLLab] bump back to 13
2019-09-08 22:06:24 -07:00
Maxime Beauchemin 68c4c3a0b9
Prevent 'main' database connection creation (#8038)
* prevent 'main' database connection creation

* fix tests

* removing get_main_database

* Kill get_main_database

* Point to examples tables
2019-09-08 10:18:09 -07:00
Garrett Bates 9d350aadf0 ignore formatting for <Select> (#8187) 2019-09-08 10:16:07 -07:00
Paul Vickers 22302e341f Bump flask-appbuilder to 2.1.13 (#8174)
* Bump flask-appbuilder to 2.1.12

To pick up this fix https://github.com/dpgaspar/Flask-AppBuilder/pull/1095 which addresses https://github.com/apache/incubator-superset/issues/7739

* Bump FAB again to 2.1.13
2019-09-08 09:58:59 -07:00
Ville Brofeldt 3250c5ac94
[bugfix] fix timegrain addon regression (#8165)
* Fix regression in time grain addons

* Revert privatization of time_grain_functions

* Fix test

* Rename variable

* Fix test

* Fix typing error

* Refactor and add tests

* Add TODO
2019-09-08 08:34:40 +02:00
John Bodley 9dfa0a3f8e
Update core.py (#8191) 2019-09-07 23:32:17 -07:00
serenajiang be33934b83 [fix] retry stop_query on all exceptions (#8184) 2019-09-06 10:16:08 -07:00