Jesse Yang
d2da25a621
refactor: remove queryFields in QueryObject and update chart control configs ( #12091 )
...
* Clean up queryFields
* Clean up unused vars
* Bump chart plugins
* Bringing changes in #12147
2020-12-22 17:10:19 -08:00
Nikola Gigić
a52031a55e
chore: Change chart_is_fav to chart_is_favorite ( #12075 )
...
* Change chart_is_fav to chart_is_favorite
* Trigger cypress tests
* Retrigger cypress tests
* Retrigger all tests
* Dashboard
* Additions
2020-12-22 10:03:26 -08:00
Yongjie Zhao
b592cc7e73
feat(explore): time picker enhancement ( #11418 )
2020-12-17 18:27:21 -08:00
Daniel Vaz Gaspar
f79e52f48e
feat(charts): security perm simplification ( #11981 )
...
* feat(charts): security perm simplification
* fix superset explore
* fix JS test
* fix cypress test
* fix split heads
* fix favorite permission
* fix permission
* update with new async permission
* fix new permission coming from master
* fix core permission assert
* black
* update alembic down revision
2020-12-15 11:27:06 +00:00
Rob DiCiuccio
4d329071a1
feat(SIP-39): Async query support for charts ( #11499 )
...
* Generate JWT in Flask app
* Refactor chart data API query logic, add JWT validation and async worker
* Add redis stream implementation, refactoring
* Add chart data cache endpoint, refactor QueryContext caching
* Typing, linting, refactoring
* pytest fixes and openapi schema update
* Enforce caching be configured for async query init
* Async query processing for explore_json endpoint
* Add /api/v1/async_event endpoint
* Async frontend for dashboards [WIP]
* Chart async error message support, refactoring
* Abstract asyncEvent middleware
* Async chart loading for Explore
* Pylint fixes
* asyncEvent middleware -> TypeScript, JS linting
* Chart data API: enforce forced_cache, add tests
* Add tests for explore_json endpoints
* Add test for chart data cache enpoint (no login)
* Consolidate set_and_log_cache and add STORE_CACHE_KEYS_IN_METADATA_DB flag
* Add tests for tasks/async_queries and address PR comments
* Bypass non-JSON result formats for async queries
* Add tests for redux middleware
* Remove debug statement
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Skip force_cached if no queryObj
* SunburstViz: don't modify self.form_data
* Fix failing annotation test
* Resolve merge/lint issues
* Reduce polling delay
* Fix new getClientErrorObject reference
* Fix flakey unit tests
* /api/v1/async_event: increment redis stream ID, add tests
* PR feedback: refactoring, configuration
* Fixup: remove debugging
* Fix typescript errors due to redux upgrade
* Update UPDATING.md
* Fix failing py tests
* asyncEvent_spec.js -> asyncEvent_spec.ts
* Refactor flakey Python 3.7 mock assertions
* Fix another shared state issue in Py tests
* Use 'sub' claim in JWT for user_id
* Refactor async middleware config
* Fixup: restore FeatureFlag boolean type
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-10 20:21:56 -08:00
Beto Dealmeida
475f59cb1c
feat: confirm overwrite when importing ( #11982 )
...
* feat: confirm overwrite when importing
* Skip flaky test
2020-12-10 14:50:10 -08:00
Kasia Kucharczyk
4da47f1635
tests: added fixture with energy usage instead of example ( #11308 )
...
* Added energy usage fixture. Updated dashboard utils and unicode fixture with new method parameters.
* Add energy fixture to tests/access_tests.py
* Add energy fixture to tests/core_tests.py
* Add energy fixture to tests/dashboard_tests.py
* Add energy fixture to tests/datasets/api_tests.py
* Add energy fixture to tests/db_engine_specs/base_engine_spec_tests.py
* Add energy fixture to tests/import_export_tests.py
* Add energy fixture to tests/model_tests.py
* Add energy fixture to tests/query_context_tests.py
* Add energy fixture to tests/security_tests.py
* Add energy fixture to tests/charts/api_tests.py
* Changed formatting of slices' parameters in energy usage fixture
* Removed loading energy udage data from test conf file
* Add energy fixture to tests/databases/api_tests.py
* Fixes after review: removed isort:skip, load_charts->load_energy_charts, removed unused import.
* Added energy fixture to tests/charts/commands_tests.py and retrieving proper Slice by name
* Fixed charts/api_tests.py to use energy_usage from fixtures
* Fixed datasets/commands_tests.py to retrieve dataset by name and use energy_usage fixture
* Changed energy usage data to generated data and fixed chart tests which was checking energy usage data
2020-12-09 12:02:29 -08:00
Ville Brofeldt
327a2817d3
feat: add event and interval annotation support to chart data ep ( #11665 )
...
* feat: add event and interval annotation support to chart data ep
* add tests + refactor fixtures
* use chart dao
2020-12-04 14:40:31 +02:00
Kasia Kucharczyk
462b39d762
fix: update chart doesn't remove all connections to dashboards ( #11830 )
...
* Added possibility to not change dashboards connection when chart is changed
* Added two chart unit tests which checks if dashboards properly change on update
2020-11-30 09:48:14 -08:00
Daniel Vaz Gaspar
bac84a3aac
fix: delete chart, dashboards, dbs with assoc reports ( #11801 )
...
* fix: delete chart or dashboards with assoc reports
* database constraint to reports and tests
* add tests for dashboards and database
* fix exceptions default text
2020-11-26 08:45:49 +00:00
Beto Dealmeida
c354e7e0ab
fix: remove root dir from ZIP bundle ( #11805 )
...
* fix: remove root dir from ZIP bundle
* Fix lint
* Fix tests
* Improve tests
* Fix dashboard as well
2020-11-25 11:47:48 -08:00
Beto Dealmeida
a3a2a68f01
feat: API endpoint to import charts ( #11744 )
...
* ImportChartsCommand
* feat: API endpoint to import charts
* Add dispatcher
* Fix docstring
2020-11-20 14:40:27 -08:00
ʈᵃᵢ
edb9619731
refactor: reduce number of api calls needed to fetch favorite status for charts and dashboards ( #11502 )
2020-11-02 21:26:14 -08:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators ( #10936 )
...
* Initial commit of new filters badge.
* refactor applied/rejected filters code
* finished filter indicators
* filter badge tested
* unnecessary imports
* formatting and types
* fixes
* license
* code quality tweaks
* state management for showing focused filter scope
* clean up filter key extraction code
* remove unnecessary styles
* temp css to demonstrate highlighting
* fix focused filter logic
* no more color badges
* new toys for highlighting dash components (#11144 )
* tweak style for the filter chart when filter is focused
* style: Filters p0 css2 (#11151 )
* nixing background tweak
* src paths
* another quick theme color
* src paths, adjusting pill icon color, changing icons, showing applied/busted counts
* linting stuff
* fixing and tweaking tests
* show filter indicator when filters are not active
* chart title bar cleanup
* open the right panel when popover opens
* unused import
* fix EditableTitle tests
* margin on dashboard header
* show the chart dropdown menu
* fix blur filter breaking dropdowns
* style tweak - no pointer events when irrelevant charts are blurred
* fix box shadow on filter highlight
* it's an array
* attempt fixing e2e
* style: filters p0 icon churn (#11215 )
* new filters icon
* icon styling
* bigger icons in list views
* better sizing of table actions and favStars
* more icon sizing...
* fixing more button size jankiness
* linting
* Filters performance (#11255 )
* fixing time filter "ok" button
* making unset filter menu collapsible
* sort alphabetically
* fix highlighting when removing items
* try a flex layout (for browser render perf)
* more specific transitioning
* temp: comment out some code as a test
* temp: comment out more code
* temp: remove possibly expensive computations from ChartHolder
* Revert "temp: comment out some code as a test"
This reverts commit 309b880e90
.
* Revert "temp: comment out more code"
This reverts commit 64c88b2cba
.
* Revert "temp: remove possibly expensive computations from ChartHolder"
This reverts commit 37ce0214f0
.
* experiment: upgrade react-select to v3
* Revert "experiment: upgrade react-select to v3"
This reverts commit c3972ba486
.
* fix the damn problem
* remove code used for testing purposes
* awful hack to avoid adding a class to a container
* approaching infinity... and not beyond!
* fix ref forwarding
* add theme to tests as necessary
* fix(extra-filters): add logic for identifying applied extra filters (#11325 )
* fix: use dashboard id for stable cache key (#11293 )
* fix: button translations missing (#11187 )
* button translations missing
* blank space before text
* feat: update time_compare description and choices (#11294 )
* feat: update time_compare description and choices
* Update sections.jsx
* fix(extra-filters): add logic for identifying applied extra filters
* lint
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* address design feedback
* slight tweak to panel logic, keep panels open that user has opened
* rearrange code to be more graceful
* fix: bump superset-ui/core (#11385 )
* use is_dttm instead of is_temporal
* types, names
* only show unset filter panel if there are unset filters
* fix highlighting the filter control
* fix filterbox layout
* translations
* fix cypress
* actually add the test attribute
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* formatting
* add link comment to hack
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* stop importing lodash
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* skip broken test
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* adjust colors of titles
* linting
* no indicators when chart is loading
* support all time fields
* fix lock file
Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2020-10-28 15:46:24 -07:00
Beto Dealmeida
633355ab00
feat: export charts as ZIP files ( #11349 )
...
* Export datasets as ZIP files
* Add logging when failing to parse extra
* Export charts as Zip file
* Fix lint
2020-10-22 12:06:58 -07:00
Beto Dealmeida
94e23bfc82
feat: export databases as a ZIP bundle ( #11229 )
...
* Export databases as Zip file
* Fix tests
* Address comments
* Implement mulexport for database
* Fix lint
* Fix lint
2020-10-16 11:10:39 -07:00
Kasia Kucharczyk
9caf875263
Refactored api_tests in charts. Split filter test into several unit tests cases. Added table id based on database id ( #11249 )
2020-10-14 12:41:37 -07:00
Kasia Kucharczyk
32e174d4b8
test: removed unicode_test example from unit tests ( #11131 )
...
* Removed depemdency to unicode example in tests config.
* Added common methods for creating dashboards for tests.
* Added fixtures to all tests which were using unicode example.
* Added cleanup for unicode_test table
* Removed unnecessary fixture parts of unicode dashboard tests
* Parametrized creating slice for tests
* Moved fixtures for unicode test to separate file and refactored to several methods. Added param types and return types.
* Cleandup after fix
* Changed variable names to more readable
* Added cleanup for dashboards and slices
* Applied unicode fixture to charts api tests
* Update schema variable to dtype in dashboard utils
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Changed variable schema to dtype in dashboards. Replaced accessing first element with one_or_none
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-10-07 18:29:37 +03:00
Daniel Vaz Gaspar
4c85d33109
feat: custom favorite filter for dashboards, charts and saved queries ( #11083 )
...
* feat: custom favorite filter for dashboards
* lint and sort
* add favored for charts
* fix tests and lint
* more tests and saved query filter
* fix tests
* fix tests
* lint
* lint and fix conflict
* remove unnecessary prop
* separate tests
2020-10-01 15:08:40 -07:00
Lily Kuang
5b284e67eb
feat: add created by chart CRUD view ( #11067 )
2020-09-30 13:53:04 -07:00
Ville Brofeldt
ada66e30dd
fix(chart-data-api): ignore missing filters ( #11112 )
2020-09-30 09:34:23 +01:00
ʈᵃᵢ
1dc05d4c12
feat(charts): modify custom api filter to include more fields ( #11054 )
2020-09-28 10:18:34 -07:00
Ville Brofeldt
58b075bc17
fix(jinja): extract form_data from json body ( #10684 )
...
* fix(jinja): extract form_data from json body
* add test
* disable test for presto
2020-08-28 21:26:07 +03:00
Bogdan
0071d374da
chore: move load examples to the fixture ( #10545 )
...
* Move load examples to the fixture
* Update tests/celery_tests.py
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Address feedback
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-08-10 13:20:19 -07:00
Erik Ritter
fd2d1c58c5
Revert "chore: Cleanup database sessions ( #10427 )" ( #10537 )
...
This reverts commit 7645fc85c3
.
2020-08-06 15:33:48 -07:00
Bogdan
62b873e3da
feat: welcome presto to the suite of tested databases ( #10498 )
...
* Add presto to the CI
Sample test data
Datetime conversion
Sample test data
Fix tests
* TODO to switch to timestamps
* Address feedback
* Update requirements
* Add TODOs
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-06 12:07:22 -07:00
Bogdan
ab404ea2cf
Sample test data ( #10487 )
...
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-08-03 09:08:49 -07:00
John Bodley
7645fc85c3
chore: Cleanup database sessions ( #10427 )
...
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-07-30 23:07:56 -07:00
ʈᵃᵢ
78cad9a4a8
refactor(listviews): use correct filter endpoints for charts and datasets ( #10442 )
2020-07-29 11:00:19 -07:00
Ville Brofeldt
7af8b2b3f8
feat: add optional prophet forecasting functionality to chart data api ( #10324 )
...
* feat: add prophet post processing operation
* add tests
* lint
* whitespace
* remove whitespace
* address comments
* add note to UPDATING.md
2020-07-20 18:46:51 +03:00
Daniel Vaz Gaspar
74cb82e1ad
fix: humanised changed on UTC on dashboards and charts ( #10321 )
...
* fix: API marshmallow3 drop utc for naive datetime fields
* fix: API marshmallow3 drop utc for naive datetime fields
* fix, tests
* isort and test
* black
* add and fix test
* fix comment
2020-07-15 19:09:32 +01:00
Ville Brofeldt
42b6347fca
fix: fix csv and query result type and QueryObject schema ( #10312 )
2020-07-14 16:37:19 +03:00
Ville Brofeldt
c44ee06b5d
fix(chart-data-api): improve chart data endpoint errors ( #10300 )
...
* fix: improve chart data error response
* Populate error_message in QueryResult
* add tests
* Lint + fix incorrect raise
* add more tests
2020-07-14 12:40:00 +03:00
Ville Brofeldt
b316f723a1
fix(chart-data-api): case insensitive evaluation of filter op ( #10299 )
...
* fix(chart-data-api): case insensitive evaluation of filter op
* fix(chart-data-api): case insensitive evaluation of filter op
* mypy
* remove print statement
* add test
2020-07-13 17:21:02 +03:00
Daniel Vaz Gaspar
878dbcda3f
feat(api): bump marshmallow and FAB to version 3 ( #9964 )
...
* feat(api): bump marshmallow and FAB to version 3
* revert query context tests changes
* obey mypy
* fix tests
* ignore types that collide with marshmallow
* preparing for RC2
* fix tests for marshmallow 3
* typing fixes for marshmallow
* fix tests and black
* fix tests
* bump to RC3 and lint
* Test RC4
* Final 3.0.0
* Address comments, fix tests, better naming, docs
* fix test
* couple of fixes, addressing comments
* bumping marshmallow
2020-07-07 13:26:54 +01:00
Bogdan
4e340c8368
feat: Switch from nosetest to pytest ( #10177 )
...
* Switch from nosetest to pytest
Fix schedule tests
Collect pytest coverage
Move pytest config into pytest.ini
Move cov to the pytest.ini
* Append coverage for the 2nd run
* Add coverage to all commands
* Coverage only for tests
* Get coverage from 1 place
* Rename classes to be pytest compatible
* Test coverage for examples and tests
* Max diff to -1
* Explain how to run pytest for the whole project
* Do not append code coverage for the main run
* Do not run coverage on examples
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-06-29 15:36:06 -07:00
Ville Brofeldt
315518d2d2
feat: add support for query offset ( #10010 )
...
* feat: add support for query offset
* Address comments and add new tests
2020-06-09 11:46:28 +03:00
Daniel Vaz Gaspar
0d85d25314
docs(api): improve openapi documentation for dash, charts and queries ( #9724 )
2020-05-05 14:42:18 +01:00
Daniel Vaz Gaspar
f13ba2561c
fix(tests): custom filter flaky tests on dash and charts ( #9679 )
2020-04-29 08:36:11 +01:00
Ville Brofeldt
a6cedaaa87
chore: Improve chart data API + schemas + tests ( #9599 )
...
* Make all fields optional in QueryObject and fix having_druid schema
* fix: datasource type sql to table
* lint
* Add missing fields
* Refactor tests
* Linting
* Refactor query context fixtures
* Add typing to test func
2020-04-23 14:30:48 +03:00
ʈᵃᵢ
0b999e3b91
[charts] adds new filters ui ( #9530 )
...
* [charts] adds new filters ui
* move null check to be more visible
* better filter lists and async filter functionality
2020-04-21 12:04:11 -07:00
Lily Kuang
7cefc89c64
[charts] feat: add statsd to charts api ( #9571 )
...
* add statsd to charts api
* update test for charts api
* [charts] add statsd asserts wrapper
* [charts] update api test
* removed white space
2020-04-21 19:57:42 +01:00
Ville Brofeldt
0472c11157
fix: Add deprecated fields to QueryObject schema ( #9579 )
...
* fix: Add deprecated fields to QueryObject schema
* linting
2020-04-18 20:28:57 +03:00
Ville Brofeldt
8e439b1115
chore: Add OpenAPI docs to /api/v1/chart/data EP ( #9556 )
...
* Add OpenAPI docs to /api/v1/chart/data EP
* Add missing fields to QueryObject, fix linting and unit test errors
* Fix unit test errors
* abc
* Fix errors uncovered by schema validation and add unit test for invalid payload
* Add schema for response
* Remove unnecessary pylint disable
2020-04-17 16:44:16 +03:00
Daniel Vaz Gaspar
622561f756
[charts] New, custom filter for name OR description ( #9492 )
...
* [charts] New, custom filter for name OR description
* Improve test
2020-04-11 07:25:54 +01:00
Daniel Vaz Gaspar
0610c489bb
[query] Migrate api v1 query to new location ( #9479 )
...
* [query] Migrate api v1 query to new location
* Improved errors and tests
* [query] nit and revert undesired change
* [query] lint
* [query] revert nan change
* Update superset/queries/api.py
Co-Authored-By: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* Update tests/queries/api_tests.py
Co-Authored-By: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
* change endpoint location to charts
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-04-09 09:05:49 +01:00
Daniel Vaz Gaspar
4485800e21
[tests] refactor, change datasets and charts to it's own folder ( #9487 )
2020-04-08 08:44:35 +01:00