pt/superset
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2024-09-06 13:57:40 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix(dashboard|chart): use correct url for favorite_status and change request type to rison (#13557)

Browse Source
This commit is contained in:
ʈᵃᵢ 2021-03-15 10:53:16 -06:00 committed by GitHub
parent fc345b9ab1
commit 4de6040d89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
superset-frontend/src/views/CRUD/hooks.ts
View File

@ -484,15 +484,15 @@ type FavoriteStatusResponse = {
}; };
const favoriteApis = { const favoriteApis = {
chart: makeApi<string, FavoriteStatusResponse>({ chart: makeApi<Array<string | number>, FavoriteStatusResponse>({
requestType: 'search', requestType: 'rison',
method: 'GET', method: 'GET',
endpoint: '/api/v1/chart/favorite_status', endpoint: '/api/v1/chart/favorite_status/',
}), }),
dashboard: makeApi<string, FavoriteStatusResponse>({ dashboard: makeApi<Array<string | number>, FavoriteStatusResponse>({
requestType: 'search', requestType: 'rison',
method: 'GET', method: 'GET',
endpoint: '/api/v1/dashboard/favorite_status', endpoint: '/api/v1/dashboard/favorite_status/',
}), }),
}; };
@ -510,7 +510,7 @@ export function useFavoriteStatus(
if (!ids.length) { if (!ids.length) {
return; return;
} }
favoriteApis[type](`q=${rison.encode(ids)}`).then( favoriteApis[type](ids).then(
({ result }) => { ({ result }) => {
const update = result.reduce((acc, element) => { const update = result.reduce((acc, element) => {
acc[element.id] = element.value; acc[element.id] = element.value;
@ -524,7 +524,7 @@ export function useFavoriteStatus(
), ),
), ),
); );
}, [ids]); }, [ids, type, handleErrorMsg]);
const saveFaveStar = useCallback( const saveFaveStar = useCallback(
(id: number, isStarred: boolean) => { (id: number, isStarred: boolean) => {