From 4de6040d89bf6c5497ac60b8b2cf0c6e75fdd001 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=CA=88=E1=B5=83=E1=B5=A2?= <tdupreetan@gmail.com>
Date: Mon, 15 Mar 2021 10:53:16 -0600
Subject: [PATCH] fix(dashboard|chart): use correct url for favorite_status and
 change request type to rison (#13557)

---
 superset-frontend/src/views/CRUD/hooks.ts | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/superset-frontend/src/views/CRUD/hooks.ts b/superset-frontend/src/views/CRUD/hooks.ts
index bae34f8dfa..67b0a72015 100644
--- a/superset-frontend/src/views/CRUD/hooks.ts
+++ b/superset-frontend/src/views/CRUD/hooks.ts
@@ -484,15 +484,15 @@ type FavoriteStatusResponse = {
 };
 
 const favoriteApis = {
-  chart: makeApi<string, FavoriteStatusResponse>({
-    requestType: 'search',
+  chart: makeApi<Array<string | number>, FavoriteStatusResponse>({
+    requestType: 'rison',
     method: 'GET',
-    endpoint: '/api/v1/chart/favorite_status',
+    endpoint: '/api/v1/chart/favorite_status/',
   }),
-  dashboard: makeApi<string, FavoriteStatusResponse>({
-    requestType: 'search',
+  dashboard: makeApi<Array<string | number>, FavoriteStatusResponse>({
+    requestType: 'rison',
     method: 'GET',
-    endpoint: '/api/v1/dashboard/favorite_status',
+    endpoint: '/api/v1/dashboard/favorite_status/',
   }),
 };
 
@@ -510,7 +510,7 @@ export function useFavoriteStatus(
     if (!ids.length) {
       return;
     }
-    favoriteApis[type](`q=${rison.encode(ids)}`).then(
+    favoriteApis[type](ids).then(
       ({ result }) => {
         const update = result.reduce((acc, element) => {
           acc[element.id] = element.value;
@@ -524,7 +524,7 @@ export function useFavoriteStatus(
         ),
       ),
     );
-  }, [ids]);
+  }, [ids, type, handleErrorMsg]);
 
   const saveFaveStar = useCallback(
     (id: number, isStarred: boolean) => {