diff --git a/superset-frontend/src/views/CRUD/hooks.ts b/superset-frontend/src/views/CRUD/hooks.ts index bae34f8dfa..67b0a72015 100644 --- a/superset-frontend/src/views/CRUD/hooks.ts +++ b/superset-frontend/src/views/CRUD/hooks.ts @@ -484,15 +484,15 @@ type FavoriteStatusResponse = { }; const favoriteApis = { - chart: makeApi({ - requestType: 'search', + chart: makeApi, FavoriteStatusResponse>({ + requestType: 'rison', method: 'GET', - endpoint: '/api/v1/chart/favorite_status', + endpoint: '/api/v1/chart/favorite_status/', }), - dashboard: makeApi({ - requestType: 'search', + dashboard: makeApi, FavoriteStatusResponse>({ + requestType: 'rison', method: 'GET', - endpoint: '/api/v1/dashboard/favorite_status', + endpoint: '/api/v1/dashboard/favorite_status/', }), }; @@ -510,7 +510,7 @@ export function useFavoriteStatus( if (!ids.length) { return; } - favoriteApis[type](`q=${rison.encode(ids)}`).then( + favoriteApis[type](ids).then( ({ result }) => { const update = result.reduce((acc, element) => { acc[element.id] = element.value; @@ -524,7 +524,7 @@ export function useFavoriteStatus( ), ), ); - }, [ids]); + }, [ids, type, handleErrorMsg]); const saveFaveStar = useCallback( (id: number, isStarred: boolean) => {