mirror of
https://github.com/apache/superset.git
synced 2024-09-19 20:19:37 -04:00
18658f45be
* Initial commit of new filters badge. * refactor applied/rejected filters code * finished filter indicators * filter badge tested * unnecessary imports * formatting and types * fixes * license * code quality tweaks * state management for showing focused filter scope * clean up filter key extraction code * remove unnecessary styles * temp css to demonstrate highlighting * fix focused filter logic * no more color badges * new toys for highlighting dash components (#11144) * tweak style for the filter chart when filter is focused * style: Filters p0 css2 (#11151) * nixing background tweak * src paths * another quick theme color * src paths, adjusting pill icon color, changing icons, showing applied/busted counts * linting stuff * fixing and tweaking tests * show filter indicator when filters are not active * chart title bar cleanup * open the right panel when popover opens * unused import * fix EditableTitle tests * margin on dashboard header * show the chart dropdown menu * fix blur filter breaking dropdowns * style tweak - no pointer events when irrelevant charts are blurred * fix box shadow on filter highlight * it's an array * attempt fixing e2e * style: filters p0 icon churn (#11215) * new filters icon * icon styling * bigger icons in list views * better sizing of table actions and favStars * more icon sizing... * fixing more button size jankiness * linting * Filters performance (#11255) * fixing time filter "ok" button * making unset filter menu collapsible * sort alphabetically * fix highlighting when removing items * try a flex layout (for browser render perf) * more specific transitioning * temp: comment out some code as a test * temp: comment out more code * temp: remove possibly expensive computations from ChartHolder * Revert "temp: comment out some code as a test" This reverts commit309b880e90
. * Revert "temp: comment out more code" This reverts commit64c88b2cba
. * Revert "temp: remove possibly expensive computations from ChartHolder" This reverts commit37ce0214f0
. * experiment: upgrade react-select to v3 * Revert "experiment: upgrade react-select to v3" This reverts commitc3972ba486
. * fix the damn problem * remove code used for testing purposes * awful hack to avoid adding a class to a container * approaching infinity... and not beyond! * fix ref forwarding * add theme to tests as necessary * fix(extra-filters): add logic for identifying applied extra filters (#11325) * fix: use dashboard id for stable cache key (#11293) * fix: button translations missing (#11187) * button translations missing * blank space before text * feat: update time_compare description and choices (#11294) * feat: update time_compare description and choices * Update sections.jsx * fix(extra-filters): add logic for identifying applied extra filters * lint Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: rubenSastre <ruben.sastre@decathlon.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> * address design feedback * slight tweak to panel logic, keep panels open that user has opened * rearrange code to be more graceful * fix: bump superset-ui/core (#11385) * use is_dttm instead of is_temporal * types, names * only show unset filter panel if there are unset filters * fix highlighting the filter control * fix filterbox layout * translations * fix cypress * actually add the test attribute * Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * formatting * add link comment to hack * Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * stop importing lodash * Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * skip broken test * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * adjust colors of titles * linting * no indicators when chart is loading * support all time fields * fix lock file Co-authored-by: Natalie Ruhe <natalie@preset.io> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: rubenSastre <ruben.sastre@decathlon.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
190 lines
6.4 KiB
JavaScript
190 lines
6.4 KiB
JavaScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import { Provider } from 'react-redux';
|
|
import React from 'react';
|
|
import { mount, shallow } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
import { Tabs as BootstrapTabs, Tab as BootstrapTab } from 'react-bootstrap';
|
|
import { supersetTheme, ThemeProvider } from '@superset-ui/core';
|
|
|
|
import DashboardComponent from 'src/dashboard/containers/DashboardComponent';
|
|
import DeleteComponentButton from 'src/dashboard/components/DeleteComponentButton';
|
|
import HoverMenu from 'src/dashboard/components/menu/HoverMenu';
|
|
import DragDroppable from 'src/dashboard/components/dnd/DragDroppable';
|
|
import Tabs from 'src/dashboard/components/gridComponents/Tabs';
|
|
import { DASHBOARD_ROOT_ID } from 'src/dashboard/util/constants';
|
|
import WithDragDropContext from '../../helpers/WithDragDropContext';
|
|
import { dashboardLayoutWithTabs } from '../../fixtures/mockDashboardLayout';
|
|
import { mockStoreWithTabs } from '../../fixtures/mockStore';
|
|
|
|
describe('Tabs', () => {
|
|
const props = {
|
|
id: 'TABS_ID',
|
|
parentId: DASHBOARD_ROOT_ID,
|
|
component: dashboardLayoutWithTabs.present.TABS_ID,
|
|
parentComponent: dashboardLayoutWithTabs.present[DASHBOARD_ROOT_ID],
|
|
index: 0,
|
|
depth: 1,
|
|
renderTabContent: true,
|
|
editMode: false,
|
|
availableColumnCount: 12,
|
|
columnWidth: 50,
|
|
onResizeStart() {},
|
|
onResize() {},
|
|
onResizeStop() {},
|
|
createComponent() {},
|
|
handleComponentDrop() {},
|
|
onChangeTab() {},
|
|
deleteComponent() {},
|
|
updateComponents() {},
|
|
logEvent() {},
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
// We have to wrap provide DragDropContext for the underlying DragDroppable
|
|
// otherwise we cannot assert on DragDroppable children
|
|
const wrapper = mount(
|
|
<Provider store={mockStoreWithTabs}>
|
|
<WithDragDropContext>
|
|
<Tabs {...props} {...overrideProps} />
|
|
</WithDragDropContext>
|
|
</Provider>,
|
|
{
|
|
wrappingComponent: ThemeProvider,
|
|
wrappingComponentProps: { theme: supersetTheme },
|
|
},
|
|
);
|
|
return wrapper;
|
|
}
|
|
|
|
it('should render a DragDroppable', () => {
|
|
// test just Tabs with no children DragDroppables
|
|
const wrapper = setup({ component: { ...props.component, children: [] } });
|
|
expect(wrapper.find(DragDroppable)).toExist();
|
|
});
|
|
|
|
it('should render BootstrapTabs', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(BootstrapTabs)).toExist();
|
|
});
|
|
|
|
it('should set animation=true, mountOnEnter=true, and unmounOnExit=false on BootstrapTabs for perf', () => {
|
|
const wrapper = setup();
|
|
const tabProps = wrapper.find(BootstrapTabs).props();
|
|
expect(tabProps.animation).toBe(true);
|
|
expect(tabProps.mountOnEnter).toBe(true);
|
|
expect(tabProps.unmountOnExit).toBe(false);
|
|
});
|
|
|
|
it('should render a BootstrapTab for each child', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(BootstrapTab)).toHaveLength(
|
|
props.component.children.length,
|
|
);
|
|
});
|
|
|
|
it('should render an extra (+) BootstrapTab in editMode', () => {
|
|
const wrapper = setup({ editMode: true });
|
|
expect(wrapper.find(BootstrapTab)).toHaveLength(
|
|
props.component.children.length + 1,
|
|
);
|
|
});
|
|
|
|
it('should render a DashboardComponent for each child', () => {
|
|
// note: this does not test Tab content
|
|
const wrapper = setup({ renderTabContent: false });
|
|
expect(wrapper.find(DashboardComponent)).toHaveLength(
|
|
props.component.children.length,
|
|
);
|
|
});
|
|
|
|
it('should call createComponent if the (+) tab is clicked', () => {
|
|
const createComponent = sinon.spy();
|
|
const wrapper = setup({ editMode: true, createComponent });
|
|
wrapper
|
|
.find('.dashboard-component-tabs .nav-tabs a')
|
|
.last()
|
|
.simulate('click');
|
|
|
|
expect(createComponent.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call onChangeTab when a tab is clicked', () => {
|
|
const onChangeTab = sinon.spy();
|
|
const wrapper = setup({ editMode: true, onChangeTab });
|
|
wrapper
|
|
.find('.dashboard-component-tabs .nav-tabs a')
|
|
.at(1) // will not call if it is already selected
|
|
.simulate('click');
|
|
|
|
expect(onChangeTab.callCount).toBe(1);
|
|
});
|
|
|
|
it('should not call onChangeTab when anchor link is clicked', () => {
|
|
const onChangeTab = sinon.spy();
|
|
const wrapper = setup({ editMode: true, onChangeTab });
|
|
wrapper
|
|
.find('.dashboard-component-tabs .nav-tabs a .short-link-trigger')
|
|
.at(1) // will not call if it is already selected
|
|
.simulate('click');
|
|
|
|
expect(onChangeTab.callCount).toBe(0);
|
|
});
|
|
|
|
it('should render a HoverMenu in editMode', () => {
|
|
let wrapper = setup();
|
|
expect(wrapper.find(HoverMenu)).not.toExist();
|
|
|
|
wrapper = setup({ editMode: true });
|
|
expect(wrapper.find(HoverMenu)).toExist();
|
|
});
|
|
|
|
it('should render a DeleteComponentButton in editMode', () => {
|
|
let wrapper = setup();
|
|
expect(wrapper.find(DeleteComponentButton)).not.toExist();
|
|
|
|
wrapper = setup({ editMode: true });
|
|
expect(wrapper.find(DeleteComponentButton)).toExist();
|
|
});
|
|
|
|
it('should call deleteComponent when deleted', () => {
|
|
const deleteComponent = sinon.spy();
|
|
const wrapper = setup({ editMode: true, deleteComponent });
|
|
wrapper.find(DeleteComponentButton).simulate('click');
|
|
|
|
expect(deleteComponent.callCount).toBe(1);
|
|
});
|
|
|
|
it('should direct display direct-link tab', () => {
|
|
let wrapper = shallow(<Tabs {...props} />);
|
|
// default show first tab child
|
|
expect(wrapper.state('tabIndex')).toBe(0);
|
|
|
|
// display child in directPathToChild list
|
|
const directPathToChild = dashboardLayoutWithTabs.present.ROW_ID2.parents.slice();
|
|
const directLinkProps = {
|
|
...props,
|
|
directPathToChild,
|
|
};
|
|
|
|
wrapper = shallow(<Tabs {...directLinkProps} />);
|
|
expect(wrapper.state('tabIndex')).toBe(1);
|
|
});
|
|
});
|