mirror of
https://github.com/apache/superset.git
synced 2024-09-19 12:09:42 -04:00
18658f45be
* Initial commit of new filters badge. * refactor applied/rejected filters code * finished filter indicators * filter badge tested * unnecessary imports * formatting and types * fixes * license * code quality tweaks * state management for showing focused filter scope * clean up filter key extraction code * remove unnecessary styles * temp css to demonstrate highlighting * fix focused filter logic * no more color badges * new toys for highlighting dash components (#11144) * tweak style for the filter chart when filter is focused * style: Filters p0 css2 (#11151) * nixing background tweak * src paths * another quick theme color * src paths, adjusting pill icon color, changing icons, showing applied/busted counts * linting stuff * fixing and tweaking tests * show filter indicator when filters are not active * chart title bar cleanup * open the right panel when popover opens * unused import * fix EditableTitle tests * margin on dashboard header * show the chart dropdown menu * fix blur filter breaking dropdowns * style tweak - no pointer events when irrelevant charts are blurred * fix box shadow on filter highlight * it's an array * attempt fixing e2e * style: filters p0 icon churn (#11215) * new filters icon * icon styling * bigger icons in list views * better sizing of table actions and favStars * more icon sizing... * fixing more button size jankiness * linting * Filters performance (#11255) * fixing time filter "ok" button * making unset filter menu collapsible * sort alphabetically * fix highlighting when removing items * try a flex layout (for browser render perf) * more specific transitioning * temp: comment out some code as a test * temp: comment out more code * temp: remove possibly expensive computations from ChartHolder * Revert "temp: comment out some code as a test" This reverts commit309b880e90
. * Revert "temp: comment out more code" This reverts commit64c88b2cba
. * Revert "temp: remove possibly expensive computations from ChartHolder" This reverts commit37ce0214f0
. * experiment: upgrade react-select to v3 * Revert "experiment: upgrade react-select to v3" This reverts commitc3972ba486
. * fix the damn problem * remove code used for testing purposes * awful hack to avoid adding a class to a container * approaching infinity... and not beyond! * fix ref forwarding * add theme to tests as necessary * fix(extra-filters): add logic for identifying applied extra filters (#11325) * fix: use dashboard id for stable cache key (#11293) * fix: button translations missing (#11187) * button translations missing * blank space before text * feat: update time_compare description and choices (#11294) * feat: update time_compare description and choices * Update sections.jsx * fix(extra-filters): add logic for identifying applied extra filters * lint Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: rubenSastre <ruben.sastre@decathlon.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> * address design feedback * slight tweak to panel logic, keep panels open that user has opened * rearrange code to be more graceful * fix: bump superset-ui/core (#11385) * use is_dttm instead of is_temporal * types, names * only show unset filter panel if there are unset filters * fix highlighting the filter control * fix filterbox layout * translations * fix cypress * actually add the test attribute * Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * formatting * add link comment to hack * Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * stop importing lodash * Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * skip broken test * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx Co-authored-by: Evan Rusackas <evan@preset.io> * adjust colors of titles * linting * no indicators when chart is loading * support all time fields * fix lock file Co-authored-by: Natalie Ruhe <natalie@preset.io> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: rubenSastre <ruben.sastre@decathlon.com> Co-authored-by: Erik Ritter <erik.ritter@airbnb.com> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
113 lines
4.3 KiB
TypeScript
113 lines
4.3 KiB
TypeScript
/**
|
|
* Licensed to the Apache Software Foundation (ASF) under one
|
|
* or more contributor license agreements. See the NOTICE file
|
|
* distributed with this work for additional information
|
|
* regarding copyright ownership. The ASF licenses this file
|
|
* to you under the Apache License, Version 2.0 (the
|
|
* "License"); you may not use this file except in compliance
|
|
* with the License. You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
import { supersetTheme } from '@superset-ui/core';
|
|
import * as SupersetUI from '@superset-ui/core';
|
|
import { CHART_UPDATE_SUCCEEDED } from 'src/chart/chartAction';
|
|
import { buildActiveFilters } from 'src/dashboard/util/activeDashboardFilters';
|
|
import FiltersBadge from 'src/dashboard/containers/FiltersBadge';
|
|
import { getMockStoreWithFilters } from '../fixtures/mockStore';
|
|
import { sliceId } from '../fixtures/mockChartQueries';
|
|
import { dashboardFilters } from '../fixtures/mockDashboardFilters';
|
|
import { dashboardWithFilter } from '../fixtures/mockDashboardLayout';
|
|
|
|
describe('FiltersBadge', () => {
|
|
// there's this bizarre "active filters" thing
|
|
// that doesn't actually use any kind of state management.
|
|
// Have to set variables in there.
|
|
buildActiveFilters({
|
|
dashboardFilters,
|
|
components: dashboardWithFilter,
|
|
});
|
|
|
|
beforeEach(() => {
|
|
// shallow rendering in enzyme doesn't propagate contexts correctly,
|
|
// so we have to mock the hook.
|
|
// See https://medium.com/7shifts-engineering-blog/testing-usecontext-react-hook-with-enzyme-shallow-da062140fc83
|
|
jest.spyOn(SupersetUI, 'useTheme').mockImplementation(() => supersetTheme);
|
|
});
|
|
|
|
it("doesn't show number when there are no active filters", () => {
|
|
const store = getMockStoreWithFilters();
|
|
// start with basic dashboard state, dispatch an event to simulate query completion
|
|
store.dispatch({
|
|
type: CHART_UPDATE_SUCCEEDED,
|
|
key: sliceId,
|
|
queryResponse: {
|
|
status: 'success',
|
|
applied_filters: [],
|
|
rejected_filters: [],
|
|
},
|
|
dashboardFilters,
|
|
});
|
|
const wrapper = shallow(<FiltersBadge {...{ store }} chartId={sliceId} />);
|
|
expect(
|
|
wrapper.dive().find('[data-test="applied-filter-count"]'),
|
|
).not.toExist();
|
|
});
|
|
|
|
it('shows the indicator when filters have been applied', () => {
|
|
const store = getMockStoreWithFilters();
|
|
// start with basic dashboard state, dispatch an event to simulate query completion
|
|
store.dispatch({
|
|
type: CHART_UPDATE_SUCCEEDED,
|
|
key: sliceId,
|
|
queryResponse: {
|
|
status: 'success',
|
|
applied_filters: [{ column: 'region' }],
|
|
rejected_filters: [],
|
|
},
|
|
dashboardFilters,
|
|
});
|
|
const wrapper = shallow(<FiltersBadge {...{ store }} chartId={sliceId} />);
|
|
expect(wrapper.dive().find('DetailsPanelPopover')).toExist();
|
|
expect(
|
|
wrapper.dive().find('[data-test="applied-filter-count"]'),
|
|
).toHaveText('1');
|
|
expect(wrapper.dive().find('WarningFilled')).not.toExist();
|
|
});
|
|
|
|
it("shows a warning when there's a rejected filter", () => {
|
|
const store = getMockStoreWithFilters();
|
|
// start with basic dashboard state, dispatch an event to simulate query completion
|
|
store.dispatch({
|
|
type: CHART_UPDATE_SUCCEEDED,
|
|
key: sliceId,
|
|
queryResponse: {
|
|
status: 'success',
|
|
applied_filters: [],
|
|
rejected_filters: [{ column: 'region', reason: 'not_in_datasource' }],
|
|
},
|
|
dashboardFilters,
|
|
});
|
|
const wrapper = shallow(<FiltersBadge {...{ store }} chartId={sliceId} />);
|
|
expect(wrapper.dive().find('DetailsPanelPopover')).toExist();
|
|
expect(
|
|
wrapper.dive().find('[data-test="applied-filter-count"]'),
|
|
).toHaveText('0');
|
|
expect(
|
|
wrapper.dive().find('[data-test="incompatible-filter-count"]'),
|
|
).toHaveText('1');
|
|
// to look at the shape of the wrapper use:
|
|
// console.log(wrapper.dive().debug())
|
|
expect(wrapper.dive().find('Icon[name="alert-solid"]')).toExist();
|
|
});
|
|
});
|