Commit Graph

5861 Commits

Author SHA1 Message Date
Evan Rusackas fa9963519e
fix: adding nofollow (#11225) 2020-10-09 23:47:57 -07:00
Kamil Gabryjelski b071344531
refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab (#11212)
* Create styled Antd Tabs and Dropdown

* Replace Tabs in SqlLab
2020-10-09 23:11:25 -07:00
Bogdan cb3f649a7f
chore: simplify alerting data model to leverage a single class (#11179)
* Collapse alerting models into a single one

Fixing upgrade migration & tests

* Address feedback

Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-10-09 19:20:12 -07:00
Moriah Kreeger a6fc3d2384
feat: CSS Templates List (#11189) 2020-10-09 16:32:31 -07:00
ʈᵃᵢ 7b0dabd7aa
style(listview): various changes to get closer to SIP-34 designs (#11101) 2020-10-09 13:06:26 -07:00
Kasia Kucharczyk 56d5e8a1cb
Changed cache uid to be depending on table in test_csv_response_format (#11214) 2020-10-09 09:01:26 -07:00
Kasia Kucharczyk d93b1afe79
test: test_cache_logging is not depending on other dashboard (#11213)
* Changed test_cache_logging to be idempotent and not depending on other data than tested one

* Changed cache uid to be depending on table, not datashource
2020-10-09 09:00:41 -07:00
Jesse Yang 761e6dbf52
chore: Add __pycache__ to gitignore (#11208) 2020-10-08 19:51:26 -07:00
jharding-blw 5561b429f3
Fix typo "insode" -> "inside" (#11204) 2020-10-08 13:58:58 -07:00
Grace Guo a10e86ab31
fix: revert eTag cache feature for dashboard (#11203)
* revert #11137

* revert #10963
2020-10-08 12:15:08 -07:00
Beto Dealmeida b6728d87a0
fix: skip unit test that is failing in master for test-postgres-hive (#11196)
* Get full diff

* Test

* Test

* Test

* Test

* Test

* Explicitly detect backend to skip test
2020-10-08 09:17:09 -07:00
Daniel Vaz Gaspar 7c60939429
chore: turn SQL templating off by default (#11172)
* feat: possible to turn off SQL templating

* turn SQL templating off by default

* Update UPDATING.md

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* fix missing PR number

* fix missing PR number

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-10-08 11:55:39 +01:00
John Bodley 2a447ff466
Revert "refactor: Replace react-bootstrap tabs with Antd tabs (#11090)" (#11194)
This reverts commit 4fd993c4e0.

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-10-07 16:21:24 -07:00
Beto Dealmeida 9785667a0d
feat: add UUID column to ImportMixin (#11098)
* Add UUID column to ImportMixin

* Fix default value

* Fix lint

* Fix order of downgrade

* Add logging when downgrade fails

* Migrate position_json to contain UUIDs, and add schedule tables

* Save UUID when adding charts to dashboard

* Fix heads

* Rename migration file

* Fix dashboard serialization

* Fix migration script with Postgres

* Fix unique contraint name

* Handle UUID when exporting dashboard

* Fix Dataset PUT

* Add UUID JSON serialization

* Fix tests

* Simplify logic

* Try binary=True
2020-10-07 09:00:55 -07:00
John Bodley 6e0d1b8409
chore: cleanup FAB update perms (#11155)
* chore: Using cache factory method

* chore: Deprecate outdated FAB_UPDATE_PERMS information

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2020-10-07 08:33:41 -07:00
Kasia Kucharczyk 32e174d4b8
test: removed unicode_test example from unit tests (#11131)
* Removed depemdency to unicode example in tests config.

* Added common methods for creating dashboards for tests.

* Added fixtures to all tests which were using unicode example.

* Added cleanup for unicode_test table

* Removed unnecessary fixture parts of unicode dashboard tests

* Parametrized creating slice for tests

* Moved fixtures for unicode test to separate file and refactored to several methods. Added param types and return types.

* Cleandup after fix

* Changed variable names to more readable

* Added cleanup for dashboards and slices

* Applied unicode fixture to charts api tests

* Update schema variable to dtype in dashboard utils

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Changed variable schema to dtype in dashboards. Replaced accessing first element with one_or_none

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-10-07 18:29:37 +03:00
Ville Brofeldt 1fa8bf7d7b
fix(viz): downgrade exception for missing viz/datasource (#11173)
* fix(viz): downgrade exception for missing datasource

* add translations
2020-10-07 15:16:51 +03:00
Lily Kuang a0713938b3
fixed undefined names error (#11180) 2020-10-06 22:11:16 -07:00
Moriah Kreeger 21c8d672a8
fix: save query modal/button styling + convert to ant-d modal (#11164) 2020-10-06 16:55:17 -07:00
Maxime Beauchemin fb8320f7fe
fix: cosmetic issue template (#11176) 2020-10-06 16:26:48 -07:00
Lily Kuang 2eb400a2fc
chore: remove SIP_34_SAVED_QUERIES_UI feature flag (#11175) 2020-10-06 15:13:41 -07:00
Maxime Beauchemin ad250637eb
chore: add issue template for 'Cosmetic Issue' (#11174)
* chore: add issue template for 'Cosmetic Issue'

* addressing comment
2020-10-06 14:17:34 -07:00
Maxime Beauchemin 071c81f82e
fix: 📜 `/docs/api` won't render (#11168)
* fix: docs/api won't render

    fix: docs/api won't render

    It's unclear to me exactly why, but docz is flimsy with the way
    things are named and runs into odd collision and error messages.

    Somehow renaming the route seem to help. Jut rolling with it after many
    `gatsby clean`

* kill paths-ignore on github-actions

* trigger
2020-10-06 13:51:40 -07:00
Maxime Beauchemin c8a5dec84d
style(dashboard): minor improvements to chart context menu (#11170)
Bumping "Explore/edit chart" as the first option. Getting rid of the
old "edit chart properties" deprecated CRUD link
2020-10-06 12:55:13 -07:00
Maxime Beauchemin f109f11ceb
style: fix too light form labels in DatabaseModal + DRY css (#11056)
eventually should be moved away from bootstrap and onto a DRY
ControlLabel component in our design system.
2020-10-06 12:51:00 -07:00
Maxime Beauchemin b2af0c0e22
style(sqllab): make database errors more clear and render as monospace (#11075)
* style(sqllab): make database errors more clear and render as monospace

In SQL Lab, when a database error message is returned, generally because
of a user error in the SQL, it's identified as an "Unexpected Error" and
some of the text formatting of the error message (\n, spaces, tabs, ...)
are lost as they are rendered in html.

This PR identifies the error as a "Database Error", and renders like
more like a <pre>, using a monospace font.

* fix the build

* addressing comments

* addressed comments

* lint + removing cruft

* addressing comments
2020-10-06 12:50:38 -07:00
Grace Guo 13963acefb
fix: Fix Time Column dropdown for date filter (#11149) 2020-10-06 11:51:10 -07:00
Jesse Yang 38dccf9e12
fix: enable consistent etag across workers and force no-cache for dashboards (#11137)
* fix: enable consistent etag across workers

* Use CACHE_DEFAULT_TIMEOUT instead of 0

* Change timeout to 0 and set expires header even for no-cache

* Reduce number of if branches to appease Pylint

* Fix mypy error
2020-10-06 09:43:43 -07:00
Maxime Beauchemin 3d7b805755
chore: more 'datasource' -> 'dataset' renaming (#11055)
* chore: more 'datasource' -> 'dataset' renaming

* fix build

* explicitely setting disabled to false to avoid cypress confusion

* fix tests

* RAT
2020-10-05 20:04:17 -07:00
Rob DiCiuccio 6f619829d2
Remove erroneous package-lock.json (#11108) 2020-10-05 18:31:40 -07:00
Lily Kuang 152315d0f4
feat: saved query preview modal (#11135) 2020-10-05 16:21:59 -07:00
Amit Miran 63579b3049
allow passing bash args into the pytest (#11040)
this can be used in local environment when for example you want to pass specific *mark* to run against
2020-10-05 15:46:25 -07:00
Johannes Lange 3a0446f00d
docs: typo (#11152)
* docs: typo

* docs: consistent two-line gap before sections in README

this is merely to touch something outside of docs/ to work around a CI
issue (comment in #11152), while not creating diff-noise only
2020-10-05 13:29:47 -07:00
Maxime Beauchemin 6358a7f1b5
docs: add API page to docs using Swagger UI (#11154)
* docs: add API page to docs using Swagger UI

* silence fossa
2020-10-04 22:01:36 -07:00
John Bodley 5e0603f957
chore: Remove obsolete creating missing metric permissions (#11143) 2020-10-04 09:16:29 -07:00
Erik Ritter 3d76f81bf7
Revert "refactor: Remove usages of reactable from TimeTable (#11046)" (#11150)
This reverts commit f01b8a30f7.
2020-10-02 22:21:10 -07:00
henryyeh e9f4fcb4d9
fix: fixing CI workflow (#11145)
* dummy commit to trigger jenkins pipeline

* removing unused workflow

Co-authored-by: Henry Yeh <henry@preset.io>
2020-10-02 17:33:40 -07:00
Kamil Gabryjelski 07f87149e6
fix: Enable ESLint rule default-props-match-prop-types (#11058)
* Re-enable ESLint rule default-props-match-props-types

* Add cypress test for switching tabs

* fix

* Typo fix

* Test fix
2020-10-02 15:54:56 -07:00
Elizabeth Thompson d95b7c2a73
fix: clean up prop type errors in jest tests (#11120) 2020-10-02 14:59:04 -07:00
Ville Brofeldt 662fb43350
fix(examples): missing expressions in birth_names (#11141)
* fix(examples): missing expressions in birth_names

* disable flaky tests
2020-10-02 23:47:38 +03:00
Kamil Gabryjelski 4fd993c4e0
refactor: Replace react-bootstrap tabs with Antd tabs (#11090)
* Replace tabs in profile

* Replace tabs in SouthPane

* Replace tabs in TabbedSqlEditors

* Add typing for dropdown

* Add license

* Remove isSelected

* Fixes

* Add data-test

* Fix test

* Remove unnecessary style

* Remove unnecessary style

* Tests fix

* Tests fix

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Tabs.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/common/components/Dropdown.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Remove inModal prop

* Remove inModal from storybook

* Move inline style to styled component

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-02 13:07:52 -07:00
Jesse Yang 53cd05d74a
perf(explore): render datasource details only when needed (#10924) 2020-10-02 12:15:06 -07:00
ʈᵃᵢ 269644d18e
style: override ace edit error icon (#11139) 2020-10-02 09:45:36 -07:00
John Bodley e90c63fc7b
fix: Alembic migration 18532d70ab98 (#11136) 2020-10-02 09:12:03 +01:00
Evan Rusackas 2cb2a0093d
docs: docs site footer link tweak (#11140)
* rescinding htaccess rewrite

* Changing License link title to make Apache happy

* Revert "rescinding htaccess rewrite"

This reverts commit 0ee153ef08.

* changing url in asf.yaml
2020-10-01 23:31:52 -07:00
Maxime Beauchemin d578d8133f
docs: comply to ASF requirements (#11133)
* docs: comply to ASF requirements

* touch something out of docs/

* Just a few more things...

* messing with .htaccess

* SEO
2020-10-01 22:15:36 -07:00
Elizabeth Thompson a4e1dc9c27
add info about case sensitive search (#11124) 2020-10-01 21:30:39 -07:00
ʈᵃᵢ 017e5acd14
style(listview): dynamic card size and grid spacing (#11111) 2020-10-01 15:44:42 -07:00
Maxime Beauchemin 5f55d94b9b
style: rename label 'table name'->'dataset name' (#11126) 2020-10-01 15:13:01 -07:00
Daniel Vaz Gaspar 4c85d33109
feat: custom favorite filter for dashboards, charts and saved queries (#11083)
* feat: custom favorite filter for dashboards

* lint and sort

* add favored for charts

* fix tests and lint

* more tests and saved query filter

* fix tests

* fix tests

* lint

* lint and fix conflict

* remove unnecessary prop

* separate tests
2020-10-01 15:08:40 -07:00