ʈᵃᵢ
f918ca14aa
fix(datasets): add custom filter for virtual datasets based on sql attribute ( #11452 )
2020-10-29 13:11:33 -07:00
Evan Rusackas
e024267447
fix: Unwinds icon fallout that came along with filters PR ( #11474 )
...
* Unwinds icon revamp that came along with filters PR.
* cleanup/linting
* removing unused import
2020-10-28 19:44:39 -07:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators ( #10936 )
...
* Initial commit of new filters badge.
* refactor applied/rejected filters code
* finished filter indicators
* filter badge tested
* unnecessary imports
* formatting and types
* fixes
* license
* code quality tweaks
* state management for showing focused filter scope
* clean up filter key extraction code
* remove unnecessary styles
* temp css to demonstrate highlighting
* fix focused filter logic
* no more color badges
* new toys for highlighting dash components (#11144 )
* tweak style for the filter chart when filter is focused
* style: Filters p0 css2 (#11151 )
* nixing background tweak
* src paths
* another quick theme color
* src paths, adjusting pill icon color, changing icons, showing applied/busted counts
* linting stuff
* fixing and tweaking tests
* show filter indicator when filters are not active
* chart title bar cleanup
* open the right panel when popover opens
* unused import
* fix EditableTitle tests
* margin on dashboard header
* show the chart dropdown menu
* fix blur filter breaking dropdowns
* style tweak - no pointer events when irrelevant charts are blurred
* fix box shadow on filter highlight
* it's an array
* attempt fixing e2e
* style: filters p0 icon churn (#11215 )
* new filters icon
* icon styling
* bigger icons in list views
* better sizing of table actions and favStars
* more icon sizing...
* fixing more button size jankiness
* linting
* Filters performance (#11255 )
* fixing time filter "ok" button
* making unset filter menu collapsible
* sort alphabetically
* fix highlighting when removing items
* try a flex layout (for browser render perf)
* more specific transitioning
* temp: comment out some code as a test
* temp: comment out more code
* temp: remove possibly expensive computations from ChartHolder
* Revert "temp: comment out some code as a test"
This reverts commit 309b880e9064c88b2cba37ce0214f0c3972ba486#11325 )
* fix: use dashboard id for stable cache key (#11293 )
* fix: button translations missing (#11187 )
* button translations missing
* blank space before text
* feat: update time_compare description and choices (#11294 )
* feat: update time_compare description and choices
* Update sections.jsx
* fix(extra-filters): add logic for identifying applied extra filters
* lint
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* address design feedback
* slight tweak to panel logic, keep panels open that user has opened
* rearrange code to be more graceful
* fix: bump superset-ui/core (#11385 )
* use is_dttm instead of is_temporal
* types, names
* only show unset filter panel if there are unset filters
* fix highlighting the filter control
* fix filterbox layout
* translations
* fix cypress
* actually add the test attribute
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* formatting
* add link comment to hack
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* stop importing lodash
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* skip broken test
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* adjust colors of titles
* linting
* no indicators when chart is loading
* support all time fields
* fix lock file
Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2020-10-28 15:46:24 -07:00
Moriah Kreeger
e9dba18466
feat: annotation layers CRUD list view ( #11432 )
2020-10-28 15:45:07 -07:00
Kamil Gabryjelski
52294c836a
refactor: Replace react-bootstrap Modals with Antd in Datasource ( #11390 )
...
* ChangeDatasourceModal
* DatasourceModal
* DeleteModal, AddDatasetModal
* Fix tests
* Remove unused file
* Fix e2e tests
* Fix test
* Remove it.only
* Fix after rebase
* Fix e2e tests
* Fix data-test in modal
* Lint fix
2020-10-28 14:42:13 -07:00
Kamil Gabryjelski
155b5edec1
refactor: Use Antd Modals instead of react-bootstrap Modals ( #11366 )
...
* Make Modal responsive
* ErrorAlert
* OmniContainer
* dashboard/PropertiesModal
* Fix e2e tests
* Lint fix
* E2E test fix
* Fix test
* Use grid units
* Change padding to padding-left/right
2020-10-27 13:08:04 -07:00
adam-stasiak-polidea
4bebf51453
chore: Cypress chart selectors refactor ( #11312 )
...
* cypress selectors refactor in chart list tests
* fixed wrong selector
2020-10-27 11:38:05 -07:00
Kamil Gabryjelski
894ca3c09b
refactor: Use Modals from Antd instead of react-bootstrap ( #11330 )
...
* Refactor ModalTrigger to use antd modal
* Refactor a few components
* dynamic width
* Fix unit tests
* Use i18n for button text
2020-10-26 11:20:10 -07:00
Jesse Yang
ac498ddd23
chore: upgrade TypeScript (3.8.3 -> 4.0.3) ( #11421 )
...
* chore: upgrade TypeScript (3.8.3 -> 4.0.3)
* Refactor the button component
2020-10-25 22:01:41 -07:00
Maxime Beauchemin
0ab15373fa
style: fix labels vertical align ( #11415 )
...
* style: fix labels vertical align
* addressed comments
* just adding the space for now
* fix timer
2020-10-25 17:55:22 -07:00
Evan Rusackas
efdda8b69e
chore: Button cruft cleanup ( #11342 )
...
* toggleSchedule
* cleaning up run query button
* removing unnecessary (subtle!) style overrides
* bulk action classname to button style prop
* nixing btn-primary
* nixing cancelQuery class
* togglesave
* nixing autocomplete class
* linting
* nixing button classes of 'ok' and 'reset'
* unoing diagnostic test
* begrudgingly adding an m-r-3 class... for now
* this is not a class to worry about
* test fixes for limit control
* updating TODO notes, calling it a day for now.
* gah... copy paste error.
2020-10-23 10:42:29 -07:00
Evan Rusackas
d64260fc0e
fix: long labels now truncate with ellipsis ( #11400 )
2020-10-22 18:35:37 -07:00
Elizabeth Thompson
43b92b220f
fix: dashboard edit/save errors ( #10834 )
...
* use conditional operator for lookup
* editing dashboard title should update after save
* uncomment test
* fix json metadata save
* json metadata color scheme should overwrite state
* test's functionality is no longer applicable
* add lastModifiedTime to DashboardInfo
2020-10-22 14:33:22 -07:00
Kamil Gabryjelski
dc5e5a978b
refactor: Replace usages of reactable in TableLoader ( #11240 )
...
* Refactor TableLoader to use react-bootstrap
* Remove unnecessary css classes
* Fix import
* Fix styling for no data
* Refactor TableLoader into functional component
* Convert TableLoader to typescript
2020-10-22 14:00:02 -07:00
Maxime Beauchemin
64b5aae6bc
style: improve the "Create New Chart" screen's usability ( #11383 )
...
* style: make disabled buttons more readable
* making more of a CTA for VizControl
2020-10-22 10:16:58 -07:00
ʈᵃᵢ
225c905bd5
fix(listview): hide actions column if no actions are allowed ( #11337 )
2020-10-21 09:27:48 -07:00
Maxime Beauchemin
c360413fc2
style(menu): clean up right menu - leaving only "Settings" ( #11227 )
...
* style(menu): clean up right menu - leaving only settings
* bring pre-commit back
* fix frontend tests
* pre-commit
* re-introduce subtle '+'
2020-10-20 21:33:28 -07:00
Kamil Gabryjelski
901a42b1df
refactor: Replace usages of Popover from react-bootstrap with Antd ( #11163 )
...
* New popover component
* LimitControl
* Moar components migrated
* TimeSeriesColumnControl
* Hotkeys
* ColorPicker
* FilterBoxItemCOntrol
* AdhocFilterEditPopover
* AdhocMetric
* AnnotationLayerControl
* DateFilterControl
* Tests fix
* Fix linting issue
* Fix tests
* Bug fix
* Test fix
* Remove Antd global stylesheet
* Fix linting
* Fix test
* Fix test
* Fix test
* Fix test
* Fix test
2020-10-19 20:42:33 -07:00
ʈᵃᵢ
4208ca76e0
refactor: replace AvatarIcon instances with FacePile ( #11279 )
2020-10-19 20:23:16 -07:00
rubenSastre
4f0a06dda5
fix: button translations missing ( #11187 )
...
* button translations missing
* blank space before text
2020-10-15 21:27:26 -07:00
adam-stasiak-polidea
fc03549299
chore: Added data-test attributes for testing ( #11254 )
...
* Added data-test attributes for testing
* fixed incorrect naming change
* review changes
2020-10-14 16:12:01 -07:00
Erik Ritter
fc74b5d4a2
Revert "fix: keep placeholder in multivalue select when a value exists ( #11181 )" ( #11270 )
...
This reverts commit 31cc4155b7
2020-10-14 12:58:58 -07:00
Kamil Gabryjelski
820fa473a7
refactor: Implement TableView component ( #11217 )
2020-10-14 11:15:34 -07:00
Elizabeth Thompson
31cc4155b7
fix: keep placeholder in multivalue select when a value exists ( #11181 )
2020-10-13 13:45:31 -07:00
ʈᵃᵢ
7b0dabd7aa
style(listview): various changes to get closer to SIP-34 designs ( #11101 )
2020-10-09 13:06:26 -07:00
Maxime Beauchemin
b2af0c0e22
style(sqllab): make database errors more clear and render as monospace ( #11075 )
...
* style(sqllab): make database errors more clear and render as monospace
In SQL Lab, when a database error message is returned, generally because
of a user error in the SQL, it's identified as an "Unexpected Error" and
some of the text formatting of the error message (\n, spaces, tabs, ...)
are lost as they are rendered in html.
This PR identifies the error as a "Database Error", and renders like
more like a <pre>, using a monospace font.
* fix the build
* addressing comments
* addressed comments
* lint + removing cruft
* addressing comments
2020-10-06 12:50:38 -07:00
Maxime Beauchemin
3d7b805755
chore: more 'datasource' -> 'dataset' renaming ( #11055 )
...
* chore: more 'datasource' -> 'dataset' renaming
* fix build
* explicitely setting disabled to false to avoid cypress confusion
* fix tests
* RAT
2020-10-05 20:04:17 -07:00
Lily Kuang
152315d0f4
feat: saved query preview modal ( #11135 )
2020-10-05 16:21:59 -07:00
Erik Ritter
3d76f81bf7
Revert "refactor: Remove usages of reactable from TimeTable ( #11046 )" ( #11150 )
...
This reverts commit f01b8a30f7
2020-10-02 22:21:10 -07:00
Kamil Gabryjelski
07f87149e6
fix: Enable ESLint rule default-props-match-prop-types ( #11058 )
...
* Re-enable ESLint rule default-props-match-props-types
* Add cypress test for switching tabs
* fix
* Typo fix
* Test fix
2020-10-02 15:54:56 -07:00
ʈᵃᵢ
017e5acd14
style(listview): dynamic card size and grid spacing ( #11111 )
2020-10-01 15:44:42 -07:00
Phillip Kelley-Dotson
07716ffd76
chore: refactor submenu's right nav to accept list of buttons ( #11102 )
...
* submenu right-nav button refactor
* undo changes
* fix lint
* fix test
* update pr with suggested changes and test
* fix lint
* use enum to define btn style props
* add suggestions
* update savedquery buttons
2020-10-01 15:05:49 -07:00
Maxime Beauchemin
c4d96f64ff
fix: SpatialControl popover won't open ( #11127 )
...
Recently a change related to emotion styling not properly working through
react-bootstrap's popover broke the SpatialControl.
This PR makes SpatialControl use antd's equivalent, and addresses the
issue as a result: emotion's styling context is preserved through
this superior popover.
2020-09-30 23:12:51 -07:00
Moriah Kreeger
e7a4265c30
feat: saved query list actions ( #11109 )
2020-09-30 18:18:34 -07:00
Erik Ritter
fa5dab85c4
feat: more specific presto error messages ( #11099 )
2020-09-29 21:50:58 -07:00
Evan Rusackas
0409b12a55
style: fix secondary label border ( #11100 )
2020-09-29 14:15:18 -07:00
Lily Kuang
e337355162
refactor: table selector on dataset editor ( #10914 )
...
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
2020-09-28 11:16:03 -07:00
ʈᵃᵢ
1dc05d4c12
feat(charts): modify custom api filter to include more fields ( #11054 )
2020-09-28 10:18:34 -07:00
Kamil Gabryjelski
f01b8a30f7
refactor: Remove usages of reactable from TimeTable ( #11046 )
...
* Use ListView instead of reactable
* Refactor TimeTable
* Spark column width fix
2020-09-28 09:42:06 -07:00
Kamil Gabryjelski
a879622e07
refactor: Remove usages of reactable from AlteredSliceTag ( #11012 )
...
* Remove usages of reactable in AlteredSliceTag
* Fix tests
* Move mocked data to fixtures file
* Use optional chaining
* Remove default value, change a unit test logic
* Code review fixes
2020-09-28 09:41:08 -07:00
Evan Rusackas
23d62f37a6
removing unused component ( #11072 )
2020-09-25 23:02:01 -07:00
Evan Rusackas
8cba1c823d
changing to the correct hex color ( #11073 )
2020-09-25 21:09:59 -07:00
Evan Rusackas
eeeb21077d
feat: adding all icons from the design system to the codebase ( #11033 )
...
* error -> error-solid
* warning -> warning-solid
* all the new icons mixed in!
* card-view -> card_view
* circle-check-solid -> circle_check_solid
* corrected circle-check to new name and correct (stroke) icon
* sort-asc/desc -> sort_asc/desc
* databases -> database
* compass -> nav_explore
* pencil -> edit-alt
* more pencil migrations
* easy list view rename
* star -> favorite (changed in Figma)
* removing deprecated icon
* renaming icon to mach figma
* More -> More Horiz
* forgot to change this when ranming the file
* updating some icon names in use
* adding hella icons
* fixing errant viewboxes
* removing dropdown-arrow in favor of triangle-down
* adding key to storybook map.
* fixing icon component reference
* tweaks to fave star styling to support revised icon
* fixing a bad icon inclusion
* missed a license
* touchup to virtual dataset... will tweak later.
* e2e fix
* linting
2020-09-25 14:49:30 -07:00
Evan Rusackas
d056e3dfd3
clickable labels have outlines, storybook shows them ( #11034 )
2020-09-24 20:50:44 -07:00
Grace Guo
3467d2d8d6
Revert "style: fix checkbox color ( #10970 )" ( #11051 )
...
This reverts commit e4e78b66fa
2020-09-24 16:53:02 -07:00
Grace Guo
f99753a800
Revert "ESLint: Re-enable rule default-props-match-prop-types ( #10868 )" ( #11050 )
...
This reverts commit 9f01a7fdf8
2020-09-24 12:33:38 -07:00
ʈᵃᵢ
eded51b2f8
feat(saved_queries): add custom api filter for all string & text fields ( #11031 )
2020-09-24 11:05:25 -07:00
Jesse Yang
7549dad12d
fix: timer component, fixes #10849 , closes #11002 ( #11004 )
2020-09-23 10:53:24 -07:00
ʈᵃᵢ
345fe07d64
fix: menu shows a 0 when there are not settings ( #11009 )
2020-09-23 09:22:45 -07:00
Beto Dealmeida
d992c306c2
Bring back import menu ( #11007 )
2020-09-22 19:32:44 -07:00
