* Add DrillDetailModal test
* Add DrillDetailPane tests
* Add TableControls test
* Lint
* Enhance SliceHeaderControls tests
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* Added environment tag and relevant tests
* Reorganize imports
* Prevent errors when config value not set
* Default production tag to be hidden
* Change tag to Label component
* Fix import order
* Allow tag to be colored with theme
* Use theme for tag border radius
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
* Fix styling
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
* Inital duplicate functionality
* Fix formatting
* Create dedicated duplicate API
* Make use of new API
* Make use of new api permissions
* Add integration tests for duplicating datasets
* Add licenses
* Fix linting errors
* Change confirm button to 'Duplicate'
* Fix HTTP status code and response
* Add missing import
* Use user id instead of user object
* Remove stray debug print
* Fix sqlite tests
* Specify type of extra
* Add frontend tests
* Add match statement to test
* Prevent series limit when no series limit columns specified.
* Add timeseries check for legacy charts.
* Apply fix to helpers.py.
* Skip Cypress color consistency tests.
* chore(explore): Add cypress test for creating chart from dataset list
* Add cypress test for creating chart from sqllab query
* Fix the test for editing dataset in exploer
* Fix lint
* Fix tests
* Add new Database Modal
When adding a new database and selecting Snowflake, the database and account fields had the same placeholder. This PR adds a placeholder prop so values can be sent dynamically by field
* Call translation function for string literals
Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
* fix(database): make to display validation error msg when all cases
* fix(db): make to update the alert error condition
* fix(db): make to add error detail display
* fix(db): make to update error alert display by superset error style guide.
* fix(db): make to style modal header title with h4
* fix(db): make to place see more on bottom instead of top
* fix(db): make to fix shortly
* fix(db): make to fix lint issue
Co-authored-by: Evan Rusackas <evan@preset.io>
* Work in progress to add Chromatic publishing to superset-fronted storybook
Adds new Github action to publish storybook builds to chromatic
Adjusts configuration to support MDX story format
Updates Alert stories to take advantage of MDX format for example in storybook that will publish to Chromatic
Fixes issue in ListViewCard stories that make the story build fail
* Adjust Chromatic Github action
* Adjust action so Gtihub Secret is read into env
Github secrets are not accessible in conditional blocks so this change moves the access of the github secret into an env variable which is accessible in conditional logic
* Removes unneccesary projectToken from package json
* Using a temp key to debug no access to value from github secret
* Refining skipping if no changes to superset-frontend
* Remove typos from Action component story, consolidate on folder check in Chromatic action
* Fix error in Chromatic action event
* Testing action with pul_request_target
* adjustments to Chromatic action triggers
* lint fix
* Testing if pull_request_target is disabled
* More adjustments to Chromatic action
* UI Change to trigger action
* Change to story text to test action
* update package-lock after merge conflicts from master
* Changes to test chromatic action
* Finalize Chromatic actions, fix lint errors
* Backs out addition of @storybook/addon-docs which is included in addon-essentials
* Lint error in package.json
* perf(sqllab): Rendering perf improvement using immutable state
- keep queryEditors immutable during active state
- add unsavedQueryEditor to store all active changes
- refactor each component to subscribe the related unsaved editor state only
* revert ISaveableDatasource type cast
* missing trigger prop
* a default of an empty object and optional operator
* Add drill-to-detail modal.
* Include additional filters from dashboard context in request.
* Set page cache size to be approximately equal to memory usage of Samples pane.
* Update getDatasourceSamples signature.
* One-line import/export.
* Fix incorrect argument order in getDatasourceSamples invocation.
* Fix height of modal.
* Disable option in chart menu unless feature flag is set.
* Open modal on right-click.
* Fix double requests on modal open, controls disappearing on filter update.
* Show formattedVal in clearable filter tag.
* Set force=false for all requests.
* Rearrange/refactor DrillDetailPane.
* Reset page index on reload.
* Fix endless re-requests on request failure.
* Fix modal layout issues.
* Fix bug: some word not translate in js.
delete the 'null,' in messages.json,
so that word can be translate in js.
* docs:No code change. Reformat the database logs with size 400*160,modify the aprt of "Supported dabase" in README
* Mixed TimeSeries:
- When Bar chart is used as serie type, we need to hide values that are greater than the max Y Axis Bound.
* Mixed Time Series:
- Simplify logic for getOverMaxHiddenFormatter
* Mixed Time Series:
- Add tests for new getOverMaxHiddenFormatter util func
* updates to allow insertion of workspace home sidescroll/table UI
* fix types
* fix User type import
* add welcome message to ui registry
* add extra fields to individual chart/query GET results (for workspace home required info)
* update list view card to support a subtitle
* add id to individual chart fetch
* update chart api test
* another test fix
* fix saved query test
* update extension types + insert point
* fix typing
* fix type name
* [sc-54864] Adds safety check to provide near term fix for Queries not saving
There is an error when casting the columns array to String() for saving queries where the objects in the array are missing the toString method. This is a near term rapid patch to fix workflow in production which will have a follow up to identify root cause.
* fix typo
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Adjusted chekc to be explicit for undefined instead of truthy
This fixes issue caught by unit test where the if statement was using a truthy check where it should be explicitly checking for value of undefined
* Adds new unit test to get 100% coverage for callApi
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* feat: Adds drill to detail context menu for ECharts visualizations
* Rebases and adds time grain
* Fixes selected gauge values
* Fixes Treemap edge click
* Adds right click to big number trendline
* Address some comments
* chore: update text for dbconn modal
* fix text and close opts for adddataset modal
* update loading state, add state change for cta btns, and styling
* remove space
* Time Series Chart:
-Apache echarts has this option as false by default for time axis, so we need to override it for our charts so it's uto determined and not fixed to hidden.
- Add AxisType enum so we stop comparing agains raw strings when checking xAxis type
* Time Series Chart:
- set the showMaxLabel option directly without using merge
* Time Series Chart:
- Rename the property to showMaxLabel as it was originally
* beginning of routing
* elizabeth review
* changed folder layout
* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/index.tsx
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
* Update superset-frontend/src/views/CRUD/data/dataset/DatasetPage/RightPanel/index.tsx
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
* Moving entire split save btn PR
* Addressed review comments
* Remove arbitrary div from ErrorBoundary in Chart
* Added accidentally removed comment
* Fix act errors in SaveQuery tests
* Fix SaveDatasetActionButton test
* SaveDatasetModal test almost working
* SaveDatasetModal tests all passing
* Clean SaveDatasetModal test
* Fix create chart button and SaveDatasetModal text in SQL Lab
* Fix untitled dataset name on SaveDatasetModal in explore
* Fix styling on split save button
* Update Explore icons and icon colors.
* Change shade of blue and make blue only appear when fields have never been filled in.
* Fix Cypress test.
* Update non-error validation color from blue to yellow.
* Unpack ternary.
* Replace direct AntD imports with our Icons component.
When a custom date field value converted in a string format, some aggregators truncated to the first four digits.
This is caused by the parseFloat function which converts to first matched number rather than NaN(Not-A-Number) value.
This commit replaces the parseFloat by Number wrapper to handle this case correctly.
* add POC ExploreMixin
* Working POC
> columns are loading into page
* Created/tested query dataset dropdown
* Add isValidDatasourceType to @superset-ui/core and hide query dropdown
* Visual updates to explore datasource panel
* Temporarily make Query icon visible
* Remove Query icon visibility
* Removed isValidDatasourceType check
* Added Query preview Modal from DatasourceControl if the data source type is Query [41493]
Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component
* > fix integration point with frontend
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working
* Adjusts conditional logic approach to be extensible for additional types from DatasourceTypes options
* refactor
* set field for sql
* Fixes issue where Missing query parameters error was showing in datasourcePanel
* add query_language
* fix ds main_dttm
* Fixes issue where menu.tsx was blocking access to redux debugging for SqlLab and Explore
* Fixes issue where database id was not available to save query as dataset, adds default metric when chart source is query
* oops
* fix pre-commit to 50 errors now
* fix circuliar dep
* Disables showing Metrics section in DatasourcePanel when Query is the datasource
A follow on separate effort will enable having a default Count metric when Query is the datasource type
* adds condition to use query.columns if query.results is not present enable saving query as a dataset
* down to 26 now
* patch for pre-commit
* one more pre-commit
* added explore_json error
* added error messages
* add for metrics
* add text for columns
* add model open/close method
* add propogation and methods
* change link to span
* lint fix
* Fixes frontend lint and TypeScript errors unit test fixes will be next commit
* Aditional TypeScript error fix
* Fixes unit test failure
* fix some types
* added frontend piece
* fix type
* Fixes bad import caused by merge from master and removes duplicate showSaveDatasetModal check
* Fixes for DartasourceControl Test Suite
* Fix lint error
* Fixes unit test issues due to array instead of a component being passed to modal footer
* Fixes unit test failure for DatasourceControl and simplifies getDatasourceTitle based on PR comment
* fix ts
* pylint
* core_test fix
* Fixes line error post merge from master
* fixed from master
* fixed from master
* Fixes issue where Overwrite dataset does not work due to userid error
SPA refractor changed Redux structure that is used when in explore (which is now within SPA). user object is at the root of the store now for anything under SPA.
* Resolves TypeScript errors with changes made for SPA merging in and changes needed for overwriting dataset from SaveDatasetModal
* fix: top right panel view query functionality
* remove unneeded code from core.py
* working samples endpoint for query
* add owner check
* update FE for it
* handle columns are dict vs object
* fix exceptions
* fix fe lint
* fix test
* add tab_name to payload
* Enables use of tab name from Query
* fix cypress test
* save columns on execution
* fix frontend build test
* remove parathesis around columns
* changing column types
* fixing samples that has literal_columns
* address comments
* add changes
* fix path
* fix merge
* fix types
* remove console
* add type
* fix linting
* update to enum
* fix test
* remove explore from buttons
* fix logic
* fix logic
* oops
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
Co-authored-by: Eric Briscoe <eric.j.briscoe@gmail.com>
Co-authored-by: AAfghahi <arash.afghahi@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
* Add Resizable panel in DashboardBuilder to adjust the width for FiltersPanel
* store the adjusted width for individual dashboard in localStorage to memorize the state
* migrate DashboardBuilder test code by testing-library and jest
