Commit Graph

3289 Commits

Author SHA1 Message Date
Yongjie Zhao
ebe585df3d [bugfix] Encode unicode error message response (#5687)
* Fix unicode error message response

* Update
2018-08-21 20:47:40 -07:00
Sumedh Sakdeo
80e777823b Field names in big query can contain only alphanumeric and underscore (#5641)
* Field names in big query can contain only alphanumeric and underscore

* bad quote

* better place for mutating labels

* lint

* bug fix thanks to mistercrunch

* lint

* lint again
2018-08-21 13:45:42 -07:00
Maxime Beauchemin
71e0c07904
[bugfix] making secondary_metric optional (#5682)
I noticed that `secondary_metric` was required in the chart that users
it, namely sunburst, parallel coordinates, and world_map.

I set the control as allowing null, and found related bugs in the
process:
* parallel coordinates did not have support for the new MetricControl
* added color scheme support for parallel coordinates
* added option to set row_limit on these viz types
* sunburst to support numeric columns (number would show as blank)
2018-08-21 11:31:33 -07:00
Emily Littleworth
8dfa565c22 Upgrade mysqlclient to 1.3.13 (#5665) 2018-08-21 11:29:48 -07:00
Beto Dealmeida
14b5c6b8b1 Fix CSS (#5640) 2018-08-21 11:24:39 -07:00
Krist Wongsuphasawat
fdb8001e0b change title from hotkeys to keyboard shortcuts (#5688) 2018-08-21 11:16:06 -07:00
Maxime Beauchemin
50042af25d
[bug] 'an error has ooccured' when saving datasource (#5683)
The check_ownership was failing when Alpha user was saving a datasource
from the datasource editor.
2018-08-21 10:10:44 -07:00
hitdemo
5e5360fc11 make some text localizable, mainly in dashboard, explore, datasource editor, webpage title (#5685) 2018-08-21 10:10:09 -07:00
Sumedh Sakdeo
0fbda33c68 Handling bigquery dialect when previewing data (#5655)
* Handling bigquery dialect when previewing data

* review comments

* lint
2018-08-20 22:04:22 -07:00
Maxime Beauchemin
2d23ae1065
[bugfix] df is None breaks df.empty check (#5657) 2018-08-20 17:01:03 -07:00
Krist Wongsuphasawat
683edc377e Refactor Chord vis (#5671)
* refactor Chord vis

* Add PropTypes

* change module.exports to export default
2018-08-20 17:00:25 -07:00
Beto Dealmeida
fef39a7878 Fix time filter in cache (#5681) 2018-08-20 16:37:19 -07:00
Krist Wongsuphasawat
cdd348ab94 Minor improvements to SQL Lab UI (#5662)
* Remove "for"

* add space

* Separate control to select table from database and schema.

* Adjust schema displays

* Fix caret and arrow position in Select and Tab

* Reduce space after caret in tab header

* Use translator

* Align icons in the pop-up menu in Sql Lab

* Add new table in front of the list (so it will appear on top)

* shorten message

* reduce line
2018-08-19 22:43:00 -07:00
Beto Dealmeida
4c5142d969 Filter out null locations by default (#5642)
* Filter out null locations by default

* Move exception to better place

* Add unit test

* Return columns in order for test and readibility
2018-08-19 16:04:01 -07:00
Hugh A. Miles II
dd5e0ba70b
Update CONTRIBUTING.md (#5668) 2018-08-19 15:42:09 -07:00
Chris Williams
3d15d910af
[sqllab] call out transient state of tabs to users (#5652) 2018-08-17 17:44:56 -07:00
Maxime Beauchemin
0a1aa6dd50
[bugfix] TypeError: adhocMetric.comparator.join is not a function (#5661)
Somehow we have a "IN" filter where the filter is a string, not an
array. While this may need to get fixed upstream as well, this prevents
the explore view from completely crashing.

Side note: this function looked somewhat brittle, I'm assuming it's used to keep
the free form SQL tab in sync and not used to generate the actual SQL
being executed.
2018-08-17 15:53:04 -07:00
Yongjie Zhao
5a4b70dad7 Fix checkbox is fails When disable Druid datasource (#5645) 2018-08-16 23:54:27 -07:00
Junda Yang
97acfc7f17 fix multilayer viz backend error (#5649) 2018-08-16 23:52:39 -07:00
Sumedh Sakdeo
cc9324ae8b handle exception and set dtype value to JSON, when column type JSON (#5644)
* handle exception and set dtype value to JSON, when column type JSON

* review comment

* only when we handle exception
2018-08-16 20:04:08 -07:00
timifasubaa
4ff5686e0c
make filters use security manager (#5567)
* make filters use security manager

* remove the superset short-circuit
2018-08-16 14:17:41 -07:00
michellethomas
32b3d00825 Updating yarn.lock for the vx upgrade (#5648) 2018-08-16 13:16:52 -07:00
michellethomas
2e0418034f Upgrading vx responsive to fix ResizeObserver issue (#5647) 2018-08-16 11:17:22 -07:00
michellethomas
492ad6c49a use_slice_data in slice_json calls (#5643) 2018-08-16 09:35:34 -07:00
Sumedh Sakdeo
5966a674e5 Explore View Perf Fix (#5637) 2018-08-15 12:27:08 -07:00
michellethomas
bf0afef7a9 Fix form data issue switching viz types (#5100)
* Fixing issue with extra params in formData

* Pass in param use_slice_data to decide whether to use slice data

* Fixing core_tests to not use explore_json overrides
2018-08-15 11:25:06 -07:00
John Bodley
4e3b2e7cbc
[title] Fix issue with non-string names in series title (#5433) 2018-08-15 09:35:44 -07:00
Sumedh Sakdeo
c9bd5a6167 Fetch a batch of rows from bigquery (#5632)
* Fetch a batch of rows from bigquery

* unused const

* review comments
2018-08-14 21:44:04 -07:00
John Bodley
46f89f4516
[bubble] Fixing ad-hoc metric labels (#5630) 2018-08-14 17:11:40 -07:00
Maxime Beauchemin
d601ff4747
Tackling late-arriving comments from #5186 (#5626) 2018-08-14 16:30:50 -07:00
Maxime Beauchemin
be04c98cd3
[sql lab] always use NullPool (#5612)
I think that the only place where we want db connection pooling would be
to talk to the metadata database. SQL Lab should close its connections
and never pool them.
Given that each Gunicorn worker will create its own pool that can lead
to way too many connections opened.

closes https://github.com/apache/incubator-superset/issues/4666
2018-08-14 16:27:13 -07:00
Conglei
2171ffb630 [bug fix] Fixed forced percentage format on tooltips and bubble chart tooltips format. (#5631)
* fixed forced percentage format on tooltip and correct reflection on bubble chart tooltip format

* re-trigger build
2018-08-14 16:04:24 -07:00
Maxime Beauchemin
4c2be71e83
[bugfix] TIMESTAMP not detected as date (#5629)
* [bugfix] TIMESTAMP not detected as date

* minor tweak
2018-08-14 13:01:28 -07:00
Hugh A. Miles II
85a6da19ee
Fix annotation_json endpoint (#5621)
* fix annotation_json endpoint

* add time back

* set db to None

* change if condition

* remove prop

* add guard for to_dttm

* linting
2018-08-14 11:40:14 -07:00
Grace Guo
9f6ac0898e
[Dashobard]Fix bad merge (#5624) 2018-08-14 10:56:45 -07:00
Krist Wongsuphasawat
1d7f4f282e [bugfix] line_multi chart crashed on chosen (#5568) (#5572)
* Fix bug for line_multi

* refactor forEach to map

* reorder fields

* fix issue with datasource
2018-08-14 10:48:21 -07:00
Jillian Rowe
a39dfb9ff9 Add additional heatmap schemas (#5549)
* got skeleton started

* added d3-scale-chromatic to package.json

* got hex values instead of calling from a function

* got rid of d3-scale-chromatic - no longer needed

* added schemas to controls

* damn editor broken some line spacing

* commit

* fix style issues

* whyyyyy won't this build

* whyyyyy won't this build

* damn typo

* hahaha got editor to deal with style configs

* no i guess i didn't

* gotta get them all

* again

* trying to get docker build ot work

* updated installation docs with some osx instructions

* restoring yarn.lock not sure why it changed

* trying to fix indent

* trying again

* CODE STYLE CHANGES WORK

* removing some colors that are too close to white

* human readable labels for names

* human readable labels for names
2018-08-13 23:37:17 -07:00
Beto Dealmeida
763eeca75a No exception on no data (#5597)
* No exception on no data

* Remove unreachable exception
2018-08-13 22:33:29 -07:00
Beto Dealmeida
5c1d906976 Add option to run query with ctrl+enter (#5622) 2018-08-13 21:43:57 -07:00
Krist Wongsuphasawat
536478e96d [feature] Allow min/max value for the sparkline in time series table (#5603)
* Allow min/max value for the sparkline in time series table

* show bound lines

* User can choose to show y-axis bounds

* show label for the bounds

* compute necessary padding for the bound label

* extract sparkline code to another component

* can show y-axis in sparkline without setting bounds

* reorder option rows
2018-08-13 16:19:19 -07:00
John Bodley
e0c02be14e
[dashboards] Increasing position_json to MEDIUMTEXT for MySQL (#5618) 2018-08-13 14:52:59 -07:00
John Bodley
2685ab4f1f
[fix] Enforcing main dttm column (#5584) 2018-08-13 13:54:55 -07:00
hitdemo
50981dbc69 make some text localizable (#5611) 2018-08-12 20:47:55 -07:00
Narcissus7
7d61eea604 fix cal_heatmap tips location error (#5480) (#5587)
* fix cal_heatmap tips location error

* fix graph-legend
2018-08-12 20:44:54 -07:00
John Bodley
d1ef81f102
[ad-hoc filters] Fixing legacy conversion (#5589) 2018-08-10 10:22:06 -07:00
Maxime Beauchemin
682ca3874e
[sql lab - explore flow] make sure groupby is empty (#5596) 2018-08-09 14:48:36 -07:00
Grace Guo
21bf8d9f8f [bug]Fix load_examples dashboard version key name (#5592) 2018-08-09 13:09:14 -07:00
Maxime Beauchemin
f4b45f07c3
[sql lab] visualization flow to detect unaliased columns (#5579)
* [sql lab] visualization flow to detect unaliased columns

* Addressing comments
2018-08-09 13:04:09 -07:00
Maxime Beauchemin
a8f4849911
[table editor] disable 'Sync table metadata' button for Superset views (#5580)
This was a bit tricky since there's a bug in react-bootstrap that make
it tricky to show a tooltip on a disabled button.
2018-08-09 10:53:25 -07:00
Beto Dealmeida
222b79df7e Template dashboard (#5550)
* Template dashboard

* Fix MySQL test

* Model for user attributes

* Redirect to welcome dash

* Fix lint

* Add missing file

* Add migration script

* Fix lint

* Fix more lint
2018-08-07 17:39:15 -07:00