Commit Graph

12258 Commits

Author SHA1 Message Date
Joe Li
4b221378cc
fix: Revert "#20095 - fix(database): make to display validation error msg when all … (#21277) 2022-08-31 16:56:56 -06:00
AAfghahi
a7fe4850ed
fix: dataset exists error in save Dataset modal (#21244)
* dataset exists error

* fixed flashing modal
2022-08-31 16:47:39 -04:00
AAfghahi
9c4ae2ab7e
fix: bump min version of elastic search (#21274)
* dataset exists error

* change min version of elasticsearch
2022-08-31 12:42:48 -07:00
Daniel Vaz Gaspar
3f2e894af3
fix: dataset name change and permission change (#21161)
* fix: dataset name change and permission change
2022-08-31 18:11:03 +01:00
EugeneTorap
0c87ff783a
fix: Table content disappears when switching between tabs (#21251) 2022-08-31 15:46:48 +02:00
Daniel Vaz Gaspar
6223042050
fix: SQLAlchemy coercing subquery warning on RLS (#21257) 2022-08-31 08:16:57 +01:00
JUST.in DO IT
034ee1c3c1
fix(sqllab): unable to create new tabs (#21260) 2022-08-30 13:54:42 -07:00
aehanno
944808a0ce
fix: Add french translation missing (#20061) 2022-08-30 22:23:05 +02:00
Lily Kuang
05354a96bf
feat: filter with created_by for charts and dashboards (#21199)
* feat: filter with created_by for charts and dashboards

* add tests

* update tests

* update tests
2022-08-30 12:27:38 -07:00
JUST.in DO IT
1aa1864d13
chore: missing IconType on Icons (#21218) 2022-08-30 09:56:05 -07:00
JUST.in DO IT
ad6b98c2b7
fix(sqllab): update persistent queryEditor keys (#21246) 2022-08-30 09:46:31 -07:00
Moritz Rathberger
05bdaf2376
feat(helm): Added env variable SERVER_WORKER_AMOUNT (#21236)
* added SERVER_WORKER_AMOUNT

* added more gunicorn variables

* Update values.yaml
2022-08-30 09:38:41 -07:00
Hugh A. Miles II
f2d67f75d0
Revert "ok (#21116)" (#21247)
This reverts commit 642a0d7704.
2022-08-30 09:31:34 -07:00
ʈᵃᵢ
04dd8d414d
fix(celery cache warmup): add auth and use warm_up_cache endpoint (#21076) 2022-08-30 09:24:24 -07:00
Shubham Sinha
b354f2265a
fix(dev-server run): Check for environment tag not being undefined (#21232)
* fixed local dev-server run

* removed console log

* removed console log
2022-08-30 14:51:32 +08:00
Stephen Liu
0c43190e04
fix(database-list): hidden upload file button if no permission (#21216) 2022-08-30 10:34:28 +08:00
Beto Dealmeida
8772e2cdb3
fix: improve get_db_engine_spec_for_backend (#21171)
* fix: improve get_db_engine_spec_for_backend

* Fix tests

* Fix docs

* fix lint

* fix fallback

* Fix engine validation

* Fix test
2022-08-29 11:42:42 -07:00
Geido
710a8ce5c0
chore: Minor Applitools enhancements (#21239)
* Enhance logging

* Update conf
2022-08-29 19:38:13 +03:00
Geido
1d3a805a61
chore: Drill to detail Modal tests (#21148)
* Add DrillDetailModal test

* Add DrillDetailPane tests

* Add TableControls test

* Lint

* Enhance SliceHeaderControls tests

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/DrillDetailPane/TableControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-08-29 14:22:15 +03:00
Michael S. Molina
77f54585de
chore: Keeps context menu in viewport (#21212) 2022-08-29 08:14:22 -03:00
Geido
f017f98b88
chore: E2E tests for the Drill to detail modal (#21187)
* Add example ECharts Dashboard

* [WIP] E2E test

* Add echarts interactions

* Lint

* DRY
2022-08-29 11:25:27 +03:00
Đặng Minh Dũng
ccb293a083
fix(Trino): create PrestoBaseEngineSpec base class to share common code between Trino and Presto (#21066)
* chore: create `PrestoBaseEngineSpec` class that share common functions between Presto and Trino

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* feat(Trino): support CertificateAuthentication

* chore(Presto): move `get_function_names` to `PrestoBaseEngineSpec`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores(Presto): remove `is_readonly_query`

* feat(Trino): implement `extra_table_metadata`

* feat(Trino): specify `User-Agent`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* fix: pylint

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* chores(Presto): move `PrestoBaseEngineSpec` to `presto.py`

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

* fix(Presto): typing annotations

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>

Signed-off-by: Đặng Minh Dũng <dungdm93@live.com>
2022-08-29 10:21:28 +03:00
Eric Briscoe
5f76ac9001
fix: Fixes error caused by step id placed in wrong location (#21226)
* Update chromatic PR action to have access to Job outputs

Adjusting to follow docs at: https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs

* Fixes error where step ID was incorrect location
2022-08-28 14:44:54 -07:00
Shubham Sinha
d408393ba9
fixed guest role permissions (#21208) 2022-08-28 09:08:41 +02:00
Hugh A. Miles II
c61a507e14
fix: add back custom sql filtering with Query as source (#21190) 2022-08-26 19:12:21 -07:00
Eric Briscoe
e2ab966910
Update chromatic PR action to have access to Job outputs (#21224)
Adjusting to follow docs at: https://docs.github.com/en/actions/using-jobs/defining-outputs-for-jobs
2022-08-26 16:21:22 -07:00
Eric Briscoe
092460a1f1
Removes if statement causing comment not to run (#21222) 2022-08-26 15:42:26 -07:00
Hugh A. Miles II
653c9f0e7f
fix: Update exception for DatasourceNotFound from DatasourceDao.get_datasource() (#21217)
* update exception

* add 404
2022-08-26 15:11:47 -07:00
Reese
25cc7897b1
feat: Environment tag (#20295)
* Added environment tag and relevant tests

* Reorganize imports

* Prevent errors when config value not set

* Default production tag to be hidden

* Change tag to Label component

* Fix import order

* Allow tag to be colored with theme

* Use theme for tag border radius

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>

* Fix styling

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
2022-08-26 16:08:24 -06:00
Reese
16032ed3e2
feat: Virtual dataset duplication (#20309)
* Inital duplicate functionality

* Fix formatting

* Create dedicated duplicate API

* Make use of new API

* Make use of new api permissions

* Add integration tests for duplicating datasets

* Add licenses

* Fix linting errors

* Change confirm button to 'Duplicate'

* Fix HTTP status code and response

* Add missing import

* Use user id instead of user object

* Remove stray debug print

* Fix sqlite tests

* Specify type of extra

* Add frontend tests

* Add match statement to test
2022-08-26 16:07:56 -06:00
Eric Briscoe
f09c4327f8
Splitting into two separate chromatic jobs to reduce conditional logic causing run issues (#21219) 2022-08-26 14:56:19 -07:00
JUST.in DO IT
4e23d62d4f
fix(sqllab): missing zero values while copy-to-clipboard (#21153) 2022-08-26 14:28:48 -07:00
Michael S. Molina
d41f44fcdf
fix: World Map right-click value (#21209) 2022-08-26 15:08:24 -03:00
Cody Leff
0726840fb7
fix(explore): Prevent unnecessary series limit subquery (#21154)
* Prevent series limit when no series limit columns specified.

* Add timeseries check for legacy charts.

* Apply fix to helpers.py.

* Skip Cypress color consistency tests.
2022-08-26 11:16:13 -06:00
Michael S. Molina
68fa4d2665
feat: Adds drill to detail context menu to Table (#21168)
* feat: Adds drill to detail context menu to Table

* Improves context menu positioning

* Fixes Pivot Table typying
2022-08-26 13:35:26 -03:00
yuzutas0
982210ad83
Fix formatting in README.md (#21205) 2022-08-26 12:21:43 -04:00
Michael S. Molina
859b6d2d20
feat: Adds drill to detail context menu to Pivot Table (#21198)
* feat: Adds drill to detail context menu to Pivot Table

* Adds useCallback
2022-08-26 08:23:26 -03:00
Michael S. Molina
1143e17742
fix: Typing of labelMap (#21181)
* fix: Typing of labelMap

* Adjusts val types
2022-08-26 08:22:57 -03:00
Cody Leff
5811262cf2
Add warnings if feature flags are read before initialization. (#21201) 2022-08-25 16:53:18 -06:00
Kamil Gabryjelski
17ad0d80de
chore: Add new e2e tests for Explore (#21184)
* chore(explore): Add cypress test for creating chart from dataset list

* Add cypress test for creating chart from sqllab query

* Fix the test for editing dataset in exploer

* Fix lint

* Fix tests
2022-08-25 18:50:31 +02:00
EugeneTorap
994e1f6bdc
chore: bump clickhouse-sqlalchemy 0.2.2 (#21195) 2022-08-25 15:35:20 +02:00
Paulo Eduardo da Silva
93557e3a1a
removing unnecessary margin for 50% fields (#21167) 2022-08-25 11:48:31 +08:00
Paulo Eduardo da Silva
74e40c2de1
removing bottom margin on CronPicker (#21140) 2022-08-25 11:44:16 +08:00
Anthony Gainor
da3401a698
fix(database-modal): Show a different placeholder text in Snowflake connection form (#21172)
* Add new Database Modal

When adding a new database and selecting Snowflake, the database and account fields had the same placeholder. This PR adds a placeholder prop so values can be sent dynamically by field

* Call translation function for string literals

Co-authored-by: Herbert Gainor <herbert.gainor@preset.io>
2022-08-24 15:37:47 -06:00
smileydev
d568999592
fix(database): make to display validation error msg when all cases (#20095)
* fix(database): make to display validation error msg when all cases

* fix(db): make to update the alert error condition

* fix(db): make to add error detail display

* fix(db): make to update error alert display by superset error style guide.

* fix(db): make to style modal header title with h4

* fix(db): make to place see more on bottom instead of top

* fix(db): make to fix shortly

* fix(db): make to fix lint issue

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-08-24 11:29:22 -06:00
Lily Kuang
604e30b3f0
fix: Filter throwing an error on Embedded Dashboard (#21157)
* fix: Filter throwing an error on Embedded Dashboard

* use short_id if storage not available

* avoid infinite loop
2022-08-24 09:38:20 -07:00
JUST.in DO IT
53de94c047
Revert "fix(sqllab): avoid unexpected re-rendering on DatabaseSelector (#21141)" (#21174) 2022-08-23 22:26:05 -07:00
Bogdan
ed6212a1f9
Reimplement permissions fetching to do it in a single transaction (#21156)
Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2022-08-23 18:45:39 -07:00
Hugh A. Miles II
cda7d70565
feat: print comment for chromatic storybook link (#21170)
* Update chromatic.yml

* Update chromatic.yml

* Update chromatic.yml

* Update chromatic.yml

* Update chromatic.yml

* Update chromatic.yml

* working

* plz work

* plzzzzz

* one more time

* one one more time

* this works

* lit

* last one
2022-08-23 19:31:05 -04:00
Eric Briscoe
6a0b7e5598
feat: Add Chromatic publishing to superset-frontend storybook (#21095)
* Work in progress to add Chromatic publishing to superset-fronted storybook

Adds new Github action to publish storybook builds to chromatic
Adjusts configuration to support MDX story format
Updates Alert stories to take advantage of MDX format for example in storybook that will publish to Chromatic
Fixes issue in ListViewCard stories that make the story build fail

* Adjust Chromatic Github action

* Adjust action so Gtihub Secret is read into env

Github secrets are not accessible in conditional blocks so this change moves the access of the github secret into an env variable which is accessible in conditional logic

* Removes unneccesary projectToken from package json

* Using a temp key to debug no access to value from github secret

* Refining skipping if no changes to superset-frontend

* Remove typos from Action component story, consolidate on folder check in Chromatic action

* Fix error in Chromatic action event

* Testing action with pul_request_target

* adjustments to Chromatic action triggers

* lint fix

* Testing if pull_request_target is disabled

* More adjustments to Chromatic action

* UI Change to trigger action

* Change to story text to test action

* update package-lock after merge conflicts from master

* Changes to test chromatic action

* Finalize Chromatic actions, fix lint errors

* Backs out addition of @storybook/addon-docs which is included in addon-essentials

* Lint error in package.json
2022-08-23 16:16:28 -04:00