Commit Graph

5825 Commits

Author SHA1 Message Date
Maxime Beauchemin 7f1e4e441d
fix: surface connection error messages on the client (#11077)
* fix: surface connection error messages on the client

* typo

* lint
2020-09-26 16:09:40 -07:00
Yongjie Zhao 1493450a6f
fix(jest): using UTC mock date (#11079) 2020-09-26 14:53:41 -07:00
Evan Rusackas 23d62f37a6
removing unused component (#11072) 2020-09-25 23:02:01 -07:00
Evan Rusackas 8cba1c823d
changing to the correct hex color (#11073) 2020-09-25 21:09:59 -07:00
Maxime Beauchemin 8e6f7d6598
style: remove unecessary padding (#11071) 2020-09-25 17:22:46 -07:00
Moriah Kreeger 374b06b4dd
fix: database list checkboxes (#11068) 2020-09-25 16:28:22 -07:00
Evan Rusackas eeeb21077d
feat: adding all icons from the design system to the codebase (#11033)
* error -> error-solid

* warning -> warning-solid

* all the new icons mixed in!

* card-view -> card_view

* circle-check-solid -> circle_check_solid

* corrected circle-check to new name and correct (stroke) icon

* sort-asc/desc -> sort_asc/desc

* databases -> database

* compass -> nav_explore

* pencil -> edit-alt

* more pencil migrations

* easy list view rename

* star -> favorite (changed in Figma)

* removing deprecated icon

* renaming icon to mach figma

* More -> More Horiz

* forgot to change this when ranming the file

* updating some icon names in use

* adding hella icons

* fixing errant viewboxes

* removing dropdown-arrow in favor of triangle-down

* adding key to storybook map.

* fixing icon component reference

* tweaks to fave star styling to support revised icon

* fixing a bad icon inclusion

* missed a license

* touchup to virtual dataset... will tweak later.

* e2e fix

* linting
2020-09-25 14:49:30 -07:00
Erik Ritter 052d7a0a3e
fix: sql lab autocomplete width (#11063) 2020-09-25 10:13:21 -07:00
Evan Rusackas d056e3dfd3
clickable labels have outlines, storybook shows them (#11034) 2020-09-24 20:50:44 -07:00
Srini Kadamati 66e49807ef
fixed routes for customer in docs (#11052) 2020-09-24 20:43:03 -07:00
Grace Guo 3467d2d8d6
Revert "style: fix checkbox color (#10970)" (#11051)
This reverts commit e4e78b66fa.
2020-09-24 16:53:02 -07:00
Lily Kuang ea105bc23b
feat: add "created by" to dashboard CRUD view (#11030) 2020-09-24 14:33:55 -07:00
Kasia Kucharczyk 92dd257ef4
Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (#11037) 2020-09-24 13:50:09 -07:00
Kasia Kucharczyk 63d0e801ad
chore: updated lint rules in models module (#11036)
* Removed disabled pylint rule `unused_import` from `dashboards.py` in `models` module. Added missing break in too long line. Formatting.

* Changed `datasource_access_request.py` in models` module: removed disabled pylint rule `unused_import`, removed `no-member` disabled rules which aren't needed. Formatting

* Changed `slice.py` in models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument`
2020-09-24 13:49:00 -07:00
Kasia Kucharczyk 6b318c477e
Removed disable global pytlint rule `standarderror-builtin` which isn't appearing for Python3 (#11038) 2020-09-24 13:48:02 -07:00
Kasia Kucharczyk eba1aa8a53
Enabled argument-differ for bulk_delete (#11039) 2020-09-24 13:47:00 -07:00
Kasia Kucharczyk 7ca4192fe6
Enabled no-self-use pylint rule in security. Formatter (#11041) 2020-09-24 13:46:21 -07:00
Kasia Kucharczyk 8bc05bda6f
Changed variable name from capitals to lowercase and changed lint rule (#11044) 2020-09-24 13:45:19 -07:00
Grace Guo f99753a800
Revert "ESLint: Re-enable rule default-props-match-prop-types (#10868)" (#11050)
This reverts commit 9f01a7fdf8.
2020-09-24 12:33:38 -07:00
ʈᵃᵢ eded51b2f8
feat(saved_queries): add custom api filter for all string & text fields (#11031) 2020-09-24 11:05:25 -07:00
Bogdan b2fdf12f62
Support jinja templates (#11008)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-24 10:29:44 -07:00
Ville Brofeldt 6181994084
chore: bump pandas to latest stable version (#11018)
* chore: bump pandas to latest stable version

* fix nest_values
2020-09-24 13:11:10 +03:00
Grace Guo 8e9b0b3f11
fix: dashboard edit button (again) (#11029) 2020-09-23 15:42:06 -07:00
Maxime Beauchemin dc76a2688e
style(explore): use tertiary button against gray background (#11011)
"primary" style buttons seem to expect a white background and really
look muted against the gray background. Using "tertiary" style button makes
things much better.

Eventually we may reconsider the layout and gray background and go back
to secondary, but for now this makes these important pop much more
2020-09-23 11:44:39 -07:00
Rob DiCiuccio 8b683783cc
docs: add security vulnerability GH issue template (#11023)
* Add security vulnerability issue template

* Louder title
2020-09-23 11:13:13 -07:00
Grace Guo 0409393a4e
fix: [dashboard] should not show edit button when user has no edit permit (#11024) 2020-09-23 10:55:32 -07:00
Jesse Yang 7549dad12d
fix: timer component, fixes #10849, closes #11002 (#11004) 2020-09-23 10:53:24 -07:00
Kasia Kucharczyk af1e8e8839
fix: enable several pylint rules partially in db_engines_specs module (#11000)
* Enabled mssql

* Enabling pylint rules in `mysql.py` from `db_engine_specs`:
- added variable to shorten line and enable `line-too-long`
- `import-error` seems not prompting anymore
- specified exception instead broad-except

* Refactored too long line in `oracle.py` from `db_engine_specs`. Enabled too-long-line pylint rule.

* Changed fstring into string `pinot.py` to reenable `f-string-without-interpolation` rule.

* Enabled `unused-import` rule and changed line to adjust to correct number of characters in `db_engine_specs/postgres.py`.

* Enabled unused-import pylint check in `db_engine_specs/presto.py`

* Enabled unused-import pylint check in `db_engine_specs/snowflake.py`

* Enabled unused-import pylint check in `db_engine_specs/sqlite.py`
2020-09-23 10:47:56 -07:00
Kasia Kucharczyk fb6f14c469
fix: pylint checks in connectors/sqla/models.py (#10974)
* Removed unused pylint rule `too-many-instance-attributes` from SqlaTable class.

* Removed unecessary rule: `bad-whitespace` from `get_sqla_query` method

* Disabling too-many-instance-attributes since it fails on CI
2020-09-23 10:47:12 -07:00
Kasia Kucharczyk bade279883
fix: reenable pylint rule `unused-import` in charts and connectors modules (#11014)
* Removed disabled pylint rule `unused_import` from `dao.py` in `charts` module

* Removed disabled pylint rule `unused_import` from `connector_registry.py` in `connectors` module
2020-09-23 10:46:44 -07:00
Kasia Kucharczyk 26fcc08906
Enabled pylint rules in `db_engines` module: (#11016)
- `unused_import` and `import_error` - not promting anymore
- changed unused param to private and removed `unused_argument`
2020-09-23 10:45:26 -07:00
Kasia Kucharczyk a26f29e7c8
fix: changes a pylint check in dashboard module (#10978)
* Removed not needed disabled pylint rules from `set_dash_metadata`:
- `disable=too-many-locals`,
- `too-many-branches`,
- `too-many-statements`

* Changed broad exception to KeyError.

* Reverted broad_exception in get_col_type in utils
2020-09-23 10:26:22 -07:00
ʈᵃᵢ 345fe07d64
fix: menu shows a 0 when there are not settings (#11009) 2020-09-23 09:22:45 -07:00
Daniel Vaz Gaspar ba009b7c09
fix: query search low privileged user search access denied (#11017) 2020-09-23 14:16:24 +01:00
ʈᵃᵢ 50852dfbbf
chore: downgrade expected exception from error to info (#10994)
* chore: reduce number of error logs

* info -> warning
2020-09-23 12:05:44 +01:00
Lily Kuang 02ab5cc644
fix: Add Item Overflow on Dataset Editor (#10983)
* move add item button to the top

* fix cypress

* fix cypress
2020-09-22 22:19:41 -07:00
Beto Dealmeida d992c306c2
Bring back import menu (#11007) 2020-09-22 19:32:44 -07:00
ʈᵃᵢ 0d1f6119a6
feat(listview): feature flag config to set default viewing mode (#10986) 2020-09-22 18:01:19 -07:00
Jesse Yang 220c410df4
build: add react-hooks linting (#11006)
Fixed a couple of criticle errors and left the warnings as is (mostly
from react-hooks/exhaustive-deps).

Let's fix the warnings in future PRs as sometimes unexhaustive deps
are intentional.
2020-09-22 15:09:22 -07:00
Erik Ritter a491b6db41
fix: unbreak ci (#11003) 2020-09-22 14:41:15 -07:00
Kasia Kucharczyk a6f258747b
fix: enable pylint rules in db_engine_specs module (#10998)
* Athena.py: cretaed variable for too long line, removed disabled pylint rule.

* Enabled `line-too-long` in `drill.py`. Added variable for too long string.

* Reformatted hana.py:
- changed return statement into two lines to keep line lenght limit

* Enabling pylint rule in hive.py:
- `no-name-in-module` for pyhive in several places
- `line-too-long` and adding new lines
- `unused-import` is not invalid anymore

* Enabled `line-too-long` in `kylin.py`. Added variable for too long string.

* Enabled `unused_import` in `base.py` from db_engine_specs module.

* Enabled `unused_import` in `bigquery.py` from db_engine_specs module.

* Enabled `unused_import` in `druid.py` from db_engine_specs module.

* fix: athena datetime string converting
2020-09-22 13:44:45 -07:00
Kamil Gabryjelski e93d92e8ac
Replace reactable with DataTable from superset-ui in QueryTable (#10981)
* Replace reactable with DataTable from superset-ui in QueryTable

* Fix tests

* Fix pagination

* Fix tests
2020-09-22 13:24:30 -07:00
Kamil Gabryjelski 9f01a7fdf8
ESLint: Re-enable rule default-props-match-prop-types (#10868)
* Re-enable rule default-props-match-prop-types

* Restore default props and remove isRequired

* Remove unused props
2020-09-22 13:17:41 -07:00
Ville Brofeldt a9eab33d64
feat: add ECharts Pie chart (#10966)
* feat: introduce echarts pie chart

* lint

* remove viz.py shim

* remove tests

* fix cypress test

* fix test
2020-09-22 19:27:40 +03:00
Beto Dealmeida 0554c8918e
Enable subqueries in gsheetsdb (#10991) 2020-09-22 08:51:29 -07:00
Karthikeyan Singaravelan 95ba8e1fb7
fix: deprecation warnings due to invalid escape sequences. (#10710)
* fix: Fix deprecation warnings due to invalid escape sequences.

* fix: Fix black related errors.
2020-09-22 16:03:58 +01:00
Ville Brofeldt bd140e018a
fix(presto): default unknown types to string type (#10753)
* fix(presto): default unknown types to string type

* lint
2020-09-22 13:16:54 +03:00
Ville Brofeldt 448a41a4e7
feat(row-level-security): add base filter type and filter grouping (#10946)
* feat(row-level-security): add filter type and group key

* simplify tests and add custom list widget

* address comments

* use enum value to ensure case sensitive value is used
2020-09-22 08:54:10 +03:00
Maxime Beauchemin 3be8bdad9a
docs: add gallery screenshot & link in README (#10988)
* docs: add gallery screenshot & link in README

* deallowing large files
2020-09-21 22:48:55 -07:00
Maxime Beauchemin 8e4a1c8356
docs: add a "Gallery" page (#10968)
* docs: add a gallery page

* Adding image gallery

* linted

* add more screenshots

* a few more screenshots
2020-09-21 22:27:03 -07:00