pt
/
superset
mirror of https://github.com/apache/superset.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Changed `tags.py` and `helpers.py` in `models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument. Removed redundant rules.` (#11037)

This commit is contained in:
Kasia Kucharczyk 2020-09-24 22:50:09 +02:00 committed by GitHub
parent 63d0e801ad
commit 92dd257ef4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
superset/models/helpers.py
View File

@ -136,7 +136,7 @@ class ImportMixin:
parent: Optional[Any] = None,
recursive: bool = True,
sync: Optional[List[str]] = None,
) -> Any: # pylint: disable=too-many-arguments,too-many-locals,too-many-branches
) -> Any:
"""Import obj from a dictionary"""
if sync is None:
sync = []

23
superset/models/tags.py
View File

@ -29,10 +29,10 @@ from sqlalchemy.orm.mapper import Mapper
from superset.models.helpers import AuditMixinNullable
if TYPE_CHECKING:
from superset.models.core import FavStar # pylint: disable=unused-import
from superset.models.dashboard import Dashboard # pylint: disable=unused-import
from superset.models.slice import Slice # pylint: disable=unused-import
from superset.models.sql_lab import Query # pylint: disable=unused-import
from superset.models.core import FavStar
from superset.models.dashboard import Dashboard
from superset.models.slice import Slice
from superset.models.sql_lab import Query
Session = sessionmaker(autoflush=False)
@ -136,11 +136,10 @@ class ObjectUpdater:
@classmethod
def after_insert(
cls,
mapper: Mapper,
_mapper: Mapper,
connection: Connection,
target: Union["Dashboard", "FavStar", "Slice"],
) -> None:
# pylint: disable=unused-argument
session = Session(bind=connection)
# add `owner:` tags
@ -158,11 +157,10 @@ class ObjectUpdater:
@classmethod
def after_update(
cls,
mapper: Mapper,
_mapper: Mapper,
connection: Connection,
target: Union["Dashboard", "FavStar", "Slice"],
) -> None:
# pylint: disable=unused-argument
session = Session(bind=connection)
# delete current `owner:` tags
@ -188,11 +186,10 @@ class ObjectUpdater:
@classmethod
def after_delete(
cls,
mapper: Mapper,
_mapper: Mapper,
connection: Connection,
target: Union["Dashboard", "FavStar", "Slice"],
) -> None:
# pylint: disable=unused-argument
session = Session(bind=connection)
# delete row from `tagged_objects`
@ -234,9 +231,8 @@ class QueryUpdater(ObjectUpdater):
class FavStarUpdater:
@classmethod
def after_insert(
cls, mapper: Mapper, connection: Connection, target: "FavStar"
cls, _mapper: Mapper, connection: Connection, target: "FavStar"
) -> None:
# pylint: disable=unused-argument
session = Session(bind=connection)
name = "favorited_by:{0}".format(target.user_id)
tag = get_tag(name, session, TagTypes.favorited_by)
@ -251,9 +247,8 @@ class FavStarUpdater:
@classmethod
def after_delete(
cls, mapper: Mapper, connection: Connection, target: "FavStar"
cls, _mapper: Mapper, connection: Connection, target: "FavStar"
) -> None:
# pylint: disable=unused-argument
session = Session(bind=connection)
name = "favorited_by:{0}".format(target.user_id)
query = (