From 92dd257ef49e20bb882a7b9456409135ef721690 Mon Sep 17 00:00:00 2001
From: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com>
Date: Thu, 24 Sep 2020 22:50:09 +0200
Subject: [PATCH] Changed `tags.py` and `helpers.py` in `models` module:
 removed disabled pylint rule `unused_import`, changed unused arguments to
 private and removed disabled rule `unused-argument. Removed redundant rules.`
 (#11037)

---
 superset/models/helpers.py |  2 +-
 superset/models/tags.py    | 23 +++++++++--------------
 2 files changed, 10 insertions(+), 15 deletions(-)

diff --git a/superset/models/helpers.py b/superset/models/helpers.py
index fd55bba5ce..dd3a068d94 100644
--- a/superset/models/helpers.py
+++ b/superset/models/helpers.py
@@ -136,7 +136,7 @@ class ImportMixin:
         parent: Optional[Any] = None,
         recursive: bool = True,
         sync: Optional[List[str]] = None,
-    ) -> Any:  # pylint: disable=too-many-arguments,too-many-locals,too-many-branches
+    ) -> Any:
         """Import obj from a dictionary"""
         if sync is None:
             sync = []
diff --git a/superset/models/tags.py b/superset/models/tags.py
index c09bb16858..3f508ff6c6 100644
--- a/superset/models/tags.py
+++ b/superset/models/tags.py
@@ -29,10 +29,10 @@ from sqlalchemy.orm.mapper import Mapper
 from superset.models.helpers import AuditMixinNullable
 
 if TYPE_CHECKING:
-    from superset.models.core import FavStar  # pylint: disable=unused-import
-    from superset.models.dashboard import Dashboard  # pylint: disable=unused-import
-    from superset.models.slice import Slice  # pylint: disable=unused-import
-    from superset.models.sql_lab import Query  # pylint: disable=unused-import
+    from superset.models.core import FavStar
+    from superset.models.dashboard import Dashboard
+    from superset.models.slice import Slice
+    from superset.models.sql_lab import Query
 
 Session = sessionmaker(autoflush=False)
 
@@ -136,11 +136,10 @@ class ObjectUpdater:
     @classmethod
     def after_insert(
         cls,
-        mapper: Mapper,
+        _mapper: Mapper,
         connection: Connection,
         target: Union["Dashboard", "FavStar", "Slice"],
     ) -> None:
-        # pylint: disable=unused-argument
         session = Session(bind=connection)
 
         # add `owner:` tags
@@ -158,11 +157,10 @@ class ObjectUpdater:
     @classmethod
     def after_update(
         cls,
-        mapper: Mapper,
+        _mapper: Mapper,
         connection: Connection,
         target: Union["Dashboard", "FavStar", "Slice"],
     ) -> None:
-        # pylint: disable=unused-argument
         session = Session(bind=connection)
 
         # delete current `owner:` tags
@@ -188,11 +186,10 @@ class ObjectUpdater:
     @classmethod
     def after_delete(
         cls,
-        mapper: Mapper,
+        _mapper: Mapper,
         connection: Connection,
         target: Union["Dashboard", "FavStar", "Slice"],
     ) -> None:
-        # pylint: disable=unused-argument
         session = Session(bind=connection)
 
         # delete row from `tagged_objects`
@@ -234,9 +231,8 @@ class QueryUpdater(ObjectUpdater):
 class FavStarUpdater:
     @classmethod
     def after_insert(
-        cls, mapper: Mapper, connection: Connection, target: "FavStar"
+        cls, _mapper: Mapper, connection: Connection, target: "FavStar"
     ) -> None:
-        # pylint: disable=unused-argument
         session = Session(bind=connection)
         name = "favorited_by:{0}".format(target.user_id)
         tag = get_tag(name, session, TagTypes.favorited_by)
@@ -251,9 +247,8 @@ class FavStarUpdater:
 
     @classmethod
     def after_delete(
-        cls, mapper: Mapper, connection: Connection, target: "FavStar"
+        cls, _mapper: Mapper, connection: Connection, target: "FavStar"
     ) -> None:
-        # pylint: disable=unused-argument
         session = Session(bind=connection)
         name = "favorited_by:{0}".format(target.user_id)
         query = (