Commit Graph

821 Commits

Author SHA1 Message Date
Beto Dealmeida
d304849b46
feat: disable edits on external assets (#19344)
* feat: disable edits on external assets

* Update tests
2022-03-28 16:32:57 -07:00
smileydev
cb0357005e
fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart (#19122)
* fix(report-add): make to add error toast message when already attached report is added again into dashboard or chart

* fix(export-add): make to setup the default error message

* fix(report-add): make to allow the errorMessage undefined in LabeledErrorBoundInput component
2022-03-24 17:18:34 -06:00
Michael S. Molina
65c204b288
fix: Null values on Explore filter (#19341) 2022-03-23 17:23:57 -04:00
Kamil Gabryjelski
a08f83bc60
fix(dashboard): Chart stuck in loading state when when datasets request and chart request fail (#19327) 2022-03-23 15:43:32 +01:00
Diego Medina
9e58916d93
fix: regression on Select component when handling null values (#19326) 2022-03-23 10:31:38 -03:00
Ville Brofeldt
b7ecb14230
fix(dashboard): fix default filter bar visibility + add docs (#18741)
* fix(dashboard): fix default filter tab visibility + add tests

* fix types

* lint

* rename docs + add double bang to length
2022-03-23 08:55:03 +02:00
Michael S. Molina
d3ce398448
fix: Don't allow duplicated tag values in the Select (#19283)
* fix: Don't allow duplicated tag values in the Select

* Addresses comments and adds test
2022-03-22 09:05:22 -03:00
Kamil Gabryjelski
a8a48af7fa
chore: Make font-weights themable, fix font faces (#19236)
* fix(fonts): Import all necessary font packages

* Make html tags themable

* Set bold font weight to 600, add medium font weight to theme

* Replace hard coded font weights with theme variables

* Change some font weight light elements to normal

* Fix tests

* Fix bug in pivot table

* Address code review comments
2022-03-22 09:36:15 +01:00
David Aaron Suddjian
35b8a72dae
Update ToastPresenter.tsx (#19296) 2022-03-22 10:10:43 +02:00
David Aaron Suddjian
96a123f553
feat: SupersetClient config to override 401 behavior (#19144)
* wip

* feat: make 401 responses configurable in SupersetClient

* sort

* guest unauthorized handler

* add toast container to embedded app

* add option for toast presenter to go at the top

* remove confusing comms logging

* lint

* Update superset-frontend/src/embedded/index.tsx

* type correction
2022-03-21 10:19:21 -07:00
Stephen Liu
dc575080d7
feat: improve color consistency (save all labels) (#19038) 2022-03-21 15:20:04 +08:00
David Aaron Suddjian
97abc28a1f
chore!: remove ENABLE_REACT_CRUD_VIEWS feature flag (permanently enable) (#19231)
* remove ENABLE_REACT_CRUD_VIEWS feature flag

* docs

* deal with problematic tests

* empty test suite

* skip test

* test conditions changed

* removing the tests instead of skipping
2022-03-18 14:00:23 -07:00
Grace Guo
d41f9b23a4
chore(superset 2.0): remove front-end deprecated code (#19241) 2022-03-18 11:23:00 -07:00
smileydev
e7355b9610
fix(explore comma): make that the comma can be added by removing it from token separators… (#18926)
* make that the comma can be added by removing it from token separators in select component.

* fix(explore comma): add the allowTokenSeperators props into Select

* fix(explore comma): make to allow to customize the token separators in Select.

* fix(explore comma): make to add the unit test and story book.

* fix(explore comma): make to fix the lint

* fix(explore comma): make to fix the spell  & add tokenSeparatprs props to PickedSelectProps

* Update Select.tsx

* fix(explore comma): make to run lint fix
2022-03-18 11:39:26 -03:00
Jesse Yang
f6291545fb
chore: turn on SQLLAB_BACKEND_PERSISTENCE by default (#19107)
* chore: turn on SQLLAB_BACKEND_PERSISTENCE by default

* Rewrite SQL tabs test to make it more rerunnable
2022-03-17 21:51:47 -07:00
Diego Medina
19fcd03c89
fix: allow to select <NULL> in a native filter single mode (#19076)
* fix: allow to select <NULL> in a native filter single mode

* fix lint issue

* Update superset-frontend/src/components/Select/utils.ts

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-03-17 14:05:32 -03:00
cccs-Dustin
02ef9ca4cd
feat(sqllab): Add a configuration option to disable data preview (#19104) 2022-03-17 15:22:57 +02:00
Diego Medina
0277ebc225
fix: Popovers in Explore not attached to the fields they are triggered by (#19139)
* fix: Popovers in Explore not attached to the fields they are triggered by

* fix

* PR comment

* remove unused import
2022-03-16 20:46:52 -06:00
Diego Medina
3b427b2029
fix: auto-complete of tables and names are not working in SQL lab (#19152) 2022-03-16 20:46:06 -06:00
Ville Brofeldt
b7a0559aaf
feat: add permalink to dashboard and explore (#19078)
* rename key_value to temporary_cache

* add migration

* create new key_value package

* add commands

* lots of new stuff

* fix schema reference

* remove redundant filter state from bootstrap data

* add missing license headers

* fix pylint

* fix dashboard permalink access

* use valid json mocks for filter state tests

* fix temporary cache tests

* add anchors to dashboard state

* lint

* fix util test

* fix url shortlink button tests

* remove legacy shortner

* remove unused imports

* fix js tests

* fix test

* add native filter state to anchor link

* add UPDATING.md section

* address comments

* address comments

* lint

* fix test

* add utils tests + other test stubs

* add key_value integration tests

* add filter box state to permalink state

* fully support persisting url parameters

* lint, add redirects and a few integration tests

* fix test + clean up trailing comma

* fix anchor bug

* change value to LargeBinary to support persisting binary values

* fix urlParams type and simplify urlencode

* lint

* add optional entry expiration

* fix incorrect chart id + add test
2022-03-17 01:15:52 +02:00
Jesse Yang
8d53db1db6
test: fix TimezoneSelector tests on daylight saving time (#19156) 2022-03-16 14:47:41 -07:00
David Aaron Suddjian
3d66912d89
fix: clean up chart metadata config (#19143)
* fix: clean up chart metadata config

* missed a spot

* missed another spot

* fix failing time-specific test

* can't call translation functions here

* Revert "fix failing time-specific test"

This reverts commit 3eeb8ab9cc.

* skip problematic test

* extra import
2022-03-16 09:59:56 -07:00
Jesse Yang
ae13d8313b
feat(select): keep options order when in single mode (#19085) 2022-03-11 13:01:38 -08:00
Jesse Yang
3a78165d13
refactor(TimezoneSelector): simplify override logics and tests (#19090) 2022-03-10 18:09:20 -08:00
Kamil Gabryjelski
70081a698f
fix(dashboard): Empty states overflowing small chart containers (#19095)
* fix(dashboard): Empty states overflowing small chart containers

* Fix test
2022-03-10 15:54:07 +01:00
smileydev
220c46131e
fix(altered-modal): make specified text fields wrap in table (#18822)
* fix(altered-modal): make all text fields wrap

* fix(altered-modal): limit the wrap text in particular column

* fix(altered-modal): make to update the unit test

* fix(altered-modal): make to fix the type of columnsForWrapText

* fix(alerted-modal): make to fix the type of columnsForWrapTest with string type
2022-03-09 12:43:16 -07:00
Michael S. Molina
79a7a5d1b1
fix: Select clear and loading icons overlap (#19070) 2022-03-09 10:03:30 -03:00
Jesse Yang
c75f233109
feat(select): sort exact and startsWith match to first (#18856) 2022-03-08 07:08:40 -08:00
Michael S. Molina
04a36d5c92
chore: Moves Chart to the components folder (#19029) 2022-03-08 08:57:29 -03:00
Michael S. Molina
71b8d31e77
chore: Moves CRUD components to the Datasource component (#19032)
* chore: Moves CRUD components to the Datasource component

* Fixes imports

* Fixes less import
2022-03-07 09:02:18 -03:00
Michael S. Molina
329855170e
refactor: Deletes the common/components folder (#18999) 2022-03-04 14:19:14 -03:00
Michael S. Molina
06e1e4285e
feat: Adds support to multiple dependencies to the native filters (#18793)
* chore(native-filters): Remove cascading popovers from filter bar

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-03-04 13:06:10 -03:00
Jesse Yang
5a8eb09afb
feat: remove loading indicator when typing in select (#18799) 2022-03-03 09:40:49 -08:00
smileydev
ca93d63bbb
fix(tooltip-not-dissapeared): make the tooltip disappear when mouse away (#18892)
* fix(tooltip-not-dissapeared): make the tooltip disappear when mouse away

* fix(tooltip-not-dissapeared): change css props instead of sytles props
2022-03-01 08:05:11 -07:00
Michael S. Molina
fd4bd1edbc
chore: Moves components out of the commons folder (#18931)
* refactor: Moves components out of the commons folder

* Fixes tests
2022-02-25 10:17:32 -03:00
Kamil Gabryjelski
9d5c0505cf
feat(native-filters): Re-arrange controls in FilterBar (#18784)
* feat(native-filters): Re-arrange controls in FilterBar

* Typo fix

* Add tests

* Fix tests

* Address PR reviews

* Add 1px bottom padding to icon

* Fix test

* Tiny refactor

* Change buttons background

* Add hover state to Clear all button

* Fix Clear All button logic so it clears all selections

* Remove redundant useEffect

* Set zindex higher than loading icon

* Fix scrolling issue
2022-02-22 17:45:53 +01:00
smileydev
3c17c609c9
fix(altered-modal): displayed the metric value in altered modal correctly (#18813)
Co-authored-by: Evan Rusackas <evan@preset.io>
2022-02-20 16:27:46 -08:00
smileydev
91236a5225
fix(sqllab): Removed the tooltip from CopyToClipboard button in sqllab (#18749)
* fix(15849): Removed the tooltip from CopyToClipboard button in sqllab

* chore(sqllab): added props for tooltip in CopyToClipboard component

* fix(sqllab): Added arg to storybook and refactor the component

* fix(sqllab): added a test case for hideTooltip
2022-02-18 16:22:21 -07:00
smileydev
2d67d2f14e
fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal (#18786)
* fix(delete-modal): Changed the color of the help text with grayScale.dark1 in DeleteModal

* Update superset-frontend/src/components/DeleteModal/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>
2022-02-17 11:45:04 -07:00
Corbin Robb
c8df84985c
fix(CRUD/listviews): Errors with rison and search strings using special characters (#18056)
* fix errors with rison and useQueryParams

* add test for encode/decode

* add rison link and make test case more readable

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-15 16:08:36 -06:00
Adam Dobrawy
8b3e27d68b
refactor: migrate QueryAndSaveBtns to TypeScript and add stories (#18121)
* refactor: Migrate QueryAndSaveBtns to TS and stories

* fix: change typing notation in QueryAndSaveBtns
2022-02-15 17:04:48 +02:00
Corbin Robb
5bb406b296
fix(sqllab): fix query results sorting (#18666)
* add sorting for query results grid and add natural order sort

* modify tests for natural/original order state

* clean up setState

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-14 13:42:04 -08:00
Kamil Gabryjelski
f8b3ece27b
feat(dashboard): Implement empty states for dashboard (#18712)
* feat(dashboard): Implement empty states for dashboard

* Add empty state to native filters

* Add missing license

* Remove redundant string types from EmptyState
2022-02-14 15:24:02 +01:00
Kamil Gabryjelski
a7d505db41
feat: Implement EmptyState components (#18676)
* feat: Implement EmptyState components

* Fix title in storybook

* Add licenses

* Add max widths
2022-02-11 17:43:09 +01:00
Meitong Qu
9f678e55b9
chore: migrate QueryTable component from jsx to tsx (#17944)
* chore: fix misspelling of button

* changed QuerySearch/index.jsx to index.tsx

* updated Query type at src/SqlLab/types.ts/Query and extended it into QueryTable

* updated defaultQueryLimit to be optional at ResultSetProps of superset-frontend/src/SqlLab/components/ResultSet/index.tsx

* moved statusAttributes into useMemo hook so that it will not make the dependencies of useMemo Hook change on every render and statusAttributes is only used within useMomo hook

* reset package-lock.json and package.json at frontend

* Acquired redux rootestate type for SqlLab, to be used at useSelector(state)

* updated query to be Query type and added a comment for q.status on line 178

* updated queryTable for typescript conversion

* updated actions type on QueryHistory and QuerySearch

* updated type for actions in SouthPane

* created type for SqlLab redux

Co-authored-by: David Woolner <davidwoolner@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2022-02-11 06:54:42 -06:00
Adam Dobrawy
7c69a1bc60
chore: improve React import reference consistency (#18608) 2022-02-10 21:03:16 -08:00
Emmanuel Bavoux
00eb6b1f57
feat: editable title xl certified badge (#18626)
* Add size to EditableTitle certified badge

* Lint EditableTitle file

Co-authored-by: Emmanuel Bavoux <emmanuel.bavoux@free2move.com>
2022-02-09 17:09:20 -08:00
Ville Brofeldt
8b0634c9ed
fix(listview): add nowrap to view mode container (#18246) 2022-02-04 07:42:10 +02:00
Lyndsi Kay Williams
c40b337978
feat: Added success toasts for database, dataset, chart, dashboard, and query imports (#18190)
* Added imports toasts

* Removed generic import toast

* Remove addSuccessToast from props

* Added addSuccessToast back to prop type

* Made success toast strings translatable
2022-01-28 15:29:44 -06:00
Hugh A. Miles II
e6bb0fc7ad
feat: Add toast for successful table or schema refreshes in Sqllab (#18169)
* save

* add use redux to test

* update test for db selector

* add condition for refresh only
2022-01-26 20:26:50 -05:00
David Aaron Suddjian
4ad5ad045a
feat: embedded dashboard core (#17530)
* feat(dashboard): embedded dashboard UI configuration (#17175) (#17450)

* setup embedded provider

* update ui configuration

* fix test

* feat: Guest token (for embedded dashboard auth) (#17517)

* generate an embed token

* improve existing tests

* add some auth setup, and rename token

* fix the stuff for compatibility with external request loaders

* docs, standard jwt claims, tweaks

* black

* lint

* tests, and safer token decoding

* linting

* type annotation

* prettier

* add feature flag

* quiet pylint

* apparently typing is a problem again

* Make guest role name configurable

* fake being a non-anonymous user

* just one log entry

* customizable algo

* lint

* lint again

* 403 works now!

* get guest token from header instead of cookie

* Revert "403 works now!"

This reverts commit df2f49a6d4.

* fix tests

* Revert "Revert "403 works now!""

This reverts commit 883dff38f1.

* rename method

* correct import

* feat: entry for embedded dashboard (#17529)

* create entry for embedded dashboard in webpack

* add cookies

* lint

* token message handshake

* guestTokenHeaderName

* use setupClient instead of calling configure

* rename the webpack chunk

* simplified handshake

* embedded entrypoint: render a proper app

* make the embedded page accept anonymous connections

* format

* lint

* fix test
# Conflicts:
#	superset-frontend/src/embedded/index.tsx
#	superset/views/core.py

* lint

* Update superset-frontend/src/embedded/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* comment out origins checks

* move embedded for core to dashboard

* pylint

* isort

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* feat: Authorizing guest access to embedded dashboards (#17757)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* add more test

Co-authored-by: Lily Kuang <lily@preset.io>

* feat: Row Level Security rules for guest tokens (#17836)

* helper methods and dashboard access

* guest token dashboard authz

* adjust csrf exempt list

* eums don't work that way

* Remove unnecessary import

* move row level security tests to their own file

* a bit of refactoring

* add guest token security tests

* refactor tests

* clean imports

* variable names can be too long apparently

* missing argument to get_user_roles

* don't redefine builtins

* remove unused imports

* fix test import

* default to global user when getting roles

* missing import

* mock it

* test get_user_roles

* infer g.user for ease of tests

* remove redundant check

* tests for guest user security manager fns

* use algo to get rid of warning messages

* tweaking access checks

* fix guest token security tests

* missing imports

* more tests

* more testing and also some small refactoring

* move validation out of parsing

* fix dashboard access check again

* rls rules for guest tokens

* test guest token rls rules

* more flexible rls rules

* lint

* fix tests

* fix test

* defaults

* fix some tests

* fix some tests

* lint

Co-authored-by: Lily Kuang <lily@preset.io>

* SupersetClient guest token test

* Apply suggestions from code review

Co-authored-by: Lily Kuang <lily@preset.io>

Co-authored-by: Lily Kuang <lily@preset.io>
2022-01-25 16:41:32 -08:00
Lyndsi Kay Williams
2491b89f29
Columns tab name field no longer editable, calculated columns rows now vertically aligned (#18164) 2022-01-25 14:34:56 -06:00
Adam Dobrawy
c3a17a7228
Migrate Checkbox story to tsx - see #18100 (#18101)
Looks good!
2022-01-20 15:33:45 +01:00
Erik Ritter
27000da2f8
fix: SQL Lab sorting of non-numbers (#18006) 2022-01-12 11:09:59 -08:00
AAfghahi
536ca1f62c
chore(DatasourceEditor): Create Datasource Legacy Editor Feature Flag (#18003)
* a lot of console logs

* adding new feature flag for datasource editor
2022-01-12 14:02:53 -05:00
Yongjie Zhao
46715b295c
refactor: remove unused ts-jest (#17996) 2022-01-11 23:43:45 +08:00
Lyndsi Kay Williams
f7add546ad
Fixed error handling in Report modal (#17988) 2022-01-10 17:01:08 -06:00
Lyndsi Kay Williams
df69920a2e
Moved dataset editor lock to top of component (#17930) 2022-01-10 16:55:00 -06:00
Evan Rusackas
c0a769581f
chore: bump typescript to 4.5.4, and adjust storybook story. (#17971)
* chore: bump typescript to 4.5.4, and adjust storybook story to pass linting

* ugh... missed a space. Thanks, linter :)

* nixing erroneous package lock file
2022-01-09 21:01:59 -07:00
Stephen Liu
2ae29c9281
fix(Select): options will be overwritten due to seState (#17951) 2022-01-07 08:09:25 -07:00
Michael S. Molina
aa91662ec8
chore: Moves the Menu to views/components folder (#17897)
* chore: Moves the Menu to views/components folder

* Fixes imports
2022-01-07 09:25:31 -03:00
Michael S. Molina
53d8d383cc
chore: Moves the hooks folder to the src folder (#17896) 2022-01-07 09:25:06 -03:00
Yongjie Zhao
ceecc7047b
chore: remove unused eslintrc (#17860)
* chore: remove unused eslintrc

* remove unused lint

* add comments

* change comments
2022-01-05 19:31:12 +08:00
Beto Dealmeida
2cd8054358
feat: add force option to report screenshots (#17853)
* Update existing tests

* Add backend test

* feat: add force option to report screenshots

* Add tests

* Rebase fixes

* Do not force screenshot on dashboard alerts
2021-12-22 12:16:04 -08:00
Lyndsi Kay Williams
d2ed1b72dc
chore: Help user to find the input fields in the dataset editor (#17824)
* Updated fields in Metrics and Calculated Columns tabs inside dataset editor, deleted label in expanded Metrics tab

* Fix tests

* Vertically aligned rows in columns tab
2021-12-22 12:21:37 -06:00
Stephen Liu
142b5bc506
fix: local warning in the frontend development (#17727) 2021-12-15 09:52:42 +02:00
Beto Dealmeida
63d9693f21
feat: add main datetime column to dataset editor (#17739)
* feat: add main dttm col to dataset editor

* Add tests
2021-12-14 14:47:08 -08:00
Geido
4b969710e4
Rename CertifiedIcon to CertifiedBadge (#17715) 2021-12-10 11:45:53 -07:00
Geido
8de93871d7
Fix flacky header (#17690) 2021-12-10 18:25:40 +02:00
Corbin Robb
f476ba23a2
fix(select): select component sort functionality on certain options (#17638)
* fix: Select component sort function sorting by label instead of value on numbers

* fix: change select component default sorting to sort by the initial index rather than a property like value or label

* fix: select sorting add sortOptions to select components using sortByProperty

* fix: change select component back, add order to options coming in from SelectControl

* fix: select component options intitial sort bug

* fix: add test cases for select fix

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-12-09 11:40:25 -05:00
Ville Brofeldt
c4b04952d0
feat: customize recent activity access (#17589)
* feat: customize recent activity access

* address comments

* fix and add tests

* add alert assertion and UPDATING.md entry

* replace .get_id() with .id

* fix updating comment

* update config name
2021-12-08 11:30:23 +02:00
Lyndsi Kay Williams
05752e3fe8
fix(sqllab): Floating numbers not sorting correctly in result column (#17573)
* Floating nums now sorting correctly with parseFloatingNums function

* Floating numbers AND strings now sorting correctly, +locale comparison

* Added NULL handling back to sort function

* Moved parseFloatingNums outside of sortResults

* Removed localeCompare and added testing

* Add equality check back to sort function

* Added floatValue nit
2021-12-03 16:31:46 -08:00
Hugh A. Miles II
d9e9c3a3de
refactor: Add AutoSizer to react-virtualized Grid (#17606)
* remove styles from renderCell

* remove styling on grid
2021-12-02 12:47:47 -05:00
Phillip Kelley-Dotson
4e76637252
initial fix (#17547) 2021-11-30 08:24:18 -08:00
Holger Bruch
6604a6ab28
chore(translations): Add missing i18n (#17525)
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
2021-11-27 14:50:33 +02:00
Geido
83e49fc9ee
feat: Certify Charts and Dashboards (#17335)
* Certify charts

* Format

* Certify dashboards

* Format

* Refactor card certification

* Clear details when certified by empty

* Show certification in detail page

* Add RTL tests

* Test charts api

* Enhance integration tests

* Lint

* Fix dashboards count

* Format

* Handle empty value

* Handle empty slice

* Downgrade migration

* Indent

* Use alter

* Fix revision

* Fix revision
2021-11-24 13:42:52 +02:00
Corbin Robb
c216565190
Remove loading span, add empty-loading-bar css class, change empty loading rows length to 12, remove width logic on empty loading columns (#17515)
Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-11-23 15:13:53 -08:00
Ville Brofeldt
18c7aec985
chore: remove deprecated selects and deps (#17522) 2021-11-23 12:41:16 +02:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Lyndsi Kay Williams
eb029ab068
fix(sql lab): NULL styling in grid cell (#17385)
* Fix NULL styling in gridCell

* removed unnecessary imports

* Added null styling back to renderGridCell

* Cleaned up a little code as per Elizabeth

* Found another little cleanup spot
2021-11-15 10:49:35 -08:00
Yongjie Zhao
33a8e87513
fix: failed timezone selector UT (#17370) 2021-11-08 23:52:22 +08:00
Michael S. Molina
ed4a628861
fix: Database selector overflow (#17369)
* fix: Database selector overflow

* Fix TImezoneSelector test

* Removes unused imports
2021-11-08 11:25:16 -03:00
Beto Dealmeida
43f4ab845a
fix: clear 'delete' confirmation (#17345)
* fix: clear 'delete' confirmation

* Add tests
2021-11-04 16:26:38 -07:00
AAfghahi
5948a9fd02
fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
2021-10-29 15:30:20 -07:00
Hugh A. Miles II
d0bad96b1a
fix: Allow users to update database in Dataset Edit Modal (#17265)
* add condition to fix save

* remove console.log
2021-10-29 14:19:37 -07:00
Phillip Kelley-Dotson
93f59e055e
chore: remove supersetTheme with withTheme (#17069)
* remove supersettheme

* migrate Datasourceeditor to rtl

* lint fix

* remove file

* fix import

* fix test

* fix lint

* spread tests and remove unused code

* fix lint
2021-10-27 12:42:56 -07:00
Michael S. Molina
dd71035e58
chore: Removes the ChartIcon component (#17216) 2021-10-26 09:02:31 -03:00
Geido
48fd3c185c
chore: Add docs to the Select component props (#17171)
* Add docs

* Add overall description

* Remove trailing space
2021-10-26 12:50:23 +03:00
Michael S. Molina
4c96ae76e3
chore: Breaks the dataViewCommon folder into TableCollection and Pagination (#17132) 2021-10-25 08:47:24 -03:00
Michael S. Molina
55be249870
fix: Order of Select items when unselecting (#17169)
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
2021-10-25 08:47:01 -03:00
Shiva Raisinghani
ef3afbde82
refactor: Repeated boilerplate code between upload to database forms (#16756)
* abstract boilerplate code into class and rename csv to file

* add db migration

* fix some stuff

* more renaming of csv to file

* rename in translations

* update down revision

* update down revision

* bump chart version

* switch to alter column name approach in db migration

* fix db migration for MySQL

* db migration conflict
2021-10-25 13:53:06 +03:00
Hugh A. Miles II
b5246b29df
feat: Hide nav create with RBAC (#17157)
* recommit

* Update MenuRight.tsx
2021-10-23 03:47:56 -04:00
Hugh A. Miles II
cd9e99402d
feat: Add prettier to pre-commit workflow (#17134)
* save

* fix

* fix pre-commit
2021-10-20 20:53:52 -04:00
Geido
f580f6bcba
fix(Explore): Undefined owners (#17167)
* Reconcile owners data

* Fix on save
2021-10-20 09:45:58 -06:00
Michael S. Molina
e32acd22fd
chore: Moves the datasource components to the components folder (#17130) 2021-10-20 08:13:24 -03:00
Grace Guo
96f4421961
fix: sql lab crash caused by invalid template (#17133) 2021-10-18 11:09:23 -07:00
Elizabeth Thompson
ae4ced8da6
fix: update values for default timezone selector (#17124)
* update values for default timezone selector

* fix casing and comment

* Update TimezoneSelector.test.tsx
2021-10-18 09:39:20 -07:00
Lyndsi Kay Williams
635898a76d
fix(sqllab): Hover tooltip flashes in SQL Lab (#17068)
* Changed SQL Lab result column header-style width to max-content

* Changed .ant-tooltip-open to block and tooltip placement to topLeft

* Moved tooltip style changes to local implementation instead of global
2021-10-14 16:23:22 -07:00
Beto Dealmeida
40e9add641
fix: accept headers on import (#17080)
* fix: accept headers on import

* Add unit test
2021-10-13 10:06:00 -07:00
Erik Ritter
153469dba9
fix: error alert levels again (#17027) 2021-10-11 12:28:36 -07:00
Beto Dealmeida
16a1df75fc
fix: clear modal state after adding dataset (#17044)
* fix: clear modal state after adding dataset

* Fix test

* Small fixes
2021-10-10 16:21:14 -07:00
Michael S. Molina
7c1c89c94b
fix: Loading indicator of table and schema selectors (#17040) 2021-10-08 16:17:43 -03:00
Geido
42efcdf027
chore(Dashboard): Implement dedicated message for missing dataset (#16959)
* Implement dedicated message

* Clean up
2021-10-08 17:01:00 +03:00
Erik Ritter
ea700384b3
fix: error alerts again (#17026) 2021-10-07 15:30:56 -07:00
Erik Ritter
03cdbac8bb
fix: error alerts js crash (#17015) 2021-10-07 13:09:54 -07:00
Michael S. Molina
be211437de
fix: Filtering db names while creating dataset is not working (#17023) 2021-10-07 16:23:51 -03:00
Evan Rusackas
5f73ca85d5
feat(linting): restrict direct use of supersetTheme in favor of ThemeProvider (#17001)
* feat: restrict direct use of supersetTheme

* allowing a couple of safe instances of supersetTheme
2021-10-07 08:26:57 -06:00
Geido
66b0877445
Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Geido
a782a62097
chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609)
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-10-07 14:20:32 +03:00
Evan Rusackas
66fbce9dec
chore: removing use of supersetTheme in favor of ThemeProvider (#17000) 2021-10-07 10:36:57 +03:00
Lyndsi Kay Williams
90cfa7fb22
fix: FilterableTable result div width (#16912)
* FilterableTable result div width is now inherit

* Changed style to css
2021-10-06 13:14:35 -07:00
Elizabeth Thompson
5866d5ebb0
fix: Revert "fix: RBAC hide right menu (#16902)" (#16968)
* Revert "fix: RBAC hide right menu (#16902)"

This reverts commit 87baac7650.

* fix failing test
2021-10-04 19:18:12 -07:00
Michael S. Molina
90f711f45c
chore: Moves spec files to the src folder - iteration 5 (#16927) 2021-10-01 11:24:41 -03:00
Hugh A. Miles II
87baac7650
fix: RBAC hide right menu (#16902)
* add provider to right menu

* add roles code

* bad pull
2021-09-30 14:33:54 -04:00
Michael S. Molina
1a38ec6c43
chore: Adds the drag icon (#16919) 2021-09-30 10:29:12 -03:00
Michael S. Molina
ae26967c4e
fix: Disable lazy loading for the Database selector (#16908)
* fix: Disable lazy loading for the Database selector

* Fixes the tests
2021-09-30 09:29:27 -03:00
Michael S. Molina
05632b9804
chore: Moves the stylesheets folder to the assets folder (#16880)
* chore: Moves the stylesheets folder to the assets folder

* Changes {src} to src
2021-09-30 09:28:38 -03:00
Ville Brofeldt
a3413197de
chore: upgrade to Node 16 (#16809)
* chore: upgrade to Node 16

* add docs

* fix test
2021-09-25 07:26:35 +02:00
AAfghahi
04f7ecad1c
display tooltip when disabled (#16837) 2021-09-24 12:56:33 -07:00
Erik Ritter
c933250dad
chore: Remove immutable.js (#16823) 2021-09-23 22:23:42 -07:00
Lyndsi Kay Williams
63aadd3fe4
test: RTL overhaul - hackathon (#16626)
* CachedLabel_spec fully converted to RTL

* ColumnTypeLabel_spec fully converted to RTL

* MissingChart_spec fully converted to RTL

* RefreshIntervalModal_spec mostly converted to RTL

* HoverMenu_spec mostly converted to RTL

* ResizableContainer_spec fully converted to RTL

* ResizableHandle_spec fully converted to RTL

* AggregateOption_spec fully converted to RTL

* CheckboxControl_spec fully converted to RTL

* ColorPickerControl_spec to RTL

* Finished converting ColorPickerControl_spec to RTL/TS, also converted RefreshIntervalModal_spec to TS

* Added unknown type to ColumnTypeLabelProps

* Fixed ColumnTypeLabel_spec
2021-09-22 11:37:35 -07:00
Beto Dealmeida
4af5ae08f9
fix: encode rison characters when searching (#16768) 2021-09-22 10:06:24 -07:00
Michael S. Molina
99d15b25b0
chore: Moves the images folder to the assets folder (#14429)
* chore: Moves the images folder to the assets folder

* Rebases
2021-09-22 10:28:51 -03:00
Kamil Gabryjelski
486e0d412c
chore: Upgrade Webpack to v5 (#16701)
* Upgrade Webpack to v5

* Remove mapbox hack

* Replace url-loaders and file-loaders with asset modules

* Remove 1 rule

* Change --colors to --color

* Remove invalid option (--no-progress)

* Remove url-loader, bump plugin

* Fix AnnotationLayer formula check

* Remove redundant tests

* Bump cypress packages

* Remove old comment

* Fix tests

* Remove checks for number of scripts in markdown test

* Cosmetic changes

* Add tests

* Fix test

* Fix test

* Fixes test warnings

* disable flaky test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-22 14:24:54 +03:00
Michael S. Molina
9b17e86b44
chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Michael S. Molina
b6d78bf4f2
refactor: Changes the list views to use the new Select component (#16393)
* chore: Change the list views to use the new Select component

* Fix Cypress tests

* Enables search for all controls

* Adjusts controls width

* Removes 'Me' and keeps the logged user on top

* Fixes tests

* Uses the borderless version for the filters

* Fixes the tests

* Reverts the Select theme to the default

* Rebases and fixes js error

* Fixes failing test

* Removes unused withTheme
2021-09-22 07:44:18 -03:00
Michael S. Molina
596e1cdf9b
refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483) 2021-09-22 07:43:46 -03:00
Michael S. Molina
86290cc0e5
chore: Improves the Select component to avoid additional queries when all values have been loaded (#16712)
* chore: Improves the Select component to avoid additional queries when all values have been loaded

* Handles the logic in handlePaginateFetch and removes the use effect
2021-09-15 15:39:58 -03:00
Michael S. Molina
adc3d24c21
fix: Ignore case and special keys when searching (#16706) 2021-09-15 07:33:43 -03:00
Stephen Liu
b0ac5d1625
perf(dashboard): fix filter-box performance bug (#16702) 2021-09-15 08:40:46 +03:00
Geido
fecd4124fa
fix: Select refactoring known issues (#16666)
* Clean up and reorganize effects

* Enhance optionFilterProps

* Render custom label

* Remove prop filtering

* Create options

* Create option from value in single mode

* Change to customLabel

* Show search by default

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Apply minor changes

* Fixes a bug that was failing CI

* Adds more tests to the component

* Apply customLabel in ColorSchemeControl

* Remove customLabel from rendered Option

* Hide No data when allowNewOptions

* Remove unnecessary prop from tests

* Adjust loading height

* Show no data with fetchOnlyOnSearch

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-14 17:39:27 +03:00
cccs-joel
c6ac10716a
feat: show build number value in the About if present in the config (#14955) 2021-09-13 10:59:08 -07:00
Michael S. Molina
e9e6c5de8a
chore: Writes the tests for the new Select component (#16638)
* chore: Writes the tests for the new Select component

* Uses array destructuring
2021-09-09 08:38:33 -03:00
Michael S. Molina
37c2020035
chore: Merges latest Select changes (#16587) 2021-09-07 10:41:55 -03:00
Michael S. Molina
02798a3517
fix: Adds a loading message when needed in the Select component (#16531) 2021-09-02 13:17:47 -03:00
Erik Ritter
8adc31d14c
Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Ville Brofeldt
1c71eda70f
fix(native-filters): handle null values in value filter (#16460)
* fix(native-filters): handle null values in value filter

* lint
2021-08-26 15:26:53 +03:00
Geido
db11c3e6c8
feat: Draggable and Resizable Modal (#16394)
* Implement resizable prop

* Implement resizableConfig

* Implement fluid Syntax Highlighter

* Implement draggable

* Destroy on close

* Implement draggableConfig

* Enhance with footer calculation

* Add new line

* Make whole header draggable trigger
2021-08-25 16:11:16 +03:00
Maxhui
6a2cec51c5
fix(dashboard): undo and redo buttons weird alignment (#16417)
* fix(dashboard-ui): undo and redo buttons weird alignment

* fix(Explore control pane): keyboard nav & focus

* lint: lint frontend

* fix: fix redo and undo button style

* lint: lint line

* lint: lint line

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
2021-08-25 08:52:59 -03:00
Grace Guo
08b8aa277f
fix: setupPlugin in chart list page (#16413)
* fix: setupPlugin in chart list page

* fix the order of setupPlugins call

* Fix jest test on loading geojson

* add jest changes

* fix unit tests

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-08-24 23:10:46 -07:00
AAfghahi
631ad02a76
fix: copy to Clipboard order (#16299)
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
2021-08-24 14:47:09 -07:00
Michael S. Molina
1fc9318594
chore: Changes the AlertReportModal to use the new Select component (#16144)
* chore: Changes the AlertReportModal to use the new Select component

* Gives time to close the select before changing the type
2021-08-24 08:19:27 -03:00
Geido
c14364c616
chore: Enhance Omnibar (#16273)
* Fix style and implement ESC

* Include ESC test case

* Move pagination outside of table

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Enhance

* Handle close

* Localize placeholder

* Fix tests

* Clear input on close

* Destroy modal on close

* Clean up

* Fix tests

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-24 11:52:07 +03:00
Michael S. Molina
c768941f2f
chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Michael S. Molina
0cdc7675b4
chore: Displays the dataset description in a tooltip in the datasets list (#16392) 2021-08-23 15:38:53 -03:00
Lyndsi Kay Williams
518c3c9ae0
test: Functional RTL for email report modal II (#16148)
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-20 10:08:36 -07:00
Geido
c5c28618a5
fix: Blank space in Change dataset modal without warning message (#16324)
* Make scrollTable flex

* Revert unclosable warning
2021-08-19 16:46:25 +02:00
Elizabeth Thompson
efe850b731
adjust initial state (#16329) 2021-08-18 13:18:36 -07:00
Elizabeth Thompson
4960b5ee2b
pass correct report_format (#16306) 2021-08-17 18:31:38 -07:00
Beto Dealmeida
3c0aefb61a
Revert "fix: disable text reports for now (#16257)" (#16296)
This reverts commit ee9a384758.
2021-08-17 14:21:15 -07:00
AAfghahi
f5fbfef618
timezone editor (#16281) 2021-08-17 09:32:17 -07:00
Geido
9876c36f6e
Fix table height (#16275) 2021-08-17 09:58:13 +02:00
Beto Dealmeida
ee9a384758
fix: disable text reports for now (#16257)
* fix: disable text reports for now

* Update tests
2021-08-16 08:16:48 -07:00
Michael S. Molina
0668eaad6a
chore: Improves the flow to create a new chart (#16252)
* chore: Improves the flow to create a new chart

* Adds a comment about selector specificity
2021-08-16 11:56:47 -03:00
Geido
22231addec
Move pagination outside of table (#16232) 2021-08-16 16:43:49 +02:00
Geido
c09f6ed15b
fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168)
* Fix style and implement ESC

* Include ESC test case

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-13 18:44:49 +02:00
Kamil Gabryjelski
a16e290765
fix(explore): conditional formatting value validators (#16230)
* fix(explore): conditional formatting value validators

* Fix typing, make validator more generic

* Remove commented code
2021-08-12 14:31:29 +02:00
Phillip Kelley-Dotson
a30d884cfc
fix: change listivew card layouts to the new homepage card layout (#16171)
* initial commit

* removing CardStylesOverrides (unused)

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-10 20:26:24 -07:00
Elizabeth Thompson
a3102488a1
feat: add chart image info to reports from charts (#16158)
* refetch reports on props update

* add chart types to reports
2021-08-10 15:11:10 -07:00
Geido
5e64d65a8b
Hide Safari default tooltip (#16145) 2021-08-10 14:38:13 -06:00
Elizabeth Thompson
5488a8a948
add config to hide some user menu items (#16156) 2021-08-10 09:03:13 -07:00
AAfghahi
5ce38839e7
feat: better errors for report in charts and dashboard (#16131)
* added google alert

* better errors and report actions
2021-08-09 13:32:52 -07:00
Geido
b07c80a839
Adjust width (#16092) 2021-08-09 17:25:33 +02:00
ʈᵃᵢ
b80f018691
fix: move watermark to about section (#16097) 2021-08-06 05:48:22 -07:00
Michael S. Molina
e59f318ef9
chore: Changes the RefreshIntervalModal component to use the new select component (#16048) 2021-08-06 07:58:53 -03:00
AAfghahi
4359650b7d
fix: Adding report bug (#16065)
* report add fix

* added theme
2021-08-04 11:37:46 -07:00
Michael S. Molina
1917464d2b
fix: Fix the Select unselect for object values (#16062) 2021-08-04 11:52:39 -03:00
Michael S. Molina
76a13dfc9a
fix: Modal is blinking when opening (#16035) 2021-08-02 16:18:54 -03:00
Elizabeth Thompson
e0576786c3
add feature flag to header bar (#16031) 2021-08-02 10:57:29 -07:00
Elizabeth Thompson
5031a67597
feat: Self subscribe reports (#16027)
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
Phillip Kelley-Dotson
5fd798afb7
chore: change dropdown icons from horizontal to vertical (#15958)
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
2021-07-30 17:02:40 -06:00
Phillip Kelley-Dotson
02f9749d18
feat(homepage): add more cards and new layout (#15853)
* testing out

* use %

* test

* more changes for testing

* add styles

* initial test commit

* remove ff

* default to false

* fix bug

* fix lint

* fix test

* ensure thumbnails if ff is true

* add back examples and fix layout

* fixes

* new layout

* add suggestions

* changes descriptions

* add changes

* Update superset-frontend/src/components/ListViewCard/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* add const for req

* Update superset-frontend/src/views/CRUD/utils.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix grid-gap

* fix padding

* fix cards in listviews

* address comments

* removing fractional pixel

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-07-29 11:57:00 -07:00
Elizabeth Thompson
3f6c81b621
add timezone selector to alerts and reports (#15920) 2021-07-28 10:02:00 -07:00
Michael S. Molina
5be0a89625
fix: Charts sort by in edit mode gets cut off (#15896) 2021-07-26 16:38:38 -03:00
Yaozong Liu
fb5dce07b7
chore: implement new mockup to the new viz gallery (2nd iteration) (#15868)
* chore: implement new mockup to the new viz gallery

* fix: update package-lock

* fix: add license

* fix: reduce duplication and fit within the sidebar

* fix: ut
2021-07-26 11:10:39 -07:00
Elizabeth Thompson
b81f120916
add timezone selector component (#15880) 2021-07-26 09:30:35 -07:00
Michael S. Molina
9c81599d21
chore: Adds the tests that need to be coded for the Select component (#15885) 2021-07-25 21:01:48 +02:00
John Bodley
4ba17092fa
fix: Ensure SupersetError.extra is always a dict (#15848)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-07-24 10:19:30 +12:00
Michael S. Molina
e660de6936
chore: Adds lazy loading to the Select component (#15799) 2021-07-22 15:17:31 -03:00
Michael S. Molina
fdb40350bb
chore: Changes the pagination API of the Select component (#15802) 2021-07-22 07:32:04 -03:00
Geido
fefcea7979
fix(Explore): Cell height and spacing for Data panel (#15821)
* Fix height and spacing

* Remove unnecessary padding
2021-07-21 14:30:55 -07:00
Michael S. Molina
ad773ffe79
chore: Improves the Select component UI/UX - iteration 4 (#15480) 2021-07-20 13:29:42 -03:00
stellalc7
9a14aed152
fix: margin right on warning icon to 8px (#15715)
* changed margin right on warning icon to 8px

* fixed to grid units from pixels
2021-07-19 13:53:24 -07:00
Geido
a7cbcde9bf
fix: Edit physical dataset from the Edit Dataset modal (#15770)
* Remove unnecessary onChange

* Remove confliciting onChange

* Revert unnecessary change

* Enhance and fix tests
2021-07-19 14:39:01 -04:00
Geido
625468c56a
Fix style (#15662) 2021-07-15 15:26:00 -07:00
Phillip Kelley-Dotson
5d86b8dde6
refactor: remove old Icon component (#15690)
* remove old Icon component

* remove mock fn's
2021-07-14 14:04:56 -07:00
Phillip Kelley-Dotson
070f0b6cb2
refactor: icon to icons for IconButton and Header component (#15647)
* initial commit

* fix test

* last one

* fix cypress

* remove gridunit for fonsize

* fix cypress

* more data-test removal

* last one

* more data-test
2021-07-14 11:04:21 -07:00
ʈᵃᵢ
de17acd618
feat(menu): expand support for custom branding (#15628) 2021-07-14 10:51:53 -06:00
Phillip Kelley-Dotson
1483e04381
refactor: icon to icons for Querytable, datasource test, and copyclipboard story (#15665)
* initial commit

* fix theme

* Update superset-frontend/src/SqlLab/components/QueryTable/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-13 14:24:59 -07:00
Phillip Kelley-Dotson
8efd94a14f
refactor: icon to icons for navbar (#15643)
* initial commit

* remove code
2021-07-13 08:31:12 -07:00
David Aaron Suddjian
257385e888
feat(explore): Upgraded viz select gallery (#15303)
* add modal layout with description, rework styles

* thirty percent

* test correctly

* avoid any changes in modal height

* typescriptify

* feat(viz): add categories to the viz picker (#15304)

* feat(viz): add categories to the viz picker

* fix test types

* add a catch-all category

* tweak layout

* upgrade superset-ui to get new metadata

* do i look like i know what a jpeg is

* fix tests

* lint

* remove script count test requirement

* fix e2e test

* feat(explore): Viz picker search improvements (#15399)

* upgrade superset-ui, install fuse.js

* add metadata to plugin context

* get search working

* layout improvements

* fix tests

* Update superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* use typography size instead of grid unit

* comments

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* feat(explore): Examples image gallery in the viz type control (#15489)

* feat(explore): add section for example images in viz type control

* fix jpg webpack config

* formatting

* feat(Explore): Viz gallery component tweaks (#15520)

* separate viz gallery from the modal

* use gallery directly in add slice view

* more formatting on the add slice container

* restyle the thumbnail list

* explicit thumbnail width and height

* remove crappy hack

* remove useless line

* comment

* sort categories

* comments

* tweak search behavior

* fix tests

* open gallery to the currently selected viz type

* null safety

* show all plugins when searching empty string

* get the new metadatas

* adjust categories scrolling behavior

* add time series table metadata

* upgrade superset-ui

* attempt fixing tests

* upgrade descriptions

* fix unit test

* attempt fixing e2e again

* max width for viz gallery

* update package lock

* undo unnecessary webpack changes

* don't show search results until something is entered

* force modal to open to selected viz type

* tweaks to search behavior

* gallery layout tweaks

* enshrine pivot table v2 in a place of honor

* feat(viz): Clear viz gallery when navigating between categories (#15577)

* start viz gallery with null selection, clear when switching categories

* fix AddSliceContainer tests

* show a message when there is no viz type selected

* composition > inheritance

* clarify searching code

* comment

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-07-12 10:59:10 -07:00
Phillip Kelley-Dotson
79d3d06c8a
refactor: icon to icons for homepage and card compompents (#15624)
* initial commit

* add listviewcard

* remove plural
2021-07-12 10:23:45 -07:00
Phillip Kelley-Dotson
cd4f97926c
initial commit (#15551) 2021-07-07 10:20:40 -07:00
Geido
314d49c13b
Enhance Select (#15550) 2021-07-06 13:07:33 -03:00
Phillip Kelley-Dotson
07852c3528
refactor: icon to icons for popoversection (#15461) 2021-07-05 16:00:37 +08:00
Phillip Kelley-Dotson
fb322b5bab
refactor: migrate to icons for searchinput icons (#15533)
* initial commit

* fix test

* fix lint
2021-07-05 13:59:56 +08:00
gordern
b20293d1b1
fix: click card view link to 404 page when card rendering(#15526) 2021-07-05 13:55:41 +08:00
Lyndsi Kay Williams
68704a595b
fix: Database connection R6 fixes (#15486)
* split db modal file

* split db modal file

* hook up available databases

* add comment

* split db modal file

* hook up available databases

* use new validation component

* first draft

* use new validation component

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* get tests passing

* Removed logo from test

* split db modal file

* hook up available databases

* use new validation component

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* saving for now

* revisions

* fix package-lock.json

* update styles

* save

* # This is a combination of 6 commits.
# This is the 1st commit message:

feat: validation db modal (#14832)

* split db modal file

* hook up available databases

* use new validation component
# This is the commit message #2:

feat: Icon Button (#14818)

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
# This is the commit message #3:

chore: Improves the native filters UI/UX - iteration 6 (#14932)


# This is the commit message #4:

fix: is_temporal should overwrite is_dttm (#14894)

* fix: is_temporal should overwrite is_dttm

* move up
# This is the commit message #5:

fix: time parser truncate to first day of year/month (#14945)


# This is the commit message #6:

hook up available databases

* fix test for db modal

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* more revisions

* create 1 function for setting the DB

* add function to preferred section

* small refactor and added styling

* used db.backend

* add new footer buttons

* add finsh buttong

* refactor db modal render

* fix comments issue

* added engine to model

* elizabeth revisions

* add header

* add bottom footer to sqlalchemy form

* # This is a combination of 6 commits.
# This is the 1st commit message:

feat: validation db modal (#14832)

* split db modal file

* hook up available databases

* use new validation component
# This is the commit message #2:

feat: Icon Button (#14818)

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
# This is the commit message #3:

chore: Improves the native filters UI/UX - iteration 6 (#14932)


# This is the commit message #4:

fix: is_temporal should overwrite is_dttm (#14894)

* fix: is_temporal should overwrite is_dttm

* move up
# This is the commit message #5:

fix: time parser truncate to first day of year/month (#14945)


# This is the commit message #6:

hook up available databases

* fix test for db modal

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* elizabeth revisions

* add back headers

* add step

* feat: Dynamic Form for edit DB Modal (#14845)

* split db modal file

* split db modal file

* hook up available databases

* add comment

* split db modal file

* hook up available databases

* use new validation component

* first draft

* use new validation component

* get tests passing

* split db modal file

* hook up available databases

* use new validation component

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* revisions

* fix package-lock.json

* # This is a combination of 6 commits.
# This is the 1st commit message:

feat: validation db modal (#14832)

* split db modal file

* hook up available databases

* use new validation component
# This is the commit message #2:

feat: Icon Button (#14818)

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
# This is the commit message #3:

chore: Improves the native filters UI/UX - iteration 6 (#14932)


# This is the commit message #4:

fix: is_temporal should overwrite is_dttm (#14894)

* fix: is_temporal should overwrite is_dttm

* move up
# This is the commit message #5:

fix: time parser truncate to first day of year/month (#14945)


# This is the commit message #6:

hook up available databases

* fix test for db modal

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* more revisions

* used db.backend

* added engine to model

* elizabeth revisions

* elizabeth revisions

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>

* address comments

* oops

* # This is a combination of 6 commits.
# This is the 1st commit message:

feat: validation db modal (#14832)

* split db modal file

* hook up available databases

* use new validation component
# This is the commit message #2:

feat: Icon Button (#14818)

* Creating IconButton

* Changed naming: logo is now icon

* Hard-coded inset values for ellipses

* Removed default SVG

* Fixed test

* Removed logo from test
# This is the commit message #3:

chore: Improves the native filters UI/UX - iteration 6 (#14932)


# This is the commit message #4:

fix: is_temporal should overwrite is_dttm (#14894)

* fix: is_temporal should overwrite is_dttm

* move up
# This is the commit message #5:

fix: time parser truncate to first day of year/month (#14945)


# This is the commit message #6:

hook up available databases

* fix test for db modal

* feat(db-connection-ui): Allow users to pick engine (#14884)

* poc picker for db selection

* working select

* setup is loading for available dbs and step1 view

* fix on close

* update on fetch

* remove unneeded code

* add some styls

* remove merge conflicts

* small fix on blocking creating

* feat(db-connection-ui): Big Query Add Database Form (#14829)

* fix(native-filters): Manage default value of filters by superset (#14785)

* fix:fix get permission function

* feat: manage default value in superset

* fix(native-filters): loop bug by simplify state handling (#14788)

* fix: set table name width to not hide icons when name is too long (#14489)

* fix: set table name width to now hide icons when name is too long

* fix: table style

Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>

* feat(explore): Remove default for time range filter and Metrics (#14661)

* feat(explore): Remove default for time range filter and Metrics

* Merge errors with same messages

* Fix e2e test

* Rename a variable

* Bump packages

* Fix unit tests

* feat: chart gallery search improvement (#14484)

* feat: chart gallery search improvement

* test: adding unit test for VizTypeControl

* fix: lint errors

Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>

* Update schemas.py

* Update bigquery.py

* Fix tests

* big query form is appearing on the screen

* add name to allow for actions to get picked up

* working post for saving db via paste

* working file upload

* switch to textare

* better styles

* add delete buttong

* save formating

* wrap encrypted_extra

* formatting component

* clear out file input before reloading

* remove default driver

* address comments

* fix things off rebase

* small refactore

* more patches

* checkout space file

* fix variable ref

Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Einat Bertenthal <einatbar@users.noreply.github.com>
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* feat: adding SSL Toggle to Create Database Modal (#14976)

* first draft of SSL Toggle

* added payload data

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* changed tooltips based on stephen advice

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>

* feat(database-connection-ui) Allow configuration of Database Images from SupersetText (#15023)

* saving this for now

* fix some styles

* add database images

* fix

* enforce only numbers

* add default iamge

* fix bug

* additional params to the DatabaseConnectionForm (#15071)

* additional params to the DatabaseConnectionForm

* save passing params up to api

* feat: Added Steps and centralized Headers (#15041)

* fix superset_text issue (#15095)

* fix edit issue by returning parameters properly (#15101)

* feat: added alerts (#15103)

* added alerts

* revisions

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>

* fix: fixing api tests for database connections (#15124)

* fixing api tests

* added test for no config method on create

* added config method to validation tests

* fix(db-connection-ui): Additional Query Parameters render (#15150)

* working query params

* move condition out before update or create

* fix type script issues

* feat(db-connection-ui): Move fields from Extra section and split engine and metadata (#15143)

* working edit extra options

* acquired most of json

* recontruct json

* add schema array

* add proper styles

* fix tslint issues

* remove console.log

* this is working

* style: Database connect UI Polish - Step 1 (#15119)

* save avg

* Styled step 1

* Remove Alert

* Finished styling, added ellipsis library to IconButton

* Fixed text margin

Co-authored-by: hughhhh <hughmil3s@gmail.com>

* fix app from merge

* fix tslint issues

* fix all tslint issue on feature branch

* catch errors for dialects with no driver set

* fix dremio issue

* fix dialect issue without driver attr

* Styled step 3 (#15187)

* feat: adding server-side validation and unmasked password on create (#15151)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* validation and password masking

* revisions and validation range

* revisions

* added beto revisions

* added tests for port range

* added config to available

* testing, rtl

* made tests always pass

* feat: add Close/Finish buttons to DBModal on Edit (#15199)

* fix(db-connection-ui): Allow Dynamic Big Query Edits (#15185)

* working big query edits

* fix big stoping users from moving to next step

* fix default

* save defaults

* fix tslint

* remove object

* fix styling

* fix: Connect on DB Connection wasn't working (#15201)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* fixed the connect button

* make available alphabetically sort

* make available alphabetically sort II

* fix selection

* remove console.log

* fix styling

* fix: fix api_test and typeScript error (#15202)

* fix big query issue

* allow for query params

* feat: Added Dynamic form link to SQL Alchemy Form (#15208)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* added dynamic form link

* fix: fix api tests for test_available (#15210)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* fixes api tests

* feat: added Spinner to DB Modal (#15229)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* Made header sticky (#15204)

* fix: make Edit DB modal look similar to create Modal (#15231)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* changed edit

* fix: DB Connection UI R2 Fixes (#15232)

* fix display name refill

* fix order of additional params to always be at the bottom

* remove schema check on validation

* make encryption last

* fix json file upload

* fix additional params issue

* remove comments

* add back validation

* small fixes on bigquery edit

* only wrap encrypted with bigquery

* specific conditions for wrapping big query items

* dix additional params

* fix allow display name in sqlalchemy form

* backend before engine

* fix: do not use Marshmallow validation in partial params validation (#15236)

* fix: do not use Marshmallow validation in partial params validation

* Fix lint

* Update test

* make display name required

* reset validation errors onClose (#15243)

* fix: Edit for all dynamic forms (#15244)

* fix edit for dynamic forms

* fix linting

* fix edit on sqlalchemy forms

* fix big query reference

* remove extra if

* wrap configuration method (#15274)

* add more specific engine elastic search (#15287)

* do a deep copy of obj before POST (#15298)

* feat: add Back button to extra options (#15300)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* first draft

* working

* added back button to create modal

* revisions and testing

* chore: Add tooltips and button to Connect Postgresql DB Modal Form (#15179)

* Added tooltips. Still need to place in the right spot.

* Revert to where I started.

* Added 3 tooltips, 1 Button(need link config). BigQuery not added yet.

* Added tooltip BigOuery modal. `span` above upload btn missing `*`

* Added tooltip to `Host` field. Alignment needs to be fixed.

* Stuck trying to add conditional render of tooltip to LabeledErrorBoundInput

* Clean commit for review

* Dynamic tooltip componet created. Needs alignment of SVG still.

* Fixed typo.

* Added line spacing back in

* Changed required props to optional/Remove comment

* Fixed alignment of tooltips & moved 2tooltips outside of Btn

* Added one more line space back in

* Removed Typo

* Removed another typo

* Flixed linter error

* Created test for tooltip.

* Added expectation for visible tooltipIcon

Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>

* style: Database Modal UI Polish (#15234)

* Corrected polishing tasks from Clubhouse ticket

* More UI polish

* Added more polish

* Moved encryption field and created constant value for viewBox in InfoToolTip

* feat: allow editing (#15308)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* elizabeth fixed the edit issue

* feat: Added error alert for DB connection Modal  (#15242)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* added errorAlert

* added revisions

* current work

* revisions

* fix: validation on edit (#15310)

* fix: Big Query Error messaging (#15334)

* remove validation check

* remove validation check

* fix error messaging

* stop validation on big query

* add condition for skipping specific engines for validation

* if no params

* update styles

* feat: big Query using back button (#15338)

* fix: password errors on validation (#15372)

* filter out password supply for validation

* filter password

* feat: updated Error Alert (#15377)

* Updated styling (#15379)

* fix password error filter

* feat: Arash/password field error (#15388)

* fix: Back Button on Create for DB conncetion (#15389)

* fix: add icons (#15122)

* added alerts

* revisions

* added icon

* spinner

* fixing backButton on Create

* fix doc (#15393)

* style: Database Connection Modal UI Polish R5 (#15412)

* Fixed inconsistent header spacing in step 1

* Touched up tooltips

* Added red *s to BigQuery form

* Centered modal window

* make alerts configurable (#15404)

* fix: Allow users to override database connection docs (#15434)

* allow users to override docs

* fix linting issue

* fix: Error Icon not showing up on  errored input fieds on validation (#15431)

* Fixed now-show error icon

Signed-off-by: andrewbastian <andrew.bastian@gmail.com>

* Changed `%` to `px`

* Fixed lint error

* Changed units to `theme.gridUnit`

* test: RTL testing on DatabaseModal (#15394)

* RTL testing on DatabaseModal

* Continued RTL testing on DatabaseModal

* Code cleanup

* Removed a comment that missed my radar

* test: Add e2e testing (#15376)

* create boilerplate for cypress test

* added 1 more test

* add more test cases

* saving this for development

* lit

* remove name

* update pass

* remove unused test

* fix merge conflicts

* Fixed "connetion" typo (#15458)

* fix: Database connection modal touch up (#15463)

* Removed unnecessary TODO and named the remaining ones

* Added translation functionality

* Fixed typo in Database Modal RTL test

* Update modal.test.ts

* fix: Showing errors for SQLA forms (#15462)

* fix documentation links

* fix sqlalchemy onCreate

* Fixing SQLA error messaging

* fix logic for extra save

* fix this issue

* fix: Update Invalid Port SIP-40 Reference (#15464)

* Fixed jumpy header text

* fix: Edit Modal not saving properly (#15468)

* Aligned info icons on dynamic form

* fix: merge conflict (#15479)

* chore: simplify errors and issue codes (#15437)

* Fix issue number

* Fix test

* Fixed line-height in header, also fixed translation functions in BigQuery

* Updated placeholder text in additional params field

* Fixed padding in edit form

* Corrected placeholder text in BigQuery > Service Account field

* Make linter happy

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Arash <arash.afghahi@gmail.com>
Co-authored-by: hughhhh <hughmil3s@gmail.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Einat Bertenthal <einatbar@users.noreply.github.com>
Co-authored-by: einatnielsen <einat.bertenthal@nielsen.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Andrew Bastian <50464395+andrewbastian@users.noreply.github.com>
Co-authored-by: andrewbastian <andrewbastian@hosaka-deck.lan>
2021-07-02 12:19:26 -05:00
Phillip Kelley-Dotson
ea2a98fcc2
refactor: icon to icons for popovercomponent (#15451)
* initial commit

* fix test

* lint

* align icon

* remove consoles
2021-07-02 08:07:06 -07:00
Hugh A. Miles II
d4480f5c9a
feat: Database Connection UI (#14881) 2021-07-01 14:40:27 -07:00