Commit Graph

752 Commits

Author SHA1 Message Date
Corbin Robb
c8df84985c
fix(CRUD/listviews): Errors with rison and search strings using special characters (#18056)
* fix errors with rison and useQueryParams

* add test for encode/decode

* add rison link and make test case more readable

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2022-02-15 16:08:36 -06:00
Adam Dobrawy
8b3e27d68b
refactor: migrate QueryAndSaveBtns to TypeScript and add stories (#18121)
* refactor: Migrate QueryAndSaveBtns to TS and stories

* fix: change typing notation in QueryAndSaveBtns
2022-02-15 17:04:48 +02:00
Michael S. Molina
48a80950de
feat: Improve state key generation for dashboards and charts (#18576)
* feat: Improve state key generation for dashboards and charts
2022-02-14 17:09:06 -03:00
Kamil Gabryjelski
c1205b5279
feat(explore): Implement metrics and columns popovers empty states (#18681)
* feat(explore): Implement empty states for column and metrics popovers

* Fix test

* Change copy
2022-02-14 15:26:56 +01:00
Kamil Gabryjelski
42d97fb078
feat(explore): Implement data table empty states (#18679)
* feat(explore): Implement explore data table empty states

* Make empty state titles easier to translate
2022-02-14 13:06:31 +01:00
Adam Dobrawy
bd0b9f25e4
refactor: migrate SliderControl to TypeScript & added story (#18120)
* refactor: migrate SliderControl to TypeScript & added story

* fix: Set default onChange in SliderControl
2022-02-10 14:21:48 +01:00
Michael S. Molina
f03b4dbedb
feat: Improves key expiration handling in Explore (#18624)
* feat: Improves key expiration handling in Explore

* Sets use_slice_data equals true

* Shows toast when recovering
2022-02-09 13:20:21 -03:00
Kamil Gabryjelski
830f2e71d3
feat(explore): Allow using time formatter on temporal columns in data table (#18569)
* feat(explore): Allow using time formatter on temporal columns in data table

* Fix data table loading

* Return colnames and coltypes from results request

* Fix types

* Fix tests

* Fix copy button

* Fix df is none

* Fix test

* Address comments

* Move useTimeFormattedColumns out of useTableColumns

* Make reducer more readable
2022-02-09 10:29:11 +01:00
Adam Dobrawy
fa8c81e1b1
chore: upgrade BoundsControl to TS (#18200)
* chore: upgrade BoundsControl to TS,FC, add storybook

* chore: improve React import reference consistency
2022-02-08 14:45:10 +02:00
Yongjie Zhao
aa21a963a6
feat: smart tooltip in datasourcepanel (#18080) 2022-02-07 22:48:23 +08:00
Kamil Gabryjelski
6cad7b1d05
chore(explore): make adhoc columns available without UX BETA ff (#17921)
* chore(explore): make adhoc columns available without UX BETA ff

* Remove redundant imports
2022-02-04 14:01:16 +01:00
Kamil Gabryjelski
70969821de
feat(explore): Keep or reset chart config after datasource change (#18215)
* feat(explore): Keep or reset chart config after datasource change

* Update copy

* Remove useDispatch

* fix test

* Fix bugs

* Remove ts ignore

* Scroll top when datasource changes

* Fix crashing when switching viz type
2022-02-02 21:28:35 +01:00
Adam Dobrawy
341d85589c
refactor: upgrade ControlHeader to TSX & FC and add storybook (#18188)
* refactor: upgrade ControlHeader to TSX & FC and add storybook

* fix: Add story for error in ControlHeader

* apply review comments
2022-01-31 10:03:39 -08:00
Michael S. Molina
4b61c76742
fix: Explore long URL problem (#18181)
* fix: Explore long URL problem

* Fixes lint problems

* Fixes default value

* Removes duplicated test

* Fixes share menu items

* Fixes tests

* Debounces form_data updates

* Rewrites debounce function

* Moves history update outside the functional component

* Mocks lodash function in tests

* Fixes Cypress test

* Fixes Cypress test #2
2022-01-28 17:42:16 -03:00
Yongjie Zhao
ea2d6681dd
chore: move controlPanel into time_table (#18160) 2022-01-28 12:13:12 +08:00
Yongjie Zhao
20b4ae1ef9
fix: null value and empty string in filter (#18171) 2022-01-27 22:58:06 +08:00
Stephen Liu
7bb867407a
fix(textarea-control): ace editor input exception (#18146) 2022-01-25 16:57:12 +01:00
Kamil Gabryjelski
e632193eb0
feat(explore): more toast feedback on user actions in Explore (#18108)
* feat(explore): add toasts feedback when user copies chart url

* Show toast message when updating chart properties

* Change toast type to success when saving chart

* Use success toast from props

* Fix tests

* Use withToasts instead of dispatch

* Use PropertiesModalProps instead of any
2022-01-24 11:42:24 +01:00
Stephen Liu
b083b3421f
fix(explore): fix chart embed code modal glitch (#17843) 2022-01-21 09:11:33 -07:00
Adam Dobrawy
a5e805ef2a
refactor: migrate RowCountLabel to TypeScript & added story (#18105)
* enable superbook for explore component

* migrate RowCountLabel to TypeScript

* add storybook for RowCountLabel
2022-01-20 15:35:09 +01:00
serenajiang
05d9cde203
feat: update time comparison choices (again) (#17968) 2022-01-10 10:08:15 -08:00
Michael S. Molina
647bbf1ea1
chore: Moves spec files to the src folder - iteration 10 (#17902)
* chore: Moves spec files to the src folder - iteration 10

* Fixes test

* Fixes lint problem

* Uses styledMount in test
2022-01-07 15:24:15 -03:00
Michael S. Molina
53d8d383cc
chore: Moves the hooks folder to the src folder (#17896) 2022-01-07 09:25:06 -03:00
Stephen Liu
07998fea68
fix(explore): simple tab content input problem (#17872) 2022-01-03 12:41:19 +08:00
Beto Dealmeida
b7707e8ff7
feat: bypass cache on screenshots for alerts (#17695)
* feat: bypass cache on screenshots for alerts

* Update existing tests

* Add backend test

* Add frontend test
2021-12-22 08:26:38 -08:00
Stephen Liu
d5768ab649
fix(explore): make SORT-Descending visible if Sort-by has value (#17726) 2021-12-21 15:27:21 +08:00
Erik Ritter
6edc183c5f
chore: Refactor localstorage into typesafe version (#17832) 2021-12-20 13:58:59 -08:00
Geido
4b969710e4
Rename CertifiedIcon to CertifiedBadge (#17715) 2021-12-10 11:45:53 -07:00
Kamil Gabryjelski
b5b6ceb1b3
fix(explore): don't apply time range filter to Samples table (#17711) 2021-12-10 11:40:11 -07:00
Stephen Liu
bdc4e7a322
fix(explore): deck.gl Multiple chart broken (#17703) 2021-12-09 20:03:02 +02:00
Corbin Robb
f476ba23a2
fix(select): select component sort functionality on certain options (#17638)
* fix: Select component sort function sorting by label instead of value on numbers

* fix: change select component default sorting to sort by the initial index rather than a property like value or label

* fix: select sorting add sortOptions to select components using sortByProperty

* fix: change select component back, add order to options coming in from SelectControl

* fix: select component options intitial sort bug

* fix: add test cases for select fix

Co-authored-by: Corbin Robb <corbin@Corbins-MacBook-Pro.local>
2021-12-09 11:40:25 -05:00
Geido
46cdc77ae6
fix: Redirect on 401 (#17597)
* Redirect on 401

* Bump FAB

* Format

* Update Cypress save test

* Revert Cypress change

* Bump FAB 3.4.1rc2

* Update test

* Update return statement

* Update api test

* Update datasets api test

* Update datasets api 401s to 403s

* Add typeguard

* Use Promise.resolve

* Update callApiAndParseWithhTimeout test

* Disable parseResponse test

* Try catch

* Handle npm 8 issues
2021-12-08 13:14:30 -07:00
Kamil Gabryjelski
07e8837093
feat(explore): export csv data pivoted for Pivot Table [ID-9] (#17512)
* feat(explore): export csv data pivoted for Pivot Table

* Implement dropdown with download csv options

* Change label to "Original"

* Add tests

* Add form data to query context

* Add form data to query context generator

* Explicitly make form_data optional
2021-12-03 12:42:28 +01:00
Stephen Liu
a3cce5705d
feat(explore): support show annotation label [ID-8] (#17307)
* feat(explore): support always show annotation label

* fix: lint

* fix: lint

* Hopefully appeasing the linter

* fix: lint

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change to allow none

* lint

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-12-02 00:26:32 -07:00
Michael S. Molina
a959e6df45
fix: Visualizations don't load when using keyboard shortcuts (#17542) 2021-11-29 09:14:21 -03:00
Holger Bruch
6604a6ab28
chore(translations): Add missing i18n (#17525)
* Add *.ts to babel.cfg

* Add missing i18n calls

* Update pot file

* Fix lint issues and review comment

* Incorparate review feedback

* Fix missing or non-extractable i18n calls

* Update pot file

* Fix syntax error in CommonParameters.tsx

* Fix introduced issues
2021-11-27 14:50:33 +02:00
Kamil Gabryjelski
7353a2bd75
fix(explore): Metric control breaks when saved metric deleted from dataset (#17503) 2021-11-24 13:06:11 +01:00
Geido
83e49fc9ee
feat: Certify Charts and Dashboards (#17335)
* Certify charts

* Format

* Certify dashboards

* Format

* Refactor card certification

* Clear details when certified by empty

* Show certification in detail page

* Add RTL tests

* Test charts api

* Enhance integration tests

* Lint

* Fix dashboards count

* Format

* Handle empty value

* Handle empty slice

* Downgrade migration

* Indent

* Use alter

* Fix revision

* Fix revision
2021-11-24 13:42:52 +02:00
Evan Rusackas
6d66963489
fix: hiding HiddenControl inputs for real, to reduce bootstrap space consumption (#15182)
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-11-23 15:08:24 -08:00
Yongjie Zhao
9070b6b19c
refactor(monorepo): stage 1 (#17427)
* skip geojson in pre-commit

update prettier

* update package.json

update package.json

u package

pkg

pkg2

* lint main repo 2

lint main repo

lint

* lintrc

lintrc 2

lintrc2

lintrc 3

lintrc

* fix import

* refresh lock file

* fix break line make @ts-ignore invalid

* update rat-excludes

rat-excludes

update rat-excludes

* update eslintrc.js

* lint lint lint
2021-11-17 15:31:36 +08:00
Geido
c2d8b0e72f
chore: Notify user of custom label colors and related Dashboard color scheme (#17422)
* Add alert for custom label colors

* Fix duplicate linear scheme

* Implement dashboard alert

* Remove trailing space

* Update Cypress

* Simplify check
2021-11-16 17:46:39 +02:00
Ville Brofeldt
e2a429b0c8
feat(explore): adhoc column expressions [ID-3] (#17379)
* add support for adhoc columns to api and sqla model

* fix some types

* fix duplicates in column names

* fix more lint

* fix schema and dedup

* clean up some logic

* first pass at fixing viz.py

* Add frontend support for adhoc columns

* Add title edit

* Fix showing custom title

* Use column name as default value in sql editor

* fix: Adds a loading message when needed in the Select component (#16531)

* fix(tests): make parquet select deterministic with order by (#16570)

* bump emotion to help with cache clobbering (#16559)

* fix: Support Jinja template functions in global async queries (#16412)

* Support Jinja template functions in async queries

* Pylint

* Add tests for async tasks

* Remove redundant has_request_context check

* fix: impersonate user label/tooltip (#16573)

* docs: update for small typos (#16568)

* feat: Add Aurora Data API engine spec (#16535)

* feat: Add Aurora Data API engine spec

* Fix lint

* refactor: sql_json view endpoint: encapsulate ctas parameters (#16548)

* refactor sql_json view endpoint: encapsulate ctas parameters

* fix failed tests

* fix failed tests and ci issues

* refactor sql_json view endpoint: separate concern into ad hod method (#16595)

* feat: Experimental cross-filter plugins (#16594)

* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF

* chore(deps): bump superset-ui to 0.18.2 (#16601)

* update type guard references

* fix imports

* update series_columns schema

* Add changes that got lost in rebase

* Use current columns name or expression as sql editor init value

* add integration test and do minor fixes

* Bump superset-ui

* fix linting issue

* bump superset-ui to 0.18.22

* resolve merge conflict

* lint

* fix select filter infinite loop

* bump superset-ui to 0.18.23

* Fix auto setting column popover title

* Enable adhoc columns only if UX_BETA enabled

* put back removed test

* Move popover height and width to constants

* Refactor big ternary expression

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Rob DiCiuccio <rob.diciuccio@gmail.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: joeADSP <75027008+joeADSP@users.noreply.github.com>
Co-authored-by: ofekisr <35701650+ofekisr@users.noreply.github.com>
Co-authored-by: simcha90 <56388545+simcha90@users.noreply.github.com>
2021-11-15 12:50:08 +02:00
Phillip Kelley-Dotson
e6ff25c980
fix(chart): ensure samples data is displayed (#16900)
* initial fix

* use data keys for cols

* add e2e test

* remove code

* trim logic
2021-11-12 14:23:46 -08:00
John Bodley
bcef8fa13b
feature: Add quarter unit to datetrunc (#17416)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-12 09:46:55 -08:00
Geido
7cdd58b2db
Fix missing dashboardId (#17380) 2021-11-11 19:07:00 +02:00
Mayur
8756c9089e
fix(dashboard): don't show report modal for anonymous user (#17106)
* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>
2021-11-11 07:50:12 -03:00
John Bodley
675ffaf8df
revert: Partial revert of 17236 (#17383)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-10 20:32:35 -08:00
Grace Guo
7d22c9ce17
feat(native_filter_migration): add transition mode (#16992)
* feat: [Migrate filter_box to filter component] add transition mode

* rebase and fix comments

* rebase and fix commnent -- patch 2
2021-11-09 09:55:25 -08:00
John Bodley
561d1ac9f2
feat(metrics): Provide override for disabling ad-hoc metrics (#17202)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-08 10:31:43 -08:00
Yongjie Zhao
b58f94ad2e
chore: bump @typescript-eslint/eslint-plugin to 5.3.0 (#17367) 2021-11-08 23:48:51 +08:00
Geido
d0085b1b29
Check validity of control item (#17349) 2021-11-05 12:56:03 +02:00
John Bodley
1c12167d8d
fix: Revert default series sort-by metric and enforce non-xor with series limit (#17236)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-03 13:59:38 -07:00
Geido
59a6502efe
fix: Color consistency (#17089)
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
2021-11-03 19:22:38 +02:00
Daman Arora
28b494c597
chore: migrate HiddenControl component from jsx to tsx (#17315)
* migrate HiddenControl component from jsx to tsx

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* updating the type of value in the interface

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
2021-11-02 11:51:16 -07:00
Geido
5491a4d13c
fix(Explore): Remove changes to the properties on cancel (#17184)
* Remove on close

* Fix lint

* Add tests
2021-11-02 19:27:56 +02:00
Yongjie Zhao
1f2a7a40c4
fix: datatable crash when column is empty string (#17303)
* fix: datatable crash when column is empty string

* typo
2021-11-01 23:58:31 +08:00
AAfghahi
5948a9fd02
fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
2021-10-29 15:30:20 -07:00
Kamil Gabryjelski
fa44325a36
fix(explore): Metrics disappearing after removing metric from dataset (#17201)
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
2021-10-29 16:15:19 +02:00
Yongjie Zhao
faf7c74e44
chore: bump superset-ui v0.18.16 (#17251)
* chore: import ES module from chart-controls

* chore: bump superset-ui v0.18.16
2021-10-27 23:35:48 +08:00
Yongjie Zhao
dbf5225e1f
chore: bump to superset-ui 0.18.15 (#17232)
* bump 0.18.15

* prettier and update lock file
2021-10-26 19:25:34 +08:00
Ben Elgren
3641093a44
allow owners to edit chart title (#17047) 2021-10-26 12:58:07 +03:00
Elizabeth Thompson
08aab3b399
use full results as csv type (#17194) 2021-10-25 09:36:10 -07:00
Michael S. Molina
55be249870
fix: Order of Select items when unselecting (#17169)
* fix: Order of Select items when unselecting

* Adds a property comparator that supports strings and numbers

* Uses a named export for propertyComparator
2021-10-25 08:47:01 -03:00
David Aaron Suddjian
a63a01f158
small changes to dashboard->explore code (#17145) 2021-10-22 10:53:01 -07:00
Kamil Gabryjelski
860e481a97
fix(explore): timestamp format when copy datatable to clipboard (#17166)
* fix(explore): timestamp format when copy datatable to clipboard

* Fix test

* Fix test

* Use translation for aria label

* Memoize stringified cells

* Fix test
2021-10-21 16:05:14 +02:00
Michael S. Molina
e32acd22fd
chore: Moves the datasource components to the components folder (#17130) 2021-10-20 08:13:24 -03:00
David Aaron Suddjian
57f869cf22
fix(explore): remove unnecessary parameters from the explore url (#17123)
* remove unnecessary parameters from the explore url

* refactor, test
2021-10-18 15:30:15 +03:00
simcha90
eebc953dd5
feat: Custom filters control (#17006)
* fix:fix get permission function

* feat: customize filter control

* fix: fix types

* fix: fix merge

* refactor: update according CR

* refactor: fix CR notes
2021-10-15 14:14:04 +03:00
Hugh A. Miles II
959fd763a8
fix: Owners selection in dataset edit UX (#17063)
* boilerplate

* update owner select component

* this is working

* update onchange

* refactorig

* you need to useMemo or things break

* update test

* prettier

* move logic into bootstrap data endpoint

* address concerns

* oops

* oops

* fix test
2021-10-12 20:27:56 -04:00
Geido
14b7f6cdba
fix: Exclude SUPERSET_DEFAULT from the list of available color schemes (#17018)
* Handle SUPERSET_DEFAULT theme

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/ColorSchemeControl.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-11 16:16:06 +03:00
Phillip Kelley-Dotson
2c8e06e929
initial fix (#16998) 2021-10-08 10:56:14 -07:00
Geido
a57ae35011
fix: Verify when null value should be undefined in Select (#17013)
* Check for null value

* Safety chek SelectControl and SelectAsyncControl
2021-10-08 17:32:09 +03:00
Geido
66b0877445
Strict undefined check SelectControl (#17008) 2021-10-07 17:22:52 +03:00
Geido
a782a62097
chore: Select component refactoring - SelectAsyncControl - Iteration 5 (#16609)
* Refactor Select

* Implement onError

* Separate async request

* Lint

* Allow clear

* Improve type

* Reconcile with Select latest changes

* Fix handleOnChange

* Clean up

* Add placeholder

* Accept null values

* Update superset-frontend/src/explore/components/controls/SelectAsyncControl/index.tsx

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* Clean up

* Implement type guard

* Fix lint

* Catch error within loadOptions

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2021-10-07 14:20:32 +03:00
David Aaron Suddjian
1cd0124fd5
chore: upgrade babel (#16885)
* upgrade babel versions

* upgrade babel eslint parser

* fix test
2021-10-05 15:02:57 -07:00
Geido
3f0756f637
chore: Select component refactoring - SelectControl - Iteration 5 (#16510)
* Refactor Select DatasourceEditor

* Fire onChange with allowNewOptions

* Clean up

* Refactor Select in AnnotationLayer

* Handle on clear

* Update tests

* Refactor Select in SpatialControl

* Show search

* Refactor Select in FilterBox

* Remove search where unnecessary

* Update SelectControl - WIP

* Refactor Controls

* Update SelectControl tests

* Clean up

* Test allowNewOptions false

* Use SelectControl AnnotationLayer

* Use SelectControl SpatialControl

* Clean up

* Render custom label

* Show search

* Implement filterOption

* Improve filterOption

* Update Cypress

* Update Cypress table test

* Use value for defaultValue

* Merge with latest changes

* Reconcile with latest Select changes

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Revert changes to test

* Call onPopoverClear when v value is undefined

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-04 18:24:41 +03:00
Yongjie Zhao
6225c9a4a3
fix: replace absolute difference with difference in legacy charts (#16931) 2021-10-02 09:10:20 +08:00
Phillip Kelley-Dotson
3f6a24fe1a
chore: add certified columns to top of list (#16910)
* initial commit

* inital commit

* add suggestions

* remove changes

* Update superset-frontend/src/explore/components/DatasourcePanel/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-10-01 11:50:03 -07:00
Michael S. Molina
90f711f45c
chore: Moves spec files to the src folder - iteration 5 (#16927) 2021-10-01 11:24:41 -03:00
Geido
7f330c9692
Verify undefined operatorId (#16923) 2021-09-30 18:53:48 +03:00
Geido
c8db435730
fix(Explore): Clear filter value when changing columns (#16871)
* Clear filter value onChange

* Clear filter value on user change action
2021-09-30 17:18:08 +03:00
Michael S. Molina
05632b9804
chore: Moves the stylesheets folder to the assets folder (#16880)
* chore: Moves the stylesheets folder to the assets folder

* Changes {src} to src
2021-09-30 09:28:38 -03:00
Geido
667b88c800
chore: Select component refactoring - TimeSeriesColumnControl - Iteration 5 (#16442)
* Refactor Select

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/explore/components/controls/TimeSeriesColumnControl/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix tests

* Mock debounce

* Add debounce

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-09-27 18:19:03 +03:00
Geido
271ec6ec75
chore: Select component refactoring - SaveModal - Iteration 5 (#16446)
* Refactor Select

* Fix Cypress

* Reconcile with master

* Use onChange over onSelect

* Reconcile with latest changes

* Update Cypress

* Update Cypress test

* Fix lint
2021-09-27 18:14:58 +03:00
Geido
ab9f8cb2ea
chore: Select component refactoring - PropertiesModal - Iteration 5 (#16445)
* Refactor Select

* Update tests and checks

* Clean up props

* Update ariaLabel

* Reconcile with master changes

* Apply enhancements

* Fix lint
2021-09-27 18:12:59 +03:00
Geido
e40ff3ada6
chore: Select component refactoring - DndColumnSelectControl - Iteration 5 (#16440)
* Refactor Select

* Update ariaLabel

* Reconcile with latest Select changes

* Fix lint

* Enhance labels
2021-09-27 17:27:14 +03:00
Geido
913df18075
chore: Select component refactoring - MetricControl - Iteration 5 (#16423)
* Refactor Select

* Render saved metric option

* Update tests

* Fix Cypress and ariaLabels

* Fix lint

* Lint Cypress

* Reconcile with latest Select changes
2021-09-27 17:25:51 +03:00
Geido
8ad03c4f25
chore: Select component refactoring - FilterControl - Iteration 5 (#15777)
* Refactor Select for AdhocFilterEditPopoverSqlTabContent

* Refactor Selects

* Fix numeric options

* Clean up

* Fix Select value

* Add showSearch

* Display null label

* Implement StyledSelect

* Update superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSqlTabContent/index.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Fix aria-label

* Revert MetricControls changes

* Update ariaLabel

* Reconcile with latest Select changes

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-09-27 17:23:52 +03:00
Ville Brofeldt
f703c12ae8
chore: bump superset-ui to 0.18.8 (#16850) 2021-09-27 11:54:05 +03:00
Stephen Liu
100760c464
fix(gallery): Hide the bottom info section when no chart is being selected (#16840) 2021-09-27 15:21:25 +08:00
Ville Brofeldt
4086bedb68
chore: bump superset to 0.18.6 (#16807) 2021-09-23 14:03:03 +03:00
Phillip Kelley-Dotson
a198dbb19b
feat: add certifiedby & certification details fields to the edit dataset columns fields (#16454)
* add migration

* add backend and frontend for certified

* update migration with batch

* fix integration test and update Updating.md

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* Update superset-frontend/src/datasource/DatasourceEditor.jsx

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* change method name

* add tooltip info

* add mixin

* merge heads

* address comments

* fix select label styles

* add extra field

* fix test?

* add extra field to put schema

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
2021-09-22 15:09:30 -07:00
Kamil Gabryjelski
486e0d412c
chore: Upgrade Webpack to v5 (#16701)
* Upgrade Webpack to v5

* Remove mapbox hack

* Replace url-loaders and file-loaders with asset modules

* Remove 1 rule

* Change --colors to --color

* Remove invalid option (--no-progress)

* Remove url-loader, bump plugin

* Fix AnnotationLayer formula check

* Remove redundant tests

* Bump cypress packages

* Remove old comment

* Fix tests

* Remove checks for number of scripts in markdown test

* Cosmetic changes

* Add tests

* Fix test

* Fix test

* Fixes test warnings

* disable flaky test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-22 14:24:54 +03:00
Michael S. Molina
9b17e86b44
chore: Moves messageToasts to the components folder (#14431)
* chore: Moves messageToasts to the components folder

* Rebases
2021-09-22 07:44:54 -03:00
Michael S. Molina
596e1cdf9b
refactor: Changes the DatabaseSelector and TableSelector to use the new Select component (#16483) 2021-09-22 07:43:46 -03:00
Ville Brofeldt
1d890f8913
fix(explore): make clicked dnd filters unique (#16700) 2021-09-14 18:01:21 +03:00
Geido
fecd4124fa
fix: Select refactoring known issues (#16666)
* Clean up and reorganize effects

* Enhance optionFilterProps

* Render custom label

* Remove prop filtering

* Create options

* Create option from value in single mode

* Change to customLabel

* Show search by default

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Apply minor changes

* Fixes a bug that was failing CI

* Adds more tests to the component

* Apply customLabel in ColorSchemeControl

* Remove customLabel from rendered Option

* Hide No data when allowNewOptions

* Remove unnecessary prop from tests

* Adjust loading height

* Show no data with fetchOnlyOnSearch

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-14 17:39:27 +03:00
Ville Brofeldt
c99cacbdd2
fix(explore): only refresh data panel on relevant changes (#16699)
* fix(explore): only refresh data panel on relevant changes

* add comment and supress warning
2021-09-14 15:58:05 +03:00
Ville Brofeldt
9dfa33fedf
fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Yongjie Zhao
80c39daa85
fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Phillip Kelley-Dotson
a616b8785e
make chart rerender on timeseries change (#16411) 2021-08-30 16:43:14 -07:00
Erik Ritter
8adc31d14c
Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Jesse Yang
a413f796a6
fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
Yongjie Zhao
577ede4b12
fix: prevent page crash when chart can't render (#16464) 2021-08-26 22:26:01 +08:00
Jesse Yang
ec087507e5
refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Ville Brofeldt
18be181946
fix(explore): update overwrite button on perm change (#16437)
* fix(explore): update overwrite on perm change

* remove redundant user_id prop

* fix types

* fix user type

* fix tests

* fix lint
2021-08-26 06:24:33 +03:00
Geido
db11c3e6c8
feat: Draggable and Resizable Modal (#16394)
* Implement resizable prop

* Implement resizableConfig

* Implement fluid Syntax Highlighter

* Implement draggable

* Destroy on close

* Implement draggableConfig

* Enhance with footer calculation

* Add new line

* Make whole header draggable trigger
2021-08-25 16:11:16 +03:00
Grace Guo
08b8aa277f
fix: setupPlugin in chart list page (#16413)
* fix: setupPlugin in chart list page

* fix the order of setupPlugins call

* Fix jest test on loading geojson

* add jest changes

* fix unit tests

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-08-24 23:10:46 -07:00
AAfghahi
631ad02a76
fix: copy to Clipboard order (#16299)
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
2021-08-24 14:47:09 -07:00
Evan Rusackas
81241b6024
Revert "fix(explore): let admin overwrite slice (#16290)" (#16408)
This reverts commit d13b081cfe.
2021-08-24 09:38:41 -06:00
Michael S. Molina
c768941f2f
chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Phillip Kelley-Dotson
3faf653e5f
initial commit (#16366) 2021-08-20 17:46:55 -06:00
Kamil Gabryjelski
a547dcb73e
fix(explore): reordering columns with dnd sometimes glitching (#16322)
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
2021-08-18 18:39:05 +02:00
Kamil Gabryjelski
2c595b09ea
chore(explore): make metric/column search input clearable (#16320)
* chore(explore): make metric/column search input clearable

* Fix typo

* Fix test
2021-08-18 12:23:23 +02:00
Beto Dealmeida
7a284bb9e8
fix: allow reports to update query_context (#16303) 2021-08-17 16:39:27 -07:00
Kamil Gabryjelski
203c311ca3
feat(explore): make dnd controls clickable (#16119)
* Make ghost buttons clickable

* Popover for column control

* Make column dnd ghost button clickable

* Prefill operator only if column is defined

* Remove data-tests

* lint fix

* Hide new features behind a feature flag

* Change ghost button texts

* Remove caret for non clickable columns
2021-08-17 14:56:39 +02:00
Ville Brofeldt
d13b081cfe
fix(explore): let admin overwrite slice (#16290) 2021-08-17 10:55:33 +03:00
Ville Brofeldt
2be84e78d2
chore(explore): remove unnecessary favstar redirect (#16288) 2021-08-17 09:09:38 +03:00
Elizabeth Thompson
3709131089
check roles before fetching reports (#16260) 2021-08-13 20:41:03 -07:00
AAfghahi
9d0dc561fc
Revert "feat: Changing Dataset names (#16199)" (#16235)
This reverts commit adb3ebbba3.
2021-08-12 13:59:44 -07:00
Geido
a1e18ed110
fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060)
* Implement dynamic tooltip

* Normalize and consolidate

* Clean up

* Refactor and clean up

* Remove unnecessary var

* Fix type import

* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove unnecessary styled span

* Show full tooltip title

* Force show tooltip

* Force show tooltip D&D off

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-08-12 11:48:16 -06:00
Geido
2c5731aea3
Show/hide tooltips (#16192) 2021-08-12 11:42:48 -06:00
Kamil Gabryjelski
a16e290765
fix(explore): conditional formatting value validators (#16230)
* fix(explore): conditional formatting value validators

* Fix typing, make validator more generic

* Remove commented code
2021-08-12 14:31:29 +02:00
Kamil Gabryjelski
ccfc95fbe6
fix(explore): adhoc metrics popover resets label after hovering outside (#16196)
* fix(explore): adhoc metrics popover resets label after hovering outside

* Remove irrelevant tests and skip rest

* Use ensureIsArray
2021-08-11 10:05:08 -06:00
AAfghahi
6c304b83a9
feat: Changing Dataset names (#16199)
* added google alert

* changing Dataset Names
2021-08-11 08:59:59 -07:00
Kamil Gabryjelski
98fc29cbbb
fix(explore): metric label disappearing in some scenarios (#16190) 2021-08-11 14:05:44 +02:00
Junlin Chen
9841c78967
chore: switch back tag name to popular from highly-used (#16174)
* chore: switch back tag name to popular from highly-used

* new package lock

* new package lock with npm 7

* fix lint

* remove package changes

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 20:23:14 -07:00
Elizabeth Thompson
a3102488a1
feat: add chart image info to reports from charts (#16158)
* refetch reports on props update

* add chart types to reports
2021-08-10 15:11:10 -07:00
Beto Dealmeida
7b3fce7e81
fix: revert data endpoint name (#16162) 2021-08-10 11:59:27 -07:00
Phillip Kelley-Dotson
f0e3b68cc2
fix: ensure that users viewing chart does not automatically save edit data (#16077)
* add last_change_at migration

* add last_saved_by db migration

* finish rest of api migration

* run precommit

* fix name

* run precommitt

* remove unused mods

* merge migrations

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/migrations/versions/f6196627326f_update_chart_permissions.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* fix test

* precommit

* remove print

* fix test

* change test

* test commit

* test 2

* test 3

* third time the charm

* fix put req

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 10:29:49 -06:00
Kamil Gabryjelski
6e1d16d956
feat(explore): each control can define its own canDrop for dnd (#16090)
* feat(explore): each control can define its own canDrop for dnd

* Make canDropValue optional

* Add onDropValue
2021-08-10 17:04:42 +02:00
Michael S. Molina
273ab3d257
fix: Safari is not showing scroll bars in Explore (#16089) 2021-08-10 10:41:52 -03:00
AAfghahi
606a7bf429
fix: change Alert Permissions (#16118)
* added google alert

* reworked permissions
2021-08-09 13:33:04 -07:00
Kamil Gabryjelski
b7cc89c6d4
fix(explore): dnd error when dragging metric if multi: false (#16088)
* fix(explore): dnd error when dragging metric if multi: false

* Fix error for non-dnd controls
2021-08-09 18:15:50 +02:00
Kamil Gabryjelski
6ac4f4ef2f
chore(explore): change dnd placeholders (#16116)
* chore(explore): change dnd placeholders

* Fix tests and lint
2021-08-09 17:50:11 +02:00
Kamil Gabryjelski
772da8de63
fix(explore): revert dnd column dependency array change to fix infinite rerenders (#16115)
* fix(explore): revert dnd column dependency array change to fix infinite rerenders

* Remove console.log

* Remove comment
2021-08-06 17:59:22 +02:00
David Aaron Suddjian
e6292a89bb
fix(explore): drag & drop column select component triggering onChange unnecessarily (#16073)
* fix(explore): avoid sync until after first render

* fix example
2021-08-05 15:38:28 -07:00
AAfghahi
e6274e0764
change button color (#16093) 2021-08-05 10:38:30 -07:00
Kamil Gabryjelski
a59d458e41
chore(explore): Create new entrypoints for Echarts Timeseries (#15942)
* feat(explore): Create new entrypoints for Echarts Timeseries

* Change order of some charts

* bump superset-ui

* also bump echarts package

* fix UT

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-08-05 07:28:16 +02:00
Ville Brofeldt
7ef97a54e2
feat(explore): add automatic conditional formatter to pivot table v2 (#16045) 2021-08-04 22:12:20 +03:00
Kamil Gabryjelski
5917407b9c
fix(explore): filter popover opening after removing a filter (#16024) 2021-08-02 22:01:17 +02:00
Geido
39913d286a
Implement sectionId (#16022) 2021-08-02 12:12:36 -07:00
Elizabeth Thompson
e0576786c3
add feature flag to header bar (#16031) 2021-08-02 10:57:29 -07:00
Elizabeth Thompson
5031a67597
feat: Self subscribe reports (#16027)
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
Kamil Gabryjelski
3061b6ad09
fix(explore): fix undefined error when using dnd (#16020) 2021-08-02 15:22:32 +02:00
David Aaron Suddjian
46188c1011
fix(explore): calculate query staleness correctly (#15994) 2021-07-31 19:46:34 -06:00
Phillip Kelley-Dotson
5fd798afb7
chore: change dropdown icons from horizontal to vertical (#15958)
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
2021-07-30 17:02:40 -06:00
Geido
c2e4290392
fix(dashboard): Add required message in the tooltip for the time range filter (#15941)
* Add required msg in tooltip

* Fix lint

* Keep red border on hover
2021-07-30 09:44:33 +02:00
Yongjie Zhao
11b0249803
fix: remove unused time column when update dataset (#14969)
* fix: remove unused time column when update dataset

* fix lint

* set dttm to first datatime column
2021-07-28 21:40:16 +08:00
David Aaron Suddjian
a3f54a6c7b
chore: small viz gallery tweaks (#15900)
* allow passing styles to selector component

* make onClear optional

* remove broken font-size declarations

* fix bad hook dependency

* move all charts selector outside of Collapse

* stop hiding all charts button

* slight copy change

* remove x

* min left pane size

* remove default p bottom margin

* remove unused import

* fix test
2021-07-27 18:21:19 -07:00