Commit Graph

110 Commits

Author SHA1 Message Date
Yongjie Zhao
f41d0b0cbf
fix: drilling on the categorical xaxis on the stacked barchart v2 (#21844) 2022-10-18 19:47:53 +08:00
Stephen Liu
7a7181a244
feat(color): color consistency enhancements (#21507) 2022-10-17 17:01:20 +08:00
Yongjie Zhao
8f61e3c5d9
refactor: preparation for time section migration (#21766) 2022-10-12 08:38:30 +08:00
Kamil Gabryjelski
406e44bba1
perf(dashboard): Virtualization POC (#21438) 2022-10-11 15:06:00 +02:00
Michael S. Molina
1cbf066415
feat: Adds the CROSS_REFERENCE feature flag (#21708) 2022-10-06 08:53:51 -03:00
Victor Arbues
ebd75366c0
feat(chart): add feature flag that displays the data pane closes by default (#21649) 2022-10-05 15:34:03 +08:00
Evan Rusackas
4245bc3f38
chore(style): Enforce optional chaining (#21614) 2022-10-03 09:17:20 -06:00
Yongjie Zhao
93f08e778b
feat: explicit distribute columns on BoxPlot and apply time grain (#21593) 2022-09-28 15:32:35 +08:00
Yongjie Zhao
4d12e3709e
feat: generate consistent QueryObject whether GenericAxis is enabled or disabled (#21519) 2022-09-21 09:41:21 +08:00
Yongjie Zhao
2d16100dbc
refactor: get Axis from a helper function (#21449) 2022-09-16 15:57:45 +08:00
Yongjie Zhao
ce3d38d2e7
feat: apply Time Grain to X-Axis column (#21163) 2022-09-07 16:24:15 +08:00
Cody Leff
742dbdd0a5
fix: Fix console errors about feature flags when running tests (#21275) 2022-09-01 12:42:07 -03:00
Michael S. Molina
1143e17742
fix: Typing of labelMap (#21181)
* fix: Typing of labelMap

* Adjusts val types
2022-08-26 08:22:57 -03:00
Cody Leff
5811262cf2
Add warnings if feature flags are read before initialization. (#21201) 2022-08-25 16:53:18 -06:00
Cody Leff
52648ecd7f
feat(dashboard): Add Drill to Detail modal w/ chart menu + right-click support (#20728)
* Add drill-to-detail modal.

* Include additional filters from dashboard context in request.

* Set page cache size to be approximately equal to memory usage of Samples pane.

* Update getDatasourceSamples signature.

* One-line import/export.

* Fix incorrect argument order in getDatasourceSamples invocation.

* Fix height of modal.

* Disable option in chart menu unless feature flag is set.

* Open modal on right-click.

* Fix double requests on modal open, controls disappearing on filter update.

* Show formattedVal in clearable filter tag.

* Set force=false for all requests.

* Rearrange/refactor DrillDetailPane.

* Reset page index on reload.

* Fix endless re-requests on request failure.

* Fix modal layout issues.
2022-08-22 15:57:18 -07:00
Michael S. Molina
0bf4e56dc3
fix: Drill to detail on values with comma (#21151) 2022-08-22 13:52:39 -03:00
Antonio Rivero Martinez
bdcc0a9bcf
fix(charts): Hide Values greater than Max Y Axis Bound on Mixed Time Series with Bar series (#21015)
* Mixed TimeSeries:

- When Bar chart is used as serie type, we need to hide values that are greater than the max Y Axis Bound.

* Mixed Time Series:

- Simplify logic for getOverMaxHiddenFormatter

* Mixed Time Series:

- Add tests for new getOverMaxHiddenFormatter util func
2022-08-22 08:55:09 -06:00
Kamil Gabryjelski
55304b02cd
fix(explore): Filters with custom SQL disappearing (#21114)
* fix(explore): Filters with custom SQL disappearing

* Fix adhoc filter for query b disappearing

* Improve test coverage
2022-08-17 22:15:41 +02:00
Moriah Kreeger
83dd85166f
feat: add extension point for workspace home page (#21033)
* updates to allow insertion of workspace home sidescroll/table UI

* fix types

* fix User type import

* add welcome message to ui registry

* add extra fields to individual chart/query GET results (for workspace home required info)

* update list view card to support a subtitle

* add id to individual chart fetch

* update chart api test

* another test fix

* fix saved query test

* update extension types + insert point

* fix typing

* fix type name
2022-08-15 12:16:40 -07:00
Jack Fragassi
394d62ee51
Add embedded docs config details to extensions registry (#21052) 2022-08-12 16:33:21 -07:00
Eric Briscoe
ab6ec89f68
fix: [sc-54864] Adds safety check to provide near term fix to save query (#21034)
* [sc-54864] Adds safety check to provide near term fix for Queries not saving

There is an error when casting the columns array to String() for saving queries where the objects in the array are missing the toString method.   This is a near term rapid patch to fix workflow in production which will have a follow up to identify root cause.

* fix typo

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Adjusted chekc to be explicit for undefined instead of truthy

This fixes issue caught by unit test where the if statement was using a truthy check where it should be explicitly checking for value of undefined

* Adds new unit test to get 100% coverage for callApi

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-08-10 10:33:47 -07:00
Michael S. Molina
3df8335f87
feat: Adds drill to detail context menu for ECharts visualizations (#20891)
* feat: Adds drill to detail context menu for ECharts visualizations

* Rebases and adds time grain

* Fixes selected gauge values

* Fixes Treemap edge click

* Adds right click to big number trendline

* Address some comments
2022-08-09 17:02:31 -03:00
Elizabeth Thompson
463406ff09
fix: save dataset and repopulate state (#20965)
* save dataset and repopulate state

* disable dashboard button if dataset is missing

* fix error message

* fix tests
2022-08-05 14:32:49 -07:00
Sam Faber-Manning
226712d831
feat: add 'dashboard.nav.right' extension to registry (#20835)
* add 'dashboard.nav.right' extension to registry

* add test
2022-08-04 15:24:34 -07:00
Geido
a69f016bca
chore: Feature flag for embedding charts (#20804)
* Add EMBEDDABLE_CHARTS feature flag

* Pretty

* Update test
2022-07-26 17:55:44 +03:00
Yongjie Zhao
55a89dfac9
feat: a simple LRUCache in frontend (#20842) 2022-07-26 15:02:10 +08:00
Geido
6b0c3032b2
chore: Update color scheme when deleted or changed (#20589)
* feat(explore): Use v1/explore endpoint data instead of bootstrapData

* Add tests

* Fix ci

* Remove redundant dependency

* Use form_data_key in cypress tests

* Add auth headers to for data request

* Address comments

* Remove displaying danger toast

* Conditionally add auth headers

* Address comments

* Fix typing bug

* fix

* Fix opening dataset

* Fix sqllab chart create

* Run queries in parallel

* Fallback to default color scheme

* Fix dashboard id autofill

* Fix lint

* Fix test

* Fix hydrate action

* Update dashboard colors

* Add color scheme domain

* Add check for default scheme

* Make me pretty

* Clean up

* Nit

* Clean up

* Pretty

* Fix missing sequential

* Lint

* Enhance test

* Lint

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-07-25 18:50:49 -04:00
Kamil Gabryjelski
0945d4a2f4
feat: Pass dashboard context to explore through local storage (#20743)
* feat: Pass dashboard context to explore through local storage

* Remove console log

* Remove unused local storage keys

* Fix lint

* Fix link

* Fix UT

* fix lint

* fix prettier

* Fix bug

* Fix bug with some sample dashboards

* Roll back unnecessary change

* style fix

* Add comments

* Fix lint

* Address code review comments

* Fix
2022-07-25 16:44:43 +02:00
Diego Medina
279ab954b1
fix: chart empty state & result panel when multiple queries are executed display incorrectly (#20816) 2022-07-22 14:58:42 +08:00
Kamil Gabryjelski
af1bddffad
fix(explore): Adhoc columns don't display correctly (#20802)
* fix(explore): Adhoc columns have empty labels

* Add unit test

* Address comments
2022-07-21 21:11:49 +02:00
Yongjie Zhao
9c7bcfcead
fix: core coverage and add a coverage step in workflow (#20784)
* fix: core coverage

* add step in workflow
2022-07-20 08:56:03 -03:00
Hugh A. Miles II
e5e8867394
feat: Visualize SqlLab.Query model data in Explore 📈 (#20281) 2022-07-15 19:34:02 -04:00
Kamil Gabryjelski
5317462b49
Revert "feat: Reuse Dashboard redux data in Explore (#20668)" (#20689)
This reverts commit ff5b4bc0e4.
2022-07-12 16:48:08 -03:00
Kamil Gabryjelski
ff5b4bc0e4
feat: Reuse Dashboard redux data in Explore (#20668) 2022-07-12 19:17:25 +02:00
Yongjie Zhao
8d4994a899
fix: superset-ui/core code coverage (#20676) 2022-07-12 13:34:27 +08:00
Yongjie Zhao
7f918a4ec0
fix: annotation broken (#20651)
* fix: annotation broken

* fix UT

* add annotation data to mixed timeseries chart
2022-07-11 16:23:57 -06:00
Jack Fragassi
dfab521f50
fix(embedded): Ensure guest token is passed to log endpoint (#20647)
* Pass guest token to sendBeacon

* Add tests
2022-07-08 15:17:01 -07:00
AAfghahi
0ce0c6e1eb
chore: removing Druid from front- and back- end (#20338)
* first pass at removing native Druid nosql

* removing having_druid

* addressing comments, linting

* fixed all tests

* addressing comments

* redirected to ui-core TimeGranularity type

* query form metric linting

* fixed broken chart type

* implementing feedback
2022-07-08 17:57:03 +02:00
Kamil Gabryjelski
de4f7db57e
feat(dashboard): Transition to Explore with React Router (#20606)
* feat(dashboard): Use react-router for transition to Explore + cmd click to open in new tab

* Update tooltip

* Add a feature flag

* Update edit chart onclick event

* Fix lint

* Fix tests

* Change feature flag name

* Add tooltip to Edit chart
2022-07-07 11:52:03 +02:00
David Aaron Suddjian
db088e9e2f
chore: rename "uiOverrideRegistry" -> "extensionsRegistry" (#20628)
* uiOverrideRegistry -> extensionsRegistry

* better comments

* missed a spot

* missed another spot

* url
2022-07-06 11:35:19 -07:00
Lily Kuang
2389871556
feat: add extension point to the top of welcome page (#20575)
* welcome top extension

* show database modal

* add test

* Delete lines.svg

* rename to banner

* remove lines

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-07-01 12:21:13 -07:00
Yongjie Zhao
b870a21eaa
refactor: remove unused flatten function (#20582) 2022-07-01 19:17:55 +08:00
Sam Faber-Manning
f2af81b1c7
feat: add extension point to the right side of the menu bar (#20514)
* add setupExtensions

* add 'navbar.right' extension to registry

* add test for navbar.right extension point

* rename MenuRight -> RightMenu

* lint
2022-06-30 11:43:20 -06:00
Yongjie Zhao
927d066f70
chore: move isAdhocColumn from controls to core (#20529)
* chore: move isAdhocColumn to superset-ui/core

* ut
2022-06-29 13:09:44 +08:00
Yongjie Zhao
c348a095b9
refactor(standardized form data): refine interface and improve code smells (#20518) 2022-06-28 21:09:42 +08:00
Eric Briscoe
9f9aae49c9
chore: Convert QueryAutoRefresh to TypeScript functional React component [sc-48362] (#20179)
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]'

* addressing PR comments [sc-48362]

Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf

* Address PR comment to use enum for QueryState [sc-48362]

Original implementation had string literals used in multiple places representing Query.state value options.  This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency

* Address PR comments for object type validation [sc-48362]

This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries.  A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests.  Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props.  this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly.

* Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362]

In previous implementation 'scheduled' was not included int he list of Query States.  Further investigation shows it should be added to as a running state.

* Fix prettier lint error [sc-48362]

* Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362]

* Update with changes from master [sc-48362]

Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core

* Removes logic setting user offline and relying on results panel error message [sc-48362]

* Fixes bad import after some TypeScript definitions were relocated to core [sc-48362]

* Fixes TypeScript errors [sc-48362]
2022-06-22 13:20:02 -07:00
Yongjie Zhao
9fad26fa19
fix: suppress translation warning in jest (#20404) 2022-06-21 20:38:58 +08:00
Yongjie Zhao
c79b0d62d0
refactor: create echarts query section (#20445) 2022-06-21 11:38:07 +08:00
Sam Firke
b7eb235440
style(typo): occured -> occurred (#20116)
* Occured -> Occurred

* Occured -> Occurred

* Occured -> Occurred

* Occured - > Occurred

* Update FallbackComponent.tsx

* Update FallbackComponent.tsx

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-20 08:49:45 -07:00
Lily Kuang
ab9f72f1a1
fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00