Commit Graph

2187 Commits

Author SHA1 Message Date
Phillip Kelley-Dotson
e6ff25c980
fix(chart): ensure samples data is displayed (#16900)
* initial fix

* use data keys for cols

* add e2e test

* remove code

* trim logic
2021-11-12 14:23:46 -08:00
John Bodley
bcef8fa13b
feature: Add quarter unit to datetrunc (#17416)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-12 09:46:55 -08:00
Geido
0712be4c12
fix(Dashboard): Only apply changes when editing properties (#17392)
* Apply only

* Test apply button

* Update Cypress

* Rename test
2021-11-12 19:34:21 +02:00
Yongjie Zhao
ffa55f7b7f
chore: add dependencies for monorepo (#17403) 2021-11-12 11:13:51 +08:00
Geido
7cdd58b2db
Fix missing dashboardId (#17380) 2021-11-11 19:07:00 +02:00
Mayur
8756c9089e
fix(dashboard): don't show report modal for anonymous user (#17106)
* Added sunburst echart

* fix(dashboard):Hide reports modal for anonymous users

* Address comments

* Make prettier happy

Co-authored-by: Mayur <mayurp@kpmg.com>
2021-11-11 07:50:12 -03:00
John Bodley
675ffaf8df
revert: Partial revert of 17236 (#17383)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-10 20:32:35 -08:00
Hugh A. Miles II
a1961cfc6f
fix: Users being able to update datasets across DBs (#17348)
* add database id back

* add condition to verify dataset is being changed

* Update superset/datasets/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-11-10 19:45:48 -05:00
Lyndsi Kay Williams
1beda796f2
fix(sqllab): Query limit dropdown number breaks to separate lines (#17382)
* Limit break fixed

* Used white-space: nowrap instead of width: max-content
2021-11-10 10:58:03 -08:00
Christian Pfarr
333b1371f7
feat: Drill ODBC/JDBC Impersonation feature (#17353)
* Added Drill ODBC Impersonation feature and necessary translations/docs

* Code Cleanup

* add jdbc impersonation_target parameter

* add unittests for DrillEngineSpec.modify_url_for_impersonation method

* reformat test_drill.py with black formatter

* run pre-commit locally

Co-authored-by: Christian Pfarr <Christian.Pfarr@deutschebahn.com>
Co-authored-by: Christian Pfarr <z0ltrix+gitlab@pm.me>
2021-11-10 08:45:16 +02:00
Grace Guo
7d22c9ce17
feat(native_filter_migration): add transition mode (#16992)
* feat: [Migrate filter_box to filter component] add transition mode

* rebase and fix comments

* rebase and fix commnent -- patch 2
2021-11-09 09:55:25 -08:00
John Bodley
561d1ac9f2
feat(metrics): Provide override for disabling ad-hoc metrics (#17202)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-08 10:31:43 -08:00
Yongjie Zhao
33a8e87513
fix: failed timezone selector UT (#17370) 2021-11-08 23:52:22 +08:00
Yongjie Zhao
b58f94ad2e
chore: bump @typescript-eslint/eslint-plugin to 5.3.0 (#17367) 2021-11-08 23:48:51 +08:00
Michael S. Molina
ed4a628861
fix: Database selector overflow (#17369)
* fix: Database selector overflow

* Fix TImezoneSelector test

* Removes unused imports
2021-11-08 11:25:16 -03:00
Yongjie Zhao
ee87b01766
chore: bump superset-ui 0.18.20 (#17362) 2021-11-08 13:04:29 +08:00
Erik Ritter
f05a32eeb9
fix: Remove horizontal scroll navigation from SQL Lab (#17356) 2021-11-05 11:12:30 -07:00
Geido
ee7c34b5b3
Make color scheme optional (#17357) 2021-11-05 19:09:59 +02:00
jinghua-qa
ab1fcf3068
test: add native filter e2e test part3 (#17343)
* add 2 stable test

* fix lint
2021-11-05 22:32:27 +08:00
Geido
d0085b1b29
Check validity of control item (#17349) 2021-11-05 12:56:03 +02:00
Hugh A. Miles II
e5fe18660c
fix: Show sqllab state when deleting databases (#17331)
* saving

* fix ts

* update test

* update test

* log unit

* updated test
2021-11-04 20:17:08 -04:00
Beto Dealmeida
43f4ab845a
fix: clear 'delete' confirmation (#17345)
* fix: clear 'delete' confirmation

* Add tests
2021-11-04 16:26:38 -07:00
John Bodley
1c12167d8d
fix: Revert default series sort-by metric and enforce non-xor with series limit (#17236)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-11-03 13:59:38 -07:00
Geido
59a6502efe
fix: Color consistency (#17089)
* Update label colors on the fly

* Clean up

* Improve getFormDataWithExtraFilters

* Improve code structure

* Remove labelColors from formData

* Exclude label_colors from URL

* Refactor color scheme implementation

* Clean up

* Refactor and simplify

* Fix lint

* Remove unnecessary ColorMapControl

* Lint

* Give json color scheme precedence

* Add label_colors prop in metadata

* Separate owners and dashboard meta requests

* Remove label_colors control

* bump superset-ui 0.18.19

* Fix end of file

* Update tests

* Fix lint

* Update Cypress

* Update setColorScheme method

* Use Antd modal body
2021-11-03 19:22:38 +02:00
Michael S. Molina
85a19a9cc2
fix: Unable to select None for Alert's log retention (#17268) 2021-11-03 08:48:30 -03:00
Phillip Kelley-Dotson
9a4ab1026e
fix: remove variables from styled component (#17228)
* remove variables

* fix hovermenu styles
2021-11-02 16:25:48 -07:00
Erik Ritter
7c6d6f47bf
Revert "fix(native-filters): Fix update ownState (#17181)" (#17311)
This reverts commit cf284ba3c7.
2021-11-02 13:17:29 -07:00
Daman Arora
28b494c597
chore: migrate HiddenControl component from jsx to tsx (#17315)
* migrate HiddenControl component from jsx to tsx

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

* updating the type of value in the interface

* Update superset-frontend/src/explore/components/controls/HiddenControl.tsx

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>

Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
2021-11-02 11:51:16 -07:00
Geido
a2a457b7ef
fix(Dashboard): Sidepanel positioning (#17200)
* Refactor

* Adjust top offset

* Calculate padding chart list

* Check for standalone mode

* Rename standaloneMode
2021-11-02 19:28:16 +02:00
Geido
5491a4d13c
fix(Explore): Remove changes to the properties on cancel (#17184)
* Remove on close

* Fix lint

* Add tests
2021-11-02 19:27:56 +02:00
Ville Brofeldt
9515ba68dc
chore: bump superset-ui to 0.18.17 (#17310) 2021-11-02 09:13:33 +02:00
Elizabeth Thompson
bea8502ebd
run npm install to fix a bad package version (#17314) 2021-11-01 13:57:28 -07:00
Yongjie Zhao
1f2a7a40c4
fix: datatable crash when column is empty string (#17303)
* fix: datatable crash when column is empty string

* typo
2021-11-01 23:58:31 +08:00
jinghua-qa
abf24bbb5d
test: add native filter part2 (#17283)
* add native filter part2

* fix lint

* remove unused code

* fix lint after modified
2021-11-01 11:36:47 -03:00
AAfghahi
5948a9fd02
fix(AlertReportModal): Text Area Change (#17176)
* Text Area Change

* added unique key to component

* tests passing

* changed css

* data flow and naming convention
2021-10-29 15:30:20 -07:00
Hugh A. Miles II
d0bad96b1a
fix: Allow users to update database in Dataset Edit Modal (#17265)
* add condition to fix save

* remove console.log
2021-10-29 14:19:37 -07:00
Lyndsi Kay Williams
456efc0c20
fix(reports): Owners no longer showing undefined in reports (#17223)
* Owners no longer showing undefined

* Reverted owners change

* removed print

* Owners now defined - frontend only solution!

* Remove arbitrary space
2021-10-29 10:17:47 -07:00
Kamil Gabryjelski
fa44325a36
fix(explore): Metrics disappearing after removing metric from dataset (#17201)
* fix(explore): Metrics disappearing after removing metric from dataset

* fix test

* Apply fix to non-dnd controls

* Make adhoc metrics pick up changes from dataset columns

* Remove console log

* Fix bug in nondnd controls
2021-10-29 16:15:19 +02:00
jinghua-qa
9ef9adfd78
test: added some sanity test for native filter (#17231)
* add sanity native filter cypress e2e test

* add liscense

* fix front-end lint

* fix fail

* remove unuse import
2021-10-29 11:08:18 +08:00
John Bodley
ce558e0764
chore: bump superset-ui to 0.18.17 (#17270)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-10-28 14:44:57 -07:00
Yongjie Zhao
be6cca561d
chore: bump deckgl 0.4.13 (#17266) 2021-10-28 16:24:15 +08:00
Phillip Kelley-Dotson
93f59e055e
chore: remove supersetTheme with withTheme (#17069)
* remove supersettheme

* migrate Datasourceeditor to rtl

* lint fix

* remove file

* fix import

* fix test

* fix lint

* spread tests and remove unused code

* fix lint
2021-10-27 12:42:56 -07:00
Ajay M
65f1644208
feat(dashboard): Add description to the native filter (#17025)
* Adding description works

* Add some tests

* Fix tests

* Styled look good

* Tests successful

* Address PR comments

* fix a test
2021-10-27 11:45:31 -07:00
Yongjie Zhao
faf7c74e44
chore: bump superset-ui v0.18.16 (#17251)
* chore: import ES module from chart-controls

* chore: bump superset-ui v0.18.16
2021-10-27 23:35:48 +08:00
Ville Brofeldt
4316fe6ae6
fix(annotataion): handle required fields properly (#17234) 2021-10-27 08:42:28 +03:00
Ajay M
743f4b6512
Fix resetting does not clear form (#17217) 2021-10-26 19:13:47 -07:00
Michael S. Molina
dd71035e58
chore: Removes the ChartIcon component (#17216) 2021-10-26 09:02:31 -03:00
Yongjie Zhao
dbf5225e1f
chore: bump to superset-ui 0.18.15 (#17232)
* bump 0.18.15

* prettier and update lock file
2021-10-26 19:25:34 +08:00
Geido
5f8f67e679
Fix tools position (#17221) 2021-10-26 13:00:33 +03:00
Ben Elgren
3641093a44
allow owners to edit chart title (#17047) 2021-10-26 12:58:07 +03:00