Commit Graph

12057 Commits

Author SHA1 Message Date
Eric Briscoe
ab6ec89f68
fix: [sc-54864] Adds safety check to provide near term fix to save query (#21034)
* [sc-54864] Adds safety check to provide near term fix for Queries not saving

There is an error when casting the columns array to String() for saving queries where the objects in the array are missing the toString method.   This is a near term rapid patch to fix workflow in production which will have a follow up to identify root cause.

* fix typo

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

* Adjusted chekc to be explicit for undefined instead of truthy

This fixes issue caught by unit test where the if statement was using a truthy check where it should be explicitly checking for value of undefined

* Adds new unit test to get 100% coverage for callApi

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2022-08-10 10:33:47 -07:00
Yongjie Zhao
dfe5a04938
fix: unable to show view as table modal (#21025) 2022-08-10 11:35:06 +08:00
Michael S. Molina
3df8335f87
feat: Adds drill to detail context menu for ECharts visualizations (#20891)
* feat: Adds drill to detail context menu for ECharts visualizations

* Rebases and adds time grain

* Fixes selected gauge values

* Fixes Treemap edge click

* Adds right click to big number trendline

* Address some comments
2022-08-09 17:02:31 -03:00
Evan Rusackas
0042ade66f
fix: making crossFilter.chartsInScope optional (#21030) 2022-08-09 12:21:40 -06:00
Bogdan
17b58037f8
perf: Implement model specific lookups by id to improve performance (#20974)
* Implement model specific lookups by id to improve performance

* Address comments e.g. better variable names and test cleanup

* commit after cleanup

* even better name and test cleanup via rollback

Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2022-08-09 09:59:31 -07:00
Michael S. Molina
6650076228
fix: forwardRef warnings in selects (#20970) 2022-08-09 09:00:12 -03:00
JUST.in DO IT
9114175db2
fix(plugin-echart-timeseries: legend trancated on show extra controls (#21017) 2022-08-09 16:12:00 +08:00
Geido
03764e6ae8
chore: Audit E2E tests for color schemes in Dashboard and Explore (#20807)
* Update properties tests

* Update selectors

* Verify charts changing colors

* Test shared and label colors

* Update dashboard edit test

* Enhance viz tests

* Remove chart ids

* Update color
2022-08-09 07:49:46 +03:00
Jesse Yang
58245dd7f7
fix(sqllab): result set min-height (#21016) 2022-08-08 20:52:52 -07:00
Jeremy PLANCKEEL
554ed6495e
feat(helm): add liveness and readiness for deployment webserver (#20567)
* feat(helm): add liveness and readiness for deployment webserver

* feat(helm): add example in values

* feat(helm): move config probes under supersetNode

* feat(helm): bump chart.yaml

* fix(helm): remove default values in template and use values.yaml

* fix(git): bump chart verison

* fix(json):  update the schema to get CI passing

* fix(helm): correct path for values readiness

Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com>

Co-authored-by: Jeremy PLANCKEEL <jplanckeel.externe@bedrockstreaming.com>
Co-authored-by: Craig Rueda <craig@craigrueda.com>
Co-authored-by: wiktor2200 <wiktor2200@users.noreply.github.com>
2022-08-08 14:28:36 -07:00
Jesse Yang
2c8867e4e4
chore(db-migration): ensure query_context is MediumText before viz migration (#20936) 2022-08-08 13:30:46 -07:00
Beto Dealmeida
bb3871ddaf
feat: per-db add metrics (#20990)
* feat: per-db add metrics

* Add unit tests
2022-08-08 12:07:16 -07:00
AAfghahi
846529a500
easy fix (#20999) 2022-08-08 12:31:08 -04:00
Yongjie Zhao
802b69f97b
feat: supports mulitple filters in samples endpoint (#21008) 2022-08-08 22:42:14 +08:00
Phillip Kelley-Dotson
e214e1ace6
chore: update text for dbconn modal (#20773)
* chore: update text for dbconn modal

* fix text and close opts for adddataset modal

* update loading state, add state change for cta btns, and styling

* remove space
2022-08-05 15:01:04 -07:00
Elizabeth Thompson
463406ff09
fix: save dataset and repopulate state (#20965)
* save dataset and repopulate state

* disable dashboard button if dataset is missing

* fix error message

* fix tests
2022-08-05 14:32:49 -07:00
dependabot[bot]
95fdc08e78
chore(deps): bump express in /superset-websocket/utils/client-ws-app (#20979)
Bumps [express](https://github.com/expressjs/express) from 4.17.1 to 4.18.1.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.17.1...4.18.1)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-05 13:06:34 -06:00
AAfghahi
f89ba0c7c1
beginning the reducer (#20945) 2022-08-05 11:53:55 -04:00
Kamil Gabryjelski
9350bbafee
fix(explore): Replace url search params only if current page is Explore (#20972)
* fix(explore): Replace url search params only if current page is Explore

* Add unit test
2022-08-05 16:59:52 +02:00
dependabot[bot]
499a28f599
chore(deps): bump debug in /superset-websocket/utils/client-ws-app (#20980)
Bumps [debug](https://github.com/debug-js/debug) from 4.3.2 to 4.3.4.
- [Release notes](https://github.com/debug-js/debug/releases)
- [Commits](https://github.com/debug-js/debug/compare/4.3.2...4.3.4)

---
updated-dependencies:
- dependency-name: debug
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-05 08:13:03 -06:00
Hugh A. Miles II
be4fbaf951
fix: for series limit comparison on explore with chart = Query (#20989)
* oops

* 1 more
2022-08-04 21:37:45 -04:00
John Bodley
eec6e577e6
[requirements] Bumping trino-python-client (#20976) 2022-08-04 17:13:41 -06:00
dependabot[bot]
774756dac9
chore(deps): bump cookie-parser (#20982)
Bumps [cookie-parser](https://github.com/expressjs/cookie-parser) from 1.4.5 to 1.4.6.
- [Release notes](https://github.com/expressjs/cookie-parser/releases)
- [Changelog](https://github.com/expressjs/cookie-parser/blob/master/HISTORY.md)
- [Commits](https://github.com/expressjs/cookie-parser/compare/1.4.5...1.4.6)

---
updated-dependencies:
- dependency-name: cookie-parser
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-08-04 16:46:47 -06:00
Sam Faber-Manning
226712d831
feat: add 'dashboard.nav.right' extension to registry (#20835)
* add 'dashboard.nav.right' extension to registry

* add test
2022-08-04 15:24:34 -07:00
AAfghahi
e3508232ab
fix: series limit solution for source is query (#20977)
* fix

* save

* integrate type casting for engiines

* fix orderby on column types

* fixes

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
2022-08-04 15:52:38 -04:00
Lyndsi Kay Williams
d42cf4e4c9
fix: Columns not passing properly from SQL Lab to Explore (#20975)
* debugging columns

* Clean up code

* Fix test
2022-08-04 14:59:50 -04:00
Evan Rusackas
755f654cc6
chore: make dependabot upgrade package.json + add more package.json files (#20920)
* chore: make dependabot upgrade package.json, and add more package.json files to the mix.

* trailing newline
2022-08-04 11:52:01 -06:00
Phillip Kelley-Dotson
fa416fa130
fix: remove extra line for link (#20959)
* fix: remove extra line for link

* add space
2022-08-04 13:29:07 -04:00
Hugh A. Miles II
6e5036d87f
fix: add timegrains to data payload (#20938)
* add timegrains to data payload

* fix

* opps

* save

* integrate type casting for engiines

* add perm object

* change how wwe raise_for_access

* fix orderby on column types

* linting
2022-08-04 13:26:49 -04:00
AAfghahi
eb5369f2a6
fix: No back button in save dataset modal (#20964)
* back button fix

* fixed test
2022-08-03 21:29:11 -04:00
Beto Dealmeida
7e501cd816
fix: BigQuery get_parameters_from_uri (#20966) 2022-08-03 17:27:40 -07:00
Lily Kuang
c33af83823
chore: always get dashboard_id on dashboard API get endpoint (#20894)
* chore: always get dashboard_id on dashboard API get endpoint

* lint

* pylint

* fix pylint

* lint
2022-08-03 17:20:20 -07:00
Kamil Gabryjelski
e4fc5564ce
fix: Explore scrolled down when navigating from dashboard (#20962) 2022-08-03 21:55:52 +02:00
Lily Kuang
655646d35b
feat(embedded-SDK): enable CSV download (#20416)
* feat(embedded-sdk): enable CSV download

* lint
2022-08-03 10:59:18 -07:00
Antonio Rivero Martinez
aa53c10312
Big Number Viz: (#20946)
- When the value is zero we still render the percent change and suffix if present
2022-08-03 23:12:56 +08:00
EugeneTorap
96a63bcbfe
fix: Use SPA Dataset link in Chart and Dashboard (#20941)
* Use SPA Dataset link in Chart and Dashboard

* Validate datasourceUrl

* Show datasourceName when datasourceUrl is undefined
2022-08-03 09:09:33 +02:00
Beto Dealmeida
bce32af19b
chore: unpin snowflake (#20948) 2022-08-02 21:17:06 -07:00
Elizabeth Thompson
fb5f8cacaf
skip row if created_at_fk is null (#20939) 2022-08-02 15:49:32 -07:00
Jesse Yang
7e836e9b04
test: autouse app_context in unit tests (#20911) 2022-08-02 15:42:50 -07:00
Lyndsi Kay Williams
c06d5eb70c
fix(sqllab): Fix tab state (#20947)
* Fix tab state

* Update sql_lab.py
2022-08-02 17:08:59 -05:00
Jesse Yang
ac585821d8
fix(sqllab): tracking url and error alert padding (#20937) 2022-08-02 14:55:41 -07:00
Stephen Liu
7beda3bbdb
chore: change Sort-by and Sort-Descending controls for Bar Chart v2 (#20868) 2022-08-02 14:36:21 -06:00
Antonio Rivero Martinez
9362e27ce2
fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627)
* Time Series Chart:

-Apache echarts has this option as false by default for time axis, so we need to override it for our charts so it's uto determined and not fixed to hidden.
- Add AxisType enum so we stop comparing agains raw strings when checking xAxis type

* Time Series Chart:

- set the showMaxLabel option directly without using merge

* Time Series Chart:

 - Rename the property to showMaxLabel as it was originally
2022-08-02 14:35:41 -06:00
Antonio Rivero Martinez
e2206a7151
Annotations: (#20720)
- Fix scrollbar when removing annotations
2022-08-02 14:31:48 -06:00
Diego Medina
fe581a3640
fix: adjust timeseries grid right offset to match the rest (#20933) 2022-08-02 14:19:49 -06:00
Diego Medina
6ce027d2f8
fix(import): error with disable_data_preview field (#20932) 2022-08-02 14:16:45 -06:00
Diego Medina
dd353ca86a
feat: Add resize drag handle to Dataset SQL fields (#20670)
* feat: Add resize drag handle to Dataset SQL fields

* PR comments
2022-08-02 14:13:14 -06:00
Diego Medina
9291ad5d4c
fix: Change dataset name affect data access role set to this dataset (#20574) 2022-08-02 14:06:53 -06:00
Daniel Vaz Gaspar
bfd2a3d79f
fix: database permissions on update and delete (avoid orphaned perms) (#20081)
* fix: database permissions on update and delete (avoid orphaned perms)

* fix event transaction

* fix test

* fix lint

* update datasource access permissions

* add tests

* fix import

* fix tests

* update slice and dataset perms also

* fix lint

* fix tests

* fix lint

* fix lint

* add test for edge case, small refactor

* add test for edge case, small refactor

* improve code

* fix lint
2022-08-02 18:28:46 +01:00
Elizabeth Thompson
34ad80c642
add cypress codeowners to e2e tests (#20921) 2022-08-01 17:35:35 -07:00