Commit Graph

11754 Commits

Author SHA1 Message Date
Daniel Vaz Gaspar 77ccec50cc
feat: add statsd metrics for notifications (#20158)
* feat: add statsd metrics for notifications

* fix import

* fix lint

* add decorator arg for custom prefix

* add tests
2022-05-26 15:43:05 +01:00
Dan Roscigno e56bcd36bd
Update clickhouse.mdx (#20195)
ClickHouse is camel case.
2022-05-26 10:37:03 -04:00
Yongjie Zhao e140b7aa87
fix: unable to set destroyOnClose on ModalTrigger (#20201) 2022-05-26 22:27:12 +08:00
Ville Brofeldt 64c4226817
fix(temporary-cache): when user is anonymous (#20181)
* fix(temporary-cache): fail on anonymous user

* make exceptions generic

* fix test

* remove redundant bool return

* fix unit tests
2022-05-26 14:45:20 +03:00
Yongjie Zhao e9007e3c2c
refactor: decouple DataTablesPane (#20109) 2022-05-26 18:59:54 +08:00
Ramunas Balukonis 694f75d376
fix: "Week Staring Monday" time grain for BigQuery (#20091)
* Week Staring From Monday added for BQ

* lint fix
2022-05-26 12:31:32 +03:00
smileydev 95b28fc134
fix(db): make to allow to show/hide the password when only creating (#20186) 2022-05-26 11:18:17 +08:00
Nicola Coretti ac4158e903
Update dependencies for exasol feature flag (#20127)
Updating the sqlalchemy-exasol package will fix #20105 .
2022-05-25 18:01:46 -07:00
Phillip Kelley-Dotson 0501ad25e8
fix: always create parameter json field (#19899)
* fix: always create parameter json field

* ensure validation for empty catalog

* check engine instead of name

* put validation in be

* fix test

* fix test

* remove test
2022-05-25 14:23:25 -07:00
Michael S. Molina 73443cea2f
refactor: Removes embedded/index.tsx warnings (#20193) 2022-05-25 17:42:54 -03:00
Moritz Rathberger 259e03ee12
feat(Helm Chart): Support resource limits and requests for each component (#20052) 2022-05-25 08:49:56 -07:00
Aleksei Lissitsin 4674de1e86
fix typo in secutiry.mdx (#20185) 2022-05-25 15:45:16 +03:00
Geido 3a4176a8d5
chore: Implement global header in Dashboard (#20146)
* Add gloal header

* Reimplement report dropdown

* Update unit tests

* Clean up

* Clean up

* Remove unused import

* Update Cypress

* Update Cypress save dashboard test

* Fix spacing
2022-05-25 12:56:19 +02:00
Yongjie Zhao 40abb44ba1
feat: add samples endpoint (#20170) 2022-05-25 18:18:58 +08:00
Diego Medina 365acee663
fix: avoid while cycle in computeMaxFontSize for big Number run forever when css rule applied (#20173) 2022-05-25 18:04:04 +08:00
cccs-tom b0c6935f06
fix: Allow dataset owners to see their datasets (#20135) 2022-05-25 09:58:15 +01:00
stevetracvc 7e9b85f76c
feat: add drag and drop column rearrangement for table viz (#19381) 2022-05-24 19:10:57 -07:00
Kamil Gabryjelski ce547f4098
chore: Disable flaky assert in reports cypress test (#20174)
* chore: Disable flaky assert in reports cypress test

* Disable flaky assert in alerts cypress test
2022-05-24 14:04:39 -07:00
Stephen Liu ce01ce9e2f
fix(css): transparent linear gradient not working in safari (#20086)
* fix(css): transparent linear gradient not working in safari

* use emotion-rgba instead
2022-05-24 13:50:01 +08:00
Hugh A. Miles II f8ea7788a9
feat: Add Certified filter to Datasets (#20136) 2022-05-23 17:58:15 -04:00
AAfghahi b96e20a2f4
change button name (#20163) 2022-05-23 15:44:10 -04:00
Diego Medina 22b7496d2e
fix: string aggregation is incorrect in PivotTableV2 (#19102)
* fix: string aggregation is incorrect in PivotTableV2

* cleanup

* fix

* updates
2022-05-23 12:39:18 -06:00
Kamil Gabryjelski b746e6f844
feat(dashboard): Chart title click redirects to Explore (#20111) 2022-05-23 13:18:08 +02:00
Yongjie Zhao d7e3ac306f
chore: filter undefined operators (#20157) 2022-05-23 18:24:32 +08:00
smileydev 56e96950c1
fix(chart & heatmap): make to fix that y label is rendering out of bounds (#20011) 2022-05-20 12:54:42 -06:00
Ville Brofeldt e766f8cb57
fix(explore): handle null control sections (#20142)
* fix(explore): handle null control sections

* fix type and add null to test fixture
2022-05-20 19:07:53 +03:00
Ville Brofeldt 0bcc21bc45
chore(data-table): make formatted dttm the default (#20140)
fix test
2022-05-20 15:39:10 +03:00
Daniel Vaz Gaspar d8117f7e37
fix: advanced data type API spec and permission name (#20128)
* fix: advanced data type API spec and permission name

* fix openAPI spec

* fix query schema

* fix query schema

* fix query schema
2022-05-20 10:08:27 +01:00
Daniel Vaz Gaspar b9a98aae79
fix: None dataset and schema permissions (#20108)
* fix: None dataset and schema permissions

* fix pylint

* add migration and test

* fix migration
2022-05-20 09:40:10 +01:00
Ville Brofeldt e2f11d3680
fix(presto,trino): use correct literal dttm separator (#20123)
* fix(presto,trino): use correct literal dttm separator

* remove redundant tests
2022-05-19 20:42:31 +03:00
Ville Brofeldt d5c5e58583
feat(plugin-chart-echarts): add support for generic axis to mixed chart (#20097)
* feat(plugin-chart-echarts): add support for generic axis to mixed chart

* fix tests + add new tests

* address review comments

* simplify control panel

* fix types and tests
2022-05-19 13:51:52 +03:00
Kamil Gabryjelski b2a7fadba9
feat(dashboard): Add create chart button in dashboard edit mode (#20126) 2022-05-19 12:27:16 +02:00
Ville Brofeldt 0b3d3dd4ca
fix(generic-chart-axes): set x-axis if unset and ff is enabled (#20107)
* fix(generic-chart-axes): set x-axis if unset and ff is enabled

* simplify

* simplify

* continue cleanup

* yet more cleanup
2022-05-19 13:21:25 +03:00
Hugh A. Miles II 660af409a4
feat: Save column data into json_metadata for all Query executions (#20059)
* add save_metadata function to QueryDAO

* use set_extra_json_key

* added test

* Update queries_test.py

* fix pylint

* add to session

* add to session

* refactor

* forgot the return
2022-05-18 13:11:14 -04:00
Ville Brofeldt 1d410eb763
chore: fix INTHEWILD sort order and indentation (#20104) 2022-05-19 00:04:07 +08:00
Geido 1fe30f1f0e
Add tnum property to tables (#20093) 2022-05-18 16:26:29 +02:00
Flávio Codeço Coelho 27cccd105b
Update INTHEWILD.md (#20103)
Added `The GRAPH Network`
2022-05-18 09:58:56 +03:00
Krishna Gopal 63702c48ab
fix: add primary button loading state to modals (#20018) 2022-05-17 17:58:53 -07:00
Diego Medina 1e46902602
chore: Update aiohttp to 3.8.1 (#20102) 2022-05-17 17:15:29 -04:00
Smart-Codi 6244728256
fix: Add cypress test for report page direct link issue (#20099)
* add cypress test for report page direct link issue

* add licence
2022-05-17 11:38:54 -06:00
Phillip Kelley-Dotson 5111011de9
fix: dbmodal test connection error timeout (#20068)
* fix: check for connect on ping

* clean up merge

* fix merge

* precommit
2022-05-17 10:04:52 -07:00
Kamil Gabryjelski 9cdaa28042
Revert "feat(explore): Show confirmation modal if user exits Explore without saving changes (#19993)" (#20092)
This reverts commit ca9766c109.
2022-05-17 14:56:31 +02:00
AAfghahi e69f6292c2
chore: Set limit for a query in execute_sql_statement (#20066)
* test for query limit

* fixed tests
2022-05-16 17:56:46 -04:00
smileydev 55aef4db3c
fix(chart & alert): make to show metrics properly (#19939)
* fix(chart & alert): make to show metrics properly

* fix(chart & alert): make to remove duplicate metrics

* fix(chart & alert): make to restore metrics control alert slice

* fix(chart & alert): make to fix lint issue
2022-05-16 14:22:47 -06:00
Beto Dealmeida 4126c365c5
chore: fix typo in `importexport/api.py` (#20085) 2022-05-16 10:08:01 -07:00
cccs-RyanS ddc01ea781
feat(business-types): initial implementation of SIP-78 (#18794)
* add BUSINESS_TYPE_ADDONS to config with example callback

* Removing uneeded whitespace

* [Work in progress] Modifying cidr function to allow for  single ip and adding port outline

* Added test REST endpoint, added some more ports

I've thrown in a test.py script as well that will try to connect to the
business_type endpoint.

* Moving code from config.py into the business api

Very simple api is exposed that will allow someone to call a checkport
endpoint and get back a response.

* Removing commented out bits.

* Adding fucntion dict back to the config

* Moving business_type endpoint to charts

* Adding schema for get endpoint

* Removing imports, updating docstring, fixing typo

Just some small changes as described in the title.  I've updated the
test.py as well so it functions with the endpoint changes.

* Adding translation dict

* Fixing ops

* Adding check for list

* Modifying changes to add quotes where needed

Also changed BusinessTypeResponse to resp.

* Adding in some code to call the filter config

If a column starts with "cidr_" it will call the code in config.py to
try to translate the filter.  Nothing is changed in the JSON being
executed, just some information is dumped to console.

* Porting Ryan's changes

* Adding migration script (as per Ryan's PR)

* Fixing typo

* Prettier fixes

* [CLDN-1043] Adding rough version of filter changes for business types

* fix down migration

* Fixing bugs after merge

* adding functionality to appy filters in back end

* Fixing linting issues

* fix down revision

* Changing conversion callback to handle multiple values at once

* Adding string representation of values

* Code cleanup plus fixing debouce to only be called once for each entry

* Removing non needed logginh

* Changing operator list to use sting values

* Using text value operators

* Removing clear operator call

* Moving business type endpoints

* fix down revision

* Adding port functions

* update migration

* fix bad rebase and add ff

* implement validator

* dont add invalid values to response

* [CLDN-1205] Added a new exception type for a business type translation error. Added the error message in the display_value field within the business type response. Modified the IP and Port business types to populate the error message field in the response if an error occurs

* [CLDN-1205] Added meaningful error message for port translation errors

* Removing status field from businesstype Response and adding in error message

* [CLDN-1205] Added check to make sure the port business type is within the valid range of ports, if it is not, it will populate the error message

* [CLDN-1205] Fixed the if statement that checks to see if the string_value is in the valid range of port numbers. It did not corrently verify this before now.

* [CLDN-1205] Fixed an error where it was trying to use string_value in <= statements. I just casted string_value to an integer if it is numeric, which allows <= operators to be used on it

* [CLDN-1207] Added unit tests for the cidr_func and port_translation_func functions which are located in /superset/config.py

* [CLDN-1207] removed the assertRaises line as it does not work with the cidr_func and port_translation_func functions

* [CLDN-1207] Added the skeleton of the test_cidr_translate_filter_func unit test, still need to update what the expected response from the function will be.

* [CLDN-1207] Added the remainder of the back-end unit tests for the business types

* [CLDN-1207] Fixed the syntax error which caused the test_cidr_translate_filter_func_NOT_IN_double unit test to fail

* [CLDN-1207] Removed the logging that was added for debugging purposes

* [CLDN-1207] Formatted the commands_tests.py file to make it nicer to look at/read through

* [CLDN-1207] Fixed the code so that it conformed to the pylint requirements (i.e., pylint no longer complains about the code in commands_tests.py)

* [CLDN-1207] Modified some of the docstrings so they made better use of the 100 character per line, line limit

* [CLDN-1207] Added the beginnings of the unit tests for the
business types API

* [CLDN-1207] Added a comment to the top of the commands_tests.py file explaining how to run the unit tests. This prevents the next person who tries to run them from having to waste time trying the different forms of testing that Superset supports (e.g., pytest, tox, etc.)

* [CLDN-1207] Added a grammar fix to the comments describing how to run the unit tests

* [CLDN-1207] Modified the description of the business_type API endpoints as they did not represent what the API was actually doing

* [CLDN-1207] Added further instructions on how to run the unit tests that are within the business_type/api_tests.py file

* add request validation

* disable request if business type missing

* [CLDN-1207] Unit tests for the business type API are now working, however, they need to be modified to make use of @mock as we don't want to have to run the server to be able to run the unit tests

* Removing businesss types deffinitons from config

* Adding select to only show valid business types

* Fixed Enzyme tests

* Added scalfolding for selecting filter dropdown

* Adding intigration tests

* fix revision

* fix typos and unnecessary requests

* break out useBusinessTypes

* Added front-end RTL unit tests for the business type API endpoint

* Fixed error from unit tests

* Added a unit test to ensure the operator list is updated after a business type API response is received

* Removing elect compoenet for business types

* Adding feature flag and allowing saving when no business type present

* fixing useEffect hooks

* Adding feature flag to model

* Changing behavior such that an empty string returns a default response

* add form validation

* Modified comments in unit test as command to run test has changed

* Modified comments in unit test as filename to run test has changed

* Modified the api_tests.py file to conform to the linting requirements

* Changed the name of one of the tests to reflect what the test is actually testing

* Added cypress back to the package.json

* Added informative comments

* Updated comments in files as well as removed imports which were not being used

* Changes made by npm run prettier

* Fixed spelling mistakes

* Updated models.py to remove placeholder comments used in development

* Added feature flag mocking in unit test

* Fixing open api failure

* Fixing business types to pass unit tests

* Reverting unsafe connections back to false

* Removing print statement

* Adding business tpye to export test

* setting default feature flag to false for business type

* Reverting pre commit

* Reverting pre commit and running pre commit

* Reverting pre commit and running pre commit

* Fixing formatting

* Adding license

* Fixing Linting

* Protecting api enpoints

* updating model

* Fixing code path when business type exists

* Linting

* Linting

* Fixing linting

* Fixing spelling

* Fixing schemas

* Fixing app import

* fixing item render

* Added RTL test to make sure business type operator list is updated after API response

* Fixing linting

* fix migration

* Changing unit tests

* Fixing import and DB migration after rebase

* Renaming to advanced types

* Fixing Linting

* More renaming

* Removing uneeded change

* Fixing linting and test errors

* Removing unused imports

* linting

* Adding more detailed name for migration

* Moving files to plugins

* more renaming

* Fixing schema name

* Disabling feature flag that should not be enabled by default

* Adding extra cehck

* NameChange

* formatting

* Fixing equals check

* Moveing all advanced type classes and types to one file, and converting tests to functional

* Adding advanced type to test and fix linitng

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Dan Parent <daniel.parent@cse-cst.gc.ca>
Co-authored-by: GITHUB_USERNAME <EMAIL>
Co-authored-by: cccs-Dustin <96579982+cccs-Dustin@users.noreply.github.com>
2022-05-16 17:58:21 +03:00
Geido 265013101a
Change copy (#20032) 2022-05-16 16:26:28 +02:00
Stephen Liu 9854d2d0e8
feat(plugin-chart-echarts): support horizontal bar chart (#19918)
* feat(plugin-chart-echarts): support horizontal bar chart

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/Regular/Bar/controlPanel.tsx

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* improve controlpanel

* default value

* fix ut

Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2022-05-16 21:48:36 +08:00
Ville Brofeldt d5802f7896
fix(generic-axes): apply contribution before flatten (#20077) 2022-05-16 16:26:31 +03:00
Geido 67d4318784
chore: Fix and enhance Applitools workflows (#20071)
* Enhance workflow

* Fix failing workflow

* Enhance storybook with cached-dependencies
2022-05-16 14:26:38 +02:00