Commit Graph

8325 Commits

Author SHA1 Message Date
David Aaron Suddjian a4f60010a1
add semantic title to the pull request template (#16693) 2021-09-17 13:23:39 +08:00
Evan Rusackas 986ed684ac
chore: bump path parse module in websocket sidecar app (#16720) 2021-09-16 12:07:23 -06:00
Ville Brofeldt 4e3d4f6daf
feat: add global max row limit (#16683)
* feat: add global max limit

* fix lint and tests

* leave SAMPLES_ROW_LIMIT unchanged

* fix sample rowcount test

* replace max global limit with existing sql max row limit

* fix test

* make max_limit optional in util

* improve comments
2021-09-16 19:33:41 +03:00
Andreas Schöneck 633f29f3e9
Helm chart: Support hostAliases (#16703) 2021-09-16 07:27:33 -07:00
Ville Brofeldt a839649e5c
fix(pandas-postprocessing): percentage compare to use correct column (#16716) 2021-09-16 13:29:58 +03:00
Ville Brofeldt 836b5e2c86
feat: add support for generic series limit (#16660)
* feat: add support for generic series limit

* refine series_columns logic

* update docs

* bump superset-ui

* add note to UPDATING.md

* remove default value for timeseries_limit
2021-09-16 12:09:08 +03:00
Yongjie Zhao 21f98ddc21
fix: catch exception when create connection (#16692)
* fix: catch exception when create connection

* fix lint

* added UT
2021-09-16 15:55:57 +08:00
Beto Dealmeida 092ef5bdfc
fix: set importer as owner (#16656)
* fix: set importer as owner

* Fix tests
2021-09-15 12:27:02 -07:00
Michael S. Molina 86290cc0e5
chore: Improves the Select component to avoid additional queries when all values have been loaded (#16712)
* chore: Improves the Select component to avoid additional queries when all values have been loaded

* Handles the logic in handlePaginateFetch and removes the use effect
2021-09-15 15:39:58 -03:00
Grace Guo 00ca21e016
fix: report with timeout chart (#16674) 2021-09-15 11:09:21 -07:00
Ville Brofeldt 88c09c2138
feat(jinja): improve url parameter formatting (#16711)
* feat(jinja): improve url parameter formatting

* add UPDATING.md

* fix test
2021-09-15 20:00:26 +03:00
John Bodley fb4650a6eb
chore(pylint): Remove top-level disable (#16589)
* chore(pylint): Remove top-level disable

* Update examples.py

* Update command.py

Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-09-15 09:30:23 -07:00
Michael S. Molina adc3d24c21
fix: Ignore case and special keys when searching (#16706) 2021-09-15 07:33:43 -03:00
Stephen Liu b0ac5d1625
perf(dashboard): fix filter-box performance bug (#16702) 2021-09-15 08:40:46 +03:00
Beto Dealmeida 7f804d62d1
feat: show nice error page in prod (#16695) 2021-09-14 16:56:25 -07:00
David Aaron Suddjian 540277ebb1
chore: Add option to set a custom color scheme as default (#16540)
* upgrade superset-ui for new flag

* configurable default categorical scheme

* dry refactor

* doc example

* Update superset-frontend/src/setup/setupColors.ts

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>

* re-adding # type: ignore (suggestion from ville)

* ugh... missed a space.

Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
2021-09-14 11:09:03 -07:00
Elizabeth Thompson 9f5f6794ff
bump sasl (#16669) 2021-09-14 09:28:13 -07:00
Ville Brofeldt 1d890f8913
fix(explore): make clicked dnd filters unique (#16700) 2021-09-14 18:01:21 +03:00
Geido fecd4124fa
fix: Select refactoring known issues (#16666)
* Clean up and reorganize effects

* Enhance optionFilterProps

* Render custom label

* Remove prop filtering

* Create options

* Create option from value in single mode

* Change to customLabel

* Show search by default

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Select/Select.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Apply minor changes

* Fixes a bug that was failing CI

* Adds more tests to the component

* Apply customLabel in ColorSchemeControl

* Remove customLabel from rendered Option

* Hide No data when allowNewOptions

* Remove unnecessary prop from tests

* Adjust loading height

* Show no data with fetchOnlyOnSearch

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Michael S. Molina <michael.s.molina@gmail.com>
2021-09-14 17:39:27 +03:00
aniaan 9e00e4e8cc
fix(dataset): create ES-View dataset raise exception #16623 (#16624)
* fix(dataset): create es-view dataset raise exception #16623

* fix(database): fix has_view logic

* refactor(database): fix logic

* style(lint): remove unused typing

* fix(test): add test case

* fix(test): fix test case
2021-09-14 22:29:29 +08:00
Ville Brofeldt c99cacbdd2
fix(explore): only refresh data panel on relevant changes (#16699)
* fix(explore): only refresh data panel on relevant changes

* add comment and supress warning
2021-09-14 15:58:05 +03:00
Daniel Vaz Gaspar 5ac8ac0e6c
fix: don't send invalid URLs back to the user (#16687)
* fix: don't send bogus URLs back to the user

* lint, remove f string
2021-09-14 11:29:05 +01:00
Yongjie Zhao ad60c0c4ad
fix: remove useless-suppression for pylint (#16696) 2021-09-14 13:27:21 +08:00
George d984c104cc
fix: Normalise `*.sh` File Endings (#16608)
Windows users encounter problems running the `docker-compose` commands
 to run an instance of Superset.

The reason for this is line-endings for the `*.sh` files that are
 mounted and used in the `command` sections for the superset images.

Many Windows users will check the repository out with line endings set
 to `CRLF`. When mounted in to the *nix-based containers, these line
 endings are not understood, leading to errors such as:

```text
/usr/bin/env: bash\r: No such file or directory
```

The addition of a `.gitattributes` file resolves this issue by telling
 git to always resolve these files with `LF` line endings.

+semver: fix
+ref: #10132
2021-09-13 16:25:15 -07:00
AAfghahi 376c685838
feat: adding logging to validation (#16527)
* adding logging to validation

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-13 16:09:40 -07:00
John Bodley 1669947bcd
chore(pylint): Reenable too-many-lines check (#16287)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2021-09-13 13:22:19 -07:00
cccs-joel c6ac10716a
feat: show build number value in the About if present in the config (#14955) 2021-09-13 10:59:08 -07:00
Grace Guo b0b996582c
fix: reset perf logger timer for soft navigation for SPA pages (#16668)
* fix: reset perf logger timer for soft navigation for SPA pages

* fix comments

* fix extra comments

Co-authored-by: grace_guo <grace_guo@grace-guos-MacBook-Pro.local>
2021-09-13 10:16:07 -07:00
ofekisr 29b635a0a1
refactor sql_json view endpoint: move all logic from view to ExecuteSqlCommand (#16682) 2021-09-13 20:04:59 +03:00
Ville Brofeldt 83581b126d
feat(sqla): add time grain and time column to jinja params (#16680) 2021-09-13 16:43:22 +03:00
Daniel Vaz Gaspar f2bc139e35
feat: feature flag configurable custom backend (#16618)
* feat: feature flag configurable custom backend

* fix lint

* simpler approach

* fix tests

* revert dependency updates

* Update superset/utils/feature_flag_manager.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

* Update superset/config.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2021-09-13 14:09:53 +01:00
ofekisr 1cc726364a
refactor: sql_json view endpoint: use execution context instead of query (#16677)
* refactor sql_json view endpoint: use execution context instead of query

* fix failed tests

* fix failed tests

* refactor renaming enum options
2021-09-13 11:02:57 +03:00
simcha90 668ae23f28
feat: Tabs in column (#16593)
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
2021-09-13 09:02:29 +03:00
ofekisr 51acadad74
refactor sql_json view endpoint: separate a response creation (#16676) 2021-09-12 15:02:55 +03:00
ofekisr 1429d9dab6
refactor sql_json view endpoint: extract methods and rearrange code ordering (#16675)
Co-authored-by: Jack Fragassi <jfragassi98@gmail.com>
2021-09-12 12:56:50 +03:00
Jack Fragassi 4dc859f89e
fix: Ensure alerts & reports aren't schduled when flag is off (#16639)
* Don't schedule alerts & reports when flag is off

* Fix test function name

* Fix test

* Oops

* Another tweak

* Try to lint by hand

* Fix mock
2021-09-10 13:37:21 +01:00
天河 bb014b5131
fix: fix assignment in FilterBoxViz (#16662)
* Fixing assignment.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Adding unit test for FilterBoxViz.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with black.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Revert format change in other test.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>

* Reformatting with the same black version with pre-commit config.

Signed-off-by: tianhe1986 <w1s2j3229@163.com>
2021-09-10 15:10:55 +03:00
Ajay M 4b70d46355
feat(dashboard): Native filters - add type to native filter configuration (#16549)
* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* PR comments

* PR comments

* Fix failing tests
2021-09-09 09:46:44 -07:00
ofekisr dad55a78f4
refactor sql_json view endpoint: separate set the query's limiting concern into ad hod method (#16653) 2021-09-09 19:38:37 +03:00
ofekisr 267b327a3c
refactor sql_json view endpoint: separate query rendering concern into ad hod method (#16649) 2021-09-09 18:25:58 +03:00
ofekisr 62637f275f
refactor sql_json view endpoint: separate validate the query concern into ad hod method (#16647) 2021-09-09 17:11:17 +03:00
Daniel Vaz Gaspar 3d0ebd5abc
chore: Bump Flask-OpenID to 1.3.0 (#16648) 2021-09-09 14:09:54 +01:00
ofekisr df7d9d5515
refactor sql_json view endpoint: separate save query concern into ad hod method (#16646) 2021-09-09 14:50:49 +03:00
Michael S. Molina e9e6c5de8a
chore: Writes the tests for the new Select component (#16638)
* chore: Writes the tests for the new Select component

* Uses array destructuring
2021-09-09 08:38:33 -03:00
Shaoqing Hu d0f69f2e5c
fix: pybabel extract fails (#16629)
* fix pybabel extract fails

* fix black

* trigger GitHub actions
2021-09-09 14:28:25 +03:00
Ville Brofeldt 6465ee7dbd
fix(sqla): support for date adhoc filter (#16634) 2021-09-09 06:41:50 +03:00
AAfghahi c66f278b42
feat: Backend Validation for Creation Method (#16375)
* backend creation method validation

* added tests

* Update superset/reports/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update tests/integration_tests/reports/api_tests.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update tests/integration_tests/reports/api_tests.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/dao.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/commands/create.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset/reports/commands/exceptions.py

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* revisions

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-08 16:35:18 -07:00
Kamil Gabryjelski 788c0c3dae
fix(dashboard): label colors included in explore url (#16621) 2021-09-08 15:38:02 +02:00
Daniel Vaz Gaspar 7e09b7241e
chore: Bump FAB to 3.3.2 (#16615) 2021-09-08 12:15:04 +01:00
Ville Brofeldt 9dfa33fedf
fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00