Commit Graph

2045 Commits

Author SHA1 Message Date
Grace Guo
b0b996582c
fix: reset perf logger timer for soft navigation for SPA pages (#16668)
* fix: reset perf logger timer for soft navigation for SPA pages

* fix comments

* fix extra comments

Co-authored-by: grace_guo <grace_guo@grace-guos-MacBook-Pro.local>
2021-09-13 10:16:07 -07:00
simcha90
668ae23f28
feat: Tabs in column (#16593)
* fix:fix get permission function

* feat: add tabs inside column

* lint: fix lint

* test: fix test

* test: fix tests

* test: fix tests

* fix: pass onChangeTab function through layout
2021-09-13 09:02:29 +03:00
Ajay M
4b70d46355
feat(dashboard): Native filters - add type to native filter configuration (#16549)
* iSort fixes

* Add type key to the new filters

* Fix wrong attribute

* PR comments

* PR comments

* Fix failing tests
2021-09-09 09:46:44 -07:00
Michael S. Molina
e9e6c5de8a
chore: Writes the tests for the new Select component (#16638)
* chore: Writes the tests for the new Select component

* Uses array destructuring
2021-09-09 08:38:33 -03:00
Kamil Gabryjelski
788c0c3dae
fix(dashboard): label colors included in explore url (#16621) 2021-09-08 15:38:02 +02:00
Ville Brofeldt
9dfa33fedf
fix(dnd): make clicked dnd metrics unique (#16632) 2021-09-08 13:21:21 +03:00
Elizabeth Thompson
519baa6f00
fix: params in sql lab are jumpy in the ace editor (#16536)
* fix jumpy params

* remove cypress tests
2021-09-07 09:38:45 -07:00
Michael S. Molina
37c2020035
chore: Merges latest Select changes (#16587) 2021-09-07 10:41:55 -03:00
Kamil Gabryjelski
effcf3b50f
perf(dashboard): decrease number of rerenders of FiltersBadge (#16545)
* perf(dashboard): decrease rerenders in FiltersBadge

* implement caching of dashboard filter indicators

* Implement caching for native filter indicators
2021-09-07 12:03:43 +02:00
Kamil Gabryjelski
7faa5c6aff
perf(dashboard): reduce rerenders of DragDroppable (#16525)
* perf(dashboard): reduce rerenders of DragDroppable

* lint fix
2021-09-07 11:19:07 +02:00
Duy Nguyen Hoang
3fe2e6ec73
Remove export CSV in old filter box (#16592) 2021-09-06 14:40:24 +03:00
Ville Brofeldt
7cbced8833
chore(deps): bump superset-ui to 0.18.2 (#16601) 2021-09-06 12:20:29 +03:00
simcha90
df5c0fbce9
feat: Experimental cross-filter plugins (#16594)
* fix:fix get permission function

* feat: add cross filter chart in charts gallery under FF
2021-09-06 08:25:14 +03:00
Beto Dealmeida
9bb890ebed
fix: impersonate user label/tooltip (#16573) 2021-09-03 09:42:11 -07:00
Elizabeth Thompson
a0db5367d2
bump emotion to help with cache clobbering (#16559) 2021-09-02 13:48:21 -07:00
Michael S. Molina
02798a3517
fix: Adds a loading message when needed in the Select component (#16531) 2021-09-02 13:17:47 -03:00
Yongjie Zhao
2e11b05d73
chore: bump superset-ui to 0.18.1 (#16563) 2021-09-02 09:03:43 +03:00
Ville Brofeldt
75a1b19174
chore: bump superset-ui to 0.18.0 (#16544) 2021-09-02 13:16:03 +08:00
Yongjie Zhao
80c39daa85
fix: can't drop column when name overlap (#16482) 2021-09-01 13:52:10 +08:00
Geido
f001c44727
Make Modal draggable and resizable (#16447) 2021-08-31 12:46:44 +03:00
Phillip Kelley-Dotson
a616b8785e
make chart rerender on timeseries change (#16411) 2021-08-30 16:43:14 -07:00
Phillip Kelley-Dotson
960d1e4d5d
fix: stop endless loading when dataset no longer exist (#16511)
* initial fix

* add const

* add translate
2021-08-30 16:42:02 -07:00
Grace Guo
2199f65373
fix: sql lab refetch button (#16469)
* fix: SQL Lab show "Refetch Results" button while fetching new query results (#15109)

* fix: SQL Lab show "Refetch Results" button while fetching new query results

* fix comments

(cherry picked from commit 408d58f937)

* handle exception caused by invalid query id
2021-08-30 15:47:00 -07:00
Ville Brofeldt
147637a02d
fix(native-filters): add handle undefined control value gracefully (#16468) 2021-08-27 14:03:05 +03:00
Erik Ritter
8adc31d14c
Revert "chore: Changes the DatabaseSelector to use the new Select component (#16334)" (#16478)
This reverts commit c768941f2f.
2021-08-26 22:28:04 -03:00
Jesse Yang
a413f796a6
fix(explore): JS error for creating new metrics from columns (#16477) 2021-08-26 17:04:45 -07:00
AAfghahi
ee2eccdb67
fix: queryEditor bug (#16452)
* queryEditor bug

* update tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-26 15:20:02 -07:00
Kamil Gabryjelski
f422f1ea49
perf(dashboard): decouple redux props from dashboard components (#16421)
* perf(dashboard): decouple redux props from dashboard components

* Lint fix

* Dont make copy of filters object

* Remove unnecessary exports
2021-08-26 21:54:11 +02:00
Kamil Gabryjelski
8ad495a572
perf(dashboard): reduce number of rerenders of Charts (#16444)
* perf(dashboard): reduce number of rerenders of Charts

* Remove static property

* Cleanup
2021-08-26 21:53:44 +02:00
Yongjie Zhao
577ede4b12
fix: prevent page crash when chart can't render (#16464) 2021-08-26 22:26:01 +08:00
Ville Brofeldt
1c71eda70f
fix(native-filters): handle null values in value filter (#16460)
* fix(native-filters): handle null values in value filter

* lint
2021-08-26 15:26:53 +03:00
Jesse Yang
ec087507e5
refactor(explore): improve typing for Dnd controls (#16362) 2021-08-26 01:23:14 -07:00
Ville Brofeldt
18be181946
fix(explore): update overwrite button on perm change (#16437)
* fix(explore): update overwrite on perm change

* remove redundant user_id prop

* fix types

* fix user type

* fix tests

* fix lint
2021-08-26 06:24:33 +03:00
Geido
db11c3e6c8
feat: Draggable and Resizable Modal (#16394)
* Implement resizable prop

* Implement resizableConfig

* Implement fluid Syntax Highlighter

* Implement draggable

* Destroy on close

* Implement draggableConfig

* Enhance with footer calculation

* Add new line

* Make whole header draggable trigger
2021-08-25 16:11:16 +03:00
Maxhui
6a2cec51c5
fix(dashboard): undo and redo buttons weird alignment (#16417)
* fix(dashboard-ui): undo and redo buttons weird alignment

* fix(Explore control pane): keyboard nav & focus

* lint: lint frontend

* fix: fix redo and undo button style

* lint: lint line

* lint: lint line

Co-authored-by: xuzhebin <maxhui2020@gmail.com>
2021-08-25 08:52:59 -03:00
Grace Guo
08b8aa277f
fix: setupPlugin in chart list page (#16413)
* fix: setupPlugin in chart list page

* fix the order of setupPlugins call

* Fix jest test on loading geojson

* add jest changes

* fix unit tests

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2021-08-24 23:10:46 -07:00
Grace Guo
78d8089b18
fix: Disable Slack notification method if no api token (#16367)
* feat: allow company choose alert/report notification methods

* fix: disable Slack as notification method if no api token

* fix unit test

* improve typing
2021-08-24 17:28:50 -07:00
AAfghahi
631ad02a76
fix: copy to Clipboard order (#16299)
* copy to Clipboard order

* centralized copyToClipboard

* fixed table order

* fixed tests

* added colnames to all viz types

* added colnames to all viz types

* added colnames to all viz types
2021-08-24 14:47:09 -07:00
Ville Brofeldt
5eded9fe1b
chore(viz): bump superset-ui to 0.17.87 (#16420) 2021-08-24 11:10:23 -07:00
Evan Rusackas
81241b6024
Revert "fix(explore): let admin overwrite slice (#16290)" (#16408)
This reverts commit d13b081cfe.
2021-08-24 09:38:41 -06:00
Michael S. Molina
6a5568764e
chore: Removes the TODOs and uses the default page size (#16422) 2021-08-24 11:44:27 -03:00
Michael S. Molina
575e7af859
fix: Show cross filter option only when cross filter is enabled (#16391) 2021-08-24 09:13:39 -03:00
Geido
9a37ad1a1e
fix: Return original document title when leaving a dashboard (#16323)
* Return original title on unmount

* Name var originalDocumentTitle
2021-08-24 15:08:13 +03:00
Michael S. Molina
1fc9318594
chore: Changes the AlertReportModal to use the new Select component (#16144)
* chore: Changes the AlertReportModal to use the new Select component

* Gives time to close the select before changing the type
2021-08-24 08:19:27 -03:00
Geido
c14364c616
chore: Enhance Omnibar (#16273)
* Fix style and implement ESC

* Include ESC test case

* Move pagination outside of table

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Enhance

* Handle close

* Localize placeholder

* Fix tests

* Clear input on close

* Destroy modal on close

* Clean up

* Fix tests

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-24 11:52:07 +03:00
AAfghahi
a6aad52e38
fix: regex for multi-region IPs (#16410)
* regex for multi-region IPs

* Update index.tsx
2021-08-23 13:54:25 -07:00
Michael S. Molina
c768941f2f
chore: Changes the DatabaseSelector to use the new Select component (#16334) 2021-08-23 15:41:03 -03:00
Michael S. Molina
0cdc7675b4
chore: Displays the dataset description in a tooltip in the datasets list (#16392) 2021-08-23 15:38:53 -03:00
Phillip Kelley-Dotson
3faf653e5f
initial commit (#16366) 2021-08-20 17:46:55 -06:00
Erik Ritter
a9f502b67b
fix: big number default date format (#16383) 2021-08-20 16:08:54 -07:00
Phillip Kelley-Dotson
c5081991fc
initial commit (#16380) 2021-08-20 16:59:53 -06:00
Lyndsi Kay Williams
518c3c9ae0
test: Functional RTL for email report modal II (#16148)
* Email Report Modal validation testing

* Starting RTL testing for email report

* Calendar icon now rendering!

* Create report testing in dashboard

* make linter happy

* Fixing weird error

* Removed ExploreChartHeader_spec

* Fixed dashboard header test

* revert changes from merge

* Fix tests

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
2021-08-20 10:08:36 -07:00
Ville Brofeldt
575ee24a99
fix: call external metadata endpoint with correct rison object (#16369) 2021-08-20 11:43:57 +03:00
Hugh A. Miles II
50d896f1b7
fix: Fix parsing onSaving reports toast when user hasn't saved chart (#16330)
* don't maniuplate error message

* remove extra idx reference

* u

* change print

* update with test

* add case for dashboards

* fix test
2021-08-19 14:04:23 -04:00
Ville Brofeldt
86f4e691d4
chore(viz): bump deckgl plugin to 0.4.11 (#16353) 2021-08-19 19:19:48 +03:00
Geido
c5c28618a5
fix: Blank space in Change dataset modal without warning message (#16324)
* Make scrollTable flex

* Revert unclosable warning
2021-08-19 16:46:25 +02:00
Evan Rusackas
42cd21e383
chore: bump superset-ui to v0.17.85 (#16350) 2021-08-19 09:32:24 +03:00
Elizabeth Thompson
efe850b731
adjust initial state (#16329) 2021-08-18 13:18:36 -07:00
Kamil Gabryjelski
a547dcb73e
fix(explore): reordering columns with dnd sometimes glitching (#16322)
* fix(explore): reordering columns with dnd sometimes glitching

* Fix metrics and filters popover being stale after reordering
2021-08-18 18:39:05 +02:00
Kamil Gabryjelski
2c595b09ea
chore(explore): make metric/column search input clearable (#16320)
* chore(explore): make metric/column search input clearable

* Fix typo

* Fix test
2021-08-18 12:23:23 +02:00
Elizabeth Thompson
4960b5ee2b
pass correct report_format (#16306) 2021-08-17 18:31:38 -07:00
Beto Dealmeida
7a284bb9e8
fix: allow reports to update query_context (#16303) 2021-08-17 16:39:27 -07:00
Grace Guo
b87e0b32ac
refactor: rearrange dashboard page js bundles (#16285) 2021-08-17 16:12:05 -07:00
Beto Dealmeida
3c0aefb61a
Revert "fix: disable text reports for now (#16257)" (#16296)
This reverts commit ee9a384758.
2021-08-17 14:21:15 -07:00
Phillip Kelley-Dotson
f581e0402b
change filter (#16280) 2021-08-17 09:37:39 -07:00
AAfghahi
f5fbfef618
timezone editor (#16281) 2021-08-17 09:32:17 -07:00
Kamil Gabryjelski
203c311ca3
feat(explore): make dnd controls clickable (#16119)
* Make ghost buttons clickable

* Popover for column control

* Make column dnd ghost button clickable

* Prefill operator only if column is defined

* Remove data-tests

* lint fix

* Hide new features behind a feature flag

* Change ghost button texts

* Remove caret for non clickable columns
2021-08-17 14:56:39 +02:00
Geido
9876c36f6e
Fix table height (#16275) 2021-08-17 09:58:13 +02:00
Ville Brofeldt
d13b081cfe
fix(explore): let admin overwrite slice (#16290) 2021-08-17 10:55:33 +03:00
Ville Brofeldt
2be84e78d2
chore(explore): remove unnecessary favstar redirect (#16288) 2021-08-17 09:09:38 +03:00
Beto Dealmeida
ee9a384758
fix: disable text reports for now (#16257)
* fix: disable text reports for now

* Update tests
2021-08-16 08:16:48 -07:00
Michael S. Molina
0668eaad6a
chore: Improves the flow to create a new chart (#16252)
* chore: Improves the flow to create a new chart

* Adds a comment about selector specificity
2021-08-16 11:56:47 -03:00
Geido
22231addec
Move pagination outside of table (#16232) 2021-08-16 16:43:49 +02:00
Elizabeth Thompson
3709131089
check roles before fetching reports (#16260) 2021-08-13 20:41:03 -07:00
Phillip Kelley-Dotson
a5dbe6a14d
fix examples tab for dashboard (#16253) 2021-08-13 14:56:32 -07:00
Phillip Kelley-Dotson
f94695480a
chore: bump superset-ui packages to 0.17.84 (#16251)
* initial bump

* commit pack-lock file
2021-08-13 13:40:26 -06:00
Michael S. Molina
720e5b111a
chore: Shows the dataset description in the gallery dropdown (#16200)
* chore: Shows the dataset description in the gallery dropdown

* chore: Adjusts the tooltip positioning, fixes the search and removes unnecessary bootstrap data
2021-08-13 15:08:12 -03:00
Geido
c09f6ed15b
fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168)
* Fix style and implement ESC

* Include ESC test case

* Update superset-frontend/src/components/OmniContainer/OmniContainer.test.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-13 18:44:49 +02:00
Yongjie Zhao
6cd15d54a0
refactor: external metadata fetch API (#16193)
* refactor: external metadata api

* fix comments

* fix ut

* fix fe lint

* fix UT

* fix UT
2021-08-13 20:56:42 +08:00
Kamil Gabryjelski
517a678cd7
fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233)
* fix(dashboard): cross filter chart highlight when filters badge icon pressed

* Fix tests

* Fix tests

* break out label logic

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2021-08-13 10:02:28 +02:00
Beto Dealmeida
5d3d6b6eae
fix: validate_parameters and query (#16241)
* fix: validate_parameters and query

* add onQueryChange
2021-08-12 18:05:27 -07:00
Evan Rusackas
cdcc161846
fix: Remove Advanced Analytics tag for 2 charts (#16240)
* removing AA tag from TimeTableChartPlugin

* package bump for echarts (removes AA tag there)

* package-lock bump for new echarts plugin
2021-08-12 15:32:39 -06:00
AAfghahi
9d0dc561fc
Revert "feat: Changing Dataset names (#16199)" (#16235)
This reverts commit adb3ebbba3.
2021-08-12 13:59:44 -07:00
Hugh A. Miles II
171514360e
feat: Allow users to connect via legacy SQLA form (#16201)
* hugh/dbui-other

* remove extra condition

* add not callable

* Update .pylintrc

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-12 15:10:42 -04:00
Geido
a1e18ed110
fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060)
* Implement dynamic tooltip

* Normalize and consolidate

* Clean up

* Refactor and clean up

* Remove unnecessary var

* Fix type import

* Update superset-frontend/src/explore/components/controls/OptionControls/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Remove unnecessary styled span

* Show full tooltip title

* Force show tooltip

* Force show tooltip D&D off

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-08-12 11:48:16 -06:00
Geido
2c5731aea3
Show/hide tooltips (#16192) 2021-08-12 11:42:48 -06:00
Kamil Gabryjelski
a16e290765
fix(explore): conditional formatting value validators (#16230)
* fix(explore): conditional formatting value validators

* Fix typing, make validator more generic

* Remove commented code
2021-08-12 14:31:29 +02:00
Phillip Kelley-Dotson
c79de7abd7
initial fix (#16212) 2021-08-11 15:50:50 -07:00
Phillip Kelley-Dotson
b4555dfa4f
fix: sorting on "Modified By" in chart table (#16208)
* initial fix

* Update ChartList.tsx

change sort to first name
2021-08-11 15:31:10 -07:00
Kamil Gabryjelski
ccfc95fbe6
fix(explore): adhoc metrics popover resets label after hovering outside (#16196)
* fix(explore): adhoc metrics popover resets label after hovering outside

* Remove irrelevant tests and skip rest

* Use ensureIsArray
2021-08-11 10:05:08 -06:00
AAfghahi
6c304b83a9
feat: Changing Dataset names (#16199)
* added google alert

* changing Dataset Names
2021-08-11 08:59:59 -07:00
Kamil Gabryjelski
98fc29cbbb
fix(explore): metric label disappearing in some scenarios (#16190) 2021-08-11 14:05:44 +02:00
Ville Brofeldt
4df3672baa
chore: bump superset-ui to 0.17.82 (#16186) 2021-08-11 10:08:12 +03:00
Phillip Kelley-Dotson
a30d884cfc
fix: change listivew card layouts to the new homepage card layout (#16171)
* initial commit

* removing CardStylesOverrides (unused)

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-10 20:26:24 -07:00
Junlin Chen
9841c78967
chore: switch back tag name to popular from highly-used (#16174)
* chore: switch back tag name to popular from highly-used

* new package lock

* new package lock with npm 7

* fix lint

* remove package changes

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 20:23:14 -07:00
Phillip Kelley-Dotson
a0c9b9d9c2
fix: ensure created user entities do not show inside examples (#16176)
* initial commit

* fix lint

* Update superset-frontend/src/views/CRUD/utils.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/views/CRUD/utils.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/views/CRUD/utils.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

Co-authored-by: Evan Rusackas <evan@preset.io>
2021-08-10 19:53:47 -07:00
Elizabeth Thompson
628169a171
feat: change query predicate to text (#16160)
* change query predicate to text

* make input multiline

* remove value that is too long for the downgrade

* keep logging lint rule
2021-08-10 17:52:01 -07:00
AAfghahi
2dc0bdda5d
feat: Added multi-regional IPs to Database Connections (#16170)
* added google alert

* multi-regional IPs

* beto revisions

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

* Update superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>

Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-08-10 17:25:49 -07:00
Beto Dealmeida
9f52c103ac
fix: isDynamic function (#16175)
* fix: isDynamic function

* trigger tests
2021-08-10 16:28:43 -07:00
Elizabeth Thompson
a3102488a1
feat: add chart image info to reports from charts (#16158)
* refetch reports on props update

* add chart types to reports
2021-08-10 15:11:10 -07:00