Commit Graph

32 Commits

Author SHA1 Message Date
Geido
9ed2326a20
feat: Move cross filters to Dashboard (#22785) 2023-01-25 18:01:06 +01:00
Cody Leff
3898368f26
chore(tests): Streamline Cypress login to fix fails/flakes (#22844) 2023-01-24 17:55:31 -07:00
Ville Brofeldt
630c129e3e
fix(cypress): disable flaky tests (#22512) 2022-12-22 21:25:32 +02:00
Geido
2fe68a3633
chore: E2E Dashboards Cross-references (#21805) 2022-10-21 15:10:35 +03:00
Kamil Gabryjelski
eeb979c150
chore: Create dashboard with tier 1 and tier 2 charts (#21551) 2022-09-30 14:14:26 +03:00
Geido
8539d4cb67
chore: Cypress runtime enhancements (#21332) 2022-09-12 17:48:36 +03:00
Geido
710a8ce5c0
chore: Minor Applitools enhancements (#21239)
* Enhance logging

* Update conf
2022-08-29 19:38:13 +03:00
Geido
d0b8b1e97d
feat: Applitools Cypress workflow (#19956)
* WIP

* Attempt Github Actions integration

* Add completion notification to workflow

* Update env

* Add new line

* Add license

* Fix whitespaces

* Fix Yaml indentation

* Fix afterEach

* Add initial tests

* Update config

* Use test secret

* Clean up

* Add batchName

* Disable logs - add secret

* Create separate workflow

* Clean up

* Update workflow

* Exclude applitools tests

* Update jobs name

* Run applitools tests separetely

* Fix path pattern

* Run once

* Add more initial tests

* Enhance tests

* Add dashboard edit mode test

* Move env

* Exclude applitools from sqllab test run

* Attempt pull_request_target

* Catch Applitools failures

* Clean up tests

* Add test step

* Add test step

* Remove step

* Fix SqlLab test

* Update CURL request

* Fix Yaml

* Add empty data to batch completion
2022-05-09 15:42:20 +02:00
Michael S. Molina
b6d78bf4f2
refactor: Changes the list views to use the new Select component (#16393)
* chore: Change the list views to use the new Select component

* Fix Cypress tests

* Enables search for all controls

* Adjusts controls width

* Removes 'Me' and keeps the logged user on top

* Fixes tests

* Uses the borderless version for the filters

* Fixes the tests

* Reverts the Select theme to the default

* Rebases and fixes js error

* Fixes failing test

* Removes unused withTheme
2021-09-22 07:44:18 -03:00
Beto Dealmeida
211319673f
fix: publish the new example dashboards (#15803)
* fix: publish the new example dashboards

* Fix tests
2021-07-21 17:26:03 -07:00
Phillip Kelley-Dotson
7f2f51b2bd
refactor: icon to icons for listviewcomponent (#15408)
* initial commit

* fix dashboard cypress tests

* fix more tests

* fix more tests

* fix listviews
2021-07-01 12:36:16 -06:00
Phillip Kelley-Dotson
a0179ac513
refactor: icon to icons for inderteminatecheckbox icon (#15397)
* initial commit

* fix cypress tests

* Update superset-frontend/src/components/IndeterminateCheckbox/index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update index.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2021-06-29 00:32:17 -07:00
Phillip Kelley-Dotson
95b9e2e185
refactor: icon to icons for favestar component (#15371)
* initial commit

* initial commit

* fix cypress test

* fix favstar cypress test

* fix card view

* fix other card view
2021-06-25 09:48:22 -07:00
Kamil Gabryjelski
405f95b6af
feat(dashboard/native-filters): Hide filters out of scope of current tab (#14933)
* Optimize finding charts and tabs in scope

* Put filters out of scope in Collapse

* Use lastFocusedTabId instead of directPathToChild

* Fix tests

* Fix cypress test

* Uncomment e2e test
2021-06-02 20:38:18 +02:00
Hugh A. Miles II
d006178c03
refactor: move CTAS/CVAS field II (#13877)
Co-authored-by: lyndsiWilliams <kcatgirl@gmail.com>
2021-04-05 16:57:40 -04:00
Michael S. Molina
d5e6190998
Refresh dashboard list after bulk delete (#12945) 2021-02-08 16:49:23 -08:00
Jesse Yang
29ad78e11a
chore: upgrade Cypress to 6.2.1 (#12605) 2021-01-25 15:05:43 -08:00
Michael S. Molina
7838f035ae
Apply capitalization guidelines - iteration 9 (#12343) (#12455) 2021-01-21 21:46:29 -08:00
David Aaron Suddjian
b5dd0f32cc
feat: Dynamically imported viz plugins (#10288)
* first attempts at dynamic plugin loading

* dynamic import working for explore

* memoize appropriately

* add a backend for dynamic plugins

* hack at getting dynamic plugins working with dashboards

* more work on making it work, + feature flag

* lint

* actions to fix explore state when plugins load

* handle dynamic control panel, functionify ExploreViewContainer

* fix: rearrange migrations branch

* fix: name and key as strings with length 50

* bundle url length 2000

* bundle url to text
for some reason not supported on my sql

* fix: too long varchart

* fix: pre-commit typing

* fix: licenses

* fix: add slice container was not initing feature flags

* fix: undo linting issue

* fix: adjust down revision again

* fix: adjust down revision again

* isort

* pylint

* god damn linters

* remove unnecessary(?) loading message

* only log non-standard errors

* testing

* python is terrible

* see above commit message

* fix imports in DynamicPluginProvider

* fix

* shift migration forward

* lint

* fix form data calculations to handle missing control config

* temp commit - waiting for superset-ui changes and crud fixes

* remove unnecessary todo

* use new superset-ui shared module function

* fetch the plugins instead of hardcoding the test one

* migration sort

* remove duplicated import statement

* format

* try moving the import 🙄

* copy

* fix frontend tests

* safe access

* comment out dead code

* isort

* disable pylint on necessary lines

* use @superset-ui/logging instead of console

* remove temp code

* rearrange some code

* try triggering mouseover in cypress before click

* use loading spinner instead of text

* trying to fix cypress

* attempt cypress fix

* customize permissions

* update package lock

* only admins can write to plugins by default

* better copy

* disable flaky tests

* use makeApi

* flaky tests

* cleanup code

* flaaaakkkyyyyyy

* dry

Co-authored-by: amitNielsen <amit.miran@nielsen.com>
2020-12-19 07:06:11 -08:00
Evan Rusackas
4a471b8c71
feat: Native filters fast-follow (#12138)
* wip: filter create modal

* add a feature flag

* automatic changes to package lock

* wip

* filter sidebar and basic state management

* move create button to the sidebar

* first step for edit filterconfig

* partially fix tests...

* edits to types and comments

* respect feature flag on the filter sidebar

* add filterconfig form

* get input state working

* feat: tree filter scopes UI

* fix: turn on flag

* sticky filter bar

* stop preferring default export

* feat: finish filter scoping

* fix: under toggle

* fix: title

* fix: add licence

* refactor: update TS

* fix: fix on reopen modal + validation

* new filter bar menu

* adding, but commenting out, bulk scoping action

* adding some placeholder buttons and styles therefor

* feat: add filter chart

* add relative path to package.json

* update modal

* a little input styling... just getting warmed up

* Revert "feat: add filter chart"

This reverts commit b1302d35b6.

* Revert "add relative path to package.json"

This reverts commit 26a7b40e18.

* https package lock idk

* feat: add filter chart

* add relative path to package.json

* flexboxes all the way down

* dynamically generate groupby and datasource in select control

* big wip

* fix target column name

* no importing nonexistent things

* styles and name editing

* Add hook for retrieval of all filter states

* start with a new filter when clicking add filter

* handle removed filters gracefully

* fix incorrect default filter configuration

* add fields to useAllFilterState

* add redux for filterconfigs

* add support for native_filters

* remove consoles

* improve filter removal

* unbreak infinite loop

* basic sidebar toggling working!

* collapsing and menu working more smoothly

* linting

* make dataset and column inputs work

* save filter values properly

* add dashboard event for filter updates

* guarded

* apply filters properly

* fix schema

* making New Filter button a link

* gridunits ftw

* centering modal

* tis not a button anymore! nixing type.

* plus and collapse buttons instead of "more" menu

* updating full size filter icons

* adding icons to filter collapsing/expanding

* turning off animation, but leaving class-based animation css

* fix linting error

* fix native filters for legacy charts

* updates test

* no individual apply buttons

* fix bugs with filter config modal

* remove redundant code

* switch to the filter with validation errors on submit

* separate form validation

* switch config button from add to edit

* switch to the filter with validation errors on submit

* separate form validation

* switch config button from add to edit

* update tests

* oops forgot to add the fancy new useChangeEffect hook

* comments and code reorganization

* rename native_filters to extr_form_data and move hook

* disable native filters in viz selector

* add cascading

* implement new extra form data api

* cleanup

* updates tests

* bump npm packages

* fix bad merge on package.json + lock

* lint

* replace in and not in with uppercase

* lint

* lint

* lint

* lint

* bulk test fix

* Sort select input alphabetically

* Change type for sorting elements

* sleeker filter removal UX

* fix rest of unit tests

* make filter operators all uppercase

* Hide Filter bar when there are no filters

* Show edit button for dashboard owners only

* Add visible argument to filters toggle function to avoid future regression

* Improve Toggle filters bar function

* lint

* fix js lint + set createNewOnOpen

* Handle setting extra form data in Filter Bar instead of Filter Control

* Add Handle apply filter function to Apply button

* Allow applying changes instantly

* Fix types

* remove console logs

* fix package

* Add Error Boundary component to Filter bar and Filter Config Modal

* fix jest tests

* update native filters tests to pass

* reset cypress baseUrl

* remove unnecessary field

* Add Parent Filter input field to Config Modal

* Create Cascade Filter & display children filters

* Add Cascade Popover

* Display Filter value both in Filter Bar and in Cascade Popover

* Display the youngest filter value label in the Filter bar

* Add styles to Cascade Popover and filters

* Force to apply changes instantly for parent filters and refactor styles

* Show error for no cyclical hierarchy and refactor

* Add validation for parent filter to be applied instantly

* Add Error Boundary to Filter Config Modal

* cleanup: remove unused state fields

* move unrelated types to an appropriate location

* remove misplaced resource fetch error logic

* fix cascadeParentIds error

* fix cypress password

* initial attempt at fixing scope issue

* fix bad merge

* fix lint

* trying out makeApi for saving filters

* remove unused import

* fix test

* silence bad test

* Improve styling of Filter Config Modal

* Improve styles for whole native filters feature

* Add styles for active filter tab

* Fix text for scoping

* Clean up Filter Bar and Config Modal styles

* Remove fractional gridUnits. Change name for CheckboxFormItem. Add placeholder to Parent Filter select.

* Remove unnecessary button size for Config Modal

* add native-filter feat flag config

* oops fix here

* remove space

* Update superset-frontend/src/common/components/index.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts

Co-authored-by: Evan Rusackas <evan@preset.io>

* Add Cache Wrapper helper to avoid datasets requests deduplication

* Add license to new Cache Wrapper helper

* Add Cache Wrapper tests

* Fix expanding Filter Bar

* use styledMount in tests

* comment

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* Update superset-frontend/src/dashboard/components/nativeFilters/FilterConfigurationLink.tsx

Co-authored-by: Evan Rusackas <evan@preset.io>

* address PR feedback

* fix package lock

* null guards

* Fix charts resizing

* removing emotion/react and going old school on css animation

* fxing css glitch on scoping disclaimer

* src paths.

* using gridUnits

* nixing unnecessary diamonds

* linting

* fix type errors

* Inverting collapsed icons... closer to data src selector design

* restoring feature flag to proper default setting

* missing condition

* fix tests

* patching test

* just a button

* flaky tests

Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Simcha Shats <simcha.shats@nielsen.com>
Co-authored-by: amitNielsen <amit.miran@nielsen.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
Co-authored-by: Agata Stawarz-Pastewska <agata.stawarz-pastewska@polidea.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-12-19 01:57:06 -08:00
Lily Kuang
9c69679e14
feat: filter by me on CRUD list view (#11683) 2020-11-25 11:56:48 -08:00
David Aaron Suddjian
676e0bb282
docs: fix docker config paths (#11703)
* docs: fix config paths for docker

* xit bad cypress tests
2020-11-17 22:00:12 -08:00
Craig Rueda
95246e8812
feat: Adding docker build/push (#11616)
* Adding docker build/push

* Adding build script

* Trying username

* Updating build script

* Fixing script path?

* Lising envvars

* Pulling HEAD

* Actually pushing

* Fixing build / SHA

* Logout before login

* updating docker login

* Fixing docker login

* Trying stdin pwd

* Adding check for forks

* Fixing tagging

* Fixing refspec

* Updating Dockerfile-dev

* Adding license to script

* Fixing Cypress tests
2020-11-13 11:32:18 -08:00
Maxime Beauchemin
5cb6c25ca0
docs: add support for Google Analytics on superset.apache.org (#11613)
* docs: add support for Google Analytics

* fix failing cypress test in list_view.test.ts

* xit some tests
2020-11-12 13:57:05 -08:00
adam-stasiak-polidea
280ba95e46
chore: Cypress dashboard list selectors refactor (#11314)
* cypress selectors refactor in dasboard list tests

* fixed tests

* fixes after rebase
2020-11-04 14:34:21 -08:00
Kamil Gabryjelski
52294c836a
refactor: Replace react-bootstrap Modals with Antd in Datasource (#11390)
* ChangeDatasourceModal

* DatasourceModal

* DeleteModal, AddDatasetModal

* Fix tests

* Remove unused file

* Fix e2e tests

* Fix test

* Remove it.only

* Fix after rebase

* Fix e2e tests

* Fix data-test in modal

* Lint fix
2020-10-28 14:42:13 -07:00
Kamil Gabryjelski
155b5edec1
refactor: Use Antd Modals instead of react-bootstrap Modals (#11366)
* Make Modal responsive

* ErrorAlert

* OmniContainer

* dashboard/PropertiesModal

* Fix e2e tests

* Lint fix

* E2E test fix

* Fix test

* Use grid units

* Change padding to padding-left/right
2020-10-27 13:08:04 -07:00
ʈᵃᵢ
7b0dabd7aa
style(listview): various changes to get closer to SIP-34 designs (#11101) 2020-10-09 13:06:26 -07:00
Lily Kuang
5b284e67eb
feat: add created by chart CRUD view (#11067) 2020-09-30 13:53:04 -07:00
Lily Kuang
ea105bc23b
feat: add "created by" to dashboard CRUD view (#11030) 2020-09-24 14:33:55 -07:00
Lily Kuang
7abdf53944
fix: card view failed cypress tests (#10699) 2020-08-27 11:33:12 -07:00
Lily Kuang
bb92c1f84d
feat: chart and dashboard card list view e2e cypress test (#10669)
* card view cypress tests

* update test config

* chart filter cypress test

* move setting to superset test config

* update test description card view
2020-08-27 09:38:12 -07:00