Daniel Vaz Gaspar
77ccec50cc
feat: add statsd metrics for notifications ( #20158 )
...
* feat: add statsd metrics for notifications
* fix import
* fix lint
* add decorator arg for custom prefix
* add tests
2022-05-26 15:43:05 +01:00
John Bodley
89a844a40f
fix(reports): Clear last value when state is WORKING ( #19941 )
...
* fix(reports): Clear last value when state is WORKING
* Update cbe71abde154_fix_report_schedule_and_log.py
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-05-12 21:54:23 -07:00
AAfghahi
fd611d7653
refactor: Refactor reports for Charts and Dashboards ( #19130 )
...
* bumping shillelagh
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* Preset io ch28954 refactor reports (#19129 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* refactoring reports
* ready for review
* added testing
* removed user reducer
* elizabeth suggestions
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
* deleted additional folder
* fixing tests
* all but styling
* bumping shillelagh
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* Preset io ch28954 refactor reports (#19129 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Arash/new state report (#16987 )
* code dry (#16358 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor(reports): Arash/refactor reports (#16855 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* report pickup
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor(reports): Arash/again refactor reports (#16872 )
* pexdax refactor (#16333 )
* refactor progress (#16339 )
* fix: Header Actions test refactor (#16336 )
* fixed tests
* Update index.tsx
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* code dry (#16358 )
* Fetch bug fixed (#16376 )
* continued refactoring (#16377 )
* refactor: Reports - ReportModal (#16622 )
* refactoring progress
* removed consoles
* Working, but with 2 fetches
* it is still not working
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* next changes
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
* refactor: Reports code clean 10-29 (#17424 )
* Add delete functionality
* Report schema restructure progress
* Fix lint
* Removed console.log
* fix(Explore): Remove changes to the properties on cancel (#17184 )
* Remove on close
* Fix lint
* Add tests
* fix(dashboard): don't show report modal for anonymous user (#17106 )
* Added sunburst echart
* fix(dashboard):Hide reports modal for anonymous users
* Address comments
* Make prettier happy
Co-authored-by: Mayur <mayurp@kpmg.com>
* fix(explore): Metric control breaks when saved metric deleted from dataset (#17503 )
* Add functionality is now working (#17578 )
* refactoring reports
* ready for review
* added testing
* removed user reducer
* elizabeth suggestions
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
* deleted additional folder
* fixing tests
* all but styling
* fixed tests
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Mayur <mayurnewase111@gmail.com>
Co-authored-by: Mayur <mayurp@kpmg.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
2022-05-11 14:19:51 -04:00
Jesse Yang
7b88ec7e25
refactor(ReportModal): simplify state reducer and improve error handling ( #19942 )
2022-05-05 10:06:40 -07:00
Ville Brofeldt
a619cb4ea9
chore: upgrade black ( #19410 )
2022-03-29 20:03:09 +03:00
Hugh A. Miles II
8c52fe3476
feat: Allow users to bust cache in report dashboard + alerts charts + alert dashboards ( #18795 )
...
* wip
* add force cahce bypass option to alerts
* remove default for alerts to bypass cache
* save for now
* save for now
* fix
* commenting out for now
* fix linting
* remove link
* add back force id test
* add frontend test
* address
2022-03-04 12:30:40 -08:00
Hugh A. Miles II
5d2e726f76
fix: update standalone url for slack reports ( #18756 )
...
* update url for slack reports
* fix test
* update text to be dynamic
2022-02-17 15:48:57 -05:00
Grace Guo
59b811ac5b
fix: report list search by created_by ( #18725 )
2022-02-15 19:37:17 -08:00
AAfghahi
fa11a97585
fix: remove standalone ( #18157 )
...
* removed standalone
* Update tests/integration_tests/reports/commands_tests.py
* changed standalone
* added tests
* made function more generic
* Update superset/reports/notifications/email.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2022-01-26 13:04:26 -05:00
ofekisr
e53a50a155
chore(supeset.utils.core): move all database utils to database utils module ( #18058 )
2022-01-16 08:32:50 +02:00
Ajay M
bdc35a2214
feat(alerts): Select tabs to send backend ( #17749 )
...
* Adding the extra config and validation
* wip
* reports working
* Tests working
* fix type
* Fix lint errors
* Fixing type issues
* add licence header
* fix the fixture deleting problem
* scope to session
* fix integration test
* fix review comments
* fix review comments patch 2
Co-authored-by: Grace Guo <grace.guo@airbnb.com>
2022-01-11 10:48:50 -08:00
Beto Dealmeida
2cd8054358
feat: add force option to report screenshots ( #17853 )
...
* Update existing tests
* Add backend test
* feat: add force option to report screenshots
* Add tests
* Rebase fixes
* Do not force screenshot on dashboard alerts
2021-12-22 12:16:04 -08:00
Beto Dealmeida
b7707e8ff7
feat: bypass cache on screenshots for alerts ( #17695 )
...
* feat: bypass cache on screenshots for alerts
* Update existing tests
* Add backend test
* Add frontend test
2021-12-22 08:26:38 -08:00
Grace Guo
c5af7a48df
fix: [alert] allow decimal for alert threshold value ( #17751 )
...
* fix: [alert] add tooltip message for alert threshold value
* support decimal value for alert condition threshold
* add integration test
2021-12-16 22:51:23 -08:00
Bogdan
afd2e9f2ca
chore: update fixtures scope that are loading data into the analytical db ( #17780 )
...
* Update db setup fixture scope
* Load data into db only once
* Update fixture scopes for data loading
* cleanup imports
* try import
* Update scope
* fix cleanup
* Import all fixtures
* Separate data log and metadata creation
* Retain table description
* fix dtype
Co-authored-by: Bogdan Kyryliuk <bogdankyryliuk@dropbox.com>
2021-12-16 16:11:47 -08:00
Elizabeth Thompson
f10bc6d8fe
fix: add fallback and validation for report and cron timezones ( #17338 )
...
* add fallback and validation for report and cron timezones
* add logging to exception catch
* Run black
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-11-12 12:28:17 -08:00
Yongjie Zhao
4f1d202430
chore: use official isort in pre-commmit ( #17215 )
2021-10-25 17:57:38 +08:00
Elizabeth Thompson
2a25e2d7ca
update execution logs and states for alerts ( #16736 )
2021-09-20 14:26:30 -07:00
Jack Fragassi
4dc859f89e
fix: Ensure alerts & reports aren't schduled when flag is off ( #16639 )
...
* Don't schedule alerts & reports when flag is off
* Fix test function name
* Fix test
* Oops
* Another tweak
* Try to lint by hand
* Fix mock
2021-09-10 13:37:21 +01:00
AAfghahi
c66f278b42
feat: Backend Validation for Creation Method ( #16375 )
...
* backend creation method validation
* added tests
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/integration_tests/reports/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/integration_tests/reports/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/dao.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/commands/create.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/commands/exceptions.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* revisions
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-09-08 16:35:18 -07:00
Hugh A. Miles II
50d896f1b7
fix: Fix parsing onSaving reports toast when user hasn't saved chart ( #16330 )
...
* don't maniuplate error message
* remove extra idx reference
* u
* change print
* update with test
* add case for dashboards
* fix test
2021-08-19 14:04:23 -04:00
Beto Dealmeida
afb8bd5fe6
feat: improve embedded data table in text reports ( #16335 )
...
* feat: improve HTML table in text reports
* Remove unused import
* Update tests
* Fix test
2021-08-18 17:00:29 -07:00
Elizabeth Thompson
5031a67597
feat: Self subscribe reports ( #16027 )
...
Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
Co-authored-by: AAfghahi <48933336+AAfghahi@users.noreply.github.com>
2021-08-02 09:12:09 -07:00
Beto Dealmeida
6afa840659
feat: send report data to Slack ( #15806 )
...
* feat: send data embedded in report email
* Change post-processing to use new endpoint
* Show TEXT option only to text-based vizs
* Fix test
* feat: send data embedded in report email
* feat: send report data to Slack
* Add unit test
* trigger tests
2021-07-29 10:13:28 -07:00
Beto Dealmeida
3adf8e85cd
feat: send data embedded in report email ( #15805 )
...
* feat: send data embedded in report email
* Prettify table
* Change post-processing to use new endpoint
* Show text option only for text viz
* Show TEXT option only to text-based vizs
* Fix test
* Add email test
* Add unit test
2021-07-28 09:43:04 -07:00
Elizabeth Thompson
ea49aa3d2d
feat: add timezones to report cron ( #15849 )
...
* add timezones to report cron
* fix test
2021-07-27 18:28:24 -07:00
Beto Dealmeida
2ce676d20d
feat: call screenshot to store query_context ( #15846 )
...
* feat: call screenshot to store query_context
* Add unit test
* Move updateQueryContext to ExploreChartPanel
* Add error handling
* Fix code
* Fix logic
2021-07-27 14:02:27 -07:00
Beto Dealmeida
3441182630
chore: remove unnecessary deps ( #15787 )
...
* chore: remove unneeded deps
* fix lint
* Run compile
2021-07-21 16:53:45 -07:00
AAfghahi
3a249a0090
feat: add show columns to Reports model ( #15712 )
...
* added logic for creation_method
* revisions
* added index
* Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py
* filters
* search columns updated
2021-07-19 11:47:33 -07:00
AAfghahi
674f234de6
feat: add logic to creation_method for reports schedule ( #15685 )
...
* migration
* added logic for creation_method
* revisions
* added index
* Update superset/migrations/versions/3317e9248280_add_creation_method_to_reports_model.py
* filters
* Update superset/models/reports.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update superset/reports/schemas.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* Update tests/integration_tests/reports/api_tests.py
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
* revisions
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
2021-07-15 18:27:54 -07:00
ofekisr
b5119b8dff
refactor(tests): decouple unittests from integration tests ( #15473 )
...
* refactor move all tests to be under integration_tests package
* refactor decouple unittests from integration tests - commands
* add unit_tests package
* fix celery_tests.py
* fix wrong FIXTURES_DIR value
2021-07-01 18:03:07 +03:00
