fix: update standalone url for slack reports (#18756)

* update url for slack reports

* fix test

* update text to be dynamic
This commit is contained in:
Hugh A. Miles II 2022-02-17 15:48:57 -05:00 committed by GitHub
parent 2d67d2f14e
commit 5d2e726f76
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 1 deletions

View File

@ -29,6 +29,7 @@ from superset import app
from superset.models.reports import ReportRecipientType
from superset.reports.notifications.base import BaseNotification
from superset.reports.notifications.exceptions import NotificationError
from superset.utils.urls import modify_url_query
logger = logging.getLogger(__name__)
@ -47,6 +48,11 @@ class SlackNotification(BaseNotification): # pylint: disable=too-few-public-met
return json.loads(self._recipient.recipient_config_json)["target"]
def _message_template(self, table: str = "") -> str:
url = (
modify_url_query(self._content.url, standalone="0")
if self._content.url is not None
else ""
)
return __(
"""*%(name)s*
@ -58,7 +64,7 @@ class SlackNotification(BaseNotification): # pylint: disable=too-few-public-met
""",
name=self._content.name,
description=self._content.description or "",
url=self._content.url,
url=url,
table=table,
)

View File

@ -1024,6 +1024,7 @@ def test_slack_chart_report_schedule(
notification_targets = get_target_from_report_schedule(
create_report_slack_chart
)
assert file_upload_mock.call_args[1]["channels"] == notification_targets[0]
assert file_upload_mock.call_args[1]["file"] == SCREENSHOT_FILE
@ -1118,6 +1119,10 @@ def test_slack_chart_report_schedule_with_text(
| 0 | c11 | c12 | c13 |
| 1 | c21 | c22 | c23 |"""
assert table_markdown in post_message_mock.call_args[1]["text"]
assert (
f"<http://0.0.0.0:8080/superset/explore/?form_data=%7B%22slice_id%22%3A%20{create_report_slack_chart_with_text.chart.id}%7D&standalone=0&force=false|Explore in Superset>"
in post_message_mock.call_args[1]["text"]
)
# Assert logs are correct
assert_log(ReportState.SUCCESS)