Commit Graph

4874 Commits

Author SHA1 Message Date
Yongjie Zhao
b870a21eaa
refactor: remove unused flatten function (#20582) 2022-07-01 19:17:55 +08:00
Yongjie Zhao
290b89c7b4
feat: apply standardized form data to deckgl (#20579) 2022-07-01 14:51:59 +08:00
Cody Leff
b99482dfb1
Try making skipped Cypress test less flaky and un-skip. (#20568) 2022-06-30 16:30:32 -06:00
Evan Rusackas
ac8e502228
fix: Respecting max/min opacities, and adding tests. (#20555)
* Respecting max/min opacities, and adding tests.

* revising tests

* Adding missing test case for maximum coverage :)

* removing unnecessary logic and test

* adding another unit test for (hopefully) full coverage.

* no more ternary operator

* New approach with Math.min  - take THAT codecov.

* one more stab at making codecov happy... ignoring the file next.

* lint fixes
2022-06-30 16:09:03 -06:00
Evan Rusackas
f5f8ddec3e
Revert "feat(plugin-chart-echarts): Support stacking negative and positive values (#20408)" (#20571)
This reverts commit c959d92dd1.
2022-06-30 13:52:43 -06:00
Kamil Gabryjelski
b30f6a5db1
chore(explore): Get Explore data from endpoint instead of bootstrap_data (#20519)
* feat(explore): Use v1/explore endpoint data instead of bootstrapData

* Add tests

* Fix ci

* Remove redundant dependency

* Use form_data_key in cypress tests

* Add auth headers to for data request

* Address comments

* Remove displaying danger toast

* Conditionally add auth headers

* Address comments

* Fix typing bug

* fix

* Fix opening dataset

* Fix sqllab chart create

* Run queries in parallel

* Fix dashboard id autofill

* Fix lint

* Fix test
2022-06-30 21:06:51 +02:00
Sam Faber-Manning
f2af81b1c7
feat: add extension point to the right side of the menu bar (#20514)
* add setupExtensions

* add 'navbar.right' extension to registry

* add test for navbar.right extension point

* rename MenuRight -> RightMenu

* lint
2022-06-30 11:43:20 -06:00
Cody Leff
edb1383bf8
chore(dashboard): Resolve form_data vs. formData in dashboard redux state 2022-06-30 18:49:18 +08:00
Stephen Liu
932e304ffb
fix(database-modal): forms in database modal will be effected by external form values (#20487) 2022-06-30 16:21:33 +08:00
Stephen Liu
24a53c38c6
fix(big-number): big number gets cut off on a Dashboard (#20488) 2022-06-30 16:19:38 +08:00
Jesse Yang
cadd259788
feat: save active tabs in dashboard permalink (#19983) 2022-06-29 09:43:52 -07:00
Diego Medina
c5d3678a31
fix: Unable to download the Dashboard as image in case there's an image added through Markdown (#20362)
* fix: Unable to download the Dashboard as image in case there's an image added through Markdown

* licence
2022-06-30 00:22:49 +08:00
Michael S. Molina
4eb2a6f4a3
chore: Updates metrics and columns font-size (#20526) 2022-06-29 08:05:00 -03:00
Yongjie Zhao
de524bc59f
feat: apply standardized form data to tier 2 charts (#20530) 2022-06-29 16:27:31 +08:00
Yongjie Zhao
927d066f70
chore: move isAdhocColumn from controls to core (#20529)
* chore: move isAdhocColumn to superset-ui/core

* ut
2022-06-29 13:09:44 +08:00
Antonio Rivero Martinez
850f5fa136
fix(database-modal): Refresh Data when importing (#20523)
* Database Modal:

- Add missing invocation to onDatabaseAdd after importing DB from file
- Add keys to our IconButtons

* Database Modal:

- Reduce if clause so it's more concise
2022-06-28 16:13:09 -06:00
Alex Lauderbaugh
93fbfe9d28
Updated copy in chart drop down to "View as table" (#20486) 2022-06-28 14:49:13 -06:00
Kamil Gabryjelski
e12ee59b13
feat(explore): Apply denormalization to tier 2 charts form data (#20524)
* feat(explore): Denormalize form data in Calendar Heatmap

* feat(explore): Denormalize form data in Bubble

* feat(explore): Denormalize form data in Chord

* Dimensions -> Dimension for single selection

* feat(explore): Denormalize form data in Country Map

* feat(explore): Denormalize form data in Heatmap

* feat(explore): Denormalize form data in Histogram

* feat(explore): Denormalize form data in Handlebars

* feat(explore): Denormalize form data in Percent Change

* Use new standardized form data interface
2022-06-28 20:21:36 +02:00
Yongjie Zhao
c348a095b9
refactor(standardized form data): refine interface and improve code smells (#20518) 2022-06-28 21:09:42 +08:00
smileydev
23e62d3782
fix(db): Show the only db install guide when the db is already installed and error is existed while importing file. (#20442)
* fix(db): make to show the db error msg when db installed and error is exist

* fix(db): make to replace dbinstall str into showDbInstallInstructions
2022-06-28 20:53:02 +08:00
Cody Leff
280b4be449
feat(vizgallery): Double-click viz type to submit form (#20513)
* Make double-clicking on viz type submit the form.

* Add tests.
2022-06-28 09:27:04 -03:00
Michael S. Molina
480ee38917
chore: Updates control panels font size in Explore (#20510) 2022-06-28 09:16:59 -03:00
Yongjie Zhao
bbbe102887
feat(standardized form data): keep all columns and metrics (#20377) 2022-06-24 21:46:25 +08:00
Kamil Gabryjelski
c7f1c7d5bd
chore: Restructure explore redux state (#20448)
* chore: Restructure explore redux state

* fixes

* fix tests

* add new tests

* Fix type

* Address comments

* Fix bug

* Fix import

* Add new test

* Move unsaved chart id to a constant

* Add todo
2022-06-24 15:26:07 +02:00
John Bodley
661ab35bd0
fix: Re-add filter-box time granularity/column (#20485)
Co-authored-by: John Bodley <john.bodley@airbnb.com>
2022-06-23 12:42:40 -07:00
stevetracvc
a45d011e74
fix: issue with sorting by multiple columns in a table (#19920)
Recent commit to sort alphanumeric columns via case insensitive
comparison broke the multi-column sort option. React-table only sorts
by the second (or third...) column if the first column matches.
Since the alphanumeric sort only returned -1 or 1, it never would move
to the subsequent columns when the earlier column values matched.
2022-06-23 08:39:46 -03:00
Diego Medina
4dc30441b7
fix: alert & reports active toggle optimistic update (#20402) 2022-06-23 08:33:54 -03:00
Eric Briscoe
9f9aae49c9
chore: Convert QueryAutoRefresh to TypeScript functional React component [sc-48362] (#20179)
* git commit -m 'Convert QueryAutoRefresh to functional component [sc-48362]'

* addressing PR comments [sc-48362]

Removes unneeded props and state tracking of offline, adds finally block to simplify clearing pending request, simplifies value comparison in array by using includes in place of indexOf

* Address PR comment to use enum for QueryState [sc-48362]

Original implementation had string literals used in multiple places representing Query.state value options.  This commit creates a formal TypeScript enum for QueryState so we can remove string literals and ensure better consistency

* Address PR comments for object type validation [sc-48362]

This commit resolves an issue why the TypeScript typing for queryList was marked as a Query[] but was actually a Dictionary (associative array) or Queries.  A new type QueryDictionary has been added and the QueryAutoRefresh code was adjusted to use QueryDictionary instead of Query[] in appropriate places as well as unit tests.  Commit also removes QueryAutoRefreshContainer by making the once component using QueryAutoRefresh (which is already redux connected) pass the needed values on props.  this simplifies the code base and reduce files that need unit testing while keeping QueryAutoRefresh out of needing a redux connection directly.

* Addresses PR comment to add QueryState.SCHEDULED to runningQueryStateList [sc-48362]

In previous implementation 'scheduled' was not included int he list of Query States.  Further investigation shows it should be added to as a running state.

* Fix prettier lint error [sc-48362]

* Adjust unit tests for props update hoisting callbacks out of actions wrapper object [sc-48362]

* Update with changes from master [sc-48362]

Merges in updates from master and resolves conflicts from relocation of some of the Query TypeScript definitions into core

* Removes logic setting user offline and relying on results panel error message [sc-48362]

* Fixes bad import after some TypeScript definitions were relocated to core [sc-48362]

* Fixes TypeScript errors [sc-48362]
2022-06-22 13:20:02 -07:00
cccs-Dustin
daded10992
feat(SQL Lab): Make SQL Lab explore use the default viz from the config file (#20056)
* Modified SQL Lab so it uses the default viz to explore a new dataset with

* Added a comment to the config file

* Remove trailing whitespace

* [CLDN-1312] Removed the 'viz_type' variable so that when it is undefinded in the back-end, it gets set to the default viz

* [CLDN-1312] Only sets the 'all_columns' variable if the default viz type is a 'table'

* Will only pop 'selectedColumns' out of 'form_data' if it is present

* [CLDN-1312] Updated files so that the default viz is now being used again in SQL Lab Explore
2022-06-22 11:33:44 -06:00
smileydev
a833674a8d
fix(home): Show home page tabs as pills instead of links (#20257)
* fix(home): make to update the css style of links

* fix(home): make to fix lint issue

* fix(home): make to remove underline when tab is active

* fix(homes): make to fix the issue of tab

* fix(home): make to move styles to a tag
2022-06-21 17:44:48 -06:00
Michael S. Molina
ca526e63c8
feat: Adds support for clearing the Select cache (#20397)
* feat: Adds support for clearing the Select cache

* Fixes lint errors
2022-06-21 15:13:37 -03:00
Cody Leff
44c5e2879b
chore(newchart): update chart creation dataset selection help text, styles (#20369)
* Update dataset selection help text.

* Update 'Create a new chart' flow styles.

* Add support for linking directly to Create Dataset modal via URL hash.

* Add support for linking directly to Create Dataset modal via URL hash.

* Update dataset help text to not include spaces in translated strings and only include an 'Add dataset' link when user has permission to add dataset.

* Clean up test file

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-21 14:01:43 -03:00
smileydev
1ae935379f
fix(chart & table): make to prevent dates from wrapping (#20384) 2022-06-21 09:58:50 -03:00
Yongjie Zhao
9fad26fa19
fix: suppress translation warning in jest (#20404) 2022-06-21 20:38:58 +08:00
Diego Medina
93774d1860
fix: table viz sort icon bottom aligned (#20447) 2022-06-21 09:10:37 -03:00
Yongjie Zhao
c79b0d62d0
refactor: create echarts query section (#20445) 2022-06-21 11:38:07 +08:00
Sam Firke
b7eb235440
style(typo): occured -> occurred (#20116)
* Occured -> Occurred

* Occured -> Occurred

* Occured -> Occurred

* Occured - > Occurred

* Update FallbackComponent.tsx

* Update FallbackComponent.tsx

Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
2022-06-20 08:49:45 -07:00
Yongjie Zhao
111affdb02
chore: move xaxis to superset-ui (#20438) 2022-06-20 22:36:27 +08:00
Diego Medina
c2f01a676c
fix(dashboard): new created chart did not have high lighted effect when using the permalink of chart share in dashboard (#20411) 2022-06-19 08:17:06 -06:00
Lily Kuang
ab9f72f1a1
fix(embedded): CSV download for chart (#20261)
* move postForm to superset client

* lint

* fix lint

* fix type

* update tests

* add tests

* add test for form submit

* add test for request form

* lint

* fix test

* fix tests

* more tests

* more tests

* test

* lint

* more test for postForm

* lint

* Update superset-frontend/packages/superset-ui-core/test/connection/SupersetClientClass.test.ts

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>

* update tests

* remove useless test

* make test cover happy

* make test cover happy

* make test cover happy

* make codecov happy

* make codecov happy

Co-authored-by: David Aaron Suddjian <1858430+suddjian@users.noreply.github.com>
2022-06-17 20:01:08 -07:00
Cody Leff
9f74fb7a84
Skip flaky Cypress test. (#20417) 2022-06-17 10:24:58 -06:00
jiAng
f6f93aad37
fix(cosmetic): cannot find m-r-10 class in superset.less (#20276)
* fix(cosmetic): cannot find m-r-10 class in superset.less

* fix: remove .m-r-10 class and use emotion instead

* Update superset-frontend/src/components/Datasource/CollectionTable.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/components/Datasource/DatasourceEditor.jsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
2022-06-17 08:54:27 -03:00
Stephen Liu
fa7f144a68
fix: rm eslint-plugin-translation-vars engine requirement (#20420) 2022-06-17 14:29:57 +08:00
Stephen Liu
b32288fddf
fix(bar-chart-v2): remove marker from bar chart V2 (#20409) 2022-06-17 10:52:26 +08:00
Smart-Codi
a8a6b732e9
adding extra metrics after chart configuration (#20410) 2022-06-16 12:55:14 -06:00
Kamil Gabryjelski
c959d92dd1
feat(plugin-chart-echarts): Support stacking negative and positive values (#20408) 2022-06-16 13:58:58 +02:00
Stephen Liu
1665403484
fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work (#20396)
* fix(plugin-chart-pivot-table): color weight of Conditional formatting metrics not work

* fix: test
2022-06-16 12:22:09 +08:00
Reese
498987a1a0
Prevent dataset edit modal closing on click-away in edit mode (#20278) 2022-06-15 14:28:13 -06:00
Michael S. Molina
d6f9fb5af1
chore: Removes unused vars (#20194)
* chore: Removes unused vars

* Fixes lint

* Disables no-unused-vars for the operators
2022-06-15 11:01:45 -03:00
Yongjie Zhao
0a50a9b380
feat: setting limit value when Pie chart switches (#20392) 2022-06-15 21:49:00 +08:00