Rob DiCiuccio
14aa729e66
build(deps-dev): update cypress to 5.5.0, improvements for running locally ( #11603 )
...
* reduce numTestsKeptInMemory to 0 to prevent Chrome OOM crash
* Add cypress-run-chrome script, update docs and cypress_build.sh
* Upgrade Cypress to latest version
* tox: add missing 'cypress' env, cleanup flask server
* Fix failing dashboard edit test syntax
* Reduce retry count to 1
* Prettier test
2020-11-10 15:51:47 -08:00
adam-stasiak-polidea
4eff80c3f3
chore: enabled cypress test in filter file ( #11458 )
...
* enabled cypress test in filter file
* added delay to typing
* additional assertion and timeout
* Modified test logic - changed user's action to selection from list instead of typing (unstable with cypress)
2020-11-10 15:18:20 -08:00
adam-stasiak-polidea
4d41cf900d
Disabled bubble test ( #11630 )
2020-11-09 18:58:28 -08:00
adam-stasiak-polidea
24ba5301d1
Fixed unstable test ( #11583 )
2020-11-08 17:53:43 -08:00
Kamil Gabryjelski
a6bf95e30b
fix: Filter and Metric popovers not closing after clicking Save ( #11607 )
...
* Fix filter popover not closing
* Fix metric popover not closing
* Add e2e tests
2020-11-06 14:23:12 -08:00
Kamil Gabryjelski
1490f3074d
refactor: Replace react-bootstrap MenuItems with Antd Menu ( #11554 )
...
* Refactor SliceHeaderControls
* Refactor DisplayQueryButton
* Fix duplicate keys
* Refactor SliceAdder
* Move css from styles to Emotion
* Fix e2e test
2020-11-05 13:30:03 -08:00
adam-stasiak-polidea
280ba95e46
chore: Cypress dashboard list selectors refactor ( #11314 )
...
* cypress selectors refactor in dasboard list tests
* fixed tests
* fixes after rebase
2020-11-04 14:34:21 -08:00
Kamil Gabryjelski
ad98981d9d
refactor: Replace react-bootstrap MenuItems with Antd Menu ( #11487 )
...
* Remove MenuItem from CopyToClipboard
* Refactor DateFilterControl
* fixup! Remove MenuItem from CopyToClipboard
* Remove console log
* Refactor LanguagePicker
* Refactor HeaderActionsDropdown
* Remove dir with Menu component
* Add imports to common/components/index
* Fix after rebase
2020-11-04 13:47:25 -08:00
Kamil Gabryjelski
937f9ca277
refactor: Replace react-bootstrap dialogs with Antd dialogs ( #11527 )
...
* Refactor Dialogs in dashboard properties modal
* Refactor Dialogs in explore properties modal
* Refactor dialogs in DatasourceModal
* Refactor dialogs in ExploreResultsButton
* Remove react-bootstrap-dialog from ExploreCtasResultsButton
* Remove react-bootstrap-dialog dependency
* Remove unnecessary functions from Modal
* Bump antd version to fix a bug
* Fix unit tests
* Fix e2e test
* Change antd version to 4.5.4 to fix tests
* Reenable all tests in control
* Another version bump to fix tests
2020-11-03 22:07:21 -08:00
Kamil Gabryjelski
a874b14a8a
refactor: Replace react-bootstrap Tabs with Antd Tabs in DashboardBuilder ( #11160 )
...
* Replace tabs in DashboardBuilder
* Fix tests
* Fix styling of anchor
* Fix
* Fix cypress test
* Fix tests
* Fix e2e tests
* Use data-tests
* Move tabs styles from superset.less to Emotion
* Restyle tabs in DashboardBuilder
* Test fix
* Fix styling
2020-11-02 13:31:55 -08:00
Kamil Gabryjelski
19f2deb27f
refactor: Replace react-bootstrap Modals with Antd in Explore ( #11389 )
...
* VizTypeControl
* SaveModal
* explore/PropertiesModal
* Fix e2e tests
* Remove console logs
* Fix tests
* Fix test
* Fix e2e test
* Remove unnecessary fragment
* Fix e2e tests
* Fix e2e test
2020-11-01 23:04:53 -08:00
Kamil Gabryjelski
55a3404b71
refactor: Replace react-bootstrap tabs with Antd tabs ( #11118 )
...
* Replace tabs in BuilderComponentPane
* Replace tabs in ControlPanelsContainer
* Replace tabs in AdhocMetricEditPopover
* Replace Tabs in DatasourceEditor
* Replace tabs in AdhocFilterEditPopover
* Replace tabs in DateFilterControl
* Bug fix
* Change Tab styles
* Fix tests
* Fix cypress tests
* Lint fix
* Fix tests
* Change Tabs style in ControlPanelsContainer
* Change tabs content height
* Lint fix
* Add data test
* Fix e2e test
* Move Tabs file to separate dir
* Fix after rebase
* Fix e2e tests
* Fix after rebase
2020-10-30 22:05:31 -07:00
dependabot[bot]
fe3fdd27e7
build(deps): bump lodash in /superset-frontend/cypress-base ( #11483 )
...
Bumps [lodash](https://github.com/lodash/lodash ) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases )
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20 )
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2020-10-30 14:19:09 -07:00
David Aaron Suddjian
18658f45be
feat(dashboards): Filter status indicators ( #10936 )
...
* Initial commit of new filters badge.
* refactor applied/rejected filters code
* finished filter indicators
* filter badge tested
* unnecessary imports
* formatting and types
* fixes
* license
* code quality tweaks
* state management for showing focused filter scope
* clean up filter key extraction code
* remove unnecessary styles
* temp css to demonstrate highlighting
* fix focused filter logic
* no more color badges
* new toys for highlighting dash components (#11144 )
* tweak style for the filter chart when filter is focused
* style: Filters p0 css2 (#11151 )
* nixing background tweak
* src paths
* another quick theme color
* src paths, adjusting pill icon color, changing icons, showing applied/busted counts
* linting stuff
* fixing and tweaking tests
* show filter indicator when filters are not active
* chart title bar cleanup
* open the right panel when popover opens
* unused import
* fix EditableTitle tests
* margin on dashboard header
* show the chart dropdown menu
* fix blur filter breaking dropdowns
* style tweak - no pointer events when irrelevant charts are blurred
* fix box shadow on filter highlight
* it's an array
* attempt fixing e2e
* style: filters p0 icon churn (#11215 )
* new filters icon
* icon styling
* bigger icons in list views
* better sizing of table actions and favStars
* more icon sizing...
* fixing more button size jankiness
* linting
* Filters performance (#11255 )
* fixing time filter "ok" button
* making unset filter menu collapsible
* sort alphabetically
* fix highlighting when removing items
* try a flex layout (for browser render perf)
* more specific transitioning
* temp: comment out some code as a test
* temp: comment out more code
* temp: remove possibly expensive computations from ChartHolder
* Revert "temp: comment out some code as a test"
This reverts commit 309b880e9064c88b2cba37ce0214f0c3972ba486#11325 )
* fix: use dashboard id for stable cache key (#11293 )
* fix: button translations missing (#11187 )
* button translations missing
* blank space before text
* feat: update time_compare description and choices (#11294 )
* feat: update time_compare description and choices
* Update sections.jsx
* fix(extra-filters): add logic for identifying applied extra filters
* lint
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
* address design feedback
* slight tweak to panel logic, keep panels open that user has opened
* rearrange code to be more graceful
* fix: bump superset-ui/core (#11385 )
* use is_dttm instead of is_temporal
* types, names
* only show unset filter panel if there are unset filters
* fix highlighting the filter control
* fix filterbox layout
* translations
* fix cypress
* actually add the test attribute
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/DashboardBuilder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* formatting
* add link comment to hack
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* stop importing lodash
* Update superset-frontend/src/dashboard/components/gridComponents/ChartHolder.jsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* skip broken test
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/dashboard/components/FiltersBadge/Styles.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* adjust colors of titles
* linting
* no indicators when chart is loading
* support all time fields
* fix lock file
Co-authored-by: Natalie Ruhe <natalie@preset.io>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: rubenSastre <ruben.sastre@decathlon.com>
Co-authored-by: Erik Ritter <erik.ritter@airbnb.com>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
2020-10-28 15:46:24 -07:00
Kamil Gabryjelski
52294c836a
refactor: Replace react-bootstrap Modals with Antd in Datasource ( #11390 )
...
* ChangeDatasourceModal
* DatasourceModal
* DeleteModal, AddDatasetModal
* Fix tests
* Remove unused file
* Fix e2e tests
* Fix test
* Remove it.only
* Fix after rebase
* Fix e2e tests
* Fix data-test in modal
* Lint fix
2020-10-28 14:42:13 -07:00
Ville Brofeldt
e230865216
chore(chart-data): add annotations and url params to chart data schema ( #11393 )
...
* chore(chart-data): add annotations to chart data schema
* bump superset-ui packages
* xit flaky cypress tests
2020-10-28 23:41:39 +02:00
adam-stasiak-polidea
894b94a345
enabled skipped tests in AdhocMetrics Cypress ( #11455 )
2020-10-28 10:06:16 -07:00
Kamil Gabryjelski
b2636f01bb
fix: Explore popovers issues ( #11428 )
...
* Fix spaces and comas not working in filter popover
* Fix popup not opening automatically
* Add e2e test
* Remove only from test
* Remove redundant test, add checking label content
* Add comments to e2e test
* Fix unit test
* Use destructuring
* Always open popup for functions and saved metrics, too
* Fix popover for adhoc metrics too
* Small refactor to consistency
* Refactor for consistency
* Remove redundant functions
* Test fix
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
2020-10-28 09:38:52 -07:00
Evan Rusackas
68411677e9
fix: Fixing broken Cypress test ( #11453 )
...
* fixing bad data-test selector
* linting
* typo... because I got all excited.
2020-10-27 22:51:38 -07:00
Kamil Gabryjelski
155b5edec1
refactor: Use Antd Modals instead of react-bootstrap Modals ( #11366 )
...
* Make Modal responsive
* ErrorAlert
* OmniContainer
* dashboard/PropertiesModal
* Fix e2e tests
* Lint fix
* E2E test fix
* Fix test
* Use grid units
* Change padding to padding-left/right
2020-10-27 13:08:04 -07:00
adam-stasiak-polidea
a99d795eaf
chore: cypress selectors refactor in explore module ( #11309 )
...
* cypress selectors refactor in explore module
* added delay to typing to make test more stable
* fixed missing click
2020-10-27 13:01:45 -07:00
adam-stasiak-polidea
4bebf51453
chore: Cypress chart selectors refactor ( #11312 )
...
* cypress selectors refactor in chart list tests
* fixed wrong selector
2020-10-27 11:38:05 -07:00
Maxime Beauchemin
5b968e9651
fix: multiple issues with FilterPopover ( #11412 )
...
* fix: Custom SQL in FilterPopover
* Also fix #11394
* linting
* fix tests
2020-10-26 21:48:06 -07:00
Kasia Kucharczyk
604a519d8b
fix: keeping Markdown content while resizing window on Dashboard ( #11392 )
...
* Fix: keeping markup content while resizing it
* Added bind and fixed linter
* Added resize case in Markdown editor to cypress test
2020-10-26 11:12:49 -07:00
adam-stasiak-polidea
f2c89af83f
chore: Fixed skipped cypress test - refresh dashboard function ( #11375 )
...
* Fixed skipped cypress dashboard/controls.test.js and fixed MenuItem setting state to 'loading' while refreshing
* fixed wrong cypress command in test
2020-10-24 11:29:30 -07:00
Kamil Gabryjelski
ad88a06d61
refactor: Use Antd Dropdown instead of react-bootstrap in DatasourceControl ( #11395 )
...
* Create Tooltip component
* Refactor DatasourceControl
* Bug fix
* Lint fix
* E2E test fix
* Move menu item keys to constants
* Remove LESS file
* Test fix
* Test fix
* Lint fix
2020-10-23 09:08:35 -07:00
Elizabeth Thompson
43b92b220f
fix: dashboard edit/save errors ( #10834 )
...
* use conditional operator for lookup
* editing dashboard title should update after save
* uncomment test
* fix json metadata save
* json metadata color scheme should overwrite state
* test's functionality is no longer applicable
* add lastModifiedTime to DashboardInfo
2020-10-22 14:33:22 -07:00
adam-stasiak-polidea
55ae259b13
chore: Dashboard cypress refactor ( #11280 )
...
* moved dashboard tests to use data-test attributes
* linter
* fix for unstable save test
2020-10-19 21:36:20 -07:00
Kamil Gabryjelski
901a42b1df
refactor: Replace usages of Popover from react-bootstrap with Antd ( #11163 )
...
* New popover component
* LimitControl
* Moar components migrated
* TimeSeriesColumnControl
* Hotkeys
* ColorPicker
* FilterBoxItemCOntrol
* AdhocFilterEditPopover
* AdhocMetric
* AnnotationLayerControl
* DateFilterControl
* Tests fix
* Fix linting issue
* Fix tests
* Bug fix
* Test fix
* Remove Antd global stylesheet
* Fix linting
* Fix test
* Fix test
* Fix test
* Fix test
* Fix test
2020-10-19 20:42:33 -07:00
Yongjie Zhao
16d36a776c
fix(cypress): table viz failed to run in postgres12 ( #11230 )
2020-10-11 11:28:13 -07:00
Kamil Gabryjelski
b071344531
refactor: Replace react-bootstrap tabs with Antd tabs in SqlLab ( #11212 )
...
* Create styled Antd Tabs and Dropdown
* Replace Tabs in SqlLab
2020-10-09 23:11:25 -07:00
ʈᵃᵢ
7b0dabd7aa
style(listview): various changes to get closer to SIP-34 designs ( #11101 )
2020-10-09 13:06:26 -07:00
John Bodley
2a447ff466
Revert "refactor: Replace react-bootstrap tabs with Antd tabs ( #11090 )" ( #11194 )
...
This reverts commit 4fd993c4e0
2020-10-07 16:21:24 -07:00
Maxime Beauchemin
3d7b805755
chore: more 'datasource' -> 'dataset' renaming ( #11055 )
...
* chore: more 'datasource' -> 'dataset' renaming
* fix build
* explicitely setting disabled to false to avoid cypress confusion
* fix tests
* RAT
2020-10-05 20:04:17 -07:00
Kamil Gabryjelski
07f87149e6
fix: Enable ESLint rule default-props-match-prop-types ( #11058 )
...
* Re-enable ESLint rule default-props-match-props-types
* Add cypress test for switching tabs
* fix
* Typo fix
* Test fix
2020-10-02 15:54:56 -07:00
Ville Brofeldt
662fb43350
fix(examples): missing expressions in birth_names ( #11141 )
...
* fix(examples): missing expressions in birth_names
* disable flaky tests
2020-10-02 23:47:38 +03:00
Kamil Gabryjelski
4fd993c4e0
refactor: Replace react-bootstrap tabs with Antd tabs ( #11090 )
...
* Replace tabs in profile
* Replace tabs in SouthPane
* Replace tabs in TabbedSqlEditors
* Add typing for dropdown
* Add license
* Remove isSelected
* Fixes
* Add data-test
* Fix test
* Remove unnecessary style
* Remove unnecessary style
* Tests fix
* Tests fix
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Tabs.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Update superset-frontend/src/common/components/Dropdown.tsx
Co-authored-by: Evan Rusackas <evan@preset.io>
* Remove inModal prop
* Remove inModal from storybook
* Move inline style to styled component
Co-authored-by: Evan Rusackas <evan@preset.io>
2020-10-02 13:07:52 -07:00
Lily Kuang
5b284e67eb
feat: add created by chart CRUD view ( #11067 )
2020-09-30 13:53:04 -07:00
Moriah Kreeger
b8d616a9d2
feat: saved query list view + sort/filters ( #11005 )
2020-09-29 13:39:10 -07:00
Lily Kuang
e337355162
refactor: table selector on dataset editor ( #10914 )
...
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
2020-09-28 11:16:03 -07:00
Evan Rusackas
497d3f3910
fix: Adding timeout to flaky cypress test, to wait for animation to complete ( #11074 )
...
* adding timeout for animation
* 1s timeout
2020-09-27 20:08:21 -07:00
Evan Rusackas
eeeb21077d
feat: adding all icons from the design system to the codebase ( #11033 )
...
* error -> error-solid
* warning -> warning-solid
* all the new icons mixed in!
* card-view -> card_view
* circle-check-solid -> circle_check_solid
* corrected circle-check to new name and correct (stroke) icon
* sort-asc/desc -> sort_asc/desc
* databases -> database
* compass -> nav_explore
* pencil -> edit-alt
* more pencil migrations
* easy list view rename
* star -> favorite (changed in Figma)
* removing deprecated icon
* renaming icon to mach figma
* More -> More Horiz
* forgot to change this when ranming the file
* updating some icon names in use
* adding hella icons
* fixing errant viewboxes
* removing dropdown-arrow in favor of triangle-down
* adding key to storybook map.
* fixing icon component reference
* tweaks to fave star styling to support revised icon
* fixing a bad icon inclusion
* missed a license
* touchup to virtual dataset... will tweak later.
* e2e fix
* linting
2020-09-25 14:49:30 -07:00
Lily Kuang
ea105bc23b
feat: add "created by" to dashboard CRUD view ( #11030 )
2020-09-24 14:33:55 -07:00
Jesse Yang
7549dad12d
fix: timer component, fixes #10849 , closes #11002 ( #11004 )
2020-09-23 10:53:24 -07:00
Lily Kuang
02ab5cc644
fix: Add Item Overflow on Dataset Editor ( #10983 )
...
* move add item button to the top
* fix cypress
* fix cypress
2020-09-22 22:19:41 -07:00
Ville Brofeldt
a9eab33d64
feat: add ECharts Pie chart ( #10966 )
...
* feat: introduce echarts pie chart
* lint
* remove viz.py shim
* remove tests
* fix cypress test
* fix test
2020-09-22 19:27:40 +03:00
adam-stasiak-polidea
dc893fe1b3
chore: selectors refactor in SQLLab test suite (Cypress) ( #10944 )
...
* changed selectors for not skipped tests in sqllab suite
* linter fixes
* linter fixes
2020-09-21 15:49:44 -07:00
Elizabeth Thompson
ed9b50be2c
chore: upgrade cypress to use retries ( #10923 )
2020-09-17 12:54:50 -07:00
Elizabeth Thompson
0d90bc9920
chore: update port that cypress runs on for local vs test ( #10847 )
2020-09-16 12:31:03 -07:00
Maxime Beauchemin
3b035d2af3
docs: redirect http -> https ( #10900 )
...
* docs: redirect http -> https
* fix issues
2020-09-16 08:24:08 -07:00
