Commit Graph

6094 Commits

Author SHA1 Message Date
Grace Guo
6633409a15
feat: enable ETag header for dashboard GET requests (#10963)
* feat: add etag for dashboard load requests

* fix review comments
2020-09-29 10:57:16 -07:00
Kasia Kucharczyk
89bf76553e
Updated lint in schedules.py in tasks: unused_import, ungrouped_import and changed argument name to remove unused-argument (#11045) 2020-09-29 08:10:46 -07:00
Daniel Vaz Gaspar
5d08a426d3
fix(api): unable to delete virtual dataset, wrong permission name (#11019)
* fix(api): unable to delete virtual dataset because of wrong permission name

* Still delete the dataset even when no permission was found

* migration script to fix possible existing faulty permissions on the db

* black

* fix db migration and one more test

* add more comments to the migration script

* freeze a partial schema of the model on the migration step

* fix mig script

* Update superset/migrations/versions/3fbbc6e8d654_fix_data_access_permissions_for_virtual_.py

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
2020-09-29 12:33:07 +01:00
Ville Brofeldt
80e395559d
fix: echarts timeseries groupby (#11103)
* fix: echarts timeseries groupby

* address review comment
2020-09-29 14:25:38 +03:00
Lily Kuang
8b458ac172
fix: double scroll bars on dataset editor (#11095)
* fix double scroll bar on dataset editor

* add table name to virtual tab
2020-09-28 19:28:27 -07:00
Shaik Idris
79de8f7e37
docs: Add Zeta to list of companies using Apache Superset (#11059)
* Add zeta.tech to list of companies using Apache Superset

Zeta.tech has been extensively using Apache Superset to power some of the enterprise products

* Add Zeta to list of companies using Apache Superset

At Zeta we have been using Apache Superset for over an year to power our enterprise product suite.
2020-09-28 19:28:00 -07:00
Kasia Kucharczyk
3a08fd04f3
chore: pylint fixes in files in project's root (#11064)
* Pylint rule: not necesary unused-import in extensions.py. Autofomatted

* Pylint rule: not necesary unused-import in jinja_context.py. Autofomatted

* Pylint rule: not necesary no-value-for-parameter in stats_logger.py. Autofomatted

* Pylint rule: not necesary no-member in viz.py

* Pylint rule: not necesary no-member in viz_sip38.py
2020-09-28 14:32:45 -07:00
Kasia Kucharczyk
690e27e5fd
chore: updated utils with pylint rules (#11062)
* Updated pylint in cache.py in utils: unecessary bad-whitespace. Autoformatting

* Updated pylint in core.py in utils: E0202.

* Updated pylint in logging_configurator.py in utils: disable=no-member. Formatting

* Updated pylint in machine_auth.py in utils: unused-import

* Updated pylint in screenshots.py in utils: unused-import and import-error

* Updated pylint in webdriver.py in utils: unused-import
2020-09-28 14:32:06 -07:00
Lily Kuang
e337355162
refactor: table selector on dataset editor (#10914)
Co-authored-by: Maxime Beauchemin <maximebeauchemin@gmail.com>
2020-09-28 11:16:03 -07:00
Brylie Christopher Oxley
e52a399e18
Reorganize steps (#11015)
Reorganize steps to
1. run db migrations
2. create default roles/permissions
3. create admin user
4. (optional) load examples
2020-09-28 10:51:50 -07:00
ʈᵃᵢ
1dc05d4c12
feat(charts): modify custom api filter to include more fields (#11054) 2020-09-28 10:18:34 -07:00
Kamil Gabryjelski
2fd8fca207
chore: Clean up some console warnings (#11061)
* Upgrade a few packages

* Update some prop types

* Update HTML

* Moar warning fixes

* Remove wrapper div
2020-09-28 09:43:21 -07:00
Kamil Gabryjelski
f01b8a30f7
refactor: Remove usages of reactable from TimeTable (#11046)
* Use ListView instead of reactable

* Refactor TimeTable

* Spark column width fix
2020-09-28 09:42:06 -07:00
Kamil Gabryjelski
a879622e07
refactor: Remove usages of reactable from AlteredSliceTag (#11012)
* Remove usages of reactable in AlteredSliceTag

* Fix tests

* Move mocked data to fixtures file

* Use optional chaining

* Remove default value, change a unit test logic

* Code review fixes
2020-09-28 09:41:08 -07:00
Erik Ritter
0f7e90f1f7
feat: improve presto query perf (#11069) 2020-09-28 08:52:00 -07:00
Maxime Beauchemin
046bd02d65
style: improve "Datasource & Chart Type" <Label>s (#10971)
* style: improve default <Label>

* fix name-shifting icon

* adding some styles to remove the inner drop shadow from the 'more' button

Co-authored-by: Evan Rusackas <evan@preset.io>
2020-09-28 08:32:25 -07:00
Ville Brofeldt
39cce712af
docs: add changelog entries for 0.37.2 (#11086) 2020-09-28 11:14:09 +03:00
Evan Rusackas
497d3f3910
fix: Adding timeout to flaky cypress test, to wait for animation to complete (#11074)
* adding timeout for animation

* 1s timeout
2020-09-27 20:08:21 -07:00
Evan Rusackas
cff034e2cf
chore: cleaning out unused code from utils (#11076)
* removing unused stuff (and some jquery) from utils.js

* linting
2020-09-27 20:08:05 -07:00
Maxime Beauchemin
7f1e4e441d
fix: surface connection error messages on the client (#11077)
* fix: surface connection error messages on the client

* typo

* lint
2020-09-26 16:09:40 -07:00
Yongjie Zhao
1493450a6f
fix(jest): using UTC mock date (#11079) 2020-09-26 14:53:41 -07:00
Evan Rusackas
23d62f37a6
removing unused component (#11072) 2020-09-25 23:02:01 -07:00
Evan Rusackas
8cba1c823d
changing to the correct hex color (#11073) 2020-09-25 21:09:59 -07:00
Maxime Beauchemin
8e6f7d6598
style: remove unecessary padding (#11071) 2020-09-25 17:22:46 -07:00
Moriah Kreeger
374b06b4dd
fix: database list checkboxes (#11068) 2020-09-25 16:28:22 -07:00
Evan Rusackas
eeeb21077d
feat: adding all icons from the design system to the codebase (#11033)
* error -> error-solid

* warning -> warning-solid

* all the new icons mixed in!

* card-view -> card_view

* circle-check-solid -> circle_check_solid

* corrected circle-check to new name and correct (stroke) icon

* sort-asc/desc -> sort_asc/desc

* databases -> database

* compass -> nav_explore

* pencil -> edit-alt

* more pencil migrations

* easy list view rename

* star -> favorite (changed in Figma)

* removing deprecated icon

* renaming icon to mach figma

* More -> More Horiz

* forgot to change this when ranming the file

* updating some icon names in use

* adding hella icons

* fixing errant viewboxes

* removing dropdown-arrow in favor of triangle-down

* adding key to storybook map.

* fixing icon component reference

* tweaks to fave star styling to support revised icon

* fixing a bad icon inclusion

* missed a license

* touchup to virtual dataset... will tweak later.

* e2e fix

* linting
2020-09-25 14:49:30 -07:00
Erik Ritter
052d7a0a3e
fix: sql lab autocomplete width (#11063) 2020-09-25 10:13:21 -07:00
Evan Rusackas
d056e3dfd3
clickable labels have outlines, storybook shows them (#11034) 2020-09-24 20:50:44 -07:00
Srini Kadamati
66e49807ef
fixed routes for customer in docs (#11052) 2020-09-24 20:43:03 -07:00
Grace Guo
3467d2d8d6
Revert "style: fix checkbox color (#10970)" (#11051)
This reverts commit e4e78b66fa.
2020-09-24 16:53:02 -07:00
Lily Kuang
ea105bc23b
feat: add "created by" to dashboard CRUD view (#11030) 2020-09-24 14:33:55 -07:00
Kasia Kucharczyk
92dd257ef4
Changed tags.py and helpers.py in models module: removed disabled pylint rule unused_import, changed unused arguments to private and removed disabled rule unused-argument. Removed redundant rules. (#11037) 2020-09-24 13:50:09 -07:00
Kasia Kucharczyk
63d0e801ad
chore: updated lint rules in models module (#11036)
* Removed disabled pylint rule `unused_import` from `dashboards.py` in `models` module. Added missing break in too long line. Formatting.

* Changed `datasource_access_request.py` in models` module: removed disabled pylint rule `unused_import`, removed `no-member` disabled rules which aren't needed. Formatting

* Changed `slice.py` in models` module: removed disabled pylint rule `unused_import`, changed unused arguments to private and removed disabled rule `unused-argument`
2020-09-24 13:49:00 -07:00
Kasia Kucharczyk
6b318c477e
Removed disable global pytlint rule standarderror-builtin which isn't appearing for Python3 (#11038) 2020-09-24 13:48:02 -07:00
Kasia Kucharczyk
eba1aa8a53
Enabled argument-differ for bulk_delete (#11039) 2020-09-24 13:47:00 -07:00
Kasia Kucharczyk
7ca4192fe6
Enabled no-self-use pylint rule in security. Formatter (#11041) 2020-09-24 13:46:21 -07:00
Kasia Kucharczyk
8bc05bda6f
Changed variable name from capitals to lowercase and changed lint rule (#11044) 2020-09-24 13:45:19 -07:00
Grace Guo
f99753a800
Revert "ESLint: Re-enable rule default-props-match-prop-types (#10868)" (#11050)
This reverts commit 9f01a7fdf8.
2020-09-24 12:33:38 -07:00
ʈᵃᵢ
eded51b2f8
feat(saved_queries): add custom api filter for all string & text fields (#11031) 2020-09-24 11:05:25 -07:00
Bogdan
b2fdf12f62
Support jinja templates (#11008)
Co-authored-by: bogdan kyryliuk <bogdankyryliuk@dropbox.com>
2020-09-24 10:29:44 -07:00
Ville Brofeldt
6181994084
chore: bump pandas to latest stable version (#11018)
* chore: bump pandas to latest stable version

* fix nest_values
2020-09-24 13:11:10 +03:00
Grace Guo
8e9b0b3f11
fix: dashboard edit button (again) (#11029) 2020-09-23 15:42:06 -07:00
Maxime Beauchemin
dc76a2688e
style(explore): use tertiary button against gray background (#11011)
"primary" style buttons seem to expect a white background and really
look muted against the gray background. Using "tertiary" style button makes
things much better.

Eventually we may reconsider the layout and gray background and go back
to secondary, but for now this makes these important pop much more
2020-09-23 11:44:39 -07:00
Rob DiCiuccio
8b683783cc
docs: add security vulnerability GH issue template (#11023)
* Add security vulnerability issue template

* Louder title
2020-09-23 11:13:13 -07:00
Grace Guo
0409393a4e
fix: [dashboard] should not show edit button when user has no edit permit (#11024) 2020-09-23 10:55:32 -07:00
Jesse Yang
7549dad12d
fix: timer component, fixes #10849, closes #11002 (#11004) 2020-09-23 10:53:24 -07:00
Kasia Kucharczyk
af1e8e8839
fix: enable several pylint rules partially in db_engines_specs module (#11000)
* Enabled mssql

* Enabling pylint rules in `mysql.py` from `db_engine_specs`:
- added variable to shorten line and enable `line-too-long`
- `import-error` seems not prompting anymore
- specified exception instead broad-except

* Refactored too long line in `oracle.py` from `db_engine_specs`. Enabled too-long-line pylint rule.

* Changed fstring into string `pinot.py` to reenable `f-string-without-interpolation` rule.

* Enabled `unused-import` rule and changed line to adjust to correct number of characters in `db_engine_specs/postgres.py`.

* Enabled unused-import pylint check in `db_engine_specs/presto.py`

* Enabled unused-import pylint check in `db_engine_specs/snowflake.py`

* Enabled unused-import pylint check in `db_engine_specs/sqlite.py`
2020-09-23 10:47:56 -07:00
Kasia Kucharczyk
fb6f14c469
fix: pylint checks in connectors/sqla/models.py (#10974)
* Removed unused pylint rule `too-many-instance-attributes` from SqlaTable class.

* Removed unecessary rule: `bad-whitespace` from `get_sqla_query` method

* Disabling too-many-instance-attributes since it fails on CI
2020-09-23 10:47:12 -07:00
Kasia Kucharczyk
bade279883
fix: reenable pylint rule unused-import in charts and connectors modules (#11014)
* Removed disabled pylint rule `unused_import` from `dao.py` in `charts` module

* Removed disabled pylint rule `unused_import` from `connector_registry.py` in `connectors` module
2020-09-23 10:46:44 -07:00
Kasia Kucharczyk
26fcc08906
Enabled pylint rules in db_engines module: (#11016)
- `unused_import` and `import_error` - not promting anymore
- changed unused param to private and removed `unused_argument`
2020-09-23 10:45:26 -07:00